April 2009 - PPL-devel - BUGSENG Mailman

Re: [PPL-devel] Some troubles I met while building PPL.
by Abramo Bagnara 23 Apr '09

23 Apr '09

Yuriy Taraday ha scritto: > Here it is, just as in config.log that I sent. > > Mobi-Ya:ppl-0.10.2 yorik$ gcc -v > Using built-in specs. > Target: i686-apple-darwin9 > Configured with: /var/tmp/gcc/gcc-5490~1/src/configure > --disable-checking -enable-werror --prefix=/usr --mandir=/share/man > --enable-languages=c,objc,c++,obj-c++ > --program-transform-name=/^[cg][^.-]*$/s/$/-4.0/ > --with-gxx-include-dir=/include/c++/4.0.0 --with-slibdir=/usr/lib > --build=i686-apple-darwin9 --with-arch=apple --with-tune=generic > --host=i686-apple-darwin9 --target=i686-apple-darwin9 > Thread model: posix > gcc version 4.0.1 (Apple Inc. build 5490) With this versione of gcc not only you will not be able to compile reliably the Parma Polyhedra Library, see http://www.cs.unipr.it/ppl/Download/requirements but you will have also troubles compiling GMP, see http://gmplib.org/macos.html Please retry with an more recent version. -- Abramo Bagnara Opera Unica Phone: +39.0546.656023 Via Borghesi, 16 48014 Castel Bolognese (RA) - Italy

1 0

Some troubles I met while building PPL.
by Yuriy Taraday 23 Apr '09

23 Apr '09

Good morning. My command were using your library for a new project, so I had to try to install it on my notebook with MacOS 10.5 on board. As far as I understand, only on MacOS I could find this two small problems: 1. Git version failed at automake (the first attachement has log) and autoconf (the second one). I'm not familiar with this tools so I can't suggest the reason of the errors. 2. I got ppl-0.10.2.tar.bz2, the configure script succeeded (the third log), but make failed (forth log) with (i guess) the only one error - the Bool type uses anonymous enum. I think, it'll be honest to name that enum (I just added "__Bool_enum" as name and it worked). Thank you for attention. Best regards, Yuri.

2 1

[GIT] ppl/ppl(polynomials): New commits
by Roberto Bagnara 23 Apr '09

23 Apr '09

Merge branch 'master' into polynomials. Resolved conflicts: CREDITS configure.ac src/Makefile.am tests/Makefile.am URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c5cf863b438f… -- Prof. Roberto Bagnara Computer Science Group Department of Mathematics, University of Parma, Italy http://www.cs.unipr.it/~bagnara/ mailto:bagnara@cs.unipr.it

1 0

[GIT] ppl/ppl(master): Avoid unused variable warning.
by Patricia Hill 23 Apr '09

23 Apr '09

Module: ppl/ppl Branch: master Commit: 2071de104d8f13d2109487512d2ae74e7fa888e1 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2071de104d8f… Author: Patricia Hill <p.m.hill(a)leeds.ac.uk> Date: Thu Apr 23 07:16:52 2009 +0100 Avoid unused variable warning. --- tests/Powerset/fromgrid1.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/Powerset/fromgrid1.cc b/tests/Powerset/fromgrid1.cc index e8f5fc3..938915e 100644 --- a/tests/Powerset/fromgrid1.cc +++ b/tests/Powerset/fromgrid1.cc @@ -394,7 +394,7 @@ test16() { // be set to false. // So we add this test to set the omega reduction pps_gr.reduced // flag to true. - bool top_closed = pps_gr.is_topologically_closed(); + pps_gr.is_topologically_closed(); Pointset_Powerset<NNC_Polyhedron> pps(pps_gr);

1 0

[GIT] ppl/ppl(master): Warnings avoided.
by Roberto Bagnara 22 Apr '09

22 Apr '09

Module: ppl/ppl Branch: master Commit: 20168eb89529fe9be101fa6a9a459bf83d667d9a URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=20168eb89529… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Apr 22 21:22:19 2009 +0200 Warnings avoided. --- src/Bit_Row.inlines.hh | 16 ++++++++++++---- 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/Bit_Row.inlines.hh b/src/Bit_Row.inlines.hh index e262777..8b56ad1 100644 --- a/src/Bit_Row.inlines.hh +++ b/src/Bit_Row.inlines.hh @@ -50,14 +50,18 @@ Bit_Row::Bit_Row(const Bit_Row& y) { inline Bit_Row::Bit_Row(const Bit_Row& y, const Bit_Row& z) { const mp_size_t y_size = y.vec->_mp_size; + assert(y_size >= 0); const mp_size_t z_size = z.vec->_mp_size; + assert(z_size >= 0); if (y_size < z_size) { - assert(z_size <= ULONG_MAX / PPL_BITS_PER_GMP_LIMB); + assert(static_cast<unsigned long>(z_size) + <= ULONG_MAX / PPL_BITS_PER_GMP_LIMB); mpz_init2(vec, z_size * PPL_BITS_PER_GMP_LIMB); union_helper(y, z); } else { - assert(y_size <= ULONG_MAX / PPL_BITS_PER_GMP_LIMB); + assert(static_cast<unsigned long>(y_size) + <= ULONG_MAX / PPL_BITS_PER_GMP_LIMB); mpz_init2(vec, y_size * PPL_BITS_PER_GMP_LIMB); union_helper(z, y); } @@ -125,14 +129,18 @@ Bit_Row::total_memory_in_bytes() const { inline void set_union(const Bit_Row& x, const Bit_Row& y, Bit_Row& z) { const mp_size_t x_size = x.vec->_mp_size; + assert(x_size >= 0); const mp_size_t y_size = y.vec->_mp_size; + assert(y_size >= 0); if (x_size < y_size) { - assert(y_size <= ULONG_MAX / PPL_BITS_PER_GMP_LIMB); + assert(static_cast<unsigned long>(y_size) + <= ULONG_MAX / PPL_BITS_PER_GMP_LIMB); mpz_realloc2(z.vec, y_size * PPL_BITS_PER_GMP_LIMB); z.union_helper(x, y); } else { - assert(x_size <= ULONG_MAX / PPL_BITS_PER_GMP_LIMB); + assert(static_cast<unsigned long>(x_size) + <= ULONG_MAX / PPL_BITS_PER_GMP_LIMB); mpz_realloc2(z.vec, x_size * PPL_BITS_PER_GMP_LIMB); z.union_helper(y, x); }

1 0

[GIT] ppl/ppl(master): Tests 11 fails with checked-int32 coefficients.
by Patricia Hill 22 Apr '09

22 Apr '09

Module: ppl/ppl Branch: master Commit: 4086134c0c521d493e804794ca3d69d67f2e9631 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4086134c0c52… Author: Patricia Hill <p.m.hill(a)leeds.ac.uk> Date: Wed Apr 22 07:50:17 2009 +0100 Tests 11 fails with checked-int32 coefficients. --- tests/Grid/affineimage2.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/Grid/affineimage2.cc b/tests/Grid/affineimage2.cc index cdce6dc..0569ced 100644 --- a/tests/Grid/affineimage2.cc +++ b/tests/Grid/affineimage2.cc @@ -392,6 +392,6 @@ BEGIN_MAIN DO_TEST(test08); DO_TEST(test09); DO_TEST_F16A(test10); - DO_TEST_F16(test11); + DO_TEST_F32(test11); DO_TEST_F64(test12); END_MAIN

1 0

[GIT] ppl/ppl(master): Use of PPL_ARM_CAN_CONTROL_FPU made safer.
by Roberto Bagnara 21 Apr '09

21 Apr '09

Module: ppl/ppl Branch: master Commit: 7f4c56724b1b865aa8d8fc6ef563467d105ba609 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7f4c56724b1b… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Apr 21 21:53:44 2009 +0200 Use of PPL_ARM_CAN_CONTROL_FPU made safer. When the PPL has been configured with CPPFLAGS="-DPPL_ARM_CAN_CONTROL_FPU=1", the library initialization procedure checks that the FPU can indeed be controlled and fails if that is not the case. --- NEWS | 6 ++- TODO | 4 -- src/Init.cc | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 92 insertions(+), 7 deletions(-) diff --git a/NEWS b/NEWS index 9b35ac5..cc6ecb8 100644 --- a/NEWS +++ b/NEWS @@ -12,9 +12,11 @@ New and Changed Features o Implementation of general (NNC) polyhedra speeded up. +o When the PPL has been configured with + CPPFLAGS="-DPPL_ARM_CAN_CONTROL_FPU=1", the library initialization + procedure checks that the FPU can indeed be controlled and fails if + that is not the case. -New and Changed Features -======================== Deprecated and removed methods ------------------------------ diff --git a/TODO b/TODO index cfbd3be..6c4877d 100644 --- a/TODO +++ b/TODO @@ -10,10 +10,6 @@ Enhancements for PPL 0.11 current interface based on `abandon_expensive_computations'. - Get rid of ugly assign functions defined in anonymous namespace of MIP_Problem.cc replacing it with a more general-purpose approach. -- When the PPL has been configured with - CPPFLAGS="-DPPL_ARM_CAN_CONTROL_FPU=1" make sure the library initialization - procedure checks that the FPU can indeed be controlled, failing if - that is not the case. - Reconsider the datatype for the units parameter in the Watchdog constructors: should we prefer an unsigned? - Rename set_rational_sqrt_precision_parameter to diff --git a/src/Init.cc b/src/Init.cc index 35fb4f4..45e994d 100644 --- a/src/Init.cc +++ b/src/Init.cc @@ -38,6 +38,7 @@ site: http://www.cs.unipr.it/ppl/ . */ #include "Congruence_System.defs.hh" #include "Grid_Generator_System.defs.hh" #include "Polyhedron.defs.hh" +#include <stdexcept> namespace PPL = Parma_Polyhedra_Library; @@ -57,6 +58,81 @@ ppl_set_GMP_memory_allocation_functions(void) { ; #endif +#if PPL_CAN_CONTROL_FPU \ + && defined(PPL_ARM_CAN_CONTROL_FPU) && PPL_ARM_CAN_CONTROL_FPU + +namespace { + + float nf1 = -3, pf1 = 3, f2 = 5; + double nd1 = -7, pd1 = 7, d2 = 11; +long double nl1 = -13, pl1 = 13, l2 = 17; + + float nf[2], pf[2]; + double nd[2], pd[2]; +long double nl[2], pl[2]; + +int +ppl_check_function() { + int r = 0; + if (nf[0] == nf[1] || pf[0] == pf[1] || -nf[0] != pf[1] || -nf[1] != pf[0]) + r |= 1; + if (nd[0] == nd[1] || pd[0] == pd[1] || -nd[0] != pd[1] || -nd[1] != pd[0]) + r |= 2; + if (nl[0] == nl[1] || pl[0] == pl[1] || -nl[0] != pl[1] || -nl[1] != pl[0]) + r |= 4; + return r; +} + +int +ppl_setround_function(int rounding_mode) { + return fesetround(rounding_mode); +} + +} // namespace + +namespace Parma_Polyhedra_Library { + +namespace Implementation { + +int (* volatile ppl_check_function_p)() = ppl_check_function; +int (* volatile ppl_setround_function_p)(int) = ppl_setround_function; + +} // Implementation + +} // Parma_Polyhedra_Library + +namespace { + +int +ppl_test_rounding() { + if ((*ppl_setround_function_p)(FE_DOWNWARD) != 0) + return 255; + + nf[0] = nf1 / f2; + nd[0] = nd1 / d2; + nl[0] = nl1 / l2; + pf[0] = pf1 / f2; + pd[0] = pd1 / d2; + pl[0] = pl1 / l2; + + if ((*ppl_setround_function_p)(FE_UPWARD) != 0) + return 255; + + nf[1] = nf1 / f2; + nd[1] = nd1 / d2; + nl[1] = nl1 / l2; + pf[1] = pf1 / f2; + pd[1] = pd1 / d2; + pl[1] = pl1 / l2; + + return (*ppl_check_function_p)(); +} + +} // namespace + +#endif // PPL_CAN_CONTROL_FPU + // && defined(PPL_ARM_CAN_CONTROL_FPU) && PPL_ARM_CAN_CONTROL_FPU + PPL::Init::Init() { // Only when the first Init object is constructed... if (count++ == 0) { @@ -80,12 +156,23 @@ PPL::Init::Init() { Congruence_System::initialize(); Grid_Generator_System::initialize(); Polyhedron::initialize(); + #if PPL_CAN_CONTROL_FPU + // ... and the FPU rounding direction is set. fpu_initialize_control_functions(); old_rounding_direction = fpu_get_rounding_direction(); fpu_set_rounding_direction(round_fpu_dir(ROUND_DIRECT)); -#endif + +#if defined(PPL_ARM_CAN_CONTROL_FPU) && PPL_ARM_CAN_CONTROL_FPU + if (ppl_test_rounding() != 0) + throw std::logic_error("PPL configuration error:" + " PPL_ARM_CAN_CONTROL_FPU evaluates to true," + " but rounding does not work."); +#endif // defined(PPL_ARM_CAN_CONTROL_FPU) && PPL_ARM_CAN_CONTROL_FPU + +#endif // PPL_CAN_CONTROL_FPU + // The default is choosen to have a precision greater than most // precise IEC559 floating point (112 bits of mantissa). set_rational_sqrt_precision_parameter(128);

1 0

[GIT] ppl/ppl(master): Formatting improved.
by Roberto Bagnara 21 Apr '09

21 Apr '09

Module: ppl/ppl Branch: master Commit: ec293cdd3d5b33b1ba04947b000a98febf19056e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ec293cdd3d5b… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Apr 21 21:44:41 2009 +0200 Formatting improved. --- m4/ac_check_fpu_control.m4 | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/m4/ac_check_fpu_control.m4 b/m4/ac_check_fpu_control.m4 index d613777..30f8b98 100644 --- a/m4/ac_check_fpu_control.m4 +++ b/m4/ac_check_fpu_control.m4 @@ -78,7 +78,8 @@ ppl_setround_function(int rounding_mode) { int (* volatile ppl_check_function_p)() = ppl_check_function; int (* volatile ppl_setround_function_p)(int) = ppl_setround_function; -int main() { +int +main() { if ((*ppl_setround_function_p)(FE_DOWNWARD) != 0) return 255;

1 0

[GIT] ppl/ppl(master): Made the checks for HAVE_FENV_H systems more robust.
by Roberto Bagnara 21 Apr '09

21 Apr '09

Module: ppl/ppl Branch: master Commit: d50a679f90cf1a0f7ded6026f069f98d1428924e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d50a679f90cf… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Apr 21 21:33:32 2009 +0200 Made the checks for HAVE_FENV_H systems more robust. --- m4/ac_check_fpu_control.m4 | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/m4/ac_check_fpu_control.m4 b/m4/ac_check_fpu_control.m4 index 5ccbb68..d613777 100644 --- a/m4/ac_check_fpu_control.m4 +++ b/m4/ac_check_fpu_control.m4 @@ -59,7 +59,7 @@ long double nl1 = -13, pl1 = 13, l2 = 17; long double nl[2], pl[2]; int -check() { +ppl_check_function() { int r = 0; if (nf[0] == nf[1] || pf[0] == pf[1] || -nf[0] != pf[1] || -nf[1] != pf[0]) r |= 1; @@ -70,10 +70,16 @@ check() { return r; } -int (*fun)() = check; +int +ppl_setround_function(int rounding_mode) { + return fesetround(rounding_mode); +} + +int (* volatile ppl_check_function_p)() = ppl_check_function; +int (* volatile ppl_setround_function_p)(int) = ppl_setround_function; int main() { - if (fesetround(FE_DOWNWARD) != 0) + if ((*ppl_setround_function_p)(FE_DOWNWARD) != 0) return 255; nf[0] = nf1 / f2; @@ -83,7 +89,7 @@ int main() { pd[0] = pd1 / d2; pl[0] = pl1 / l2; - if (fesetround(FE_UPWARD) != 0) + if ((*ppl_setround_function_p)(FE_UPWARD) != 0) return 255; nf[1] = nf1 / f2; @@ -93,7 +99,7 @@ int main() { pd[1] = pd1 / d2; pl[1] = pl1 / l2; - return (*fun)(); + return (*ppl_check_function_p)(); } # endif

1 0

[GIT] ppl/w3ppl(master): BagnaraHZ09TRa updated.
by Roberto Bagnara 21 Apr '09

21 Apr '09

Module: ppl/w3ppl Branch: master Commit: 944947af338e2bc74089b0e09330151f0fc9bc7e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/w3ppl.git;a=commit;h=944947af33… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Apr 21 11:31:21 2009 +0200 BagnaraHZ09TRa updated. --- htdocs/Documentation/BagnaraHZ09TRa.pdf | Bin 311884 -> 312555 bytes htdocs/Documentation/ppl.bib | 3 ++- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/htdocs/Documentation/BagnaraHZ09TRa.pdf b/htdocs/Documentation/BagnaraHZ09TRa.pdf index d4740b9..1a6554d 100644 Binary files a/htdocs/Documentation/BagnaraHZ09TRa.pdf and b/htdocs/Documentation/BagnaraHZ09TRa.pdf differ diff --git a/htdocs/Documentation/ppl.bib b/htdocs/Documentation/ppl.bib index 03d4d3e..3d81fc5 100644 --- a/htdocs/Documentation/ppl.bib +++ b/htdocs/Documentation/ppl.bib @@ -940,7 +940,8 @@ Institution = "Dipartimento di Matematica, Universit\`a di Parma, Italy", Year = 2009, Note = "Available at \url{http://www.cs.unipr.it/Publications/}. - Also published as {\tt arXiv:cs.CG/0904.1783}, + An improved version (typos corrected in statement and proof + of Theorem~6.8) has been published as {\tt arXiv:cs.CG/0904.1783}, available from \url{http://arxiv.org/}.", Abstract = "Deciding whether the union of two convex polyhedra is a convex polyhedron is a basic problem in polyhedral

1 0