July 2014 - PPL-devel - BUGSENG Mailman

Failure building ppl under Cygwin 64 with a mingw target.
by Keith Clifford 01 Aug '14

01 Aug '14

Hi, I'm building a set of cross compilers to run under mingw and I got the error below. The set of packages and their versions to do the build are: Build machine: CYGWIN_NT-6.1 1.7.31(0.272/5/3) 2014-07-21 18:40 x86_64 Cygwin Components: gmp-6.0.0a mpfr-3.1.2 mpc-1.0.2 isl-0.12.2 cloog-0.18.1 ppl-1.1 binutils-2.24 gcc-4.9.1 newlib-2.1.0 gdb-7.7 I've attached the script, mkx, that I use for building the cross compilers, the test-suit log, and the make and check logs. The individual test logs are empty. I'm set up to run so if you'd like me to try anything, let me know and I can give it a go. When the build failed it said let you know and I'm going to continue investigating. I'll let you know if I find anything. Regards, Keith Keith Clifford Cell: 250 888-4558 Tranaptic Signature

2 6

Custom Number Types
by Stefan Schupp 29 Jul '14

29 Jul '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, another (maybe silly) question: How exactly to I extend the PPL (if possible) to my own number types? Is it sufficient to implement the checked_number policies? How do I add my type to the PPL afterwards? Best regards, Stefan - -- Stefan Schupp M.Sc. RWTH Aachen University Computer Science Department, Informatik 2 D-52056 Aachen, Germany http://www-i2.informatik.rwth-aachen.de/i2/schupp/ Tel.: +49 241 80 21243 -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - https://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJT0RDDAAoJEFPSi5GyofDjH4sH/1gwYU2SQqVcV71bfcPYbFgl Y0HVGEqOB4rRu6UqYq2g9K/fVx/JFEyw+fo2qbJUKCdexvz8DyHje9NNtABdRZev 7a6EnUQtHbN97VPQPnTtujuslb925FVnzbt1rZoWTYJAPHlJfy71yC7wbNrg6I4V O3TFLz3T6ETH3Oi2NPx2efcZhRC1VXkc85FIFpKQ3gzjGeHiwymiddQICuX/Ufg0 hrHK/20/K1iqXJ4HuzWBTy43ZebtYWRSjOAAt7o78KOUBIz/StNHSXh0UFRkbu7y zX7ZF9wPbePd91DR6JrJR5SZbqYOx3+90IfZw0quB/5CtWe3OfuYng/mvHcWfuI= =lfHt -----END PGP SIGNATURE-----

2 4

[GIT] ppl/ppl(compliance): Use a monotonic indentation style.
by Roberto Bagnara 28 Jul '14

28 Jul '14

Module: ppl/ppl Branch: compliance Commit: dbc2d08da5e9062670d62e7ff37aff35e7cec601 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=dbc2d08da5e9… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Mon Jul 28 21:45:24 2014 +0200 Use a monotonic indentation style. Fixes violations detected by ECLAIR checker B.MONOINDENT. --- src/Pending_List_templates.hh | 2 +- src/Polyhedron_minimize_templates.hh | 2 +- src/Polyhedron_simplify_templates.hh | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Pending_List_templates.hh b/src/Pending_List_templates.hh index 54f04f1..440b17e 100644 --- a/src/Pending_List_templates.hh +++ b/src/Pending_List_templates.hh @@ -42,7 +42,7 @@ Pending_List<Traits>::insert(const typename Traits::Threshold& deadline, position != active_list_end && Traits::less_than(position->deadline(), deadline); ++position) { - } + } iterator pending_element_p; // Only allocate a new element if the free list is empty. if (free_list.empty()) { diff --git a/src/Polyhedron_minimize_templates.hh b/src/Polyhedron_minimize_templates.hh index 40d1d53..d9e4e78 100644 --- a/src/Polyhedron_minimize_templates.hh +++ b/src/Polyhedron_minimize_templates.hh @@ -414,7 +414,7 @@ Polyhedron::add_and_minimize(const bool con_to_gen, if (dest[first_point].expr.get(Variable(dest.space_dimension())) > 0) { break; } - } + } } if (first_point == dest_num_rows) { diff --git a/src/Polyhedron_simplify_templates.hh b/src/Polyhedron_simplify_templates.hh index c2da7bc..71d4ffb 100644 --- a/src/Polyhedron_simplify_templates.hh +++ b/src/Polyhedron_simplify_templates.hh @@ -290,8 +290,8 @@ Polyhedron::simplify(Linear_System1& sys, Bit_Matrix& sat) { swap(sat[j], sat[num_rows]); swap(num_saturators[j], num_saturators[num_rows]); } - } - else { + } + else { // If we reach this point then we know that `sat[i]' does // not contain (and is different from) `sat[j]', so that // `sys[i]' is not made redundant by inequality `sys[j]'.

1 0

[GIT] ppl/ppl(compliance): Comments should never be used for " commenting out" code.
by Roberto Bagnara 27 Jul '14

27 Jul '14

Module: ppl/ppl Branch: compliance Commit: 270d1d0c5e09996d077b52a21a85bd6c7ca09a07 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=270d1d0c5e09… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sun Jul 27 09:29:04 2014 +0200 Comments should never be used for "commenting out" code. Fixes violations of rule EP1.17 detected by ECLAIR. --- src/Bit_Row.cc | 18 ++++++++++-------- src/CO_Tree_inlines.hh | 14 ++++++++------ src/PIP_Tree.cc | 8 +++++--- src/Polyhedron_nonpublic.cc | 2 -- src/iterator_to_const_defs.hh | 1 - 5 files changed, 23 insertions(+), 20 deletions(-) diff --git a/src/Bit_Row.cc b/src/Bit_Row.cc index c8e5e87..e17d475 100644 --- a/src/Bit_Row.cc +++ b/src/Bit_Row.cc @@ -47,14 +47,16 @@ unsigned long PPL::Bit_Row::next(unsigned long position) const { ++position; - // The alternative implementation using the mpz_scan1() function - // of GMP was measured to be slower that ours. Here it is, in - // case mpz_scan1() is improved. - // - // <CODE> - // unsigned long r = mpz_scan1(vec, position); - // return (r == C_Integer<unsigned long>::max) ? -1 : r; - // </CODE> + /* + The alternative implementation using the mpz_scan1() function + of GMP was measured to be slower that ours. Here it is, in + case mpz_scan1() is improved: + + <CODE> + unsigned long r = mpz_scan1(vec, position); + return (r == C_Integer<unsigned long>::max) ? -1 : r; + </CODE> + */ const unsigned long uli = position / PPL_BITS_PER_GMP_LIMB; mp_size_t li = static_cast<mp_size_t>(uli); diff --git a/src/CO_Tree_inlines.hh b/src/CO_Tree_inlines.hh index f94f81e..1209bf5 100644 --- a/src/CO_Tree_inlines.hh +++ b/src/CO_Tree_inlines.hh @@ -343,12 +343,14 @@ CO_Tree::refresh_cached_iterators() { inline void CO_Tree::move_data_element(data_type& to, data_type& from) { - // The following code is equivalent (but slower): - // - // <CODE> - // new (&to) data_type(from); - // from.~data_type(); - // </CODE> + /* + The following code is equivalent (but slower): + + <CODE> + new (&to) data_type(from); + from.~data_type(); + </CODE> + */ std::memcpy(&to, &from, sizeof(data_type)); } diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index dae15f1..fe2318b 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -28,9 +28,11 @@ site: http://bugseng.com/products/ppl/ . */ #include <memory> #include <map> -// #define NOISY_PIP_TREE_STRUCTURE 1 -// #define NOISY_PIP 1 -// #define VERY_NOISY_PIP 1 +#if 0 +#define NOISY_PIP_TREE_STRUCTURE 1 +#define NOISY_PIP 1 +#define VERY_NOISY_PIP 1 +#endif namespace Parma_Polyhedra_Library { diff --git a/src/Polyhedron_nonpublic.cc b/src/Polyhedron_nonpublic.cc index 4743e3c..70addd4 100644 --- a/src/Polyhedron_nonpublic.cc +++ b/src/Polyhedron_nonpublic.cc @@ -2453,8 +2453,6 @@ PPL::Polyhedron::positive_time_elapse_assign_impl(const Polyhedron& y) { } PPL_ASSERT(gs->OK()); - //gs->ascii_dump(std::cout); - //IO_Operators::operator<<(std::cout, *gs); const dimension_type gs_num_rows = gs->num_rows(); diff --git a/src/iterator_to_const_defs.hh b/src/iterator_to_const_defs.hh index 9a6c29e..0e011fc 100644 --- a/src/iterator_to_const_defs.hh +++ b/src/iterator_to_const_defs.hh @@ -26,7 +26,6 @@ site: http://bugseng.com/products/ppl/ . */ #include "iterator_to_const_types.hh" #include "Powerset_types.hh" -//#include "Ask_Tell_types.hh" #include <iterator> #ifdef PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS

1 0

Minkowski-Sum
by Stefan Schupp 24 Jul '14

24 Jul '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hello, I am currently searching for a possibility to obtain the Minkowski-Sum of two polyhedra. My first idea was to unify the sets of generators from both polyhedra, as from the documentation I can take that a single polytope is generated by the Minkowski-Sum of its generators. Would you suggest this approach or is there a better way to go? Best regards, Stefan Schupp - -- Stefan Schupp M.Sc. RWTH Aachen University Computer Science Department, Informatik 2 D-52056 Aachen, Germany http://www-i2.informatik.rwth-aachen.de/i2/schupp/ Tel.: +49 241 80 21243 -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - https://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTxm5XAAoJEFPSi5GyofDjy3MH+QHKFgXlkBdnH6kfS4uN5shl y/M8N4al1B2+py6fFPMcOqiHBu2O7r2K/kw16QuSuBDJwL/dPHhgpMBYdp22+aQy V+x9UVC70LaDm038pMcwrOLSn1Y2MZgxkblBnYisaYAYbSbUv05AxWF45u0f2yNS PH3yG7OWochrdY9s9ySbgM2DtFHg5jsd9VhE18OM/v05aALrccdT2BxmZcdEatGn nRwbnff2Xg71bFjhRwGlC4IY+OGgCpjtAdvmvqNy1VX+FBx5Lqy4ejtkoBOH/FB1 WUIEJchhaQXfHv+UxVY7MAht8cAdrSgUkevVeNpsB5YapXK5UCdnIrFoEH1Y04k= =P0qH -----END PGP SIGNATURE-----

2 1

[GIT] ppl/ppl(compliance): Keep source lines to a length of 120 characters or less.
by Roberto Bagnara 02 Jul '14

02 Jul '14

Module: ppl/ppl Branch: compliance Commit: b1f5eb2caa2b3459167784509b2cae4a94920a46 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b1f5eb2caa2b… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Jul 2 16:58:24 2014 +0200 Keep source lines to a length of 120 characters or less. Fixes violations of rule LP1.41 detected by ECLAIR. --- src/Checked_Number_defs.hh | 4 ++- src/Checked_Number_inlines.hh | 4 ++- src/Linear_Expression_defs.hh | 26 ++++++++++++++------- src/Linear_Expression_inlines.hh | 32 +++++++++++++++++---------- src/checked_int_inlines.hh | 44 ++++++++++++++++++++++++++++--------- src/fpu-ia32.cc | 4 ++- 6 files changed, 79 insertions(+), 35 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=b1f5eb2c…

1 0