August 2016 - PPL-devel - BUGSENG Mailman

Thread Safety
by John Paulson 22 Sep '16

22 Sep '16

Hi Developers, I have been using PPL for a couple of years, and I have just become interested in parallelizing an application I wrote that calls it. I tried to do this (using a parallel_for loop from TBB), but I ran into varied errors at run time. I noticed that in the TODO file of the PPL distribution that it has "Make the library thread-safe" on the list. Has this been done yet? Would the lack of thread safety lead to strange run time errors? Best, John C. Paulson

3 3

[GIT] ppl/ppl(devel): Let it compile cleanly in single-thread mode.
by Enea Zaffanella 27 Aug '16

27 Aug '16

Module: ppl/ppl Branch: devel Commit: 2488d53f08997e4b525f838627337736a1437241 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2488d53f0899… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Aug 27 13:32:58 2016 +0200 Let it compile cleanly in single-thread mode. --- demos/ppl_lpsol/ppl_lpsol.c | 39 ++++++++++++++++++++++++++------------- 1 files changed, 26 insertions(+), 13 deletions(-) diff --git a/demos/ppl_lpsol/ppl_lpsol.c b/demos/ppl_lpsol/ppl_lpsol.c index f42fde1..5483c71 100644 --- a/demos/ppl_lpsol/ppl_lpsol.c +++ b/demos/ppl_lpsol/ppl_lpsol.c @@ -679,7 +679,7 @@ maybe_check_results(args_t* args, if (!check_results) return; - if (no_mip || num_integer_variables == 0) + if (no_mip || args->num_integer_variables == 0) treat_as_lp = 1; glp_set_obj_dir(glpk_lp, (maximize ? GLP_MAX : GLP_MIN)); @@ -1246,9 +1246,11 @@ process_args(void* vp) { mpz_clear(args->den_lcm); assert(args->output_file == output_file); fclose(output_file); + output_file = NULL; free(args); } +#ifdef PPL_LPSOL_MULTI_THREADED static void* thread_process_args(void* vp) { ppl_thread_initialize(); @@ -1256,6 +1258,7 @@ thread_process_args(void* vp) { ppl_thread_finalize(); return NULL; } +#endif /* defined(PPL_LPSOL_MULTI_THREADED) */ static void error_handler(enum ppl_enum_error_code code, @@ -1296,6 +1299,8 @@ glpk_message_interceptor(void* info, char* msg) { #endif /* defined(NDEBUG) */ + +#ifdef PPL_LPSOL_MULTI_THREADED static const char* get_output_name(const char* input_name) { /* FIXME: to be made platform independent. */ @@ -1327,6 +1332,7 @@ get_output_name(const char* input_name) { strcat(output_name, extension); return output_name; } +#endif /* defined(PPL_LPSOL_MULTI_THREADED) */ static void set_output_file(const char* file_name) { @@ -1337,6 +1343,8 @@ set_output_file(const char* file_name) { if (output_file == NULL) fatal("cannot open output file `%s'", output_name); #else /* !defined(PPL_LPSOL_MULTI_THREADED) */ + /* In single threaded mode, output name does not depend on input name. */ + (void) file_name; if (output_argument) { output_file = fopen(output_argument, "w"); if (output_file == NULL) @@ -1369,7 +1377,6 @@ prepare_args(const char* file_name) { set_output_file(file_name); - glpk_lp = glp_create_prob(); glp_init_mpscp(&glpk_mpscp); if (verbosity == 0) { @@ -1577,7 +1584,6 @@ prepare_args(const char* file_name) { args->saved_ru_utime = saved_ru_utime; mpz_clear(den_lcm); - glp_delete_prob(glpk_lp); return args; } @@ -1652,23 +1658,28 @@ main(int argc, char* argv[]) { #ifndef PPL_LPSOL_MULTI_THREADED - while (optind < argc) { - if (check_results) - check_results_failed = 0; - file_name = argv[optind++]; - args = prepare_args(file_name); - process_args(args); - if (check_results && check_results_failed) - break; - } + /* Initialize glpk_lp (only once). */ + glpk_lp = glp_create_prob(); + assert(optind + 1 == argc); + if (check_results) + check_results_failed = 0; + file_name = argv[optind]; + args = prepare_args(file_name); + process_args(args); + /* Finalize glpk_lp (only once). */ + glp_delete_prob(glpk_lp); #else /* defined(PPL_LPSOL_MULTI_THEADED) */ /* Span all threads (MAX_THREADS at most). */ num_threads = 0; while (optind < argc && num_threads < MAX_THREADS) { + /* Initialize glpk_lp (once per thread). */ + glpk_lp = glp_create_prob(); file_name = argv[optind++]; args = prepare_args(file_name); + /* Finalize glpk_lp (once per thread). */ + glp_delete_prob(glpk_lp); /* Closing output_file is up to thread_process_args. */ output_file = NULL; worker = &threads[num_threads++]; @@ -1694,8 +1705,10 @@ main(int argc, char* argv[]) { mpz_clear(tmp_z); /* Close output file, if any. */ - if (output_file) + if (output_file) { fclose(output_file); + output_file = NULL; + } #ifdef PPL_LPSOL_SUPPORTS_CHECK_OPTION my_exit((check_results && check_results_failed) ? 1 : 0);

1 0

[GIT] ppl/ppl(devel): Added thread-safety support to the Java interface.
by Enea Zaffanella 27 Aug '16

27 Aug '16

Module: ppl/ppl Branch: devel Commit: 57895cf11406edbc38447cdbd0adaf212fc2bb37 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=57895cf11406… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Aug 27 12:38:42 2016 +0200 Added thread-safety support to the Java interface. --- interfaces/Java/jni/ppl_java_common.cc | 76 ++++++++++---- interfaces/Java/jni/ppl_java_common_defs.hh | 40 ++++++- interfaces/Java/jni/ppl_java_common_inlines.hh | 44 ++++++++ interfaces/Java/jni/ppl_java_globals.cc | 44 ++++---- .../Parma_Polyhedra_Library.java | 31 +++++ .../Java/parma_polyhedra_library/Variable.java | 5 +- .../Java/tests/Custom_Variable_Stringifier.java | 8 +- interfaces/Java/tests/Makefile.am | 17 +++- interfaces/Java/tests/Variable_Output_test1.java | 2 +- .../Java/tests/Variable_Output_thread_safe1.java | 117 ++++++++++++++++++++ 10 files changed, 330 insertions(+), 54 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=57895cf1…

1 0

[GIT] ppl/ppl(devel): New commits
by Roberto Bagnara 25 Aug '16

25 Aug '16

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9df657b33342… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Aug 25 18:20:00 2016 +0200 The ppl_lpsol demo program now supports thread safety. If multiple input files are given as input, each of them is processed by a separate thread. Note: the file reading phase, which used glpk, is performed by the master thread (since glpk is not thread safe). The maximum number of threads is fixed at compilation time (MAX_THREADS = 8). In multi-threaded mode the meaning of option -o is modified to specify the output *directory*. Commit partially based on previous work by Maxim Gaina. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=50b0bf678467… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Aug 25 18:16:22 2016 +0200 Added thread-safety support to the C interface. Commit mostly based on previous work by Maxim Gaina except that, as done for the C++ interface, library initialization also includes the main thread initialization. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e54f91f433a5… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Aug 24 11:51:06 2016 +0200 Avoid warning (when compiling with -std=c++11). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c33bf839ea7d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Aug 24 11:29:07 2016 +0200 Got rid of deprecated std::auto_ptr. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=80790f19fb86… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Aug 24 10:23:57 2016 +0200 Avoid data races on the Init counter. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=60ca8522be71… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Aug 24 10:12:35 2016 +0200 Let the timing utilities be thread-safe.

1 0

[GIT] ppl/ppl(devel): New commits
by Roberto Bagnara 23 Aug '16

23 Aug '16

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=75c235b6362d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Aug 23 21:05:16 2016 +0200 The ppl_lcdd demo program now supports thread safety. If multiple input files are given as input, they are processed concurrently by the threads from a thread pool. Note that in multi-threaded mode the meaning of option -o is modified to specify the output *directory*. Commit mostly based on previous work by Maxim Gaina. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c40453bec347… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Aug 23 11:45:19 2016 +0200 Added make_threadable helper (mostly based on work Maxim Gaina). Also added a couple of tests for thread-safety. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=11c3561b8db4… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Aug 22 22:43:03 2016 +0200 Improved library initialization/finalization code to support thread-safety. The initialization code is now split in two phases: - a library initialization phase (to be run only once); - a thread initialization phase (to be run once for each thread). Commit mostly based on previous work by Maxim Gaina except that, for convenience, the library initialization phase also includes the thread initialization phase for the main thread (i.e., explicit thread initialization is not required for the main thread, but only when starting new ones). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1aea35eabe78… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Aug 22 09:47:28 2016 +0200 Removed useless friend declaration. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6e641153d4c2… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sun Aug 21 14:59:15 2016 +0200 Added new macro PPL_TLS to (conditionally) require thread-local storage. Using the macro for statically allocated data (change to be completed). Commit based on previous work by Maxim Gaina. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3638d28a08ad… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sun Aug 21 14:19:55 2016 +0200 Added configuration option --enable-thread-safe (disabled by default).

1 0

Problem with PPL
by the anh pham 21 Aug '16

21 Aug '16

Dear Prof. Roberto, I am working with Parma Pplyhedra Library. I realize that PPL does not wok well with mutilthreading and it leads to segmentation fault. I read in the ChangeLog and found that you has discussed about this: "2015-11-26 Enea Zaffanella <zaffanella(a)cs.unipr.it> * src/Temp_defs.hh, src/Temp_inlines.hh, src/Temp_templates.hh: Avoid a memory leak due to the global list of dirty temporaries. The memory leak was not causing a real problem, in that the list of dirty temporaries is meant to survive up to the end of the process. However, it could cause a problem if/when the library is extended to become multi-thread safe, since in such a scenario it is meaningful to have a list of dirty temporaries for each thread (to be released on thread exit)." Has you fixed this problem. Could you give me a suggestion to solve this problem (it could be temporary solution) please? Best regards, The Anh

2 1

[GIT] ppl/ppl(devel): New commits
by Roberto Bagnara 11 Aug '16

11 Aug '16

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8ad9e3f3d504… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sat Jun 25 16:15:18 2016 +0200 Typo fixed. Found by ECLAIR service B.BUGFIND. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8c039f1512c6… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sat Apr 16 21:42:54 2016 +0200 Pattern improved. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0758ce9e6d58… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Mar 16 20:05:03 2016 +0100 Const correctness improved. Fixes violations of rule MP1.7-1-1 detected by ECLAIR. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ca9227e0a582… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 14 17:04:37 2016 +0100 Added missing macro definition. Fixes violations of rule MP1.16-0-7 detected by ECLAIR. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=529bc41610bf… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sat Feb 13 11:06:56 2016 +0100 Added `virtual' to overriding virtual funcion declarations. Fixes violations of rule MP1.10-3-2 detected by ECLAIR. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=223ee0387192… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sat Feb 13 11:03:14 2016 +0100 Fixed hexadecimal integer literal. Fixes a violation of rule MP1.2-13-3 detected by ECLAIR. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b5451eae8eb5… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sat Feb 13 11:01:16 2016 +0100 Include <cstring> instead of <string.h>. Fixes a violation of rule MP1.18-0-1 detected by ECLAIR. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d20a0a11262a… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sat Feb 13 08:24:47 2016 +0100 Const correctness improved. Fixes violations of rule MP1.7-1-1 detected by ECLAIR. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=72041c4d0d7f… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Fri Feb 12 10:03:55 2016 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c34e02a8180f… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Feb 11 13:31:26 2016 +0100 Update version. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5dd18cdb37ff… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Feb 11 13:31:26 2016 +0100 Mark ChangeLog. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=32df614c49c9… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Thu Feb 11 11:19:57 2016 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b0fbd976ddba… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Wed Feb 10 22:07:33 2016 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=17c8f764368e… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Wed Feb 10 22:06:28 2016 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4d25ba5cb437… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Wed Feb 10 21:41:00 2016 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0d4d67d35e24… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Wed Feb 10 21:39:09 2016 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=60e4eab0b57e… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Wed Feb 10 21:17:11 2016 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=037cb8aab52c… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Wed Feb 10 21:12:38 2016 +0100 Version number bumped.

1 0