- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): Reduced the scope of some variables.
by Roberto Bagnara 18 Feb '12

18 Feb '12

Module: ppl/ppl Branch: master Commit: a3c18f959cc3f93de367b3b129e995a5fe629648 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a3c18f959cc3… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Feb 18 19:33:38 2012 +0100 Reduced the scope of some variables. Detected by ECLAIR service minscope. --- src/Bit_Row.cc | 3 +-- src/Box.templates.hh | 2 +- src/Linear_Form.inlines.hh | 5 +++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Bit_Row.cc b/src/Bit_Row.cc index f9c73bd..47f153c 100644 --- a/src/Bit_Row.cc +++ b/src/Bit_Row.cc @@ -32,9 +32,8 @@ unsigned long PPL::Bit_Row::first() const { const mp_size_t vec_size = vec->_mp_size; PPL_ASSERT(vec_size >= 0); - mp_size_t li = 0; mp_srcptr p = vec->_mp_d; - for (; li < vec_size; ++li, ++p) { + for (mp_size_t li = 0; li < vec_size; ++li, ++p) { const mp_limb_t limb = *p; if (limb != 0) return li*PPL_BITS_PER_GMP_LIMB + Implementation::first_one(limb); diff --git a/src/Box.templates.hh b/src/Box.templates.hh index 1eb7023..e20fdc4 100644 --- a/src/Box.templates.hh +++ b/src/Box.templates.hh @@ -2364,7 +2364,6 @@ Box<ITV>::propagate_constraint_no_check(const Constraint& c) { // Here constraint c is non-trivial. PPL_ASSERT(last_k < c_space_dim); - Result r; Temp_Boundary_Type t_bound; Temp_Boundary_Type t_a; Temp_Boundary_Type t_x; @@ -2374,6 +2373,7 @@ Box<ITV>::propagate_constraint_no_check(const Constraint& c) { int sgn_a_k = sgn(a_k); if (sgn_a_k == 0) continue; + Result r; if (sgn_a_k > 0) { open = (c_type == Constraint::STRICT_INEQUALITY) ? T_YES : T_NO; if (open == T_NO) diff --git a/src/Linear_Form.inlines.hh b/src/Linear_Form.inlines.hh index 6778d68..de26a74 100644 --- a/src/Linear_Form.inlines.hh +++ b/src/Linear_Form.inlines.hh @@ -200,9 +200,10 @@ Linear_Form<C>::ascii_dump(std::ostream& s) const { using namespace IO_Operators; dimension_type space_dim = space_dimension(); s << space_dim << "\n"; - const char separator = ' '; - for (dimension_type i = 0; i <= space_dim; ++i) + for (dimension_type i = 0; i <= space_dim; ++i) { + const char separator = ' '; s << vec[i] << separator; + } s << "\n"; }

1 0

[GIT] ppl/ppl(master): Prefer explicit tests againts zero.
by Enea Zaffanella 17 Feb '12

17 Feb '12

Module: ppl/ppl Branch: master Commit: 7b5f76fb05d066c9e1e7192f1a6859974b662c6b URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7b5f76fb05d0… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 17 12:54:04 2012 +0100 Prefer explicit tests againts zero. Detected by ECLAIR service utypflag. --- src/Powerset.templates.hh | 2 +- src/ppl-config.cc.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Powerset.templates.hh b/src/Powerset.templates.hh index f75db0e..2c5d344 100644 --- a/src/Powerset.templates.hh +++ b/src/Powerset.templates.hh @@ -90,7 +90,7 @@ Powerset<D>::omega_reduce() const { xi = x.drop_disjunct(xi); else ++xi; - if (abandon_expensive_computations && xi != x.end()) { + if (abandon_expensive_computations != 0 && xi != x.end()) { // Hurry up! x.collapse(xi.base); break; diff --git a/src/ppl-config.cc.in b/src/ppl-config.cc.in index 9032589..0fafd39 100644 --- a/src/ppl-config.cc.in +++ b/src/ppl-config.cc.in @@ -241,7 +241,7 @@ void internal_error() { bool strcaseeq(const char* s1, const char* s2) { - while (*s1 && *s2 + while (*s1 != 0 && *s2 != 0 && tolower(static_cast<unsigned char>(*s1)) == tolower(static_cast<unsigned char>(*s2))) { ++s1;

1 0

[GIT] ppl/ppl(master): Avoid abusing sort-circuited logical operators.
by Enea Zaffanella 17 Feb '12

17 Feb '12

Module: ppl/ppl Branch: master Commit: 29d65d78b2f43ecac60f5dc0f1af0804d740acab URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=29d65d78b2f4… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 17 11:05:52 2012 +0100 Avoid abusing sort-circuited logical operators. --- src/Partially_Reduced_Product.templates.hh | 17 +++++++++++------ 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/Partially_Reduced_Product.templates.hh b/src/Partially_Reduced_Product.templates.hh index d79ab8f..313ed8a 100644 --- a/src/Partially_Reduced_Product.templates.hh +++ b/src/Partially_Reduced_Product.templates.hh @@ -442,12 +442,17 @@ Partially_Reduced_Product<D1, D2, R>::ascii_load(std::istream& s) { || str.substr(1) != "reduced") return false; reduced = (str[0] == yes); - return ((s >> str) && str == "Domain" - && (s >> str) && str == "1:" - && d1.ascii_load(s) - && (s >> str) && str == "Domain" - && (s >> str) && str == "2:" - && d2.ascii_load(s)); + if (!(s >> str) || str != "Domain") + return false; + if (!(s >> str) || str != "1:") + return false; + if (!d1.ascii_load(s)) + return false; + if (!(s >> str) || str != "Domain") + return false; + if (!(s >> str) || str != "2:") + return false; + return d2.ascii_load(s); } template <typename D1, typename D2>

1 0

[GIT] ppl/ppl(master): Avoid abusing short-circuited logical operators ( prefer explicit control flow).
by Enea Zaffanella 17 Feb '12

17 Feb '12

Module: ppl/ppl Branch: master Commit: b861970ac6a1e593686b21df0619cc0f171d7a70 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b861970ac6a1… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 17 11:04:37 2012 +0100 Avoid abusing short-circuited logical operators (prefer explicit control flow). Detected by ECLAIR service utypflag. --- src/Grid_chdims.cc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/Grid_chdims.cc b/src/Grid_chdims.cc index 8349adc..092dad7 100644 --- a/src/Grid_chdims.cc +++ b/src/Grid_chdims.cc @@ -365,7 +365,8 @@ PPL::Grid::remove_higher_space_dimensions(const dimension_type new_dimension) { // Count the actual number of rows that are now redundant. dimension_type num_redundant = 0; for (dimension_type row = space_dim; row > new_dimension; --row) - dim_kinds[row] == CON_VIRTUAL || ++num_redundant; + if (dim_kinds[row] != CON_VIRTUAL) + ++num_redundant; if (num_redundant > 0) { dimension_type rows = con_sys.num_rows(); // Shuffle the remaining rows upwards.

1 0

[GIT] ppl/ppl(master): Prefer explicit tests against zero.
by Enea Zaffanella 17 Feb '12

17 Feb '12

Module: ppl/ppl Branch: master Commit: 5712e36571a5ed8744e550d51199d16c3b9f89e7 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5712e36571a5… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 17 10:38:40 2012 +0100 Prefer explicit tests against zero. Detected by ECLAIR service utypflag. --- src/PIP_Problem.cc | 4 ++-- src/PIP_Tree.cc | 26 +++++++++++++------------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/PIP_Problem.cc b/src/PIP_Problem.cc index dfdc52b..bfe1c2c 100644 --- a/src/PIP_Problem.cc +++ b/src/PIP_Problem.cc @@ -335,7 +335,7 @@ PPL::PIP_Problem::OK() const { if (!initial_context.OK()) return false; - if (current_solution) { + if (current_solution != 0) { // Check well formedness of the solution tree. if (!current_solution->OK()) { #ifndef NDEBUG @@ -708,7 +708,7 @@ PPL::memory_size_type PPL::PIP_Problem::external_memory_in_bytes() const { memory_size_type n = initial_context.external_memory_in_bytes(); // Adding the external memory for `current_solution'. - if (current_solution) + if (current_solution != 0) n += current_solution->total_memory_in_bytes(); // Adding the external memory for `input_cs'. n += input_cs.capacity() * sizeof(Constraint); diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index 8114340..ae86937 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -1034,9 +1034,9 @@ PIP_Solution_Node::set_owner(const PIP_Problem* owner) { void PIP_Decision_Node::set_owner(const PIP_Problem* owner) { owner_ = owner; - if (false_child) + if (false_child != 0) false_child->set_owner(owner); - if (true_child) + if (true_child != 0) true_child->set_owner(owner); } @@ -1048,8 +1048,8 @@ PIP_Solution_Node::check_ownership(const PIP_Problem* owner) const { bool PIP_Decision_Node::check_ownership(const PIP_Problem* owner) const { return get_owner() == owner - && (!false_child || false_child->check_ownership(owner)) - && (!true_child || true_child->check_ownership(owner)); + && (false_child == 0 || false_child->check_ownership(owner)) + && (true_child == 0 || true_child->check_ownership(owner)); } const PIP_Solution_Node* @@ -1240,13 +1240,13 @@ PIP_Decision_Node::OK() const { return false; // Recursively check if child nodes are well-formed. - if (false_child && !false_child->OK()) + if (false_child != 0 && !false_child->OK()) return false; - if (true_child && !true_child->OK()) + if (true_child != 0 && !true_child->OK()) return false; // Decision nodes should always have a true child. - if (!true_child) { + if (true_child == 0) { #ifndef NDEBUG std::cerr << "PIP_Decision_Node with no 'true' child.\n"; #endif @@ -1254,9 +1254,9 @@ PIP_Decision_Node::OK() const { } // Decision nodes with a false child must have exactly one constraint. - if (false_child) { - dimension_type - dist = std::distance(constraints_.begin(), constraints_.end()); + if (false_child != 0) { + dimension_type dist = std::distance(constraints_.begin(), + constraints_.end()); if (dist != 1) { #ifndef NDEBUG std::cerr << "PIP_Decision_Node with a 'false' child has " @@ -1283,7 +1283,7 @@ PIP_Decision_Node::update_tableau( first_pending_constraint, input_cs, parameters); - if (false_child) + if (false_child != 0) false_child->update_tableau(pip, external_space_dim, first_pending_constraint, @@ -3411,7 +3411,7 @@ PIP_Decision_Node::external_memory_in_bytes() const { memory_size_type n = PIP_Tree_Node::external_memory_in_bytes(); PPL_ASSERT(true_child != 0); n += true_child->total_memory_in_bytes(); - if (false_child) + if (false_child != 0) n += false_child->total_memory_in_bytes(); return n; } @@ -3522,7 +3522,7 @@ PIP_Decision_Node::print_tree(std::ostream& s, unsigned indent, indent_and_print(s, indent, "else\n"); - if (false_child) + if (false_child != 0) false_child->print_tree(s, indent+1, pip_dim_is_param, child_first_art_dim); else

1 0

[GIT] ppl/ppl(master): Added helper is_space(), to be used instead of directly calling isspace().
by Enea Zaffanella 17 Feb '12

17 Feb '12

Module: ppl/ppl Branch: master Commit: 249a29efe092ce88e00fec45b2e00a9ca1bdb20b URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=249a29efe092… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 17 08:50:34 2012 +0100 Added helper is_space(), to be used instead of directly calling isspace(). --- src/Interval.templates.hh | 6 +++--- src/checked.cc | 2 +- src/globals.defs.hh | 3 +++ src/globals.inlines.hh | 6 ++++++ src/wrap_string.cc | 6 +++--- 5 files changed, 16 insertions(+), 7 deletions(-) diff --git a/src/Interval.templates.hh b/src/Interval.templates.hh index 8a77acc..b1425ec 100644 --- a/src/Interval.templates.hh +++ b/src/Interval.templates.hh @@ -241,7 +241,7 @@ operator>>(std::istream& is, Interval<Boundary, Info>& x) { do { if (!is.get(c)) goto fail; - } while (isspace(c)); + } while (is_space(c)); // Get the opening parenthesis and handle the empty interval case. if (c == '(') @@ -270,7 +270,7 @@ operator>>(std::istream& is, Interval<Boundary, Info>& x) { do { if (!is.get(c)) goto fail; - } while (isspace(c)); + } while (is_space(c)); if (c != ',') goto unexpected; @@ -284,7 +284,7 @@ operator>>(std::istream& is, Interval<Boundary, Info>& x) { do { if (!is.get(c)) goto fail; - } while (isspace(c)); + } while (is_space(c)); if (c == ')') upper_open = true; else if (c != ']') { diff --git a/src/checked.cc b/src/checked.cc index e35ed75..2fc1900 100644 --- a/src/checked.cc +++ b/src/checked.cc @@ -147,7 +147,7 @@ parse_number_part(std::istream& is, number_struct& numer) { do { if (!is.get(c)) return V_CVT_STR_UNK; - } while (isspace(c)); + } while (is_space(c)); switch (c) { case '-': numer.neg_mantissa = true; diff --git a/src/globals.defs.hh b/src/globals.defs.hh index b2bf946..cafe55a 100644 --- a/src/globals.defs.hh +++ b/src/globals.defs.hh @@ -350,6 +350,9 @@ struct Recycle_Input { << "for " PPL_XSTR(class_prefix) << "." << std::endl; \ } +//! Returns <CODE>true</CODE> if \p c is any kind of space character. +bool is_space(char c); + template <typename T, long long v, typename Enable = void> struct Fit : public False { }; diff --git a/src/globals.inlines.hh b/src/globals.inlines.hh index f132ea5..97bde3f 100644 --- a/src/globals.inlines.hh +++ b/src/globals.inlines.hh @@ -26,6 +26,7 @@ site: http://bugseng.com/products/ppl/ . */ #include <limits> #include <cassert> +#include <cctype> namespace Parma_Polyhedra_Library { @@ -120,6 +121,11 @@ total_memory_in_bytes(const mpq_class& x) { return sizeof(x) + external_memory_in_bytes(x); } +inline bool +is_space(char c) { + return isspace(c) != 0; +} + } // namespace Parma_Polyhedra_Library #endif // !defined(PPL_globals_inlines_hh) diff --git a/src/wrap_string.cc b/src/wrap_string.cc index 04f431e..1845f8d 100644 --- a/src/wrap_string.cc +++ b/src/wrap_string.cc @@ -51,7 +51,7 @@ wrap_string(const std::string& src_string, } if (src[i] == ',' && i < line_length) last_comma = i; - if (isspace(src[i]) && (i == 0 || !isspace(src[i-1]))) + if (is_space(src[i]) && (i == 0 || !is_space(src[i-1]))) last_space = i; } if (split_pos < 0) { @@ -65,7 +65,7 @@ wrap_string(const std::string& src_string, ++i; break; } - if (isspace(src[i])) + if (is_space(src[i])) break; } split_pos = i; @@ -75,7 +75,7 @@ wrap_string(const std::string& src_string, dst_string.append(indent_depth, ' '); dst_string.append(src, split_pos); src += split_pos; - if (isspace(*src)) + if (is_space(*src)) ++src; while (*src == ' ') ++src;

1 0

[GIT] ppl/ppl(master): Renamed is_infinity() as infinity_sign(), returning an `int' in {-1, 0, 1}.
by Enea Zaffanella 16 Feb '12

16 Feb '12

Module: ppl/ppl Branch: master Commit: 4921272596a31a0d7d68b67623911c2725736375 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4921272596a3… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 22:45:01 2012 +0100 Renamed is_infinity() as infinity_sign(), returning an `int' in {-1, 0, 1}. Prefer explicit tests against zero. Detected by ECLAIR service utypflag. --- src/Boundary.defs.hh | 2 +- src/Checked_Number.defs.hh | 2 +- src/Checked_Number.inlines.hh | 2 +- src/Interval.defs.hh | 4 +- src/Interval.inlines.hh | 50 ++++++++++++++++++++-------------------- 5 files changed, 30 insertions(+), 30 deletions(-) diff --git a/src/Boundary.defs.hh b/src/Boundary.defs.hh index 5af4328..72d8858 100644 --- a/src/Boundary.defs.hh +++ b/src/Boundary.defs.hh @@ -297,7 +297,7 @@ is_reverse_infinity(Boundary_Type type, const T& x, const Info& info) { template <typename T, typename Info> inline int -is_infinity(Boundary_Type type, const T& x, const Info& info) { +infinity_sign(Boundary_Type type, const T& x, const Info& info) { if (is_boundary_infinity(type, x, info)) return (type == LOWER) ? -1 : 1; else if (is_reverse_infinity(type, x, info)) diff --git a/src/Checked_Number.defs.hh b/src/Checked_Number.defs.hh index ce29ee0..3b998ca 100644 --- a/src/Checked_Number.defs.hh +++ b/src/Checked_Number.defs.hh @@ -452,7 +452,7 @@ is_plus_infinity(const T& x); /*! \relates Checked_Number */ template <typename T> typename Enable_If<Is_Native_Or_Checked<T>::value, int>::type -is_infinity(const T& x); +infinity_sign(const T& x); /*! \relates Checked_Number */ template <typename T> diff --git a/src/Checked_Number.inlines.hh b/src/Checked_Number.inlines.hh index 18b1f51..6e97d02 100644 --- a/src/Checked_Number.inlines.hh +++ b/src/Checked_Number.inlines.hh @@ -239,7 +239,7 @@ is_plus_infinity(const T& x) { template <typename T> inline typename Enable_If<Is_Native_Or_Checked<T>::value, int>::type -is_infinity(const T& x) { +infinity_sign(const T& x) { return is_minus_infinity(x) ? -1 : (is_plus_infinity(x) ? 1 : 0); } diff --git a/src/Interval.defs.hh b/src/Interval.defs.hh index 5ee45f5..bd0045b 100644 --- a/src/Interval.defs.hh +++ b/src/Interval.defs.hh @@ -456,7 +456,7 @@ public: info().set_boundary_property(UPPER, OPEN, true); } - bool is_infinity() const { + int infinity_sign() const { PPL_ASSERT(OK()); if (is_reverse_infinity(LOWER, lower(), info())) return 1; @@ -519,7 +519,7 @@ public: return assign(refinement); PPL_DIRTY_TEMP(Boundary, u); Result result = sub_2exp_assign_r(u, upper(), w, ROUND_UP); - if (!result_overflow(result) && u > lower()) + if (result_overflow(result) == 0 && u > lower()) return assign(refinement); info().clear(); switch (r) { diff --git a/src/Interval.inlines.hh b/src/Interval.inlines.hh index e3b15da..f8e659d 100644 --- a/src/Interval.inlines.hh +++ b/src/Interval.inlines.hh @@ -60,8 +60,8 @@ f_is_singleton(const Interval<Boundary, Info>& x) { } template <typename Boundary, typename Info> inline int -is_infinity(const Interval<Boundary, Info>& x) { - return x.is_infinity(); +infinity_sign(const Interval<Boundary, Info>& x) { + return x.infinity_sign(); } namespace Interval_NS { @@ -614,16 +614,16 @@ Interval<To_Boundary, To_Info>::add_assign(const From1& x, const From2& y) { PPL_ASSERT(f_OK(y)); if (check_empty_arg(x) || check_empty_arg(y)) return assign(EMPTY); - int inf = Parma_Polyhedra_Library::is_infinity(x); - if (inf) { - if (Parma_Polyhedra_Library::is_infinity(y) == -inf) + int inf_sign = Parma_Polyhedra_Library::infinity_sign(x); + if (inf_sign != 0) { + if (Parma_Polyhedra_Library::infinity_sign(y) == -inf_sign) return assign(EMPTY); } else - inf = Parma_Polyhedra_Library::is_infinity(y); - if (inf < 0) + inf_sign = Parma_Polyhedra_Library::infinity_sign(y); + if (inf_sign < 0) return assign(MINUS_INFINITY); - else if (inf > 0) + else if (inf_sign > 0) return assign(PLUS_INFINITY); PPL_DIRTY_TEMP(To_Info, to_info); to_info.clear(); @@ -651,16 +651,16 @@ Interval<To_Boundary, To_Info>::sub_assign(const From1& x, const From2& y) { PPL_ASSERT(f_OK(y)); if (check_empty_arg(x) || check_empty_arg(y)) return assign(EMPTY); - int inf = Parma_Polyhedra_Library::is_infinity(x); - if (inf) { - if (Parma_Polyhedra_Library::is_infinity(y) == inf) + int inf_sign = Parma_Polyhedra_Library::infinity_sign(x); + if (inf_sign != 0) { + if (Parma_Polyhedra_Library::infinity_sign(y) == inf_sign) return assign(EMPTY); } else - inf = -Parma_Polyhedra_Library::is_infinity(y); - if (inf < 0) + inf_sign = -Parma_Polyhedra_Library::infinity_sign(y); + if (inf_sign < 0) return assign(MINUS_INFINITY); - else if (inf > 0) + else if (inf_sign > 0) return assign(PLUS_INFINITY); PPL_DIRTY_TEMP(To_Info, to_info); @@ -708,16 +708,16 @@ Interval<To_Boundary, To_Info>::mul_assign(const From1& x, const From2& y) { int xus = (xls > 0) ? 1 : sgn_b(UPPER, f_upper(x), f_info(x)); int yls = sgn_b(LOWER, f_lower(y), f_info(y)); int yus = (yls > 0) ? 1 : sgn_b(UPPER, f_upper(y), f_info(y)); - int inf = Parma_Polyhedra_Library::is_infinity(x); + int inf_sign = Parma_Polyhedra_Library::infinity_sign(x); int ls, us; - if (inf) { + if (inf_sign != 0) { ls = yls; us = yus; goto inf; } else { - inf = Parma_Polyhedra_Library::is_infinity(y); - if (inf) { + inf_sign = Parma_Polyhedra_Library::infinity_sign(y); + if (inf_sign != 0) { ls = xls; us = xus; inf: @@ -726,8 +726,8 @@ Interval<To_Boundary, To_Info>::mul_assign(const From1& x, const From2& y) { if (ls == -us) return set_infinities(); if (ls < 0 || us < 0) - inf = -inf; - if (inf < 0) + inf_sign = -inf_sign; + if (inf_sign < 0) return assign(MINUS_INFINITY); else return assign(PLUS_INFINITY); @@ -877,15 +877,15 @@ Interval<To_Boundary, To_Info>::div_assign(const From1& x, const From2& y) { int yus = (yls > 0) ? 1 : sgn_b(UPPER, f_upper(y), f_info(y)); if (yls == 0 && yus == 0) return assign(EMPTY); - int inf = Parma_Polyhedra_Library::is_infinity(x); - if (inf) { - if (Parma_Polyhedra_Library::is_infinity(y)) + int inf_sign = Parma_Polyhedra_Library::infinity_sign(x); + if (inf_sign != 0) { + if (Parma_Polyhedra_Library::infinity_sign(y) != 0) return assign(EMPTY); if (yls == -yus) return set_infinities(); if (yls < 0 || yus < 0) - inf = -inf; - if (inf < 0) + inf_sign = -inf_sign; + if (inf_sign < 0) return assign(MINUS_INFINITY); else return assign(PLUS_INFINITY);

1 0

[GIT] ppl/ppl(master): New commits
by Roberto Bagnara 16 Feb '12

16 Feb '12

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=37719b83d11d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 21:48:03 2012 +0100 Prefer explicit tests against zero. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0d4a79c9ad28… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 21:44:34 2012 +0100 Prefer `while (true)' and `while (false)' wrt `while (1)' and `while(0)'. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=af3d0755dad9… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 21:39:07 2012 +0100 Prefer explicit tests against zero. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=69c5683e1657… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 21:37:02 2012 +0100 Prefer explicit tests against zero. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2b9312e845c2… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 21:33:25 2012 +0100 Prefer explicit tests against zero. Do not abusing short-circuit operators (prefer explicit control flow). Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=72ea4b00d875… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 21:30:21 2012 +0100 Prefer explicit test against zero. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b5e126e5bc24… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 18:31:29 2012 +0100 Prefer explicit usage of the istream::fail() method. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=77a999e4d467… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 16 18:13:59 2012 +0100 Rename as `const_bool_value' the "anonymous" enums encoding a bool value.

1 0

[GIT] ppl/ppl(master): Prefer using vector::resize wrt insert.
by Enea Zaffanella 15 Feb '12

15 Feb '12

Module: ppl/ppl Branch: master Commit: ca495c20a548f8befaa4402a2bd970ec252fb373 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ca495c20a548… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 15 22:48:38 2012 +0100 Prefer using vector::resize wrt insert. --- src/conversion.cc | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conversion.cc b/src/conversion.cc index 0f7e0b8..bb37274 100644 --- a/src/conversion.cc +++ b/src/conversion.cc @@ -398,9 +398,8 @@ PPL::Polyhedron::conversion(Linear_System& source, // product is 0 if and only if the generator saturates the // constraint. PPL_DIRTY_TEMP(std::vector<Coefficient>, scalar_prod); - const int needed_space = dest_num_rows - scalar_prod.size(); - if (needed_space > 0) - scalar_prod.insert(scalar_prod.end(), needed_space, Coefficient_zero()); + if (dest_num_rows > scalar_prod.size()) + scalar_prod.resize(dest_num_rows, Coefficient_zero()); // `index_non_zero' will indicate the first generator in `dest' // that does not saturate the constraint `source_k'. dimension_type index_non_zero = 0;

1 0

[GIT] ppl/ppl(master): Prefer explicit tests against zero.
by Enea Zaffanella 15 Feb '12

15 Feb '12

Module: ppl/ppl Branch: master Commit: 7c9fe958cb324b418ed19bba5ba6d99fba169cfe URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7c9fe958cb32… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 15 22:47:35 2012 +0100 Prefer explicit tests against zero. Detected by ECLAIR service utypflag. --- src/Grid_Status.inlines.hh | 2 +- src/Result.inlines.hh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Grid_Status.inlines.hh b/src/Grid_Status.inlines.hh index 1539605..935217a 100644 --- a/src/Grid_Status.inlines.hh +++ b/src/Grid_Status.inlines.hh @@ -43,7 +43,7 @@ Grid::Status::test_all(flags_t mask) const { inline bool Grid::Status::test_any(flags_t mask) const { - return flags & mask; + return (flags & mask) != 0; } inline void diff --git a/src/Result.inlines.hh b/src/Result.inlines.hh index 4f0a97f..36e754d 100644 --- a/src/Result.inlines.hh +++ b/src/Result.inlines.hh @@ -71,7 +71,7 @@ result_overflow(Result r) { inline bool result_representable(Result r) { - return !(r & V_UNREPRESENTABLE); + return (r & V_UNREPRESENTABLE) == 0; } inline Result operator|(Result a, Result b) {

1 0