- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): Added missing template parameter.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: a372f86d78f0effbfb551dd6f1078f6a4a7a0161 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a372f86d78f0… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 08:16:03 2012 +0100 Added missing template parameter. --- configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eed647d..983f8c7 100644 --- a/configure.ac +++ b/configure.ac @@ -24,7 +24,7 @@ # Process this file with Autoconf to produce a configure script. # Every other copy of the package version number gets its value from here. -AC_INIT([the Parma Polyhedra Library], [0.12pre4], [ppl-devel(a)cs.unipr.it] [ppl]) +AC_INIT([the Parma Polyhedra Library], [0.12pre5], [ppl-devel(a)cs.unipr.it] [ppl]) # Minimum Autoconf version required. AC_PREREQ(2.61) @@ -673,7 +673,7 @@ AM_CONDITIONAL(USE_INT64, test x"$coefficient_bits" = x64) if test x"$coefficient_kind" = xnative then - coefficient_type="Parma_Polyhedra_Library::Checked_Number<int${coefficient_bits}_t, Checked_Number_Transparent_Policy>" + coefficient_type="Parma_Polyhedra_Library::Checked_Number<int${coefficient_bits}_t, Checked_Number_Transparent_Policy<int${coefficient_bits}_t> >" AC_DEFINE_UNQUOTED(PPL_COEFFICIENT_TYPE, $coefficient_type, [The integral type used to represent coefficients.]) AC_DEFINE_UNQUOTED(PPL_COEFFICIENT_BITS, $coefficient_bits, [The number of bits of coefficients; 0 if unbounded.]) AC_DEFINE(PPL_NATIVE_INTEGERS, 1, [Defined if the integral type to be used for coefficients is a native one.])

1 0

[GIT] ppl/ppl(master): INT_MIN % -1 is undefined behavior in C++11.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: 7a847c76c10734e3d554f43963f647ac421f93f4 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7a847c76c107… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 08:14:28 2012 +0100 INT_MIN % -1 is undefined behavior in C++11. The PPL has been proven to be immune to this potential problem by ECLAIR. (Thanks to Rene Sugar.) Long lines avoided on passing. --- src/checked_int.inlines.hh | 55 +++++++++++++++++++++++++++++-------------- 1 files changed, 37 insertions(+), 18 deletions(-) diff --git a/src/checked_int.inlines.hh b/src/checked_int.inlines.hh index 0e0e421..ffcc55a 100644 --- a/src/checked_int.inlines.hh +++ b/src/checked_int.inlines.hh @@ -926,7 +926,8 @@ neg_int_larger(Type& to, const Type x, Rounding_Dir dir) { return assign<To_Policy, To_Policy>(to, l, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result add_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { typename Larger<Type>::type_for_add l = x; @@ -934,7 +935,8 @@ add_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { return assign<To_Policy, To_Policy>(to, l, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result sub_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { typename Larger<Type>::type_for_sub l = x; @@ -942,7 +944,8 @@ sub_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { return assign<To_Policy, To_Policy>(to, l, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result mul_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { typename Larger<Type>::type_for_mul l = x; @@ -973,7 +976,8 @@ neg_unsigned_int(Type& to, const Type from, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result add_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_add) @@ -990,7 +994,8 @@ add_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result add_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_add) @@ -1002,7 +1007,8 @@ add_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result sub_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_sub) @@ -1019,7 +1025,8 @@ sub_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result sub_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_sub) @@ -1031,7 +1038,8 @@ sub_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result mul_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_mul) @@ -1070,7 +1078,8 @@ mul_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result mul_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_mul) @@ -1089,7 +1098,8 @@ mul_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result div_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1100,6 +1110,8 @@ div_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { to = x / y; if (round_not_requested(dir)) return V_LGE; + if (y == -1) + return V_EQ; Type m = x % y; if (m < 0) return round_lt_int_no_overflow<To_Policy>(to, dir); @@ -1109,7 +1121,8 @@ div_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result div_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1124,7 +1137,8 @@ div_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return round_gt_int<To_Policy>(to, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result idiv_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1136,7 +1150,8 @@ idiv_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result idiv_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1146,17 +1161,19 @@ idiv_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result rem_signed_int(Type& to, const Type x, const Type y, Rounding_Dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { return assign_nan<To_Policy>(to, V_MOD_ZERO); } - to = x % y; + to = (y == -1) ? 0 : (x % y); return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result rem_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1453,7 +1470,8 @@ sqrt_signed_int(Type& to, const Type from, Rounding_Dir dir) { return sqrt_unsigned_int<To_Policy, From_Policy>(to, from, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result add_mul_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { Type z; @@ -1475,7 +1493,8 @@ add_mul_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { } } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result sub_mul_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { Type z;

1 0

[GIT] ppl/ppl(master): Reflected file removal.
by Roberto Bagnara 11 Feb '12

11 Feb '12

Module: ppl/ppl Branch: master Commit: cb83c4ee577c102c190f919efbd711ef53e7519a URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cb83c4ee577c… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Feb 11 21:02:10 2012 +0100 Reflected file removal. --- m4/Makefile.am | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/m4/Makefile.am b/m4/Makefile.am index e4dffad..bf7d977 100644 --- a/m4/Makefile.am +++ b/m4/Makefile.am @@ -48,7 +48,6 @@ ac_cxx_long_double_binary_format.m4 \ ac_cxx_long_double_exact_output.m4 \ ac_cxx_plain_char_is_signed.m4 \ ac_cxx_proper_long_double.m4 \ -ac_cxx_remainder_bug.m4 \ ac_prog_jar.m4 \ ac_prog_java.m4 \ ac_prog_javac.m4 \

1 0

[GIT] ppl/ppl(master): INT_MIN % -1 is undefined behavior in C++11.
by Roberto Bagnara 11 Feb '12

11 Feb '12

Module: ppl/ppl Branch: master Commit: ccd09e698f00e26a8dc4ccc2265843e6b9ec1598 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ccd09e698f00… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Feb 11 20:51:31 2012 +0100 INT_MIN % -1 is undefined behavior in C++11. The PPL has been proven to be immune to this potential problem by ECLAIR. (Thanks to Rene Sugar.) --- TODO | 7 ---- configure.ac | 5 +-- m4/ac_cxx_remainder_bug.m4 | 71 -------------------------------------------- src/checked.cc | 1 + 4 files changed, 2 insertions(+), 82 deletions(-) diff --git a/TODO b/TODO index 6ea8729..271fb42 100644 --- a/TODO +++ b/TODO @@ -23,13 +23,6 @@ Enhancements for PPL 0.12 or later versions Explain it in README.configure. - Ensure the tests in tests/MIP_Problem/* cover every line of code in MIP_Problem.*. -- Define functions rem() and remp() to compute the remainder of division - in the general case, for rem(), and in the case where the second - argument is known to be positive, for remp(). In the implementation - of rem(), if CXX_HAS_REMAINDER_BUG is nonzero, a suitable workaround - should be implemented to circumvent the INT_MIN % -1 bug. - rem() and remp() should be used (with a strong preference to the second, - of course) wherever we now use operator%(). - Suppose we want to sum three numbers, and suppose we do it by add(T& to, const T& x, const T& y, const T& z) { diff --git a/configure.ac b/configure.ac index 898f540..eed647d 100644 --- a/configure.ac +++ b/configure.ac @@ -24,7 +24,7 @@ # Process this file with Autoconf to produce a configure script. # Every other copy of the package version number gets its value from here. -AC_INIT([the Parma Polyhedra Library], [0.12pre3], [ppl-devel(a)cs.unipr.it] [ppl]) +AC_INIT([the Parma Polyhedra Library], [0.12pre4], [ppl-devel(a)cs.unipr.it] [ppl]) # Minimum Autoconf version required. AC_PREREQ(2.61) @@ -780,9 +780,6 @@ AC_CXX_SUPPORTS_ZERO_LENGTH_ARRAYS # Check whether the IEEE inexact flag is supported in C++. AC_CXX_SUPPORTS_IEEE_INEXACT_FLAG -# Check whether the C++ compiler has the remainder bug. -AC_CXX_HAS_REMAINDER_BUG - # Check whether the C++ compiler supports __attribute__ ((weak)). AC_CXX_SUPPORTS_ATTRIBUTE_WEAK diff --git a/m4/ac_cxx_remainder_bug.m4 b/m4/ac_cxx_remainder_bug.m4 deleted file mode 100644 index 0dfb146..0000000 --- a/m4/ac_cxx_remainder_bug.m4 +++ /dev/null @@ -1,71 +0,0 @@ -dnl A function to check whether the C++ compiler has the `remainder' bug. -dnl Copyright (C) 2001-2010 Roberto Bagnara <bagnara(a)cs.unipr.it> -dnl Copyright (C) 2010-2012 BUGSENG srl (http://bugseng.com) -dnl -dnl This file is part of the Parma Polyhedra Library (PPL). -dnl -dnl The PPL is free software; you can redistribute it and/or modify it -dnl under the terms of the GNU General Public License as published by the -dnl Free Software Foundation; either version 3 of the License, or (at your -dnl option) any later version. -dnl -dnl The PPL is distributed in the hope that it will be useful, but WITHOUT -dnl ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or -dnl FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License -dnl for more details. -dnl -dnl You should have received a copy of the GNU General Public License -dnl along with this program; if not, write to the Free Software Foundation, -dnl Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA. -dnl -dnl For the most up-to-date information see the Parma Polyhedra Library -dnl site: http://bugseng.com/products/ppl/ . - -AC_DEFUN([AC_CXX_HAS_REMAINDER_BUG], -[ - -ac_save_CPPFLAGS="$CPPFLAGS" -ac_save_LIBS="$LIBS" -AC_LANG_PUSH(C++) - -AC_MSG_CHECKING([if the compiler has the remainder bug]) -AC_RUN_IFELSE([AC_LANG_SOURCE([[ -#include <climits> - -int minus_one(int n) { - return (n+1)*(n-1)-n*n; -} - -int p(int x, int y) { - int z = x % y; - return z; -} - -int main(int argc, char** argv) { - if (p(INT_MIN, minus_one(argc)) != 0) - return 1; - else - return 0; -} -]])], - AC_MSG_RESULT(no) - ac_cv_cxx_has_remainder_bug=no, - AC_MSG_RESULT(yes) - ac_cv_cxx_has_remainder_bug=yes, - AC_MSG_RESULT([assuming yes]) - ac_cv_cxx_has_remainder_bug=yes) - -if test x"$ac_cv_cxx_has_remainder_bug" = xyes -then - value=1 -else - value=0 -fi -AC_DEFINE_UNQUOTED(PPL_CXX_HAS_REMAINDER_BUG, $value, - [Not zero if the C++ compiler has the remainder bug.]) - -AC_LANG_POP(C++) -CPPFLAGS="$ac_save_CPPFLAGS" -LIBS="$ac_save_LIBS" -]) - diff --git a/src/checked.cc b/src/checked.cc index 104fecf..93a933c 100644 --- a/src/checked.cc +++ b/src/checked.cc @@ -278,6 +278,7 @@ parse_number_part(std::istream& is, number_struct& numer) { goto unexpected; exp: state = EXPONENT; + PPL_ASSERT(numer.base >= 2); max_exp_div = LONG_MAX / numer.base; max_exp_rem = static_cast<int>(LONG_MAX % numer.base); if (!is.get(c))

1 0

[GIT] ppl/ppl(master): Added a default label to switch.
by Patricia Hill 03 Feb '12

03 Feb '12

Module: ppl/ppl Branch: master Commit: a190d3da98795c4e4a696746633e08fe8f335baa URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a190d3da9879… Author: Patricia Hill <p.m.hill(a)leeds.ac.uk> Date: Fri Feb 3 16:58:13 2012 +0000 Added a default label to switch. --- src/Grid_Generator.inlines.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Grid_Generator.inlines.hh b/src/Grid_Generator.inlines.hh index e691739..14379f6 100644 --- a/src/Grid_Generator.inlines.hh +++ b/src/Grid_Generator.inlines.hh @@ -76,8 +76,8 @@ Grid_Generator::type() const { case Generator::LINE: return LINE; case Generator::CLOSURE_POINT: + default: PPL_UNREACHABLE; - return POINT; } }

1 0

[GIT] ppl/ppl(master): Be consistent with the use of attribute weak.
by Roberto Bagnara 03 Feb '12

03 Feb '12

Module: ppl/ppl Branch: master Commit: 9516ac54f007f2155b89ac0453bdfcd85a4204de URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9516ac54f007… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Feb 3 10:19:01 2012 +0100 Be consistent with the use of attribute weak. --- src/assert.hh | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/assert.hh b/src/assert.hh index 1d6680a..e803a61 100644 --- a/src/assert.hh +++ b/src/assert.hh @@ -95,7 +95,12 @@ namespace Parma_Polyhedra_Library { #ifdef PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS //! Helper function causing program termination by calling \c abort. #endif // defined(PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS) -void ppl_unreachable() __attribute__((weak, noreturn)); +void ppl_unreachable() +#if PPL_CXX_SUPPORTS_ATTRIBUTE_WEAK + __attribute__((weak, noreturn)); +#else + __attribute__((noreturn)); +#endif #ifdef PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS /*! \brief @@ -105,7 +110,12 @@ void ppl_unreachable() __attribute__((weak, noreturn)); #endif // defined(PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS) void ppl_unreachable_msg(const char* msg, const char* file, unsigned int line, - const char* function) __attribute__((weak, noreturn)); + const char* function) +#if PPL_CXX_SUPPORTS_ATTRIBUTE_WEAK + __attribute__((weak, noreturn)); +#else + __attribute__((noreturn)); +#endif #ifdef PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS /*! \brief

1 0

[GIT] ppl/ppl(master): The functions fatal() and internal_error() are now attributed with noreturn.
by Roberto Bagnara 03 Feb '12

03 Feb '12

Module: ppl/ppl Branch: master Commit: 23359d3f3ae607d613f8fd535030dea5a66dc48f URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=23359d3f3ae6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Feb 3 10:18:08 2012 +0100 The functions fatal() and internal_error() are now attributed with noreturn. --- src/ppl-config.cc.in | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/ppl-config.cc.in b/src/ppl-config.cc.in index 7d23460..9032589 100644 --- a/src/ppl-config.cc.in +++ b/src/ppl-config.cc.in @@ -207,6 +207,9 @@ static const char* usage_string const char* program_name = 0; void +fatal(const char* format, ...) __attribute__((__noreturn__)); + +void fatal(const char* format, ...) { va_list ap; va_start(ap, format); @@ -230,6 +233,8 @@ warning(const char* format, ...) { } */ +void internal_error() __attribute__((__noreturn__)); + void internal_error() { fatal("internal error: please submit a bug report to ppl-devel(a)cs.unipr.it"); }

1 0

PPL (6 of 70 tests failed) OS X Lion, XCode 4.2 [clang]
by David Abdurachmanov 31 Jan '12

31 Jan '12

Hi, I am running 'make check' on my PPL build on Mac OS X Lion with XCode 4.2 using clang compiler. I was using clean environment (env -i) and additional environment variables: export CC='/Developer/usr/bin/clang' export CXX='/Developer/usr/bin/clang++' export F90FLAGS='-O2 -m64' export OBJC='/Developer/usr/bin/clang' export FCFLAGS='-O2 -m64' export INSTALL='/usr/bin/install -c' export OBJCFLAGS='-O2 -arch x86_64' export FFLAGS='-O2 -m64' export ABI='64' Here is the list of failed tests: tests failed: test08 FAIL: affineimage1 tests failed: test03 test04 FAIL: frompolyhedron1 tests failed: test01 test02 FAIL: frompolyhedron2 tests failed: test01 test03 FAIL: propagateconstraints2 tests failed: test01 FAIL: refinewithconstraint1 tests failed: test03 test04 FAIL: nnc_frompolyhedron1 $ /Developer/usr/bin/clang -v Apple clang version 3.0 (tags/Apple/clang-211.12) (based on LLVM 3.0svn) Target: x86_64-apple-darwin11.2.0 Thread model: posix Thanks, David

2 3

[GIT] ppl/ppl(master): Improved.
by Roberto Bagnara 22 Jan '12

22 Jan '12

Module: ppl/ppl Branch: master Commit: 9cd53027cc4ddcfe5e38030e697e968b26a4cfa1 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9cd53027cc4d… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Jan 22 20:44:03 2012 +0100 Improved. --- devtools/bump_copyright_years | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/devtools/bump_copyright_years b/devtools/bump_copyright_years index abf71c8..0fca806 100755 --- a/devtools/bump_copyright_years +++ b/devtools/bump_copyright_years @@ -1,8 +1,8 @@ -#!/bin/sh +#!/bin/bash temp_file=`mktemp /tmp/bump_copyright_years.XXXXXXXXXX` || exit 1 -for k in `find . -type f` +find . -type f -print0 | while read -d $'\0' file do - sed -e "s/Copyright (C) 2010-2012 BUGSENG srl/Copyright (C) 2010-2012 BUGSENG srl/g" <$k >$temp_file - chmod --reference=$k $temp_file - mv -f $temp_file $k + sed -e "s/Copyright (C) 2010-2012 BUGSENG srl/Copyright (C) 2010-2013 BUGSENG srl/g" <$file >$temp_file + chmod --reference=$file $temp_file + mv -f $temp_file $file done

1 0

[GIT] ppl/ppl(master): Reduced the scope of some variables.
by Roberto Bagnara 20 Jan '12

20 Jan '12

Module: ppl/ppl Branch: master Commit: 68ee3845682d61e60861d9c9afd9fdb707164c39 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=68ee3845682d… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jan 20 18:46:10 2012 +0100 Reduced the scope of some variables. Detected by ECLAIR service minscope. --- src/Grid.templates.hh | 2 +- src/Grid_Generator_System.cc | 2 +- src/Grid_public.cc | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Grid.templates.hh b/src/Grid.templates.hh index be1d9af..94d756f 100644 --- a/src/Grid.templates.hh +++ b/src/Grid.templates.hh @@ -66,12 +66,12 @@ Grid::Grid(const Box<Interval>& box, for (dimension_type k = space_dim; k-- > 0; ) { // This is declared here because it may be invalidated by the call to // gen_sys.insert() at the end of the loop. - Grid_Generator& point = gen_sys[0]; bool closed = false; // TODO: Consider producing the system(s) in minimized form. if (box.get_lower_bound(k, closed, l_n, l_d)) { if (box.get_upper_bound(k, closed, u_n, u_d)) if (l_n * u_d == u_n * l_d) { + Grid_Generator& point = gen_sys[0]; // A point interval sets dimension k of every point to a // single value. con_sys.insert(l_d * Variable(k) == l_n); diff --git a/src/Grid_Generator_System.cc b/src/Grid_Generator_System.cc index 4e9f3ba..534f5e9 100644 --- a/src/Grid_Generator_System.cc +++ b/src/Grid_Generator_System.cc @@ -83,10 +83,10 @@ PPL::Grid_Generator_System::recycling_insert(Grid_Generator& g) { void PPL::Grid_Generator_System::insert(const Grid_Generator& g) { - dimension_type g_space_dim = g.space_dimension(); if (g.is_parameter()) if (g.all_homogeneous_terms_are_zero()) { + dimension_type g_space_dim = g.space_dimension(); dimension_type initial_space_dim = space_dimension(); if (initial_space_dim < g_space_dim) { // Adjust the space dimension. diff --git a/src/Grid_public.cc b/src/Grid_public.cc index 17b8a9b..1d778b2 100644 --- a/src/Grid_public.cc +++ b/src/Grid_public.cc @@ -1059,7 +1059,8 @@ PPL::Grid::OK(bool check_not_empty) const { goto fail; Grid tmp_gr = *this; - Congruence_System cs_copy = tmp_gr.con_sys; + // Make a copy here, before changing tmp_gr, to check later. + const Congruence_System cs_copy = tmp_gr.con_sys; // Clear the generators in tmp_gr. Grid_Generator_System gs(space_dim); @@ -1643,7 +1644,6 @@ PPL::Grid::simplify_using_context_assign(const Grid& y) { const Congruence_System& x_cs = x.con_sys; const dimension_type x_cs_num_rows = x_cs.num_rows(); - const Grid_Generator_System& y_gs = y.gen_sys; // Record into `redundant_by_y' the info about which congruences of // `x' are redundant in the context `y'. Count the number of @@ -1704,6 +1704,7 @@ PPL::Grid::simplify_using_context_assign(const Grid& y) { const Coefficient& modulus = c.modulus(); div = modulus; + const Grid_Generator_System& y_gs = y.gen_sys; dimension_type num_ruled_out_generators = 0; for (Grid_Generator_System::const_iterator k = y_gs.begin(), y_gs_end = y_gs.end(); k != y_gs_end; ++k) {

1 0