- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): test09() no longer overflows with 8-bit coefficients and assertions on.
by Enea Zaffanella 23 Apr '12

23 Apr '12

Module: ppl/ppl Branch: master Commit: 0adb0e2766c1f07f21ddb85f02aab9f2f1523d08 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0adb0e2766c1… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Apr 23 09:10:05 2012 +0200 test09() no longer overflows with 8-bit coefficients and assertions on. --- tests/Powerset/simplifyusingcontext1.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/Powerset/simplifyusingcontext1.cc b/tests/Powerset/simplifyusingcontext1.cc index 51a3eef..42e6715 100644 --- a/tests/Powerset/simplifyusingcontext1.cc +++ b/tests/Powerset/simplifyusingcontext1.cc @@ -455,5 +455,5 @@ BEGIN_MAIN DO_TEST(test06); DO_TEST(test07); DO_TEST(test08); - DO_TEST_F8A(test09); + DO_TEST(test09); END_MAIN

1 0

R: Re: R: Re: PPL 0.12 bug reporting
by Erotavlas_turbo＠libero.it 21 Apr '12

21 Apr '12

Hi, >Yes, and more details are needed to understand what is going on. >Please send the file called `test-suite.log' that has been >created in the directory where `make check' fails. >Kind regards, I can't find this file `test-suite.log' inside the directory where I run make check. Thank you >----Messaggio originale---- >Da: bagnara(a)cs.unipr.it >Data: 21/04/2012 9.43 >A: "Erotavlas_turbo(a)libero.it"<Erotavlas_turbo(a)libero.it> >Cc: "The Parma Polyhedra Library developers' list"<ppl-devel(a)cs.unipr.it> >Ogg: Re: R: Re: [PPL-devel] PPL 0.12 bug reporting > >On 04/20/12 23:15, Erotavlas_turbo(a)libero.it wrote: >> Hi, > >Hi Salvatore. > >> I have attached the config.log file. > >Thanks. I saw nothing wrong in it. > >> At the end of the compilation process I >> get this messages >> >> PASS: C_Expr >> PASS: linearform1 >> PASS: linearize >> PASS: digitalfilters1 >> PASS: bdshape1 >> PASS: bdshape2 >> collect2: ld returned 1 exit statusnFAIL: octagonalshape1 >> collect2: ld returned 1 exit statusnFAIL: octagonalshape2 >> collect2: ld returned 1 exit statusnFAIL: polyhedron1 >> collect2: ld returned 1 exit statusnFAIL: polyhedron2 >> ====================================== >> 4 of 10 tests failed >> Please report to ppl-devel(a)cs.unipr.it >> ====================================== >> It seems a problem of ld. Is it right? > >Yes, and more details are needed to understand what is going on. >Please send the file called `test-suite.log' that has been >created in the directory where `make check' fails. >Kind regards, > > Roberto > >P.S. Please direct all messages to ppl-devel(a)cs.unipr.it > > >>> ----Messaggio originale---- >>> Da: bagnara(a)cs.unipr.it >>> Data: 16/04/2012 8.11 >>> A: "The Parma Polyhedra Library developers' list"<ppl-devel(a)cs.unipr.it> >>> Cc: "Erotavlas_turbo(a)libero.it"<Erotavlas_turbo(a)libero.it> >>> Ogg: Re: [PPL-devel] PPL 0.12 bug reporting >>> >>> On 04/15/12 11:11, Erotavlas_turbo(a)libero.it wrote: >>>> Hi, >>>> >>>> I have a problem with the latest version of PPL 0.12. I have tried to >> compile it with Ubuntu 64 bit 11.04 and 11.10. I can compile PPL well but when >> I make the tests (by make check), I get a message like this: >>>> >>>> Some test failed, please report a bug to the PPL developers. With the PPL >> 0.11 all the test are passed. >>>> >>>> Best Regards >>>> >>>> Salvatore Frandina >>> >>> Hi Salvatore, >>> >>> we need more details about the particular test(s) that failed. >>> Please compress and send also the config.log file that was >>> created at configure time. >>> Kind regards, >>> >>> Roberto >>> >>> -- >>> Prof. Roberto Bagnara >>> Applied Formal Methods Laboratory >>> Department of Mathematics, University of Parma, Italy >>> http://www.cs.unipr.it/~bagnara/ >>> mailto:bagnara@cs.unipr.it >>> >> > > >-- >Prof. Roberto Bagnara >Applied Formal Methods Laboratory >Department of Mathematics, University of Parma, Italy >http://www.cs.unipr.it/~bagnara/ >mailto:bagnara@cs.unipr.it >

2 1

[GIT] ppl/ppl(master): Fixed typo.
by Abramo Bagnara 21 Apr '12

21 Apr '12

Module: ppl/ppl Branch: master Commit: a57c6b6540476c0c5ce7b9fd4e2d99a4558d6a9a URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a57c6b654047… Author: Abramo Bagnara <abramo.bagnara(a)gmail.com> Date: Sat Apr 21 12:04:47 2012 +0200 Fixed typo. --- src/globals.defs.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/globals.defs.hh b/src/globals.defs.hh index e91ba78..15340c2 100644 --- a/src/globals.defs.hh +++ b/src/globals.defs.hh @@ -156,7 +156,7 @@ public: ++count; } ~In_Assert() { - ++count; + --count; } static bool asserting() { return count != 0;

1 0

[GIT] ppl/ppl(master): Protect in_assert flag from exceptions.
by Abramo Bagnara 21 Apr '12

21 Apr '12

Module: ppl/ppl Branch: master Commit: 1fd3370f93b3fbc26ad024a1bedc2d280660ecc3 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1fd3370f93b3… Author: Abramo Bagnara <abramo.bagnara(a)gmail.com> Date: Sat Apr 21 11:52:50 2012 +0200 Protect in_assert flag from exceptions. --- src/assert.hh | 3 +-- src/globals.cc | 4 +--- src/globals.defs.hh | 23 +++++++++++++++++------ src/globals.inlines.hh | 2 +- 4 files changed, 20 insertions(+), 12 deletions(-) diff --git a/src/assert.hh b/src/assert.hh index 7751da2..3c64266 100644 --- a/src/assert.hh +++ b/src/assert.hh @@ -82,9 +82,8 @@ site: http://bugseng.com/products/ppl/ . */ #else #define PPL_ASSERT_HEAVY(cond__) \ do { \ - ++Parma_Polyhedra_Library::Implementation::in_assert; \ + Parma_Polyhedra_Library::In_Assert guard; \ PPL_ASSERT_IMPL_(cond__); \ - --Parma_Polyhedra_Library::Implementation::in_assert; \ } while (false) #endif // !defined(NDEBUG) diff --git a/src/globals.cc b/src/globals.cc index ea28df1..7e11305 100644 --- a/src/globals.cc +++ b/src/globals.cc @@ -35,11 +35,9 @@ Weightwatch_Traits::Threshold Weightwatch_Traits::weight = 0; void (*Weightwatch_Traits::check_function)(void) = 0; #ifndef NDEBUG -namespace Implementation { -unsigned int in_assert = 0; +unsigned int In_Assert::count = 0; -} // namespace Implementation #endif diff --git a/src/globals.defs.hh b/src/globals.defs.hh index 339aef3..e91ba78 100644 --- a/src/globals.defs.hh +++ b/src/globals.defs.hh @@ -146,12 +146,23 @@ struct Weightwatch_Traits { #ifndef NDEBUG -namespace Implementation { -//! Non zero during evaluation of PPL_ASSERT expression. -extern unsigned int in_assert; +class In_Assert { +private: + //! Non zero during evaluation of PPL_ASSERT expression. + static unsigned int count; +public: + In_Assert() { + ++count; + } + ~In_Assert() { + ++count; + } + static bool asserting() { + return count != 0; + } +}; -} // namespace Implementation #endif @@ -524,12 +535,12 @@ least_significant_one_mask(dimension_type i); #define WEIGHT_BEGIN() #define WEIGHT_ADD(delta) \ do { \ - if (Implementation::in_assert == 0) \ + if (!In_Assert::asserting()) \ Weightwatch_Traits::weight += delta; \ } while (false) #define WEIGHT_ADD_MUL(delta, factor) \ do { \ - if (Implementation::in_assert == 0) \ + if (!In_Assert::asserting()) \ Weightwatch_Traits::weight += delta * factor; \ } while (false) #endif diff --git a/src/globals.inlines.hh b/src/globals.inlines.hh index ed9dc55..748f6dc 100644 --- a/src/globals.inlines.hh +++ b/src/globals.inlines.hh @@ -76,7 +76,7 @@ Throwable::~Throwable() { inline void maybe_abandon() { #ifndef NDEBUG - if (Implementation::in_assert != 0) + if (In_Assert::asserting()) return; #endif if (Weightwatch_Traits::check_function != 0)

1 0

Re: [PPL-devel] R: Re: PPL 0.12 bug reporting
by Roberto Bagnara 21 Apr '12

21 Apr '12

On 04/20/12 23:15, Erotavlas_turbo(a)libero.it wrote: > Hi, Hi Salvatore. > I have attached the config.log file. Thanks. I saw nothing wrong in it. > At the end of the compilation process I > get this messages > > PASS: C_Expr > PASS: linearform1 > PASS: linearize > PASS: digitalfilters1 > PASS: bdshape1 > PASS: bdshape2 > collect2: ld returned 1 exit statusnFAIL: octagonalshape1 > collect2: ld returned 1 exit statusnFAIL: octagonalshape2 > collect2: ld returned 1 exit statusnFAIL: polyhedron1 > collect2: ld returned 1 exit statusnFAIL: polyhedron2 > ====================================== > 4 of 10 tests failed > Please report to ppl-devel(a)cs.unipr.it > ====================================== > It seems a problem of ld. Is it right? Yes, and more details are needed to understand what is going on. Please send the file called `test-suite.log' that has been created in the directory where `make check' fails. Kind regards, Roberto P.S. Please direct all messages to ppl-devel(a)cs.unipr.it >> ----Messaggio originale---- >> Da: bagnara(a)cs.unipr.it >> Data: 16/04/2012 8.11 >> A: "The Parma Polyhedra Library developers' list"<ppl-devel(a)cs.unipr.it> >> Cc: "Erotavlas_turbo(a)libero.it"<Erotavlas_turbo(a)libero.it> >> Ogg: Re: [PPL-devel] PPL 0.12 bug reporting >> >> On 04/15/12 11:11, Erotavlas_turbo(a)libero.it wrote: >>> Hi, >>> >>> I have a problem with the latest version of PPL 0.12. I have tried to > compile it with Ubuntu 64 bit 11.04 and 11.10. I can compile PPL well but when > I make the tests (by make check), I get a message like this: >>> >>> Some test failed, please report a bug to the PPL developers. With the PPL > 0.11 all the test are passed. >>> >>> Best Regards >>> >>> Salvatore Frandina >> >> Hi Salvatore, >> >> we need more details about the particular test(s) that failed. >> Please compress and send also the config.log file that was >> created at configure time. >> Kind regards, >> >> Roberto >> >> -- >> Prof. Roberto Bagnara >> Applied Formal Methods Laboratory >> Department of Mathematics, University of Parma, Italy >> http://www.cs.unipr.it/~bagnara/ >> mailto:bagnara@cs.unipr.it >> > -- Prof. Roberto Bagnara Applied Formal Methods Laboratory Department of Mathematics, University of Parma, Italy http://www.cs.unipr.it/~bagnara/ mailto:bagnara@cs.unipr.it

1 0

Fwd: R: Re: PPL 0.12 bug reporting
by Roberto Bagnara 21 Apr '12

21 Apr '12

-------- Original Message -------- Subject: R: Re: [PPL-devel] PPL 0.12 bug reporting Date: Fri, 20 Apr 2012 23:15:35 +0200 (CEST) From: Erotavlas_turbo(a)libero.it <Erotavlas_turbo(a)libero.it> Reply-To: Erotavlas_turbo(a)libero.it <Erotavlas_turbo(a)libero.it> To: <bagnara(a)cs.unipr.it> Hi, I have attached the config.log file. At the end of the compilation process I get this messages PASS: C_Expr PASS: linearform1 PASS: linearize PASS: digitalfilters1 PASS: bdshape1 PASS: bdshape2 collect2: ld returned 1 exit statusnFAIL: octagonalshape1 collect2: ld returned 1 exit statusnFAIL: octagonalshape2 collect2: ld returned 1 exit statusnFAIL: polyhedron1 collect2: ld returned 1 exit statusnFAIL: polyhedron2 ====================================== 4 of 10 tests failed Please report to ppl-devel(a)cs.unipr.it ====================================== It seems a problem of ld. Is it right? Best Regards Salvatore >----Messaggio originale---- >Da: bagnara(a)cs.unipr.it >Data: 16/04/2012 8.11 >A: "The Parma Polyhedra Library developers' list"<ppl-devel(a)cs.unipr.it> >Cc: "Erotavlas_turbo(a)libero.it"<Erotavlas_turbo(a)libero.it> >Ogg: Re: [PPL-devel] PPL 0.12 bug reporting > >On 04/15/12 11:11, Erotavlas_turbo(a)libero.it wrote: >> Hi, >> >> I have a problem with the latest version of PPL 0.12. I have tried to compile it with Ubuntu 64 bit 11.04 and 11.10. I can compile PPL well but when I make the tests (by make check), I get a message like this: >> >> Some test failed, please report a bug to the PPL developers. With the PPL 0.11 all the test are passed. >> >> Best Regards >> >> Salvatore Frandina > >Hi Salvatore, > >we need more details about the particular test(s) that failed. >Please compress and send also the config.log file that was >created at configure time. >Kind regards, > > Roberto > >-- >Prof. Roberto Bagnara >Applied Formal Methods Laboratory >Department of Mathematics, University of Parma, Italy >http://www.cs.unipr.it/~bagnara/ >mailto:bagnara@cs.unipr.it >

1 0

[GIT] ppl/ppl(master): Another test where we get an overflow with changed sign.
by Enea Zaffanella 20 Apr '12

20 Apr '12

Module: ppl/ppl Branch: master Commit: 0cb66f9c98e9666127379244c2e14952e4c7c46e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0cb66f9c98e9… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Apr 20 10:34:42 2012 +0200 Another test where we get an overflow with changed sign. --- interfaces/Prolog/tests/expected_clpq2_int16 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/interfaces/Prolog/tests/expected_clpq2_int16 b/interfaces/Prolog/tests/expected_clpq2_int16 index 707c9d1..97834f0 100644 --- a/interfaces/Prolog/tests/expected_clpq2_int16 +++ b/interfaces/Prolog/tests/expected_clpq2_int16 @@ -21,7 +21,7 @@ PPL clpq ?- Y = 8 more? yes PPL clpq ?- yes PPL clpq ?- -Error: an overflow has been detected by the PPL: Negative overflow. +Error: an overflow has been detected by the PPL: Positive overflow. no PPL clpq ?- yes PPL clpq ?- X = 10

1 0

[GIT] ppl/ppl(master): Sign of overflow has changed.
by Enea Zaffanella 19 Apr '12

19 Apr '12

Module: ppl/ppl Branch: master Commit: 70e0472e92b89b4d9f9132925e3e672122587dc3 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=70e0472e92b8… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Apr 19 18:52:09 2012 +0200 Sign of overflow has changed. --- interfaces/Prolog/tests/expected_clpq2_int8 | 2 +- interfaces/Prolog/tests/expected_pchk_int8 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/interfaces/Prolog/tests/expected_clpq2_int8 b/interfaces/Prolog/tests/expected_clpq2_int8 index 4d11dbb..8696719 100644 --- a/interfaces/Prolog/tests/expected_clpq2_int8 +++ b/interfaces/Prolog/tests/expected_clpq2_int8 @@ -25,7 +25,7 @@ Error: an overflow has been detected by the PPL: Positive overflow. no PPL clpq ?- yes PPL clpq ?- -Error: an overflow has been detected by the PPL: Negative overflow. +Error: an overflow has been detected by the PPL: Positive overflow. no PPL clpq ?- yes PPL clpq ?- X =< 5 diff --git a/interfaces/Prolog/tests/expected_pchk_int8 b/interfaces/Prolog/tests/expected_pchk_int8 index 45056d1..c1a4555 100644 --- a/interfaces/Prolog/tests/expected_pchk_int8 +++ b/interfaces/Prolog/tests/expected_pchk_int8 @@ -3,5 +3,5 @@ Error: an overflow has been detected by the PPL: Positive overflow. Error: an overflow has been detected by the PPL: Negative overflow. -Error: an overflow has been detected by the PPL: Negative overflow. +Error: an overflow has been detected by the PPL: Positive overflow. OK

1 0

[GIT] ppl/ppl(master): test14() overflows with 16 bit integers and assertions turned off.
by Enea Zaffanella 19 Apr '12

19 Apr '12

Module: ppl/ppl Branch: master Commit: c0f985b6593077af5ac7bac2546a7db28e79799f URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c0f985b65930… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Apr 19 18:41:32 2012 +0200 test14() overflows with 16 bit integers and assertions turned off. --- tests/Grid/wrap1.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/Grid/wrap1.cc b/tests/Grid/wrap1.cc index d675c71..c826567 100644 --- a/tests/Grid/wrap1.cc +++ b/tests/Grid/wrap1.cc @@ -554,7 +554,7 @@ BEGIN_MAIN DO_TEST_F8(test11); DO_TEST_F8(test12); DO_TEST_F8(test13); - DO_TEST_F8(test14); + DO_TEST_F16(test14); DO_TEST_F8(test15); DO_TEST_F8(test16); DO_TEST_F8(test17);

1 0

[GIT] ppl/ppl(master): test16() overflows on 16 bits even with assertions turned off.
by Enea Zaffanella 19 Apr '12

19 Apr '12

Module: ppl/ppl Branch: master Commit: 6e0e4f3e2f9cf1a8e3390575e9522e97b5cceafd URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6e0e4f3e2f9c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Apr 19 18:38:06 2012 +0200 test16() overflows on 16 bits even with assertions turned off. --- tests/Grid/affineimage2.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/Grid/affineimage2.cc b/tests/Grid/affineimage2.cc index 7f04741..3aec6c8 100644 --- a/tests/Grid/affineimage2.cc +++ b/tests/Grid/affineimage2.cc @@ -392,7 +392,7 @@ BEGIN_MAIN DO_TEST(test07); DO_TEST(test08); DO_TEST(test09); - DO_TEST_F16A(test10); + DO_TEST_F16(test10); DO_TEST_F32(test11); DO_TEST_F64(test12); END_MAIN

1 0