November 2001 - PPL-devel - BUGSENG Mailman

ppl/src Matrix.cc
by Elisa Ricci 04 Nov '01

04 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: ericci(a)cs.unipr.it 2001-11-04 12:01:59 Modified files: src : Matrix.cc Log message: In function Matrix::gauss(), we change a row without changing "changed" that indicates that the matrix is changed: so the flag "sorted" of the matrix was true even if the matrix was not sorted. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Matrix.cc.diff?cvsroot=pp…

1 0

ppl/interfaces/Prolog/SICStus ppl_sicstus.cc
by Roberto Bagnara 04 Nov '01

04 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2001-11-04 10:25:02 Modified files: interfaces/Prolog/SICStus: ppl_sicstus.cc Log message: ppl_intersection_assign/2 calls Polyhedron::intersection_assign(). Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/interfaces/Prolog/SICStus/ppl…

1 0

Big commit
by Roberto Bagnara 04 Nov '01

04 Nov '01

Dear all, three days ago I started a simple project aimed at using Matrix::resize_no_copy() instead of Matrix::resize() in order to shrink matrices in the Polyhedron::remove...() methods. This looked like an easy task but it was not. To keep a long story short, this simple move triggered a series of bugs that has been difficult to track and also somewhat difficult to fix. And I have still not finished to fix them. However, I have already modified too many files to delay the commit any longer. Even though this commit does not show any regression, I have tagged the sources before and after the commit. The tags used are before_big_RB_commit_on_Nov_04 after_big_RB_commit_on_Nov_04 Notice that the problems testified by bug1.cc and bug2.cc are exactly the same, before and after the commit. Ciao, Roberto -- Roberto Bagnara Computer Science Group Department of Mathematics, University of Parma, Italy http://www.cs.unipr.it/~bagnara/ mailto:bagnara@cs.unipr.it

1 0

ppl/src ConSys.cc GenSys.cc Makefile.am Matrix ...
by Roberto Bagnara 04 Nov '01

04 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2001-11-04 09:38:35 Modified files: src : ConSys.cc GenSys.cc Makefile.am Matrix.cc Matrix.defs.hh Matrix.inlines.hh Polyhedron.cc Row.cc Row.defs.hh Row.inlines.hh SatRow.inlines.hh conversion.cc globals.hh minimize.cc Removed files: src : globals.cc Log message: OK() methods changed to allow for ConSys and GenSys with a single column. Temporary Integer's now incapsulated into a function: the source globals.cc is no longer necessary. The funcionality of Matrix::compute_row_capacity() is now provided by Row::compute_capacity(). Tracking of capacity improved (there are still several problems though). Matrix::sort_rows() rewritten: the STL algorithms keep the freedom of making copies of rows and we cannot accept that. Temporaty kludges added to the Matrix::add_row() methods: if the rows vector must grow, the implementation will copy the rows changing their capacity. A proper solution to this problem must be found. OK() safety checks added tp Polyhedron::remove_dimensions() and Polyhedron::remove_higher_dimensions(). Polyhedron::remove_dimensions() and Polyhedron::remove_higher_dimensions() where not clearing the "generators are minimized" flag. With this change the flag is cleared a bit too often. A proper solution must be found. Polyhedron::remove_dimensions() and Polyhedron::remove_higher_dimensions() now use Matrix::resize_no_copy() instead of Matrix::resize() in order to shrink matrices. Row::OK() added and used. When compiling with assertions each rows brings its own capacity in the capacity_ flag. The consistency of this information is checked by Row::OK() which, in turn, is called by Matrix::OK() for each row of the matrix. For internal use, the capacity_ field can be accessed by `size_t Row::capacity() const'. `void Row::assign(Row& y)' added to assign the implementation of y to *this. `std::iter_swap()' specialized both for vector<Row> and vector<SatRow>. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/ConSys.cc.diff?cvsroot=pp… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/GenSys.cc.diff?cvsroot=pp… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Makefile.am.diff?cvsroot=… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Matrix.cc.diff?cvsroot=pp… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Matrix.defs.hh.diff?cvsro… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Matrix.inlines.hh.diff?cv… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Polyhedron.cc.diff?cvsroo… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Row.cc.diff?cvsroot=ppl&r… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Row.defs.hh.diff?cvsroot=… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Row.inlines.hh.diff?cvsro… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/SatRow.inlines.hh.diff?cv… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/conversion.cc.diff?cvsroo… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/globals.hh.diff?cvsroot=p… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/minimize.cc.diff?cvsroot=… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/globals.cc.diff?cvsroot=p…

1 0

ppl/tests Makefile.am bug2.cc
by Roberto Bagnara 04 Nov '01

04 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2001-11-04 08:50:01 Modified files: tests : Makefile.am Added files: tests : bug2.cc Log message: bug2.cc shows a problem whereby we do not correctly keep track of the status of saturation matrices. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/bug2.cc.diff?cvsroot=pp… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/Makefile.am.diff?cvsroo…

1 0

ppl/tests Makefile.am bug1.cc
by Roberto Bagnara 04 Nov '01

04 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2001-11-04 08:29:28 Modified files: tests : Makefile.am Added files: tests : bug1.cc Log message: bug1.cc shows a problem with the tracking of matrix sortedness. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/bug1.cc.diff?cvsroot=pp… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/Makefile.am.diff?cvsroo…

1 0

ppl/tests append1.cc
by Roberto Bagnara 03 Nov '01

03 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2001-11-03 17:08:22 Modified files: tests : append1.cc Log message: Two assertions added: they prove that Polyhedron::remove_dimensions() is broken. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/append1.cc.diff?cvsroot…

1 0

ppl/src ConSys.defs.hh GenSys.defs.hh
by Enea Zaffanella 03 Nov '01

03 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: zaffanella(a)cs.unipr.it 2001-11-03 13:49:05 Modified files: src : ConSys.defs.hh GenSys.defs.hh Log message: "no guarantee at all" changed into "no guarantees" as suggested by Pat. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/ConSys.defs.hh.diff?cvsro… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/GenSys.defs.hh.diff?cvsro…

1 0

ppl/src Polyhedron.cc
by Elisa Ricci 03 Nov '01

03 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: ericci(a)cs.unipr.it 2001-11-03 10:45:04 Modified files: src : Polyhedron.cc Log message: In a comment correct an error: there was "systemo" instead of "system". Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Polyhedron.cc.diff?cvsroo…

1 0

ppl interfaces/Prolog/SICStus/ppl_sicstus.cc s ...
by Elisa Ricci 03 Nov '01

03 Nov '01

CVSROOT: /cvs/ppl Module name: ppl Changes by: ericci(a)cs.unipr.it 2001-11-03 10:40:01 Modified files: interfaces/Prolog/SICStus: ppl_sicstus.cc src : Polyhedron.cc Polyhedron.defs.hh tests : inters1.cc inters2.cc Log message: The function Polyhedron::intersection_assign now is Polyhedron::intersection_assign_and_minimize. Added a new function Polyhedron::intersection_assign that computes the intersection between x and y without minimizing the result. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/interfaces/Prolog/SICStus/ppl… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Polyhedron.cc.diff?cvsroo… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Polyhedron.defs.hh.diff?c… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/inters1.cc.diff?cvsroot… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/inters2.cc.diff?cvsroot…

1 0