March 2002 - PPL-devel - BUGSENG Mailman

Even more questionable feature of the C++ interface (GMP 4.0.1)
by Roberto Bagnara 05 Apr '02

05 Apr '02

I did it again and this time is even worse. Without looking at the documentation I thought there should be an assignment operator for assigning an mpz_t to a class_mpz. So I did it, the compiler did not complain even with -Wall -W and then strange behavior started. The guilty is now the following line in <gmpxx.h> __gmp_expr & operator=(bool b) { mpz_set_ui(mp, b); return *this; } Strictly speaking, I am not reporting anything new with respect to my previous message. What makes things worse is that I now realize that it is much easier to be bitten by this problem, since, IMHO, the user is somewhat legitimate to assume that mpz_t objects can be used to initialize/assign to mpz_class objects. My revised proposal is that these two lines in <gmpxx.hh> __gmp_expr(bool b) { mpz_init_set_ui(mp, b); } __gmp_expr & operator=(bool b) { mpz_set_ui(mp, b); return *this; } are _replaced_ by their analagous taking an mpz_t argument. Here is a small test program that exemplifies the problem: /////////////////////////////////////////////////////////////////////////// #include <gmp.h> #include <gmpxx.h> #include <iostream> using namespace std; int main() { mpz_class n; mpz_t m; mpz_init_set_si(m, 123); // I thought I was assigning 123 to n... n = m; // ... but I was assigning 1! cout << n << endl; } /////////////////////////////////////////////////////////////////////////// All the best Roberto -- Prof. Roberto Bagnara Computer Science Group Department of Mathematics, University of Parma, Italy http://www.cs.unipr.it/~bagnara/ mailto:bagnara@cs.unipr.it _______________________________________________ PPL-devel mailing list PPL-devel(a)cs.unipr.it http://www.cs.unipr.it/mailman/listinfo/ppl-devel

3 3

ppl ./TODO interfaces/C/Makefile.am interfaces ...
by Roberto Bagnara 31 Mar '02

31 Mar '02

1 0

ppl ./configure.ac interfaces/C/Makefile.am in ...
by Roberto Bagnara 31 Mar '02

31 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-31 21:35:59 Modified files: . : configure.ac interfaces/C : Makefile.am Added files: interfaces/C/lpenum: .cvsignore Makefile.am lpenum.c Log message: Added a first starting draft of `lpenum', a program to solve linear programming problems by vertex/point enumeration. Just a toy to test the C interface of the library. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/configure.ac.diff?cvsroot=ppl… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/interfaces/C/Makefile.am.diff… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/interfaces/C/lpenum/.cvsignor… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/interfaces/C/lpenum/Makefile.… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/interfaces/C/lpenum/lpenum.c.…

1 0

ppl/interfaces/C/lpenum
by Roberto Bagnara 31 Mar '02

31 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-31 21:14:08 ppl/interfaces/C/lpenum Update of /cvs/ppl/ppl/interfaces/C/lpenum In directory spartacus.cs.unipr.it:/tmp/cvs-serv6641/lpenum Log Message: Directory /cvs/ppl/ppl/interfaces/C/lpenum added to the repository

1 0

ppl/src Generator.cc Matrix.cc PolyBase.cc Row ...
by Roberto Bagnara 31 Mar '02

31 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-31 20:55:05 Modified files: src : Generator.cc Matrix.cc PolyBase.cc Row.cc SatMatrix.cc Log message: All the OK() methods are now silent if the NDEBUG symbol is defined. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Generator.cc.diff?cvsroot… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Matrix.cc.diff?cvsroot=pp… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.cc.diff?cvsroot=… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Row.cc.diff?cvsroot=ppl&r… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/SatMatrix.cc.diff?cvsroot…

1 0

ppl/src PolyBase.cc
by Roberto Bagnara 31 Mar '02

31 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-31 19:26:24 Modified files: src : PolyBase.cc Log message: Always provide default cases in switches. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.cc.diff?cvsroot=…

1 0

ppl/src ConSys.defs.hh ConSys.inlines.hh Const ...
by Roberto Bagnara 31 Mar '02

31 Mar '02

1 0

ppl/src PolyBase.cc
by Roberto Bagnara 31 Mar '02

31 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-31 11:45:22 Modified files: src : PolyBase.cc Log message: Started exploiting the return value of PolyBase::minimize(). Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.cc.diff?cvsroot=…

1 0

ppl/tests Makefile.am widening1.cc
by Roberto Bagnara 31 Mar '02

31 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-31 11:42:34 Modified files: tests : Makefile.am Added files: tests : widening1.cc Log message: Test Polyhedron::widening_assign() with empty polyhedra. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/widening1.cc.diff?cvsro… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/Makefile.am.diff?cvsroo…

1 0

ppl/src PolyBase.cc
by Roberto Bagnara 31 Mar '02

31 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-31 10:31:10 Modified files: src : PolyBase.cc Log message: PolyBase::intersection_assign_and_minimize() fixed. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.cc.diff?cvsroot=…

1 0