March 2002 - PPL-devel - BUGSENG Mailman

ppl/src PolyBase.defs.hh
by Roberto Bagnara 27 Mar '02

27 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-27 18:54:37 Modified files: src : PolyBase.defs.hh Log message: Documentation for PolyBase::OK() improved. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.defs.hh.diff?cvs…

1 0

ppl ./TODO interfaces/C/ppl_c.cc src/NNC_Polyh ...
by Roberto Bagnara 27 Mar '02

27 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-27 18:45:20 Modified files: . : TODO interfaces/C : ppl_c.cc src : NNC_Polyhedron.cc PolyBase.cc PolyBase.defs.hh Polyhedron.cc Log message: Now the default for PolyBase::OK() is not to check for non-emptiness. This is more consistent since OK() without arguments now checks for well-formedness only as all the other methods with the same name. Use OK(true) if you want the extra service of non-emptiness checking. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/TODO.diff?cvsroot=ppl&r1=1.16… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/interfaces/C/ppl_c.cc.diff?cv… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/NNC_Polyhedron.cc.diff?cv… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.cc.diff?cvsroot=… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.defs.hh.diff?cvs… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Polyhedron.cc.diff?cvsroo…

1 0

ppl/src ConSys.cc ConSys.defs.hh Constraint.cc ...
by Enea Zaffanella 27 Mar '02

27 Mar '02

1 0

Documenting the classes PolyBase, Polyhedron and NNC_Polyhedron.
by Enea Zaffanella 27 Mar '02

27 Mar '02

Hi all. Now that we have merged the strict branch into the main one, we have to find a proper way of documenting classes PolyBase, Polyhedron and NNC_Polyhedron, as far as the "user" manual is concerned. In _theory_, PolyBase is related to implementation and it should not appear in the user manual. However, as things are now, almost all the methods are defined only in PolyBase and barely inherited by the two derived classes. This will be eventually solved by having both Polyhedron and NNC_Polyhedron inherit in a "protected" way from the base class and then populating the Polyhedron and NNC_Polyhedron classes of "using" directives (hoping that Doxygen will understand them). This way, topology mismatches will be detected at compile time. Now, Doxygen has two configuration variables named INHERIT_DOCS and INLINE_INHERITED_MEMBERS. The following comes from the Doxygen manual: ================== INHERIT_DOCS If the INHERIT_DOCS tag is set to YES (the default) then an undocumented member inherits the documentation from any documented member that it reimplements. ================== INLINE_INHERITED_MEMB If the INLINE_INHERITED_MEMB tag is set to YES, doxygen will show all inherited members of a class in the documentation of that class as if those members were ordinary class members. Constructors, destructors and assignment operators of the base classes will not be shown. =================== These seems not enough for our goal, for 4 reasons: 1) I am not sure that Doxygen will interpret a "using" directive as the redefinition of a method, so that INHERIT_DOCS may not work; 2) according to the above explanation, INHERIT_DOCS works provided the underlying methods of the class PolyBase are _documented_, whereas in the user manual all "implementation" classes should NOT be documented. 3) Even if we avoid the above problems (e.g., by using the variable INLINE_INHERITED MEMBERS), we would end-up having all the methods documented twice, once in Polyhedron and once in NNC_Polyhedron. 4) It seems to me that protected methods are documented in any case, i.e., they are NOT affected by the HIDE_PRIVATE_MEMBERS variable. Also, I cannot see handy alternatives. A possible solution is to have class PolyBase appear in the user manual and document all the common methods there. Also, to avoid spreading the documentation here and there, ALL the examples should appear in the detailed description section of the class PolyBase, included those examples that describe methods implemented in the derived classes, such as the constructors, the conversion functions mapping a Polyhedron into a NNC_Polyhedron and viceversa, and those few dedicated methods such as is_topologically_closed(). Is anyone foreseeing better alternatives ? Enea.

3 2

ppl/src PolyBase.cc
by Roberto Bagnara 27 Mar '02

27 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-27 16:43:59 Modified files: src : PolyBase.cc Log message: PolyBase::OK(bool check_not_empty) was disregarding its argument in some cases. This bug was hiding two bogus assertions in PolyBase::add_constraints() and PolyBase::add_constraints_and_minimize(). Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.cc.diff?cvsroot=…

1 0

ppl/tests addconstraints1.cc
by Roberto Bagnara 27 Mar '02

27 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-27 16:42:03 Modified files: tests : addconstraints1.cc Log message: Unused variable removed. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/tests/addconstraints1.cc.diff…

1 0

ppl/src NNC_Polyhedron.defs.hh Polyhedron.defs.hh
by Enea Zaffanella 27 Mar '02

27 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: zaffanella(a)cs.unipr.it 2002-03-27 16:03:59 Modified files: src : NNC_Polyhedron.defs.hh Polyhedron.defs.hh Log message: Removed duplicate documentation stuff from Polyhedron.defs.hh. Documented constructors of classes Polyhedron and NNC_Polyhedron. Provided a brief explanation of the reason why we do have 2 classes. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/NNC_Polyhedron.defs.hh.di… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Polyhedron.defs.hh.diff?c…

1 0

ppl TODO
by Roberto Bagnara 27 Mar '02

27 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: roberto(a)cs.unipr.it 2002-03-27 15:37:02 Modified files: . : TODO Log message: At a closer scrutiny, the <CODE> and </CODE> tags are actually superior to any other alternative. Remove the TODO item that suggested not to use them. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/TODO.diff?cvsroot=ppl&r1=1.15…

1 0

ppl/src ConSys.defs.hh GenSys.defs.hh Generato ...
by Enea Zaffanella 27 Mar '02

27 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: zaffanella(a)cs.unipr.it 2002-03-27 12:01:24 Modified files: src : ConSys.defs.hh GenSys.defs.hh Generator.defs.hh PolyBase.defs.hh Row.cc Log message: Started adjusting the documentation to made it aware of the new kind of constraints and generators. Corrected a couple of docuementation problems causing Doxygen warnings. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/ConSys.defs.hh.diff?cvsro… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/GenSys.defs.hh.diff?cvsro… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Generator.defs.hh.diff?cv… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.defs.hh.diff?cvs… http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/Row.cc.diff?cvsroot=ppl&r…

1 0

ppl/src PolyBase.cc
by Enea Zaffanella 27 Mar '02

27 Mar '02

CVSROOT: /cvs/ppl Module name: ppl Changes by: zaffanella(a)cs.unipr.it 2002-03-27 10:05:47 Modified files: src : PolyBase.cc Log message: One FIXME removed: was related to an efficiency concern where we really do not have any efficiency problem. Patches: http://www.cs.unipr.it/cgi-bin/cvsweb.cgi/ppl/src/PolyBase.cc.diff?cvsroot=…

1 0