February 2010 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(floating_point): Removed whitespaces.
by Roberto Amadini 22 Feb '10

22 Feb '10

Module: ppl/ppl Branch: floating_point Commit: 670c44bcc1e510cd4a88f605fbd402c411da6fe8 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=670c44bcc1e5… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Mon Feb 22 22:21:24 2010 +0100 Removed whitespaces. --- src/Variable_Floating_Point_Expression.inlines.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Variable_Floating_Point_Expression.inlines.hh b/src/Variable_Floating_Point_Expression.inlines.hh index a9ddd2f..48843d0 100644 --- a/src/Variable_Floating_Point_Expression.inlines.hh +++ b/src/Variable_Floating_Point_Expression.inlines.hh @@ -73,7 +73,7 @@ Variable_Floating_Point_Expression<FP_Interval_Type, FP_Format> i != lf_store.end();) { typename FP_Linear_Form_Abstract_Store::iterator j = i++; - if ( (j->second).coefficient(Variable(variable_index)) != 0 ) { + if ((j->second).coefficient(Variable(variable_index)) != 0) { lf_store.erase(j); } }

1 0

[GIT] ppl/ppl(floating_point): Fixed indentation.
by Roberto Amadini 22 Feb '10

22 Feb '10

Module: ppl/ppl Branch: floating_point Commit: 8d085a775bc86b61c993ed8abe96ad8b2735e211 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8d085a775bc8… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Mon Feb 22 22:15:50 2010 +0100 Fixed indentation. --- src/BD_Shape.templates.hh | 6 +- src/Cast_Floating_Point_Expression.templates.hh | 2 +- ...fference_Floating_Point_Expression.templates.hh | 4 +- ...Division_Floating_Point_Expression.templates.hh | 4 +- ...lication_Floating_Point_Expression.templates.hh | 4 +- src/Octagonal_Shape.templates.hh | 2 +- src/Opposite_Floating_Point_Expression.inlines.hh | 2 +- src/Sum_Floating_Point_Expression.templates.hh | 4 +- src/Variable_Floating_Point_Expression.inlines.hh | 2 +- tests/Floating_Point_Expression/digitalfilters1.cc | 62 ++++++++++---------- .../floatingpointexpr1.cc | 4 +- 11 files changed, 48 insertions(+), 48 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=8d085a77…

1 0

[GIT] ppl/ppl(floating_point): Fixed digitalfilters1.cc
by Roberto Amadini 22 Feb '10

22 Feb '10

Module: ppl/ppl Branch: floating_point Commit: f2aee435d05bfdd61cb831362a346006104bf968 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f2aee435d05b… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Mon Feb 22 17:35:09 2010 +0100 Fixed digitalfilters1.cc --- tests/Floating_Point_Expression/digitalfilters1.cc | 118 +++++++++++--------- 1 files changed, 67 insertions(+), 51 deletions(-) diff --git a/tests/Floating_Point_Expression/digitalfilters1.cc b/tests/Floating_Point_Expression/digitalfilters1.cc index 4a04f40..a36341d 100644 --- a/tests/Floating_Point_Expression/digitalfilters1.cc +++ b/tests/Floating_Point_Expression/digitalfilters1.cc @@ -492,29 +492,32 @@ test05() { abstract_store.affine_form_image(D, FP_Linear_Form(tmp)); // S = Y; + abstract_store.affine_form_image(S, FP_Linear_Form(tmp)); Var_FP_Expression var_y(Y.id()); - if(var_y.linearize(abstract_store, lf_abstract_store, ly)) + if(var_y.linearize(abstract_store, lf_abstract_store, ly)) { bd.affine_form_image(S, ly); - abstract_store.affine_form_image(S, FP_Linear_Form(tmp)); - // Intersection between the values of the variables in - // the BD_Shape and in the abstract store. - abstract_store.intersection_assign(Box<FP_Interval>(bd)); + // Intersection between the values of the variables in + // the BD_Shape and in the abstract store. + abstract_store.intersection_assign(Box<FP_Interval>(bd)); + } // R = X - S; Var_FP_Expression* px = new Var_FP_Expression(X.id()); Var_FP_Expression* ps = new Var_FP_Expression(S.id()); Dif_FP_Expression x_dif_s(px, ps); - if(x_dif_s.linearize(abstract_store, lf_abstract_store, lr)) - bd.affine_form_image(R, lr); abstract_store.affine_form_image(R, FP_Linear_Form(X - S)); - abstract_store.intersection_assign(Box<FP_Interval>(bd)); + if(x_dif_s.linearize(abstract_store, lf_abstract_store, lr)) { + bd.affine_form_image(R, lr); + abstract_store.intersection_assign(Box<FP_Interval>(bd)); + } // Y = X; Var_FP_Expression var_x(X.id()); - if(var_x.linearize(abstract_store, lf_abstract_store, lx)) - bd.affine_form_image(Y, lx); abstract_store.affine_form_image(Y, FP_Linear_Form(X)); - abstract_store.intersection_assign(Box<FP_Interval>(bd)); + if(var_x.linearize(abstract_store, lf_abstract_store, lx)) { + bd.affine_form_image(Y, lx); + abstract_store.intersection_assign(Box<FP_Interval>(bd)); + } // if (R <= -D) FP_BD_Shape bd_then(bd); @@ -526,10 +529,11 @@ test05() { Var_FP_Expression* pd = new Var_FP_Expression(D.id()); Var_FP_Expression* ps2 = new Var_FP_Expression(S.id()); Dif_FP_Expression s_dif_d(ps2, pd); - if(s_dif_d.linearize(as_then, lf_abstract_store, ly)) - bd_then.affine_form_image(Y, ly); as_then.affine_form_image(Y, FP_Linear_Form(S - D)); - as_then.intersection_assign(Box<FP_Interval>(bd_then)); + if(s_dif_d.linearize(as_then, lf_abstract_store, ly)) { + bd_then.affine_form_image(Y, ly); + as_then.intersection_assign(Box<FP_Interval>(bd_then)); + } // else skip; bd.refine_with_linear_form_inequality(-lk, lr); @@ -551,10 +555,11 @@ test05() { Var_FP_Expression* pd1 = new Var_FP_Expression(D.id()); Var_FP_Expression* ps3 = new Var_FP_Expression(S.id()); Sum_FP_Expression s_sum_d(ps3, pd1); - if(s_sum_d.linearize(as_then, lf_abstract_store, ly)) - bd_then.affine_form_image(Y, ly); as_then.affine_form_image(Y, FP_Linear_Form(S + D)); - as_then.intersection_assign(Box<FP_Interval>(bd_then)); + if(s_sum_d.linearize(as_then, lf_abstract_store, ly)) { + bd_then.affine_form_image(Y, ly); + as_then.intersection_assign(Box<FP_Interval>(bd_then)); + } // else skip; bd.refine_with_linear_form_inequality(lr, lk); @@ -668,28 +673,32 @@ test06() { // S = Y. Var_FP_Expression var_y(Y.id()); - if(var_y.linearize(abstract_store, lf_abstract_store, ly)) - oc.affine_form_image(S, ly); abstract_store.affine_form_image(S, FP_Linear_Form(Y)); - // Intersection between the values of the variables in - // the octagon and in the abstract store. - abstract_store.intersection_assign(Box<FP_Interval>(oc)); + if(var_y.linearize(abstract_store, lf_abstract_store, ly)) { + oc.affine_form_image(S, ly); + // Intersection between the values of the variables in + // the octagon and in the abstract store. + abstract_store.intersection_assign(Box<FP_Interval>(oc)); + } // R = X - S; Var_FP_Expression* px = new Var_FP_Expression(X.id()); Var_FP_Expression* ps = new Var_FP_Expression(S.id()); Dif_FP_Expression x_dif_s(px, ps); - if(x_dif_s.linearize(abstract_store, lf_abstract_store, lr)) - oc.affine_form_image(R, lr); abstract_store.affine_form_image(R, FP_Linear_Form(X - S)); - abstract_store.intersection_assign(Box<FP_Interval>(oc)); + if(x_dif_s.linearize(abstract_store, lf_abstract_store, lr)) { + oc.affine_form_image(R, lr); + abstract_store.intersection_assign(Box<FP_Interval>(oc)); + } // Y = X; Var_FP_Expression var_x(X.id()); - if(var_x.linearize(abstract_store, lf_abstract_store, lx)) - oc.affine_form_image(Y, lx); abstract_store.affine_form_image(Y, FP_Linear_Form(X)); - abstract_store.intersection_assign(Box<FP_Interval>(oc)); + if(var_x.linearize(abstract_store, lf_abstract_store, lx)) { + oc.affine_form_image(Y, lx); + abstract_store.intersection_assign(Box<FP_Interval>(oc)); + } + // if (R <= -D) FP_Octagonal_Shape oc_then(oc); @@ -701,10 +710,11 @@ test06() { Var_FP_Expression* pd = new Var_FP_Expression(D.id()); Var_FP_Expression* ps2 = new Var_FP_Expression(S.id()); Dif_FP_Expression s_dif_d(ps2, pd); - if(s_dif_d.linearize(as_then, lf_abstract_store, ly)) - oc_then.affine_form_image(Y, ly); as_then.affine_form_image(Y, FP_Linear_Form(S - D)); - as_then.intersection_assign(Box<FP_Interval>(oc_then)); + if(s_dif_d.linearize(as_then, lf_abstract_store, ly)) { + oc_then.affine_form_image(Y, ly); + as_then.intersection_assign(Box<FP_Interval>(oc_then)); + } // else skip. oc.refine_with_linear_form_inequality(-lk, lr); @@ -726,10 +736,11 @@ test06() { Var_FP_Expression* pd1 = new Var_FP_Expression(D.id()); Var_FP_Expression* ps3 = new Var_FP_Expression(S.id()); Sum_FP_Expression s_sum_d(ps3, pd1); - if(s_sum_d.linearize(as_then, lf_abstract_store, ly)) - oc_then.affine_form_image(Y, ly); as_then.affine_form_image(Y, FP_Linear_Form(S + D)); - as_then.intersection_assign(Box<FP_Interval>(oc_then)); + if(s_sum_d.linearize(as_then, lf_abstract_store, ly)) { + oc_then.affine_form_image(Y, ly); + as_then.intersection_assign(Box<FP_Interval>(oc_then)); + } // else skip. oc.refine_with_linear_form_inequality(lr, lk); @@ -836,28 +847,31 @@ test07() { // S = Y; Var_FP_Expression var_y(Y.id()); - if(var_y.linearize(abstract_store, lf_abstract_store, ly)) - ph.affine_form_image(S, ly); abstract_store.affine_form_image(S, FP_Linear_Form(tmp)); - // Intersection between the values of the variables in - // the polyhedron and in the abstract store. - abstract_store.intersection_assign(Box<FP_Interval>(ph)); + if(var_y.linearize(abstract_store, lf_abstract_store, ly)) { + ph.affine_form_image(S, ly); + // Intersection between the values of the variables in + // the polyhedron and in the abstract store. + abstract_store.intersection_assign(Box<FP_Interval>(ph)); + } // R = X - S; Var_FP_Expression* px = new Var_FP_Expression(X.id()); Var_FP_Expression* ps = new Var_FP_Expression(S.id()); Dif_FP_Expression x_dif_s(px, ps); - if(x_dif_s.linearize(abstract_store, lf_abstract_store, lr)) - ph.affine_form_image(R, lr); abstract_store.affine_form_image(R, FP_Linear_Form(X - S)); - abstract_store.intersection_assign(Box<FP_Interval>(ph)); + if(x_dif_s.linearize(abstract_store, lf_abstract_store, lr)) { + ph.affine_form_image(R, lr); + abstract_store.intersection_assign(Box<FP_Interval>(ph)); + } // Y = X; Var_FP_Expression var_x(X.id()); - if(var_x.linearize(abstract_store, lf_abstract_store, lx)) - ph.affine_form_image(Y, lx); abstract_store.affine_form_image(Y, FP_Linear_Form(X)); - abstract_store.intersection_assign(Box<FP_Interval>(ph)); + if(var_x.linearize(abstract_store, lf_abstract_store, lx)) { + ph.affine_form_image(Y, lx); + abstract_store.intersection_assign(Box<FP_Interval>(ph)); + } // if (R <= -D) NNC_Polyhedron ph_then(ph); @@ -869,10 +883,11 @@ test07() { Var_FP_Expression* pd = new Var_FP_Expression(D.id()); Var_FP_Expression* ps2 = new Var_FP_Expression(S.id()); Dif_FP_Expression s_dif_d(ps2, pd); - if(s_dif_d.linearize(as_then, lf_abstract_store, ly)) - ph_then.affine_form_image(Y, ly); as_then.affine_form_image(Y, FP_Linear_Form(S - D)); - as_then.intersection_assign(Box<FP_Interval>(ph_then)); + if(s_dif_d.linearize(as_then, lf_abstract_store, ly)) { + ph_then.affine_form_image(Y, ly); + as_then.intersection_assign(Box<FP_Interval>(ph_then)); + } // else skip; ph.refine_with_linear_form_inequality(-lk, lr); @@ -894,10 +909,11 @@ test07() { Var_FP_Expression* pd1 = new Var_FP_Expression(D.id()); Var_FP_Expression* ps3 = new Var_FP_Expression(S.id()); Sum_FP_Expression s_sum_d(ps3, pd1); - if(s_sum_d.linearize(as_then, lf_abstract_store, ly)) - ph_then.affine_form_image(Y, ly); as_then.affine_form_image(Y, FP_Linear_Form(S + D)); - as_then.intersection_assign(Box<FP_Interval>(ph_then)); + if(s_sum_d.linearize(as_then, lf_abstract_store, ly)) { + ph_then.affine_form_image(Y, ly); + as_then.intersection_assign(Box<FP_Interval>(ph_then)); + } // else skip; ph.refine_with_linear_form_inequality(lr, lk);

1 0

[GIT] ppl/ppl(master): Fixed call to ppl_PIP_Solution_Node_get_parametric_values().
by Enea Zaffanella 22 Feb '10

22 Feb '10

Module: ppl/ppl Branch: master Commit: 4685b3625210502b74edbf46f9b630e66afb611a URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4685b3625210… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 22 21:15:26 2010 +0100 Fixed call to ppl_PIP_Solution_Node_get_parametric_values(). --- interfaces/C/tests/pip_test.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/interfaces/C/tests/pip_test.c b/interfaces/C/tests/pip_test.c index 32fc606..80456fa 100644 --- a/interfaces/C/tests/pip_test.c +++ b/interfaces/C/tests/pip_test.c @@ -134,8 +134,7 @@ display_solution_i(ppl_const_PIP_Tree_Node_t node, for (i=0; i<n_vars; ++i) { if (notfirst) printf(" ; "); - ppl_PIP_Solution_Node_get_parametric_values(sn, vars[i], parameters, - n_params, &le); + ppl_PIP_Solution_Node_get_parametric_values(sn, vars[i], &le); ppl_io_print_Linear_Expression(le); notfirst = 1; }

1 0

[GIT] ppl/ppl(master): Added tentative solution to bugs shown by pipproblem1 tests 16, 17 and 18.
by Enea Zaffanella 22 Feb '10

22 Feb '10

Module: ppl/ppl Branch: master Commit: 95009146c346328599abf0da6873e4d3572b6328 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=95009146c346… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 22 18:54:20 2010 +0100 Added tentative solution to bugs shown by pipproblem1 tests 16, 17 and 18. --- src/PIP_Problem.cc | 38 +++++++++++++++++++++++++++++++++----- src/PIP_Tree.defs.hh | 8 +++++++- tests/PIP_Problem/pipproblem1.cc | 22 +++++++++++++++++++--- 3 files changed, 59 insertions(+), 9 deletions(-) diff --git a/src/PIP_Problem.cc b/src/PIP_Problem.cc index 23a0503..8df7d1b 100644 --- a/src/PIP_Problem.cc +++ b/src/PIP_Problem.cc @@ -153,19 +153,47 @@ PPL::PIP_Problem::solve() const { { dimension_type i = 1; for (Variables_Set::const_iterator - pi = param_begin; pi != param_end; ++pi, ++i) - row[i] = c.coefficient(Variable(*pi)); + pi = param_begin; pi != param_end; ++pi, ++i) { + if (*pi < c_space_dim) + row[i] = c.coefficient(Variable(*pi)); + else + break; + } } // Adjust inhomogenous term if strict. if (c.is_strict_inequality()) --row[0]; - // Insert new row into context. - x.initial_context.add_row(row); + + // Check for compatibility. + if (PIP_Solution_Node::compatibility_check(initial_context, row)) + // Insert new row into initial context. + x.initial_context.add_row(row); + else { + // Problem found to be unfeasible. + delete x.current_solution; + x.current_solution = 0; + x.status = UNSATISFIABLE; + PPL_ASSERT(OK()); + return UNFEASIBLE_PIP_PROBLEM; + } + // If it is an equality, also insert its negation. if (c.is_equality()) { for (dimension_type i = new_num_cols; i-- > 0; ) neg_assign(row[i], row[i]); - x.initial_context.add_row(row); + + // Check for compatibility. + if (PIP_Solution_Node::compatibility_check(initial_context, row)) + // Insert new row into initial context. + x.initial_context.add_row(row); + else { + // Problem found to be unfeasible. + delete x.current_solution; + x.current_solution = 0; + x.status = UNSATISFIABLE; + PPL_ASSERT(OK()); + return UNFEASIBLE_PIP_PROBLEM; + } } } diff --git a/src/PIP_Tree.defs.hh b/src/PIP_Tree.defs.hh index c51962c..87d4663 100644 --- a/src/PIP_Tree.defs.hh +++ b/src/PIP_Tree.defs.hh @@ -572,6 +572,10 @@ private: The algorithm ensures the feasible solutions are integer, by applying a cut generation method when intermediate non-integer solutions are found. + + \note + It is assumed that matrix \p ctx and row \c cnst have the same + size and capacity; otherwise the behavior is undefined. */ static bool compatibility_check(const Matrix& ctx, const Row& cnst); @@ -589,8 +593,10 @@ protected: */ PIP_Solution_Node(const PIP_Solution_Node& y, No_Constraints); - // PIP_Problem ascii load method needs access set_owner. + // PIP_Problem::ascii load() method needs access set_owner(). friend bool PIP_Problem::ascii_load(std::istream& s); + // PIP_Problem::solve() method needs access compatibility_check(). + friend PIP_Problem_Status PIP_Problem::solve() const; //! Sets the pointer to the PIP_Problem owning object. virtual void set_owner(const PIP_Problem* owner); diff --git a/tests/PIP_Problem/pipproblem1.cc b/tests/PIP_Problem/pipproblem1.cc index f41aced..9810c33 100644 --- a/tests/PIP_Problem/pipproblem1.cc +++ b/tests/PIP_Problem/pipproblem1.cc @@ -511,6 +511,22 @@ test17() { return ok; } +bool +test18() { + PIP_Problem pip; + pip.add_space_dimensions_and_embed(0, 2); + // Adding unsatisfiable context constraints. + Variable n(0); + Variable m(1); + pip.add_constraint(n == 2); + pip.add_constraint(m == 2); + pip.add_constraint(n + m == 3); + bool ok = (pip.solve() == UNFEASIBLE_PIP_PROBLEM); + if (pip.solution() != 0) + pip.print_solution(nout); + return ok; +} + } // namespace BEGIN_MAIN @@ -529,7 +545,7 @@ BEGIN_MAIN DO_TEST(test13); DO_TEST(test14); DO_TEST(test15); - // The following two tests show a bug in the PIP solver. - DO_TEST_F(test16); - DO_TEST_F(test17); + DO_TEST(test16); + DO_TEST(test17); + DO_TEST(test18); END_MAIN

1 0

[GIT] ppl/ppl(master): Do set the `solution_valid' flag on exit from update_solution().
by Enea Zaffanella 22 Feb '10

22 Feb '10

Module: ppl/ppl Branch: master Commit: af2621d1726b8eae41b4ebb46f929681bf4938a0 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=af2621d1726b… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 22 15:48:20 2010 +0100 Do set the `solution_valid' flag on exit from update_solution(). --- src/PIP_Tree.cc | 3 ++ tests/PIP_Problem/exceptions1.cc | 71 ++++++++++++++++++++++++++++++++++++++ tests/PIP_Problem/pipproblem2.cc | 29 +++++++++++++++ 3 files changed, 103 insertions(+), 0 deletions(-) diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index d404db7..4c6de77 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -2649,6 +2649,9 @@ PIP_Solution_Node norm_coeff = row[0] / den; sol_i += norm_coeff; } + + // Mark solution as valid. + x.solution_valid = true; } } // namespace Parma_Polyhedra_Library diff --git a/tests/PIP_Problem/exceptions1.cc b/tests/PIP_Problem/exceptions1.cc index d9c5966..16b8e3e 100644 --- a/tests/PIP_Problem/exceptions1.cc +++ b/tests/PIP_Problem/exceptions1.cc @@ -292,6 +292,75 @@ test13() { return false; } +bool +test14() { + Variable i(0); + Variable j(1); + Variable n(2); + Variable m(3); + Variables_Set params(n, m); + + Constraint_System cs; + cs.insert(3*j >= -2*i+8); + cs.insert(j <= 4*i - 4); + cs.insert(j <= m); + cs.insert(i <= n); + + PIP_Problem pip(cs.space_dimension(), cs.begin(), cs.end(), params); + (void) pip.solve(); + + const PIP_Decision_Node* root = pip.solution()->as_decision(); + const PIP_Decision_Node* t_child = root->child_node(true)->as_decision(); + const PIP_Solution_Node* t_t_child = t_child->child_node(true)->as_solution(); + + try { + // It is illegal to ask for the parametric value of a parameter. + (void) t_t_child->parametric_values(n); + } + catch (std::invalid_argument& e) { + nout << "invalid_argument: " << e.what() << endl << endl; + return true; + } + catch (...) { + } + return false; +} + +bool +test15() { + Variable i(0); + Variable j(1); + Variable n(2); + Variable m(3); + Variables_Set params(n, m); + + Constraint_System cs; + cs.insert(3*j >= -2*i+8); + cs.insert(j <= 4*i - 4); + cs.insert(j <= m); + cs.insert(i <= n); + + PIP_Problem pip(cs.space_dimension(), cs.begin(), cs.end(), params); + (void) pip.solve(); + + const PIP_Decision_Node* root = pip.solution()->as_decision(); + const PIP_Decision_Node* t_child = root->child_node(true)->as_decision(); + const PIP_Solution_Node* t_t_child = t_child->child_node(true)->as_solution(); + + try { + // It is illegal to ask for the parametric value of a variable + // having space dimension greater than that o fthe problem. + (void) t_t_child->parametric_values(Variable(4)); + } + catch (std::invalid_argument& e) { + nout << "invalid_argument: " << e.what() << endl << endl; + return true; + } + catch (...) { + } + return false; +} + } // namespace BEGIN_MAIN @@ -308,4 +377,6 @@ BEGIN_MAIN DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); + DO_TEST(test14); + DO_TEST(test15); END_MAIN diff --git a/tests/PIP_Problem/pipproblem2.cc b/tests/PIP_Problem/pipproblem2.cc index 777c3bc..9f65993 100644 --- a/tests/PIP_Problem/pipproblem2.cc +++ b/tests/PIP_Problem/pipproblem2.cc @@ -298,6 +298,34 @@ test15() { return ok; } +bool +test16() { + // NOTE: adopting a strange dimension ordering to increase code coverage. + Variable i(2); + Variable j(3); + Variable n(0); + Variable m(1); + Variables_Set params(n, m); + + Constraint_System cs; + cs.insert(3*j >= -2*i+8); + cs.insert(j <= 4*i - 4); + cs.insert(j <= m); + cs.insert(i <= n); + + PIP_Problem pip(cs.space_dimension(), cs.begin(), cs.end(), params); + (void) pip.solve(); + + const PIP_Decision_Node* root = pip.solution()->as_decision(); + const PIP_Decision_Node* t_child = root->child_node(true)->as_decision(); + const PIP_Solution_Node* t_t_child = t_child->child_node(true)->as_solution(); + const Linear_Expression& v_i = t_t_child->parametric_values(i); + bool ok = v_i.coefficient(n) == 0 + && v_i.coefficient(m) == 0 + && v_i.inhomogeneous_term() == 2; + return ok; +} + } // namespace BEGIN_MAIN @@ -316,4 +344,5 @@ BEGIN_MAIN DO_TEST(test13); DO_TEST(test14); DO_TEST(test15); + DO_TEST_F8(test16); END_MAIN

1 0

[GIT] ppl/ppl(master): New commits
by Roberto Bagnara 22 Feb '10

22 Feb '10

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c07572474d4d… Merge: 8ad05a7fa1293c23494ebd8c1a8222c8cc39dc0e 089e2db3d5f73dc3ad5c1545dd777671ac583f58 Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 22 14:48:11 2010 +0100 Merge branch 'floating_point' URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=089e2db3d5f7… Merge: 99eaa536d87db8c8a5b34ab451196d11a57aa6a1 537a4928e00e2b811822089da4cf12a1dd4344cf Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 22 10:03:52 2010 +0100 Merge branch 'master' into floating_point URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=99eaa536d87d… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Sat Feb 20 16:49:27 2010 +0100 Floating_Point_Expression::absolute_error is now a symmetric interval. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=bdae3bb7bff5… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Sat Feb 20 14:39:08 2010 +0100 Use build method instead of join_assign to build convex intervals. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b8ac7e594ab0… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Thu Feb 18 17:33:36 2010 +0100 Changed linearize method interface for Floating Point Expressions. Now, it has a bool return type which indicates if the linearization succeeded (or not). Thus, Linearization_Failed exception class has been removed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=945e8f14d130… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Thu Feb 18 13:55:09 2010 +0100 Fixed comments. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7c0b14249c7c… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Thu Feb 18 13:27:55 2010 +0100 Improved comments. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=86cb551f54cb… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Thu Feb 18 00:06:40 2010 +0100 Added and fixed documentation for Var_FP_Expression. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1e75fbc5ddcd… Author: Fabio <Fabio(a)C1P4.(none)> Date: Wed Feb 17 17:02:05 2010 +0100 Added "affine from relation" section into definitions.dox. Fixed a reference to "affine from relation". URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=01e3978bbebd… Merge: 3f6a0a0624328d63cdef17da7e06a8bd31e1f93e eab71496fec3819d941c5c444cb09041aea7eb0f Author: Fabio <Fabio(a)C1P4.(none)> Date: Wed Feb 17 10:25:20 2010 +0100 Merge branch 'floating_point' of ssh://git.cs.unipr.it/git/ppl/ppl into floating_point URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3f6a0a062432… Author: Fabio <Fabio(a)C1P4.(none)> Date: Wed Feb 17 10:01:15 2010 +0100 Fixed a type error. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=eab71496fec3… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Tue Feb 16 15:11:53 2010 +0100 Fixed Cast_Floating_Point_Expression.inlines.hh and added a test. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2287f9b3cc25… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Mon Feb 15 23:40:43 2010 +0100 Added classes. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5f573312d066… Author: Roberto Amadini <r.amadini(a)virgilio.it> Date: Mon Feb 15 23:32:09 2010 +0100 Added a first implementation of Cast_Floating_Point_Expression classes.

1 0

[GIT] ppl/ppl(master): Fixed exception safety issue in PIP_Decision_Node copy constructor.
by Enea Zaffanella 22 Feb '10

22 Feb '10

Module: ppl/ppl Branch: master Commit: 8ad05a7fa1293c23494ebd8c1a8222c8cc39dc0e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8ad05a7fa129… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 22 14:22:26 2010 +0100 Fixed exception safety issue in PIP_Decision_Node copy constructor. --- src/PIP_Tree.cc | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index 56dfb79..d404db7 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -406,15 +406,18 @@ PIP_Decision_Node::PIP_Decision_Node(const PIP_Decision_Node& y) : PIP_Tree_Node(y), false_child(0), true_child(0) { - // FIXME: exception safety? if (y.false_child != 0) { false_child = y.false_child->clone(); false_child->set_parent(this); } + // Protect false_child from exception safety issues via std::auto_ptr. + std::auto_ptr<PIP_Tree_Node> wrapped_node(false_child); if (y.true_child != 0) { true_child = y.true_child->clone(); true_child->set_parent(this); } + // It is now safe to release false_child. + wrapped_node.release(); } PIP_Decision_Node::~PIP_Decision_Node() {

1 0

[GIT] ppl/ppl(master): Changed interface for public method PIP_Solution_Node::parametric_values() .
by Enea Zaffanella 22 Feb '10

22 Feb '10

Module: ppl/ppl Branch: master Commit: 84dfaed9e347b23ade2704d1ed84710e59432dfb URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=84dfaed9e347… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 22 14:04:27 2010 +0100 Changed interface for public method PIP_Solution_Node::parametric_values(). The new interface no longer requires the set of problem parameters as an input argument (which was error prone): rather, the set of parameters of the PIP_Problem is now automatically retrieved. To this end, all PIP tree nodes are now provided by a pointer to the owning PIP_Problem object. Method PIP_Problem::OK() modified to check for well formedness of the solution tree and, in particular, check that all its nodes are marked as owned by the right PIP_Problem object. Removed the no longer useful method PIP_Tree_Node::insert_artificials(). Corrected a typo in PIP_Problem::operator<<(). Simplified interface of (internal) method PIP_Tree_Node::print_tree(). Added a FIXME regarding a potential exception safety issue. --- demos/ppl_pips/ppl_pips.cc | 2 +- interfaces/C/ppl_c_header.h | 9 - interfaces/C/ppl_c_implementation_common.cc | 7 +- src/PIP_Problem.cc | 55 ++++- src/PIP_Tree.cc | 330 ++++++++++++++++----------- src/PIP_Tree.defs.hh | 177 +++++++++------ src/PIP_Tree.inlines.hh | 5 + tests/PIP_Problem/pipproblem1.cc | 14 +- 8 files changed, 355 insertions(+), 244 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=84dfaed9…

1 0

[GIT] ppl/ppl(floating_point): New commits
by Roberto Bagnara 22 Feb '10

22 Feb '10

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=089e2db3d5f7… Merge: 99eaa536d87db8c8a5b34ab451196d11a57aa6a1 537a4928e00e2b811822089da4cf12a1dd4344cf Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 22 10:03:52 2010 +0100 Merge branch 'master' into floating_point URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=537a4928e00e… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 22 09:16:36 2010 +0100 Fixed oversight in error-handling code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1b73c49a9feb… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 22 09:16:06 2010 +0100 Avoid printing unless noisy or very-noisy mode was requested. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e52d48a8ab59… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 21 18:07:01 2010 +0100 Be more informative in case something goes wrong. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3bbfa4bc9da9… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 21 18:05:49 2010 +0100 Use the C++ compiler to perform the tests meant for C++. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9b0ba93300fb… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 21 12:49:16 2010 +0100 sigaction() is also needed, in addition to setitimer() in order to support Watchdog objects. We could check if signal() is available if there is request for such a feature. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1fa465112d1f… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 21 11:16:27 2010 +0100 If setitimer() is not available, no initialization is necessary. This also works around a linking bug in Mingw. C tests improved with error-handling code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5e638dd4922a… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 14:38:26 2010 +0100 Improved code coverage. Removed useless (and not accessible by user) Tableau::total_memory_in_bytes(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=13a2650b7180… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 13:04:13 2010 +0100 Invalidate current solution at the start of PIP_Solution_Node::solve(). This fixes the bug in pipproblem3 test03. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=511e9e86f968… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 12:52:19 2010 +0100 Adding no space dims should not invalidate previously computed solution. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=28dc8bb7f4c0… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 12:30:19 2010 +0100 Got rid of non-const PIP_Tree_Node as_decision() and as_solution() methods. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=77df3ea039c2… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 11:17:25 2010 +0100 Achieve full code coverage for the output operator. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e890db63f60f… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 10:05:36 2010 +0100 Document and test exception thrown by PIP_Problem::print_solution(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=fce6b4f6fe1e… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 09:46:35 2010 +0100 Test 09 overflows when using 8-bit coefficients. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8fc67ca60121… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 09:40:15 2010 +0100 A couple of tests marked as known to fail. These shows a bug in the solver, which fails to detect an unfeasible initial context. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=12d4e15ef5be… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 08:52:24 2010 +0100 Put under git control. These test exercise the incremental PIP solver (still buggy). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=084cb1f82547… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 20 08:50:53 2010 +0100 Check fir and avoid space dimension mismatches in merge_assign(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3cb3ce1f0be9… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 19 22:32:24 2010 +0100 Started working on incrementality. Dealt with a FIXME in PIP_Solution_Node::update_tableau(): when adding new problem variables and parameters, the columns of the existing artificial parameters are moved to the right of the tableau.t matrix. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e191bf79e2f4… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 19 22:31:37 2010 +0100 Little code coverage improvement. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1cec252d369a… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 18 23:45:41 2010 +0100 Prefer denominator() to get_denominator(). In pipproblem1 test02(), add a lenghty check of the expected solution. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e0bd48ed51ae… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 18 22:15:57 2010 +0100 Simplified C interface to Artificial_Parameter. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d994c6364d6d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 18 21:54:53 2010 +0100 Removed two PIP_Problem enum values that need not be interfaced. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d274e1f6b47b… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 18 21:49:54 2010 +0100 Avoid parameter name hiding; mark unreachable code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=215cc5a900c2… Author: Patricia Hill <p.m.hill(a)leeds.ac.uk> Date: Thu Feb 18 20:22:54 2010 +0000 Added some missing C interface methods and enum values for the new PIP classes. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0e480f958e85… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 18 16:07:39 2010 +0100 Corrected bug in th ehandling of trivially satisfiable PIP problems. Test 16 in pipproblem1.cc (currently disabled) shows a bug in the handling of trivially unfeasible PIP problems. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ee564d807b24… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 18 15:01:45 2010 +0100 Dealt with a FIXME in PIP_Solution_Node::solve(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0d53ceac4d79… Author: Patricia Hill <p.m.hill(a)leeds.ac.uk> Date: Thu Feb 18 13:43:28 2010 +0000 Added total_memory_in_bytes() and external_memory_in_bytes() to MIP_Problem and PIP_Problem in the C interface. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=84cdf71053ad… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Feb 18 11:23:44 2010 +0100 Described the input formats. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c6a791128aef… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Feb 18 11:21:42 2010 +0100 Cosmetic improvements. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=fe233fcf5db9… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 22:30:09 2010 +0100 Updated expected results. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f85e96f4e8a3… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 22:14:57 2010 +0100 Test with all the examples. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d97532ec7447… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 22:06:42 2010 +0100 Added examples from PipLib 1.4.0. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1e6df802e280… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 17:41:50 2010 +0100 Typo fixed: we require SICStus at least version 3.9.1. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b492ed70728e… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 15:39:01 2010 +0100 Test program renamed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8d8d4194c8e1… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 15:37:50 2010 +0100 Cosmetic changes. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a7734015823e… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 17 14:50:11 2010 +0100 Drafted implementation for PIP_Problem's operator<<. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=64a04677743e… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 17 13:13:57 2010 +0100 Tests adapted to use the new method for printing a PIP problem solution. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7da6c43b438c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 17 12:47:08 2010 +0100 Added method PIP_Problem::print_solution(). The new method exploits added virtual method PIP_Tree_Node::print_tree(). Implementation is based on code from the many display_solution() helper functions that are currently spread in the tests. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=777f298702f1… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 12:33:34 2010 +0100 Cater for systems where setitimer() is not provided (part 4). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=eab6ab2fd4e4… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 12:22:12 2010 +0100 Cater for systems where setitimer() is not provided (part 3). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8ac2c64c2e9f… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 12:15:35 2010 +0100 Cater for systems where setitimer() is not provided (part 2). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9bdd6617be52… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 11:56:08 2010 +0100 Cater for systems where setitimer() is not provided (part 1). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f0cd7dc9899f… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 11:55:16 2010 +0100 Build the PWL unless not explicitly disabled at configuration time. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3c3188f08c10… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 17 10:16:43 2010 +0100 Variable shadowing avoided. Scope of variables reduced. One FIXME added. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e9f9532b4887… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 17 10:06:30 2010 +0100 Tests 2, 5, 7, 8, 9 and 10 do not overflow on 16 bit coefficients. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d3339d25083d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 16 23:15:46 2010 +0100 Solved other instances of test02, but using different cutting strategies. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=53e86bccd511… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 16 22:40:01 2010 +0100 Fixed bug introduced when improving coding style in PIP_Solution_Node::solve. Corrected wrong assertion in PIP_Solution_Node::generate_cut. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=214df020741e… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 21:43:32 2010 +0100 Important item added. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9391a5768d5e… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 21:39:51 2010 +0100 Unwanted inclusion removed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9ba82c5fb51f… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 21:35:54 2010 +0100 Use the right preprocessor conditionals for PPL_HAVE_DECL_SIGACTION. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6c5b321e1751… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 21:35:26 2010 +0100 Warnings avoided. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=bad1f4e90af2… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 20:38:32 2010 +0100 Corrected several problems. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9857bc5b9ae3… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 16 20:06:43 2010 +0100 Enable test12. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ac846ef3f2f4… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 16 20:05:36 2010 +0100 A few improvements to PIP_Problem documentation. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1789a22b1378… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 15:35:38 2010 +0100 Make the test trivially succeed when coefficients are not large enough. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c257cba9d19c… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 14:41:52 2010 +0100 Improved error handling. Cosmetic improvements. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b89a40da063c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 16 14:38:15 2010 +0100 Added unit tests for inner class PIP_Tree_Node::Artificial_Parameter. Added operator!=() and swap() methods: the last was necessary as we were inheriting it from Linear_Expression. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5ddd5a9f223c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 16 12:00:43 2010 +0100 Added another test for code coverage purposes. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=632f43866770… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 16 09:58:05 2010 +0100 Got rid of unused Boolean flag PIP_Problem::initialized. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4baadf1d8043… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 10:14:45 2010 +0100 Avoid non-ASCII characters. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=09c7bbce5f53… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 10:10:57 2010 +0100 Trailing whitespace removed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0804e05ac141… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 16 10:10:30 2010 +0100 Install also ppl_pips.1. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=22208e21cd86… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 16 09:51:24 2010 +0100 Added a couple of tests to improve code coverage. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=de1f6f6e47ec… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 22:15:44 2010 +0100 Put under Git control. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=25e8b89f3fb0… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 22:15:17 2010 +0100 Avoid non-ASCII characters. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b57e8b768d88… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 22:14:04 2010 +0100 Added a draft man page for `ppl_pips'. Other man pages updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=dff9d4152afe… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 20:28:49 2010 +0100 Missing backslash added. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=030ba2b2b3c5… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 18:32:16 2010 +0100 Added missing expected results. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6d5b20eeba49… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 16:07:42 2010 +0100 Improved the NDEBUG machinery. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9cf1cef85fea… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 14:57:57 2010 +0100 Mark expected overflows. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7ba6445b1c5a… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 14:50:19 2010 +0100 Improve portability to systems that do not (fully) support Posix signal handling. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8eecefb16080… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 15 11:35:55 2010 +0100 Version number bumped.

1 0