August 2010 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(sparse_matrices): Merge branch 'master' into sparse_matrices
by Roberto Bagnara 28 Aug '10

28 Aug '10

Module: ppl/ppl Branch: sparse_matrices Commit: 7071677012378fb4c15ceabcd59f46344df69032 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=707167701237… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 28 14:06:23 2010 +0200 Merge branch 'master' into sparse_matrices ---

1 0

[GIT] ppl/ppl(sparse_matrices): Put under Git control.
by Roberto Bagnara 28 Aug '10

28 Aug '10

Module: ppl/ppl Branch: sparse_matrices Commit: 309c66893fcd97c6a648ef72cbc1b3fed07defe6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=309c66893fcd… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 28 14:05:20 2010 +0200 Put under Git control. --- demos/ppl_pips/.gitignore | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/demos/ppl_pips/.gitignore b/demos/ppl_pips/.gitignore new file mode 100644 index 0000000..86de488 --- /dev/null +++ b/demos/ppl_pips/.gitignore @@ -0,0 +1,2 @@ +obtained +ppl_pips

1 0

[GIT] ppl/ppl(sparse_matrices): Fixed the argument type of limit_virtual_memory(): should be unsigned long .
by Roberto Bagnara 28 Aug '10

28 Aug '10

Module: ppl/ppl Branch: sparse_matrices Commit: 512ff26f25f4d9ac96a55982fa76d78607555de6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=512ff26f25f4… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 28 14:00:21 2010 +0200 Fixed the argument type of limit_virtual_memory(): should be unsigned long. --- demos/ppl_lpsol/ppl_lpsol.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/demos/ppl_lpsol/ppl_lpsol.c b/demos/ppl_lpsol/ppl_lpsol.c index cf3a6dd..ec4a5d6 100644 --- a/demos/ppl_lpsol/ppl_lpsol.c +++ b/demos/ppl_lpsol/ppl_lpsol.c @@ -521,7 +521,7 @@ set_alarm_on_cpu_time(unsigned seconds, void (*handler)(int)) { #if PPL_HAVE_DECL_RLIMIT_AS void -limit_virtual_memory(unsigned bytes) { +limit_virtual_memory(unsigned long bytes) { struct rlimit t; if (getrlimit(RLIMIT_AS, &t) != 0) @@ -537,7 +537,7 @@ limit_virtual_memory(unsigned bytes) { #else void -limit_virtual_memory(unsigned bytes ATTRIBUTE_UNUSED) { +limit_virtual_memory(unsigned long bytes ATTRIBUTE_UNUSED) { } #endif /* !PPL_HAVE_DECL_RLIMIT_AS */

1 0

[GIT] ppl/ppl(sparse_matrices): Augment the precision with which floating point numbers are printed in error messages .
by Roberto Bagnara 28 Aug '10

28 Aug '10

Module: ppl/ppl Branch: sparse_matrices Commit: cb82804e0fac7ff10ce2af5d6cd7a98fcae678f9 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cb82804e0fac… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 28 13:58:44 2010 +0200 Augment the precision with which floating point numbers are printed in error messages. --- demos/ppl_lpsol/ppl_lpsol.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/demos/ppl_lpsol/ppl_lpsol.c b/demos/ppl_lpsol/ppl_lpsol.c index 8837640..cf3a6dd 100644 --- a/demos/ppl_lpsol/ppl_lpsol.c +++ b/demos/ppl_lpsol/ppl_lpsol.c @@ -649,8 +649,8 @@ maybe_check_results(const int ppl_status, const double ppl_optimum_value) { : lpx_mip_obj_val(glpk_lp); if (fabs(ppl_optimum_value - glpk_optimum_value) > check_threshold) { - error("check failed: for GLPK the problem's optimum is %.10g," - " not %.10g", glpk_optimum_value, ppl_optimum_value); + error("check failed: for GLPK the problem's optimum is %.20g," + " not %.20g", glpk_optimum_value, ppl_optimum_value); check_results_failed = 1; } }

1 0

[GIT] ppl/ppl(master): Put under Git control.
by Roberto Bagnara 28 Aug '10

28 Aug '10

Module: ppl/ppl Branch: master Commit: 309c66893fcd97c6a648ef72cbc1b3fed07defe6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=309c66893fcd… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 28 14:05:20 2010 +0200 Put under Git control. --- demos/ppl_pips/.gitignore | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/demos/ppl_pips/.gitignore b/demos/ppl_pips/.gitignore new file mode 100644 index 0000000..86de488 --- /dev/null +++ b/demos/ppl_pips/.gitignore @@ -0,0 +1,2 @@ +obtained +ppl_pips

1 0

[GIT] ppl/ppl(master): Fixed the argument type of limit_virtual_memory(): should be unsigned long.
by Roberto Bagnara 28 Aug '10

28 Aug '10

Module: ppl/ppl Branch: master Commit: 512ff26f25f4d9ac96a55982fa76d78607555de6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=512ff26f25f4… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 28 14:00:21 2010 +0200 Fixed the argument type of limit_virtual_memory(): should be unsigned long. --- demos/ppl_lpsol/ppl_lpsol.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/demos/ppl_lpsol/ppl_lpsol.c b/demos/ppl_lpsol/ppl_lpsol.c index cf3a6dd..ec4a5d6 100644 --- a/demos/ppl_lpsol/ppl_lpsol.c +++ b/demos/ppl_lpsol/ppl_lpsol.c @@ -521,7 +521,7 @@ set_alarm_on_cpu_time(unsigned seconds, void (*handler)(int)) { #if PPL_HAVE_DECL_RLIMIT_AS void -limit_virtual_memory(unsigned bytes) { +limit_virtual_memory(unsigned long bytes) { struct rlimit t; if (getrlimit(RLIMIT_AS, &t) != 0) @@ -537,7 +537,7 @@ limit_virtual_memory(unsigned bytes) { #else void -limit_virtual_memory(unsigned bytes ATTRIBUTE_UNUSED) { +limit_virtual_memory(unsigned long bytes ATTRIBUTE_UNUSED) { } #endif /* !PPL_HAVE_DECL_RLIMIT_AS */

1 0

[GIT] ppl/ppl(master): Augment the precision with which floating point numbers are printed in error messages .
by Roberto Bagnara 28 Aug '10

28 Aug '10

Module: ppl/ppl Branch: master Commit: cb82804e0fac7ff10ce2af5d6cd7a98fcae678f9 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cb82804e0fac… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 28 13:58:44 2010 +0200 Augment the precision with which floating point numbers are printed in error messages. --- demos/ppl_lpsol/ppl_lpsol.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/demos/ppl_lpsol/ppl_lpsol.c b/demos/ppl_lpsol/ppl_lpsol.c index 8837640..cf3a6dd 100644 --- a/demos/ppl_lpsol/ppl_lpsol.c +++ b/demos/ppl_lpsol/ppl_lpsol.c @@ -649,8 +649,8 @@ maybe_check_results(const int ppl_status, const double ppl_optimum_value) { : lpx_mip_obj_val(glpk_lp); if (fabs(ppl_optimum_value - glpk_optimum_value) > check_threshold) { - error("check failed: for GLPK the problem's optimum is %.10g," - " not %.10g", glpk_optimum_value, ppl_optimum_value); + error("check failed: for GLPK the problem's optimum is %.20g," + " not %.20g", glpk_optimum_value, ppl_optimum_value); check_results_failed = 1; } }

1 0

Re: [PPL-devel] [CLooG-dev] 'make check; errors in ppl-0.10.2 and 'gcc'
by Sebastian Pop 28 Aug '10

28 Aug '10

Hi, I think that this is more relevant to be posted to the PPL mailing list rather than the CLooG development list. On Wed, Aug 25, 2010 at 12:38, sergstesh <sergstesh(a)gmail.com> wrote: > Hello, > > while building ppl-0.10.2 I've noticed that 'make check' produces a > number of errors (and ppl-0.11' 'make check' is > clean IIRC). > > OTOH, 'gcc' uses ppl-0.10.2. > > So, are the 'make check' errors in ppl-0.10.2 significant and do they > translate into 'gcc' bugs ? > I do not think that they would translate into gcc bugs. > If necessary, I can post screen output of 'make check' in question. > Please send the error messages that you are seeing, together with more information about the machine and OS that you are using. Thanks, Sebastian

4 14

[GIT] ppl/ppl(sparse_matrices): CO_Tree: improve code in rebalance().
by Marco Poletti 26 Aug '10

26 Aug '10

Module: ppl/ppl Branch: sparse_matrices Commit: 99b6226ff57e3df6e82f71ed0e0b4f2b1733453e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=99b6226ff57e… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Aug 26 09:41:26 2010 +0200 CO_Tree: improve code in rebalance(). --- src/CO_Tree.cc | 31 +++++++++++-------------------- 1 files changed, 11 insertions(+), 20 deletions(-) diff --git a/src/CO_Tree.cc b/src/CO_Tree.cc index e9a70bc..d4b9123 100644 --- a/src/CO_Tree.cc +++ b/src/CO_Tree.cc @@ -739,6 +739,14 @@ PPL::CO_Tree::rebuild_bigger_tree() { PPL::CO_Tree::tree_iterator PPL::CO_Tree::rebalance(tree_iterator itr, dimension_type key, const data_type& value) { + // Trees with reserved size 3 need not to be rebalanced. + // This check is needed because they can't be shrunk, so they may violate the + // density thresholds, and this would prevent the following while from working + // correctly. + if (reserved_size == 3) { + PPL_ASSERT(OK()); + return tree_iterator(*this); + } PPL_ASSERT(itr->first == unused_index || itr.is_leaf()); height_t itr_depth_minus_1 = itr.depth() - 1; height_t height = max_depth - itr_depth_minus_1; @@ -760,26 +768,9 @@ PPL::CO_Tree::rebalance(tree_iterator itr, dimension_type key, min_density_percent - itr_depth_minus_1 *(min_density_percent - min_leaf_density_percent) /(max_depth - 1))) { - if (itr_depth_minus_1 == 0) { - // TODO: Check if this is correct - // We may arrive here, because we are using a fake subtree_size (it - // isn't the real tree size, because the inserted/deleted element is - // already taken into account). -#ifndef NDEBUG - dimension_type real_subtree_size = subtree_size; - if (!deleting) - --real_subtree_size; - PPL_ASSERT(!is_greater_than_ratio(real_subtree_size, - subtree_reserved_size, - max_density_percent)); - if (is_greater_than_ratio(real_subtree_size, subtree_reserved_size, - min_density_percent)) - PPL_ASSERT(is_greater_than_ratio(real_subtree_size, - subtree_reserved_size/2, - max_density_percent)); -#endif - break; - } + // The density in the tree is correct, so the while condition is always + // false for the root. + PPL_ASSERT(itr_depth_minus_1 != 0); bool is_right_brother = itr.is_right_child(); itr.get_parent(); if (is_right_brother)

1 0

[GIT] ppl/ppl(sparse_matrices): CO_Tree, Sparse_Row, Sparse_Matrix: remove unnecessary includes.
by Marco Poletti 26 Aug '10

26 Aug '10

Module: ppl/ppl Branch: sparse_matrices Commit: 7f3ebd8a305797d58c497b877f380a6f265c94df URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7f3ebd8a3057… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Aug 26 08:22:58 2010 +0200 CO_Tree, Sparse_Row, Sparse_Matrix: remove unnecessary includes. --- src/CO_Tree.inlines.hh | 4 ---- src/Sparse_Matrix.inlines.hh | 4 ---- src/Sparse_Row.inlines.hh | 4 ---- src/Sparse_Row.templates.hh | 4 ---- 4 files changed, 0 insertions(+), 16 deletions(-) diff --git a/src/CO_Tree.inlines.hh b/src/CO_Tree.inlines.hh index df66f5c..7225442 100644 --- a/src/CO_Tree.inlines.hh +++ b/src/CO_Tree.inlines.hh @@ -23,10 +23,6 @@ site: http://www.cs.unipr.it/ppl/ . */ #ifndef PPL_CO_Tree_inlines_hh #define PPL_CO_Tree_inlines_hh 1 -// TODO: Remove this. -// Added to please KDevelop4. -#include "CO_Tree.defs.hh" - namespace Parma_Polyhedra_Library { inline diff --git a/src/Sparse_Matrix.inlines.hh b/src/Sparse_Matrix.inlines.hh index f7071d5..5888fad 100644 --- a/src/Sparse_Matrix.inlines.hh +++ b/src/Sparse_Matrix.inlines.hh @@ -23,10 +23,6 @@ site: http://www.cs.unipr.it/ppl/ . */ #ifndef PPL_Sparse_Matrix_inlines_hh #define PPL_Sparse_Matrix_inlines_hh 1 -// FIXME: Remove this. -// It's needed only to please KDevelop4. -#include "Sparse_Matrix.defs.hh" - namespace Parma_Polyhedra_Library { inline void diff --git a/src/Sparse_Row.inlines.hh b/src/Sparse_Row.inlines.hh index 657d5cd..8f17d2b 100644 --- a/src/Sparse_Row.inlines.hh +++ b/src/Sparse_Row.inlines.hh @@ -23,10 +23,6 @@ site: http://www.cs.unipr.it/ppl/ . */ #ifndef PPL_Sparse_Row_inlines_hh #define PPL_Sparse_Row_inlines_hh 1 -// FIXME: Remove this. -// It's needed only to please KDevelop4. -#include "Sparse_Row.defs.hh" - #include <algorithm> namespace Parma_Polyhedra_Library { diff --git a/src/Sparse_Row.templates.hh b/src/Sparse_Row.templates.hh index a982a47..6b3cc54 100644 --- a/src/Sparse_Row.templates.hh +++ b/src/Sparse_Row.templates.hh @@ -23,10 +23,6 @@ site: http://www.cs.unipr.it/ppl/ . */ #ifndef PPL_Sparse_Row_templates_hh #define PPL_Sparse_Row_templates_hh 1 -// TODO: Remove this. -// Added to please KDevelop4. -#include "Sparse_Row.defs.hh" - namespace Parma_Polyhedra_Library {

1 0