September 2010 - PPL-devel - BUGSENG Mailman

ppl "remainder bug" checking on mingw targets
by Ruben Van Boxem 17 Sep '10

17 Sep '10

Hi, I am trying to compile ppl for x86_64-w64-mingw32, for gcc. Is it normal for the "checking if the compiler has the remainder bug..." takes very long? Is there a way to bypass this check in order to speed up compilation? Thanks! Ruben PS: using ppl-0.11 and TDM64 GCC 4.5.1

2 5

[GIT] ppl/ppl(master): Prefer neg_assign to the use of unary minus on Coefficient objects.
by Enea Zaffanella 17 Sep '10

17 Sep '10

Module: ppl/ppl Branch: master Commit: f1b3b29529f9602a0ea7e36b7a5ae62518e125dc URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f1b3b29529f9… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Sep 17 16:35:35 2010 +0200 Prefer neg_assign to the use of unary minus on Coefficient objects. Use add_mul_assign even in code only activated during debugging. --- src/MIP_Problem.cc | 6 +++--- src/PIP_Tree.cc | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index 33ead88..78e5ff1 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -1730,12 +1730,12 @@ PPL::MIP_Problem::compute_generator() const { Coefficient_traits::const_reference t_row_split_var = t_row.get(split_var); if (t_row_split_var > 0) { - split_num = -t_row.get(0); + neg_assign(split_num, t_row.get(0)); split_den = t_row_split_var; } else { split_num = t_row.get(0); - split_den = -t_row_split_var; + neg_assign(split_den, t_row_split_var); } // We compute the lcm to compute subsequently the difference // between the 2 variables. @@ -1808,7 +1808,7 @@ PPL::MIP_Problem::second_phase() { const dimension_type split_var = mapping[i].second; working_cost[original_var] = new_cost[i]; if (mapping[i].second != 0) - working_cost[split_var] = - new_cost[i]; + neg_assign(working_cost[split_var], new_cost[i]); } // Here the first phase problem succeeded with optimum value zero. // Express the old cost function in terms of the computed base. diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index a5af8f7..2e102d4 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -2691,7 +2691,7 @@ PIP_Solution_Node::solve(const PIP_Problem& pip, dimension_type j = 1; for (Variables_Set::const_iterator p = all_params.begin(), p_end = all_params.end(); p != p_end; ++p, ++j) - expr += t_test.get(j) * Variable(*p); + add_mul_assign(expr, t_test.get(j), Variable(*p)); using namespace IO_Operators; std::cerr << "Found mixed parameter sign row: " << best_i << ".\n" << "Solution depends on sign of parameter " @@ -3108,8 +3108,8 @@ PIP_Solution_Node::generate_cut(const dimension_type index, Linear_Expression expr1(ctx1.get(0)); Linear_Expression expr2(ctx2.get(0)); for (dimension_type j = 1; j <= num_params; ++j, ++p) { - expr1 += ctx1.get(j) * Variable(*p); - expr2 += ctx2.get(j) * Variable(*p); + add_mul_assign(expr1, ctx1.get(j), Variable(*p)); + add_mul_assign(expr2, ctx2.get(j), Variable(*p)); } std::cout << "Inserting into context: " << Constraint(expr1 >= 0) << " ; " @@ -3158,9 +3158,9 @@ PIP_Solution_Node::generate_cut(const dimension_type index, dimension_type si = 0; for (dimension_type j = 0; j < space_dimension; ++j) { if (parameters.count(j) == 1) - expr += cut_t.get(ti++) * Variable(j); + add_mul_assign(expr, cut_t.get(ti++), Variable(j)); else - expr += cut_s.get(si++) * Variable(j); + add_mul_assign(expr, cut_s.get(si++), Variable(j)); } std::cout << "Adding cut: " << Constraint(expr + cut_t.get(0) >= 0)

1 0

[GIT] ppl/ppl(master): Mention the correction of an efficiency bug in the C interface.
by Enea Zaffanella 17 Sep '10

17 Sep '10

Module: ppl/ppl Branch: master Commit: 719f973998fc26bafb723586da46eaf3b72de66c URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=719f973998fc… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Sep 17 15:42:03 2010 +0200 Mention the correction of an efficiency bug in the C interface. --- NEWS | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5ac4a8f..93de84b 100644 --- a/NEWS +++ b/NEWS @@ -27,6 +27,9 @@ o The input routine for PPL numeric datatypes has been extended to Bugfixes ======== +o Corrected an efficiency bug in the C language interface function + int ppl_Linear_Expression_add_to_coefficient() + o Corrected a bug affecting the input routine of ppl_lpsol, whereby the inhomogeneous term of the objective function was disregarded.

1 0

Fwd: [constraints] MIPLIB Call for Contributions
by Roberto Bagnara 17 Sep '10

17 Sep '10

-------- Original Message -------- Subject: [constraints] MIPLIB Call for Contributions Date: Tue, 14 Sep 2010 12:32:48 +0200 From: Chris Beck <jcb(a)mie.utoronto.ca> Reply-To: constraints(a)yahoogroups.com To: constraints(a)yahoogroups.com CC: Timo Berthold <berthold(a)zib.de> Hi Everyone, I am passing along this announcement about MIPLIB as they are actively seeking problem instances and there is a considerable overlap between problems in past versions of MIPLIB and those that have been studied (often in different formulations) in the constraint programming literature. Chris -------- Dear colleagues, Since its first release in 1992, the MIPLIB has become a standard test set used to compare the performance of mixed integer linear optimization software and to evaluate the computational performance of newly developed algorithms and solution techniques. Seven years have passed since the last update in 2003. Again, the progress in state-of-the-art optimizers, and improvements in computing machinery have made several instances too easy to be of further interest. New challenges need to be considered! Last year a group of interested parties including participants from ASU, COIN, FICO, Gurobi, IBM, and MOSEK met at ZIB to discuss the guidelines for the 2010 release of the MIPLIB. It will be the fifth edition of the Mixed-Integer Programming LIBrary. Therefore, we are looking for interesting and challenging (mixed-)integer linear problems from all fields of Operations Research and Combinatorial Optimization, ideally ones which have been built to model real life problems. We would be very happy if you contributed to this library by sending us hard and/or real life instances. By now, we are especially interested in benchmarking instances, i.e., problems that take between 15 minutes and two hours to solve. Find the submission webpage at http://miplib.zib.de/miplib2010 The submission deadline will be the 1st October 2010. We are looking forward to your contributions. Thanks and best regards, Timo Berthold on behalf of the MIPLIB committee (see webpage) -- J. Christopher Beck Toronto Intelligent Decision Engineering Lab Mechanical& Industrial Engineering University of Toronto 5 King's College Rd Toronto, ON CANADA M5S 3G8 ph: (416) 946-8854 fax: (416) 978-7753 ------------------------------------ Yahoo! Groups Links <*> To visit your group on the web, go to: http://groups.yahoo.com/group/constraints/ <*> Your email settings: Individual Email | Traditional <*> To change settings online go to: http://groups.yahoo.com/group/constraints/join (Yahoo! ID required) <*> To change settings via email: constraints-digest(a)yahoogroups.com constraints-fullfeatured(a)yahoogroups.com <*> To unsubscribe from this group, send an email to: constraints-unsubscribe(a)yahoogroups.com <*> Your use of Yahoo! Groups is subject to: http://docs.yahoo.com/info/terms/

1 0

[GIT] ppl/ppl(floating_point): New commits
by Roberto Bagnara 17 Sep '10

17 Sep '10

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a6202d3f6416… Merge: ebcd55e82f73703737752a66ca25891ece02661a d91c33b33dbc8b59332d279550366ed55ae9ae38 Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Sep 17 08:39:48 2010 +0200 Merge branch 'master' into floating_point URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d91c33b33dbc… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 16 21:08:27 2010 +0200 MIP_Problem: fix performance bug in compute_generator(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ba9f6c92b49a… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 16 21:07:58 2010 +0200 ppl_c_implementation_common: fix performance bug in ppl_Linear_Expression_add_to_coefficient. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=10c6e068e1bf… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 13:44:59 2010 +0200 PIP_Problem: declare iterators used in for loops in the loop header. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a4a0a65c926d… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 13:44:35 2010 +0200 PIP_Tree: declare iterators used in for loops in the loop header. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3b1e87b5e0f0… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 12:22:53 2010 +0200 MIP_Problem: remove non-necessary temporary variables. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cc8ee2d086c6… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 12:09:48 2010 +0200 MIP_Problem: remove out-dated comment. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b3cff936b2c9… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 12:05:58 2010 +0200 MIP_Problem: declare iterators used in for loops in the loop header. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1df9606a9a7c… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 11:54:12 2010 +0200 Make PPL_DIRTY_TEMP_COEFFICIENT work outside the PPL namespace, too. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=620592736a50… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Sun Sep 12 10:56:32 2010 +0200 MIP_Problem: improve a little bit the get_exiting_base_index() performance. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ad3694d4bbf7… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Sep 9 17:13:48 2010 +0200 Reflected the changes in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8966 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4974d4f39e8c… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 9 08:25:24 2010 +0200 MIP_Problem: don't copy Coefficient objects to cache accesses, in steepest_edge_exact_entering_index(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ab1231051fa8… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Sep 8 07:31:19 2010 +0200 Mentioned the fix to Interval::Interval(const char*).

1 0

[GIT] ppl/ppl(MPI): New commits
by Roberto Bagnara 16 Sep '10

16 Sep '10

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c114ce2dce66… Merge: 410bc1bd073874d00ac862c758bc2ced8902dc9d ff67a6bed878e178880fcb16019ebe662e56ea51 Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 16 22:42:24 2010 +0200 Merge remote branch 'origin/sparse_matrices' into MPI Conflicts: src/MIP_Problem.cc src/MIP_Problem.defs.hh src/Sparse_Row.cc src/Sparse_Row.defs.hh URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ff67a6bed878… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 19:12:40 2010 +0200 MIP_Problem: remove useless reset() from linear_conbine(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c4547fd8dd86… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 19:12:08 2010 +0200 Sparse_Row: optimize the linear_combine() method. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e4cdaa38008b… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 19:11:39 2010 +0200 Sparse_Row: don't create stored zeroes in combine_needs_second(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=241a4a6fcb61… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 18:42:33 2010 +0200 Sparse_Row: document that linear_combine() parameters must not be 0. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c8d497ffeae2… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 18:38:44 2010 +0200 MIP_Problem: use Row::linear_combine() in linear_combine(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9a2ab566f2c5… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 18:38:14 2010 +0200 Sparse_Row: add a linear_combine() method. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e752bae13ff6… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 18:37:58 2010 +0200 Dense_Row: add a linear_combine() method. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=41c1b88df329… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 17:49:08 2010 +0200 MIP_Problem: remove some optimizations meant for dense matrices when using sparse matrices. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=eed6e5900dac… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 17:27:20 2010 +0200 PIP_Tree: remove useless code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f9c4de14d8ad… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 17:25:23 2010 +0200 PIP_Tree: remove unnecessary temporary variables. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b423bf3864d7… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 17:17:49 2010 +0200 Row, Matrix: avoid inclusion of unnecessary files. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ccad0ef8e489… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 17:17:01 2010 +0200 tests/Sparse_Matrix: run the tests only when using sparse matrices. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=46143fc9a592… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 17:10:52 2010 +0200 CO_Tree: run tests only when using sparse matrices, avoiding compiler errors. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=432dd51be380… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 16:43:54 2010 +0200 PIP_Tree: use Row and Matrix, simplifying code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e37b5f946405… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 16:16:32 2010 +0200 PIP_Problem: use Row and Matrix, simplifying code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=15f178d464a4… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 16:15:55 2010 +0200 CO_Tree.defs.hh: include CO_Tree.types.hh. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7994e8aef25d… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 14:50:55 2010 +0200 Declare typedefs for Row and Matrix, and use them in MIP_Problem. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=abc0e90fa8ef… Merge: df7a6c989c0c19ed661e1a0af488096f98fc8d0b 10c6e068e1bffe92c73954fbc1e4943756d7fdb8 Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 14:39:50 2010 +0200 Merge remote branch 'origin/master' into sparse_matrices Conflicts: src/MIP_Problem.cc URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=df7a6c989c0c… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 14:34:23 2010 +0200 tests/Sparse_Matrix/sparserow1: don't trigger assertions in Sparse_Row::lower_bound(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=129497d5d417… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 14:26:23 2010 +0200 PIP_Tree: return if there are no candidates, in find_lexico_minimum_column(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=10c6e068e1bf… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 13:44:59 2010 +0200 PIP_Problem: declare iterators used in for loops in the loop header. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a4a0a65c926d… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 13:44:35 2010 +0200 PIP_Tree: declare iterators used in for loops in the loop header. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3b1e87b5e0f0… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 12:22:53 2010 +0200 MIP_Problem: remove non-necessary temporary variables. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cc8ee2d086c6… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 12:09:48 2010 +0200 MIP_Problem: remove out-dated comment. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b3cff936b2c9… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 12:05:58 2010 +0200 MIP_Problem: declare iterators used in for loops in the loop header. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1df9606a9a7c… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 11:54:12 2010 +0200 Make PPL_DIRTY_TEMP_COEFFICIENT work outside the PPL namespace, too. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=02cc3ed26b0c… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 11:44:24 2010 +0200 MIP_Problem: add comment. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=856f1052f1a7… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 11:41:44 2010 +0200 MIP_Problem: optimize further steepest_edge_exact_entering_index() for sparse working_cost rows. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=343524886abe… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 15 11:32:27 2010 +0200 MIP_Problem: use a hint iterator for insertions in working_cost, in process_pending_constraints().

1 0

[GIT] ppl/ppl(sparse_matrices): Merge remote branch 'origin/master' into sparse_matrices
by Marco Poletti 16 Sep '10

16 Sep '10

Module: ppl/ppl Branch: sparse_matrices Commit: 90d9338c35f62fa89a86c3b7192b2fa8172d1b20 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=90d9338c35f6… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 16 21:08:52 2010 +0200 Merge remote branch 'origin/master' into sparse_matrices ---

1 0

[GIT] ppl/ppl(sparse_matrices): MIP_Problem: fix performance bug in compute_generator().
by Marco Poletti 16 Sep '10

16 Sep '10

Module: ppl/ppl Branch: sparse_matrices Commit: d91c33b33dbc8b59332d279550366ed55ae9ae38 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d91c33b33dbc… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 16 21:08:27 2010 +0200 MIP_Problem: fix performance bug in compute_generator(). --- src/MIP_Problem.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index a619ce4..33ead88 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -1768,7 +1768,7 @@ PPL::MIP_Problem::compute_generator() const { // Finally, build the generator. Linear_Expression expr; for (dimension_type i = external_space_dim; i-- > 0; ) - expr += num[i] * Variable(i); + add_mul_assign(expr, num[i], Variable(i)); MIP_Problem& x = const_cast<MIP_Problem&>(*this); x.last_generator = point(expr, lcm);

1 0

[GIT] ppl/ppl(sparse_matrices): ppl_c_implementation_common: fix performance bug in ppl_Linear_Expression_add_to_coefficient.
by Marco Poletti 16 Sep '10

16 Sep '10

Module: ppl/ppl Branch: sparse_matrices Commit: ba9f6c92b49afbbfc37d864f59fff70df90f6536 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ba9f6c92b49a… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 16 21:07:58 2010 +0200 ppl_c_implementation_common: fix performance bug in ppl_Linear_Expression_add_to_coefficient. --- interfaces/C/ppl_c_implementation_common.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/interfaces/C/ppl_c_implementation_common.cc b/interfaces/C/ppl_c_implementation_common.cc index 3380207..b95451a 100644 --- a/interfaces/C/ppl_c_implementation_common.cc +++ b/interfaces/C/ppl_c_implementation_common.cc @@ -536,7 +536,7 @@ ppl_Linear_Expression_add_to_coefficient(ppl_Linear_Expression_t le, ppl_const_Coefficient_t n) try { Linear_Expression& lle = *to_nonconst(le); const Coefficient& nn = *to_const(n); - lle += nn * Variable(var); + add_mul_assign(lle, nn, Variable(var)); return 0; } CATCH_ALL

1 0

[GIT] ppl/ppl(master): MIP_Problem: fix performance bug in compute_generator().
by Marco Poletti 16 Sep '10

16 Sep '10

Module: ppl/ppl Branch: master Commit: d91c33b33dbc8b59332d279550366ed55ae9ae38 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d91c33b33dbc… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 16 21:08:27 2010 +0200 MIP_Problem: fix performance bug in compute_generator(). --- src/MIP_Problem.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index a619ce4..33ead88 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -1768,7 +1768,7 @@ PPL::MIP_Problem::compute_generator() const { // Finally, build the generator. Linear_Expression expr; for (dimension_type i = external_space_dim; i-- > 0; ) - expr += num[i] * Variable(i); + add_mul_assign(expr, num[i], Variable(i)); MIP_Problem& x = const_cast<MIP_Problem&>(*this); x.last_generator = point(expr, lcm);

1 0