February 2011 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(ppl-0_11-branch): Updated.
by Roberto Bagnara 27 Feb '11

27 Feb '11

Module: ppl/ppl Branch: ppl-0_11-branch Commit: f606c2cef5d49c111d95378bec6df7535459db36 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f606c2cef5d4… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 27 09:45:26 2011 +0100 Updated. --- ChangeLog | 114 ++++++++++++++++++++++++++++++++++++++++++++++++++++ Watchdog/ChangeLog | 28 +++++++++++++ 2 files changed, 142 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index b305044..9556c33 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,9 +1,123 @@ +2011-02-27 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * NEWS, README, Watchdog/src/Makefile.am, configure.ac, + demos/ppl_lcdd/ppl_lcdd.1, demos/ppl_lpsol/ppl_lpsol.1, + demos/ppl_pips/ppl_pips.1, doc/libppl.3, doc/libppl_c.3, + doc/ppl-config.1, doc/ppl-config_extra_man_text, src/Makefile.am: + Preparation for the release of PPL 0.11.2. + +2011-02-25 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * src/Row.defs.hh: Fixed a documentation problem in a \ref Doxygen + command. + +2011-02-23 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * src/Checked_Number.defs.hh, src/Checked_Number.inlines.hh: Avoid + (again) using the same macro name for different purposes. Doing it + confuses both the reader and Doxygen. + +2011-02-23 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * doc/devref-language-interface.tex, doc/devref.tex, + doc/user-language-interface.tex, doc/user.tex: Get rid of LaTeX + warnings related to package fancyhdr. + +2011-02-23 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * doc/Makefile.am, doc/devref-language-interface.doxyconf.in, + doc/user-language-interface.doxyconf.in, + interfaces/C/C_interface.dox: Avoid duplicate PDF labels in the + configured C interface manuals. + +2011-02-23 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * doc/devref-language-interface.tex, doc/devref.tex, + doc/user-language-interface.tex, doc/user.tex: Fixed a duplicate + hypertarget error in the generated PDF documentation. + +2011-02-23 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * src/Checked_Number.defs.hh, src/Checked_Number.inlines.hh: Avoid + using the same macro name for different purposes. Doing it confuses + both the reader and Doxygen. + +2011-02-23 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * NEWS: Two items added. + +2011-02-23 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * m4/ac_check_gmp.m4: When cross-compiling, assume that GMP has been + compiled with support for propagating exceptions. + +2011-02-23 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * src/fpu-ia32.cc: Work around a bug showing up under mingw-w64. + +2011-02-23 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * Watchdog/doc/devref.doxyconf-latex.in, + doc/devref-language-interface.doxyconf.in, + doc/devref.doxyconf-latex.in: Set INLINE_SOURCES = NO when producing + LaTeX documentation. This change is a workaround to a pdftex + hyperref issue that may + result in the following error \pdfendlink ended up in different nesting level than + \pdfstartlink when using some versions of Doxygen (e.g., 1.7.3). According to http://tug.org/errors.html the error is triggered when + a hyperlink is split across page boundaries and it can be generated + even by valid LaTeX code. Disabling source inlining is a way to + greatly decrease its likelihood. + +2011-02-22 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * src/meta_programming.hh: Fixed a couple of Doxygen related + problems. + +2011-02-22 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * NEWS: Updated. + +2011-02-22 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * src/fpu-ia32.cc: No longer overwrite the SIGILL handler. + +2011-02-21 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * + interfaces/Java/parma_polyhedra_library/Parma_Polyhedra_Library.jav + a: Never use `\c'; use <CODE></CODE> instead (yes, uppercase). + +2011-02-21 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * NEWS, README.configure, configure.ac, m4/ac_check_fpu_control.m4: + The `--disable-fpmath' configure option now disables all floating + point computations. + 2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> * PPL 0.11.1 released. 2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> + * configure.ac: Update version. + +2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * ChangeLog: Mark ChangeLog. + +2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * Watchdog/ChangeLog: Mark ChangeLog. + +2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * ChangeLog: Updated. + +2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * NEWS: Added missing news items. + +2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> + * NEWS: Added missing news items. 2010-10-19 Enea Zaffanella <zaffanella(a)cs.unipr.it> diff --git a/Watchdog/ChangeLog b/Watchdog/ChangeLog index 1b78f74..da33606 100644 --- a/Watchdog/ChangeLog +++ b/Watchdog/ChangeLog @@ -1,7 +1,35 @@ +2011-02-27 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * NEWS, README, Watchdog/src/Makefile.am, configure.ac, + demos/ppl_lcdd/ppl_lcdd.1, demos/ppl_lpsol/ppl_lpsol.1, + demos/ppl_pips/ppl_pips.1, doc/libppl.3, doc/libppl_c.3, + doc/ppl-config.1, doc/ppl-config_extra_man_text, src/Makefile.am: + Preparation for the release of PPL 0.11.2. + +2011-02-23 Enea Zaffanella <zaffanella(a)cs.unipr.it> + + * Watchdog/doc/devref.doxyconf-latex.in, + doc/devref-language-interface.doxyconf.in, + doc/devref.doxyconf-latex.in: Set INLINE_SOURCES = NO when producing + LaTeX documentation. This change is a workaround to a pdftex + hyperref issue that may + result in the following error \pdfendlink ended up in different nesting level than + \pdfstartlink when using some versions of Doxygen (e.g., 1.7.3). According to http://tug.org/errors.html the error is triggered when + a hyperlink is split across page boundaries and it can be generated + even by valid LaTeX code. Disabling source inlining is a way to + greatly decrease its likelihood. + 2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> * PPL 0.11.1 released. +2011-02-20 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * Watchdog/ChangeLog: Mark ChangeLog. + +2011-02-19 Roberto Bagnara <bagnara(a)cs.unipr.it> + + * ChangeLog, Watchdog/ChangeLog: Updated. + 2011-02-19 Roberto Bagnara <bagnara(a)cs.unipr.it> * NEWS, README, Watchdog/config.guess, Watchdog/config.sub,

1 0

[GIT] ppl/ppl(ppl-0_11-branch): Preparation for the release of PPL 0.11.2.
by Roberto Bagnara 27 Feb '11

27 Feb '11

Module: ppl/ppl Branch: ppl-0_11-branch Commit: 1be72907093b05ed84e8009de1aed13c37f3b729 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1be72907093b… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 27 09:29:19 2011 +0100 Preparation for the release of PPL 0.11.2. --- NEWS | 2 +- README | 38 +++++++++++++++++++------------------- Watchdog/src/Makefile.am | 1 + configure.ac | 2 +- demos/ppl_lcdd/ppl_lcdd.1 | 2 +- demos/ppl_lpsol/ppl_lpsol.1 | 2 +- demos/ppl_pips/ppl_pips.1 | 2 +- doc/libppl.3 | 8 ++++---- doc/libppl_c.3 | 16 ++++++++-------- doc/ppl-config.1 | 12 ++++++------ doc/ppl-config_extra_man_text | 10 +++++----- src/Makefile.am | 1 + 12 files changed, 49 insertions(+), 47 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=1be72907…

1 0

[GIT] ppl/ppl(master): Two items added.
by Roberto Bagnara 27 Feb '11

27 Feb '11

Module: ppl/ppl Branch: master Commit: 121539b86e288e585e748b36476180c078509874 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=121539b86e28… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 23 13:25:28 2011 +0100 Two items added. --- NEWS | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 7556a73..efa276a 100644 --- a/NEWS +++ b/NEWS @@ -49,6 +49,10 @@ o Fixed the semantics of the `--disable-fpmath' configure option o The PPL no longer overwrites the SIGILL signal handler. +o Minor documentation fixes. + +o Portability improved. + -------------------------------------------------------------------------- NEWS for version 0.11.1 (released on February 20, 2011)

1 0

[GIT] ppl/ppl(master): When cross-compiling, assume that GMP has been compiled with support for propagating exceptions.
by Roberto Bagnara 27 Feb '11

27 Feb '11

Module: ppl/ppl Branch: master Commit: 9c8f5935d3a6cb4602a7251e3039c4cdf05b1d72 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9c8f5935d3a6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 23 13:23:28 2011 +0100 When cross-compiling, assume that GMP has been compiled with support for propagating exceptions. --- m4/ac_check_gmp.m4 | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/ac_check_gmp.m4 b/m4/ac_check_gmp.m4 index c5dd1c9..8c2af74 100644 --- a/m4/ac_check_gmp.m4 +++ b/m4/ac_check_gmp.m4 @@ -181,8 +181,8 @@ int main() { ac_cv_gmp_supports_exceptions=yes, AC_MSG_RESULT(no) ac_cv_gmp_supports_exceptions=no, - AC_MSG_RESULT([assuming not]) - ac_cv_gmp_supports_exceptions=no) + AC_MSG_RESULT([assuming yes]) + ac_cv_gmp_supports_exceptions=yes) gmp_supports_exceptions=${ac_cv_gmp_supports_exceptions} if test x"$gmp_supports_exceptions" = xyes

1 0

[GIT] ppl/ppl(master): Work around a bug showing up under mingw-w64.
by Roberto Bagnara 27 Feb '11

27 Feb '11

Module: ppl/ppl Branch: master Commit: 26c113f59e20e39da438e782bcd0631aa171d2cc URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=26c113f59e20… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 23 13:21:12 2011 +0100 Work around a bug showing up under mingw-w64. --- src/fpu-ia32.cc | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/fpu-ia32.cc b/src/fpu-ia32.cc index 21aa6e3..16e9aa1 100644 --- a/src/fpu-ia32.cc +++ b/src/fpu-ia32.cc @@ -30,6 +30,10 @@ site: http://www.cs.unipr.it/ppl/ . */ #include "fpu.defs.hh" #include <csetjmp> #include <csignal> +// This inclusion is to work around a bug present in some versions +// of GCC under mingw-w64. +// See http://www.cs.unipr.it/pipermail/ppl-devel/2011-February/017342.html +#include <cstddef> namespace {

1 0

Re: [PPL-devel] [PATCH] Add -lpwl to ppllibs.
by Sebastian Pop 27 Feb '11

27 Feb '11

On Wed, Feb 23, 2011 at 13:39, Ralf Wildenhues <ralf.wildenhues(a)gmx.de> wrote: > Does libpwl depend on libppl_c or libppl? If it does, then your Roberto, could you please confirm that PWL is not dependent on PPL? > AC_CHECK_LIB test will fail on a system with only static libraries, as > the -lppl_c -lppl will be listed before -lpwl thus the link will fail > due to misordering. '-l' flags generally belong in LIBS not LDFLAGS, > but in the AC_CHECK_LIB test you would need to ensure that eventual -L > flags needed to find pwl would be listed in LDFLAGS. > > If libpwl does not depend on libppl_c or libppl, then there is one more > questionable case: the AC_CHECK_LIB is also tried out if ppl is in-tree. > In that case it may be the case that an out-of-tree pwl is found. Would > that be problematic for libpwl? If not, then the patch is OK. If yes, > then the patch is still ok if you do the change I noted below inline. Roberto, would it be possible to use a version of PWL different than the version of PPL? Again, I guess that PWL and PPL are independent. > Rainer's comment applies, but as the library list was duplicated before > your patch, I won't require fixing that issue within this patch. It can > be done separately, and as it is not release-critical, it can be done in > Stage 1. I already reworked the patch to address Rainer's comments. I will send out an updated patch. Thanks for your careful review. Sebastian

2 1

[GIT] ppl/ppl(sparse_matrices): Linear_System: don't call contained objects ' OK(), in OK(); also remove the OK() argument.
by Marco Poletti 26 Feb '11

26 Feb '11

Module: ppl/ppl Branch: sparse_matrices Commit: 89080fe8226dd92ada7fbbc70db2d9bd19594b60 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=89080fe8226d… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Fri Feb 25 21:45:13 2011 +0100 Linear_System: don't call contained objects' OK(), in OK(); also remove the OK() argument. --- src/Linear_System.defs.hh | 12 +-------- src/Linear_System.templates.hh | 53 +++++++++++++-------------------------- 2 files changed, 19 insertions(+), 46 deletions(-) diff --git a/src/Linear_System.defs.hh b/src/Linear_System.defs.hh index 6878611..5b015ef 100644 --- a/src/Linear_System.defs.hh +++ b/src/Linear_System.defs.hh @@ -427,17 +427,7 @@ public: memory_size_type external_memory_in_bytes() const; //! Checks if all the invariants are satisfied. - /*! - \param check_strong_normalized - <CODE>true</CODE> if and only if the strong normalization of all - the rows in the system has to be checked. - - By default, the strong normalization check is performed. - This check may be turned off to avoid useless repeated checking; - e.g., when re-checking a well-formed Linear_System after the permutation - or deletion of some of its rows. - */ - bool OK(bool check_strong_normalized = true) const; + bool OK() const; private: //! Adds a copy of the given row to the system. diff --git a/src/Linear_System.templates.hh b/src/Linear_System.templates.hh index eb5a2e4..0f75e0e 100644 --- a/src/Linear_System.templates.hh +++ b/src/Linear_System.templates.hh @@ -192,7 +192,7 @@ Linear_System<Row>::ascii_load(std::istream& s) { set_sorted(sortedness); // Check invariants. - PPL_ASSERT(OK(true)); + PPL_ASSERT(OK()); return true; } @@ -245,9 +245,7 @@ Linear_System<Row>::insert_recycled(Row& r) { // The added row was not a pending row. PPL_ASSERT(num_pending_rows() == 0); - // Do not check for strong normalization, - // because no modification of rows has occurred. - PPL_ASSERT(OK(false)); + PPL_ASSERT(OK()); } template <typename Row> @@ -301,9 +299,7 @@ Linear_System<Row>::insert_pending_recycled(Row& r) { // The added row was a pending row. PPL_ASSERT(num_pending_rows() > 0); - // Do not check for strong normalization, - // because no modification of rows has occurred. - PPL_ASSERT(OK(false)); + PPL_ASSERT(OK()); } template <typename Row> @@ -327,9 +323,7 @@ Linear_System<Row>::insert_pending_recycled(Linear_System& y) { y.clear(); - // Do not check for strong normalization, - // because no modification of rows has occurred. - PPL_ASSERT(OK(false)); + PPL_ASSERT(OK()); } template <typename Row> @@ -368,9 +362,7 @@ Linear_System<Row>::insert_recycled(Linear_System& y) { // There are no pending_rows. unset_pending_rows(); - // Do not check for strong normalization, - // because no modification of rows has occurred. - PPL_ASSERT(OK(false)); + PPL_ASSERT(OK()); } template <typename Row> @@ -381,9 +373,7 @@ Linear_System<Row>::sort_rows() { sort_rows(0, first_pending_row()); set_index_first_pending_row(num_rows() - num_pending); sorted = true; - // Do not check for strong normalization, - // because no modification of rows has occurred. - PPL_ASSERT(OK(false)); + PPL_ASSERT(OK()); } template <typename Row> @@ -473,9 +463,7 @@ Linear_System<Row>::add_recycled_pending_row(Row& r) { r.resize(num_columns()); std::swap(rows.back(), r); - // Do not check for strong normalization, because no modification of - // rows has occurred. - PPL_ASSERT(OK(false)); + PPL_ASSERT(OK()); } template <typename Row> @@ -594,7 +582,7 @@ Linear_System<Row>::gauss(const dimension_type n_lines_or_equalities) { // having no pending rows and exactly `n_lines_or_equalities' // lines or equalities, all of which occur before the rays or points // or inequalities. - PPL_ASSERT(x.OK(true)); + PPL_ASSERT(x.OK()); PPL_ASSERT(x.num_pending_rows() == 0); PPL_ASSERT(n_lines_or_equalities == x.num_lines_or_equalities()); #ifndef NDEBUG @@ -634,7 +622,7 @@ Linear_System<Row>::gauss(const dimension_type n_lines_or_equalities) { if (changed) x.set_sorted(false); // A well-formed system is returned. - PPL_ASSERT(x.OK(true)); + PPL_ASSERT(x.OK()); return rank; } @@ -647,7 +635,7 @@ Linear_System<Row> // having no pending rows and exactly `n_lines_or_equalities' // lines or equalities, all of which occur before the first ray // or point or inequality. - PPL_ASSERT(x.OK(true)); + PPL_ASSERT(x.OK()); PPL_ASSERT(x.num_columns() >= 1); PPL_ASSERT(x.num_pending_rows() == 0); PPL_ASSERT(n_lines_or_equalities <= x.num_lines_or_equalities()); @@ -735,7 +723,7 @@ Linear_System<Row> x.set_sorted(still_sorted); // A well-formed system is returned. - PPL_ASSERT(x.OK(true)); + PPL_ASSERT(x.OK()); } template <typename Row> @@ -744,7 +732,7 @@ Linear_System<Row>::simplify() { Linear_System& x = *this; // This method is only applied to a well-formed system // having no pending rows. - PPL_ASSERT(x.OK(true)); + PPL_ASSERT(x.OK()); PPL_ASSERT(x.num_pending_rows() == 0); // Partially sort the linear system so that all lines/equalities come first. @@ -780,7 +768,7 @@ Linear_System<Row>::simplify() { // Apply back-substitution to the system of rays/points/inequalities. x.back_substitute(n_lines_or_equalities); // A well-formed system is returned. - PPL_ASSERT(x.OK(true)); + PPL_ASSERT(x.OK()); } template <typename Row> @@ -817,7 +805,7 @@ Linear_System<Row>::add_universe_rows_and_columns(const dimension_type n) { set_sorted(compare(rows[n-1], rows[n]) <= 0); // A well-formed system has to be returned. - PPL_ASSERT(OK(true)); + PPL_ASSERT(OK()); } template <typename Row> @@ -881,9 +869,7 @@ Linear_System<Row>::sort_pending_and_remove_duplicates() { rows.resize(num_rows); } set_sorted(true); - // Do not check for strong normalization, - // because no modification of rows has occurred. - PPL_ASSERT(OK(false)); + PPL_ASSERT(OK()); } template <typename Row> @@ -898,7 +884,7 @@ Linear_System<Row>::check_sorted() const { template <typename Row> bool -Linear_System<Row>::OK(const bool /* check_strong_normalized */) const { +Linear_System<Row>::OK() const { #ifndef NDEBUG using std::endl; using std::cerr; @@ -960,12 +946,10 @@ Linear_System<Row>::OK(const bool /* check_strong_normalized */) const { return false; } + // Check for topology mismatches. const Linear_System& x = *this; const dimension_type n_rows = num_rows(); - for (dimension_type i = 0; i < n_rows; ++i) { - if (!x[i].OK(num_columns())) - return false; - // Checking for topology mismatches. + for (dimension_type i = 0; i < n_rows; ++i) if (x.topology() != x[i].topology()) { #ifndef NDEBUG cerr << "Topology mismatch between the system " @@ -974,7 +958,6 @@ Linear_System<Row>::OK(const bool /* check_strong_normalized */) const { #endif return false; } - } // TODO: Re-enable this. It was disabled because a Linear_System can be a // Grid_Generator_System, which in turn can contain non-normalized rows

1 0

[GIT] ppl/ppl(sparse_matrices): Constraint_System, Generator_System, Grid_Generator_System: don't call contained objects' OK(), in OK().
by Marco Poletti 26 Feb '11

26 Feb '11

Module: ppl/ppl Branch: sparse_matrices Commit: cbcc6b8fd9f844866c88ab7d154283babb14a1a2 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cbcc6b8fd9f8… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Fri Feb 25 21:44:29 2011 +0100 Constraint_System, Generator_System, Grid_Generator_System: don't call contained objects' OK(), in OK(). --- src/Constraint_System.cc | 13 ------------- src/Constraint_System.defs.hh | 7 +------ src/Generator_System.cc | 13 ------------- src/Generator_System.defs.hh | 5 +---- src/Grid_Generator_System.cc | 11 ----------- src/Grid_Generator_System.defs.hh | 5 +---- 6 files changed, 3 insertions(+), 51 deletions(-) diff --git a/src/Constraint_System.cc b/src/Constraint_System.cc index 0c5217d..1b1af06 100644 --- a/src/Constraint_System.cc +++ b/src/Constraint_System.cc @@ -622,19 +622,6 @@ PPL::Constraint_System::finalize() { bool PPL::Constraint_System::OK() const { - // A Constraint_System must be a valid Linear_System; do not check for - // strong normalization, since this will be done when - // checking each individual constraint. - if (!Base::OK(false)) - return false; - - // Checking each constraint in the system. - const Constraint_System& x = *this; - for (dimension_type i = num_rows(); i-- > 0; ) - if (!x[i].OK()) - return false; - - // All checks passed. return true; } diff --git a/src/Constraint_System.defs.hh b/src/Constraint_System.defs.hh index f292f90..1b7cdf6 100644 --- a/src/Constraint_System.defs.hh +++ b/src/Constraint_System.defs.hh @@ -208,13 +208,8 @@ public: //! Returns the past-the-end const_iterator. const_iterator end() const; + // FIXME: This is useless: it always returns true. //! Checks if all the invariants are satisfied. -#ifdef PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS - /*! - Returns <CODE>true</CODE> if and only if \p *this is a valid - Linear_System and each row in the system is a valid Constraint. - */ -#endif // defined(PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS) bool OK() const; PPL_OUTPUT_DECLARATIONS diff --git a/src/Generator_System.cc b/src/Generator_System.cc index 61e8807..1a84fbb 100644 --- a/src/Generator_System.cc +++ b/src/Generator_System.cc @@ -1039,19 +1039,6 @@ PPL::Generator_System::finalize() { bool PPL::Generator_System::OK() const { - // A Generator_System must be a valid Linear_System; do not check for - // strong normalization, since this will be done when - // checking each individual generator. - if (!sys.OK(false)) - return false; - - // Checking each generator in the system. - const Generator_System& x = *this; - for (dimension_type i = sys.num_rows(); i-- > 0; ) - if (!x[i].OK()) - return false; - - // All checks passed. return true; } diff --git a/src/Generator_System.defs.hh b/src/Generator_System.defs.hh index af26330..fde57f0 100644 --- a/src/Generator_System.defs.hh +++ b/src/Generator_System.defs.hh @@ -270,11 +270,8 @@ public: //! Returns the past-the-end const_iterator. const_iterator end() const; + // FIXME: This is useless: it always returns true. //! Checks if all the invariants are satisfied. - /*! - Returns <CODE>true</CODE> if and only if \p *this is a valid - Linear_System and each row in the system is a valid Generator. - */ bool OK() const; PPL_OUTPUT_DECLARATIONS diff --git a/src/Grid_Generator_System.cc b/src/Grid_Generator_System.cc index f134337..3e2d03a 100644 --- a/src/Grid_Generator_System.cc +++ b/src/Grid_Generator_System.cc @@ -248,17 +248,6 @@ PPL::Grid_Generator_System::OK() const { return false; } - // A Grid_Generator_System must be a valid Linear_System; - // do not check for strong normalization. - if (!Linear_System<Linear_Row>::OK(false)) - return false; - - // Checking each grid generator in the system. - const Grid_Generator_System& x = *this; - for (dimension_type i = num_rows(); i-- > 0; ) - if (!x[i].OK()) - return false; - // All checks passed. return true; } diff --git a/src/Grid_Generator_System.defs.hh b/src/Grid_Generator_System.defs.hh index d195aee..44ed1fb 100644 --- a/src/Grid_Generator_System.defs.hh +++ b/src/Grid_Generator_System.defs.hh @@ -348,11 +348,8 @@ public: //! Returns <CODE>true</CODE> if \p *this is identical to \p y. bool is_equal_to(const Grid_Generator_System& y) const; + // FIXME: This is useless: it always returns true. //! Checks if all the invariants are satisfied. - /*! - Returns <CODE>true</CODE> if and only if \p *this is a valid - Linear_System and each row in the system is a valid Grid_Generator. - */ bool OK() const; PPL_OUTPUT_DECLARATIONS

1 0

[GIT] ppl/ppl(sparse_matrices): Grid: avoid using Congruence::operator[], in conversion().
by Marco Poletti 26 Feb '11

26 Feb '11

Module: ppl/ppl Branch: sparse_matrices Commit: 8a786eb7e47fdb0e2b73b4c4df85f4038e4f2bf6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8a786eb7e47f… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Fri Feb 25 21:29:40 2011 +0100 Grid: avoid using Congruence::operator[], in conversion(). --- src/Grid_conversion.cc | 38 ++++++++++++-------------------------- 1 files changed, 12 insertions(+), 26 deletions(-) diff --git a/src/Grid_conversion.cc b/src/Grid_conversion.cc index 17d8f67..a6d8c2e 100644 --- a/src/Grid_conversion.cc +++ b/src/Grid_conversion.cc @@ -193,10 +193,7 @@ Grid::conversion(Grid_Generator_System& source, Congruence_System& dest, if (diagonal_lcm == 0) throw std::runtime_error("PPL internal error: Grid::conversion:" " source matrix is singular."); - - Swapping_Vector<Congruence> dest_recyclable_rows; - dest.release_rows(dest_recyclable_rows); - + dest.clear(); dest.set_space_dimension(dims - 1); // In `dest' initialize row types and elements, including setting @@ -207,34 +204,23 @@ Grid::conversion(Grid_Generator_System& source, Congruence_System& dest, if (dim_kinds[dim] == LINE) --source_index; else { - Congruence cg; - if (dest_recyclable_rows.empty()) { - Congruence tmp(dest.space_dimension()); - std::swap(cg, tmp); - } else { - // Recycle an old congruence. - std::swap(cg, dest_recyclable_rows.back()); - dest_recyclable_rows.pop_back(); - - cg.set_space_dimension(dest.space_dimension()); - - // Set the appropriate elements to zero. - for (dimension_type j = dim; j-- > 0; ) - cg[j] = 0; - for (dimension_type j = dim + 1; j < dims; ++j) - cg[j] = 0; - } + Linear_Expression le; + // The `+ 1' is needed because the Congruence constructor that takes + // a Linear_Expression currently reduces the space dimension by 1. + le.set_space_dimension(dest.space_dimension() + 1); if (dim_kinds[dim] == GEN_VIRTUAL) { - cg[dims] = 0; // An equality. - cg[dim] = 1; + le.get_linear_row()[dim] = 1; + Congruence cg(le, Coefficient_zero()); + dest.insert_verbatim_recycled(cg); } else { PPL_ASSERT(dim_kinds[dim] == PARAMETER); --source_index; - cg[dims] = 1; // A proper congruence. - exact_div_assign(cg[dim], diagonal_lcm, source[source_index][dim]); + exact_div_assign(le.get_linear_row()[dim], diagonal_lcm, + source[source_index][dim]); + Congruence cg(le, Coefficient_one()); + dest.insert_verbatim_recycled(cg); } - dest.insert_verbatim_recycled(cg); } }

1 0

[GIT] ppl/ppl(master): New commits
by Roberto Bagnara 25 Feb '11

25 Feb '11

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b537ac3b2872… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 23 21:01:24 2011 +0100 Avoid (again) using the same macro name for different purposes. Doing it confuses both the reader and Doxygen. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=676839fa3c6c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 23 19:26:18 2011 +0100 Get rid of LaTeX warnings related to package fancyhdr. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=981f391c6dd5… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 23 18:32:51 2011 +0100 Avoid duplicate PDF labels in the configured C interface manuals. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=16fc9b1bbb2a… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 23 16:59:33 2011 +0100 Fixed a duplicate hypertarget error in the generated PDF documentation. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e85e862edc6b… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 23 14:10:31 2011 +0100 Avoid using the same macro name for different purposes. Doing it confuses both the reader and Doxygen. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f2f745cdb383… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 23 10:19:21 2011 +0100 Set INLINE_SOURCES = NO when producing LaTeX documentation. This change is a workaround to a pdftex + hyperref issue that may result in the following error \pdfendlink ended up in different nesting level than \pdfstartlink when using some versions of Doxygen (e.g., 1.7.3). According to http://tug.org/errors.html the error is triggered when a hyperlink is split across page boundaries and it can be generated even by valid LaTeX code. Disabling source inlining is a way to greatly decrease its likelihood. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=95893a2b2a7e… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Feb 22 17:07:35 2011 +0100 Fixed a couple of Doxygen related problems.

1 0