February 2011 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(ppl-0_11-branch): Replaced the algorithm used for sorting Linear_System and Bit_Matrix.
by Enea Zaffanella 17 Feb '11

17 Feb '11

Module: ppl/ppl Branch: ppl-0_11-branch Commit: 3cdbdf41622743f9921a2ceed4f571e1ac6b7965 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3cdbdf416227… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 17 21:15:28 2011 +0100 Replaced the algorithm used for sorting Linear_System and Bit_Matrix. The new algorithm, based on STL's std::sort and std::unique, is applied to a vector of rows' indices and implements indirect sort using function objects for the comparisons and swap operations. Apart from a (usually minor) decrease in the number of comparisons and swaps perfomed, the new algorithm should be better wrt the consumption of stack space, by getting rid of ad-hoc sort/unique functions, as well as the special-purpose iterator class Linear_System::With_Bit_Matrix_iterator. --- src/Bit_Matrix.cc | 26 +++-- src/Linear_System.cc | 50 ++++++---- src/Linear_System.defs.hh | 89 ----------------- src/Linear_System.inlines.hh | 144 --------------------------- src/swapping_sort.icc | 221 +++++++++++++++++++++++------------------- 5 files changed, 172 insertions(+), 358 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=3cdbdf41…

1 0

[GIT] ppl/ppl(sparse_matrices): New commits
by Roberto Bagnara 17 Feb '11

17 Feb '11

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cfe01f9e62f4… Merge: c46cd9cf6f042b38eb44f6ec266d01d5ce10df99 b956c5822426119ce1bfa2ad7f305cfff6db7148 Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Feb 17 16:49:16 2011 +0100 Merge branch 'master' into sparse_matrices Conflicts: src/PIP_Tree.cc src/PIP_Tree.defs.hh tests/Sparse_Matrix/Makefile.am URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b956c5822426… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Feb 17 13:02:00 2011 +0100 PIP_Solution_Node: avoid repeated lookup of Sparse_Row's coefficients, in solve(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=96804c70b4db… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Feb 17 12:07:39 2011 +0100 PIP_Solution_Node: improve the performance of solve(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=67198c5e25b8… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 16 16:16:53 2011 +0100 Disabled the `memory1' test (at least for the time being). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=fa59cbeb2a6d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 16 09:14:24 2011 +0100 test06 no longer overflows when using 8-bit coefficients. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=73cfc6e23903… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Mon Feb 14 21:23:11 2011 +0100 PIP_Tree: simplify unnecessarily complicated code in compatibility_check_find_pivot_in_set(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8ca3aebcc9cb… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 19:46:29 2011 +0100 Ignore *.lzma. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=24b68b1c48e4… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Mon Feb 14 19:45:34 2011 +0100 PIP_Tree: avoid repeated calls to Sparse_Row::get(), in solve(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=215c270204d9… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 14 19:14:13 2011 +0100 Corrected a (checked-integer related) problem in PIP_Solution_Tree::solve(). Updated expected results for 32-bits checked integers: ppl_pips test lineri.dat no longer overflows. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=41c580634b7e… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 16:56:35 2011 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b4e8a607e5a6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 16:45:57 2011 +0100 Fixed a number of wrong conditionals. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5147bf4e1914… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 14 16:45:38 2011 +0100 Minor improvements to documentation. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d6bbae877309… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 13:01:50 2011 +0100 Copyright notices updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0f42c4966e4c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 14 11:57:05 2011 +0100 Document parameter indent_level in PIP_Tree_Node::solve(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5e75a7050611… Author: Abramo Bagnara <abramo.bagnara(a)gmail.com> Date: Thu Feb 3 17:26:08 2011 +0100 Added other plain char specializations. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e5f893b6c2cf… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Feb 3 17:11:20 2011 +0100 Added missing specializations for plain char. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8b29e34e75e9… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Feb 3 07:48:15 2011 +0100 Specialize C_Integer<T> for plain char. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=69c0e4568236… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Jan 30 22:11:01 2011 +0100 Added specializations for plain char. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6861c446e762… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Jan 30 22:08:31 2011 +0100 Copy-and-paste mistake fixed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=743d879f0284… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Jan 30 20:06:05 2011 +0100 Detect whether the plain char type is signed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8a7cd78d3971… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 10:55:23 2011 +0100 Reduce the argument of valgrind's --num-callers below the allowed maximum. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=73dd768d9265… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 14 08:36:29 2011 +0100 Mentioned a correction affecting PIP_Problem solution trees. Mentioned an improvement in the generation of PIP_Tree_Node tautological cnstraints, node splitting constraints and artificial parameters. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2a224dfc21ff… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 07:33:55 2011 +0100 Copyright notices updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=32c3efb0d9a7… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 11 15:01:08 2011 +0100 Fixed auxiliary function aux_test to perform proper comparisons. In the meanwhile, fixed another typo. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e42f8b60421c… Merge: 9d99c21af3e717056a34d4f67739afb375cabe94 22b1565be0efe35f86e6323180ff6de113b19b18 Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 11 10:17:30 2011 +0100 Merge branch 'master' into pip URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=22b1565be0ef… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 11 09:53:50 2011 +0100 Mentioned the correction of a few problems. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9d99c21af3e7… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 11 08:50:37 2011 +0100 Minor readability improvements to PIP_Decision_Node::solve(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a5d400f674a9… Merge: 29201d2a5893bbe17744777de36e9a106ed8ea95 d0f6bd037c90676130e9547e5ed909cf6ba8eee9 Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 10 18:50:11 2011 +0100 Merge branch 'master' into pip URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=29201d2a5893… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 10 18:48:11 2011 +0100 For readability, separate the input operation from input stream status check. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=bb08fb49f561… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 10 18:46:41 2011 +0100 Corrected expected results. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d0f6bd037c90… Author: Abramo Bagnara <abramo.bagnara(a)gmail.com> Date: Thu Feb 10 16:47:22 2011 +0100 Fixed stream state on checked input. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b86cb60dbf77… Merge: 3c8f16e240439811d501629660cedb8f99f0009a c23ded5ce0023a753fdd5da2dbbd99d1a084566c Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 10 10:49:20 2011 +0100 Merge branch 'master' into pip URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3c8f16e24043… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 10 10:47:59 2011 +0100 Corrected the expected result for test02 to match integral simplifications. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0e4098c48d6f… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Feb 10 10:46:03 2011 +0100 Exploit variable integrality when creating tautology constraints. Factored out helper function void integral_simplification(Row&); used when generating tautology and sign splitting constraints. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c23ded5ce002… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 5 21:01:13 2011 +0100 Fixed function ppl_Pointset_Powerset_*_get_disjunct in OCaml interface. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=caaa126b56cc… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 4 17:22:07 2011 +0100 Fixed a bug in the simplification of the solution tree. We were too eager in merging a single true child with its parent: if the true child happened to be a decision node with both childs, the merging was causing the violation of a PIP_Decision_Node invariant. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=20f99dbe73d5… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 4 15:42:15 2011 +0100 Further improvement to debug output. Preprocessor flag NOISY_PIP_TREE_STRUCTURE only activate those debug print taht is useful to hightlight the solution tree construction process. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d6c61aaed265… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 4 14:21:07 2011 +0100 A minor improvement to the debug printing mechanism. Methods solve() and generate_cut() are now provided with additional argument indent_level, telling the amount of indentation for debug prints. Added several messages to debug prints so as to clarify the solution tree construction process. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=03f79f0649bf… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 4 11:22:41 2011 +0100 Exploit integrality when adding constraints for mixed parameter sign rows. Try to distinguish between NOISY and VERY_NOISY debugging output. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=35d2df08098d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 4 09:52:58 2011 +0100 Fully normalize artificial parameters on construction. When in noisy mode, print normalized parameters. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3f551cfb8700… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Feb 4 08:39:12 2011 +0100 Minor changes related to coding standards. Prefer initial capitalization for (user-defined) type names. Prefer function objects to function pointers. Avoid nesting an anonymous namespace into another anonymous namespace.

1 0

[GIT] ppl/ppl(master): PIP_Solution_Node: avoid repeated lookup of Sparse_Row's coefficients, in solve().
by Marco Poletti 17 Feb '11

17 Feb '11

Module: ppl/ppl Branch: master Commit: b956c5822426119ce1bfa2ad7f305cfff6db7148 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b956c5822426… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Feb 17 13:02:00 2011 +0100 PIP_Solution_Node: avoid repeated lookup of Sparse_Row's coefficients, in solve(). --- src/PIP_Tree.cc | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index 416abad..bc1c494 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -2639,16 +2639,19 @@ PIP_Solution_Node::solve(const PIP_Problem& pip, Row& s_i = tableau.s[i]; Row& t_i = tableau.t[i]; - if (s_i.get(pj) == 0) + Row::iterator s_i_pj_itr = s_i.find(pj); + + if (s_i_pj_itr == s_i.end()) continue; - // NOTE: For sparse rows, the non-const operator[] ensures that - // the element is actually stored in the row. At this point, however, - // it can't be zero, so it is already stored in the row. // NOTE: This is a Coefficient& instead of a // Coefficient_traits::const_reference, because scale() may silently // modify it. - Coefficient& s_i_pj = s_i[pj]; + Coefficient& s_i_pj = *s_i_pj_itr; + + if (s_i_pj == 0) + continue; + Row::iterator k = t_i.end(); for (Row::const_iterator j = t_pivot.begin(), j_end = t_pivot.end(); j != j_end; ++j) {

1 0

[GIT] ppl/ppl(master): PIP_Solution_Node: improve the performance of solve( ).
by Marco Poletti 17 Feb '11

17 Feb '11

Module: ppl/ppl Branch: master Commit: 96804c70b4db623d36eff204053761203529a84e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=96804c70b4db… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Feb 17 12:07:39 2011 +0100 PIP_Solution_Node: improve the performance of solve(). --- src/PIP_Tree.cc | 20 +++++++++++++++----- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index c9fe387..416abad 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -2602,6 +2602,10 @@ PIP_Solution_Node::solve(const PIP_Problem& pip, Row& s_i = tableau.s[i]; PPL_DIRTY_TEMP_COEFFICIENT(s_i_pj); s_i_pj = s_i.get(pj); + + if (s_i_pj == 0) + continue; + Row::iterator itr = s_i.end(); for (Row::const_iterator j = s_pivot.begin(), j_end = s_pivot.end(); j != j_end; ++j) { @@ -2634,7 +2638,17 @@ PIP_Solution_Node::solve(const PIP_Problem& pip, for (dimension_type i = num_rows; i-- > 0; ) { Row& s_i = tableau.s[i]; Row& t_i = tableau.t[i]; - Coefficient s_i_pj = s_i.get(pj); + + if (s_i.get(pj) == 0) + continue; + + // NOTE: For sparse rows, the non-const operator[] ensures that + // the element is actually stored in the row. At this point, however, + // it can't be zero, so it is already stored in the row. + // NOTE: This is a Coefficient& instead of a + // Coefficient_traits::const_reference, because scale() may silently + // modify it. + Coefficient& s_i_pj = s_i[pj]; Row::iterator k = t_i.end(); for (Row::const_iterator j = t_pivot.begin(), j_end = t_pivot.end(); j != j_end; ++j) { @@ -2647,10 +2661,6 @@ PIP_Solution_Node::solve(const PIP_Problem& pip, gcd_assign(gcd, product, s_pivot_pj); exact_div_assign(scale_factor, s_pivot_pj, gcd); tableau.scale(scale_factor); - // s_i[pj] has been modified by scale(), so s_i_pj must be - // updated. - s_i_pj *= scale_factor; - PPL_ASSERT(s_i.get(pj) == s_i_pj); product *= scale_factor; } PPL_ASSERT(product % s_pivot_pj == 0);

1 0

[GIT] ppl/ppl(ppl-0_11-branch): Disabled the `memory1' test ( at least for the time being).
by Roberto Bagnara 16 Feb '11

16 Feb '11

Module: ppl/ppl Branch: ppl-0_11-branch Commit: ef211f83fcc4c07eec6b6bced0093796a9e3b3c4 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ef211f83fcc4… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 16 16:16:53 2011 +0100 Disabled the `memory1' test (at least for the time being). --- tests/Polyhedron/Makefile.am | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/tests/Polyhedron/Makefile.am b/tests/Polyhedron/Makefile.am index 4ff8b49..940ec13 100644 --- a/tests/Polyhedron/Makefile.am +++ b/tests/Polyhedron/Makefile.am @@ -663,9 +663,21 @@ watchdog1_SRCS = watchdog1.cc weightwatch1_SRCS = weightwatch1.cc if !VALGRIND_TESTS_ENABLED -VALGRIND_BRITTLE_TESTS = memory1 - -memory1_SOURCES = $(memory1_SRCS) +# The `memory1' test is currently disabled. The reason is that there +# is currently no reliable way to make it work, at least on Linux. +# The reason is that memory is limited using RLIMIT_AS, which limits +# brk, mmap and the stack: when we run out of stack, then of course +# we crash. So RLIMIT_AS cannot be used. In principle, we could use +# RLIMIT_DATA, which limits brk only. However, glibc uses mmap when +# it cannot obtain memory from brk (and perhaps in other cases as well), +# but mmap is not limited by RLIMIT_DATA. In summary, RLIMIT_AS limits +# too much (in particular the stack, that should not be limited); +# RLIMIT_DATA limits too little (it does not limit mmap, as we would like +# it to). + +#VALGRIND_BRITTLE_TESTS = memory1 + +#memory1_SOURCES = $(memory1_SRCS) endif !VALGRIND_TESTS_ENABLED

1 0

[GIT] ppl/ppl(master): Disabled the `memory1' test ( at least for the time being).
by Roberto Bagnara 16 Feb '11

16 Feb '11

Module: ppl/ppl Branch: master Commit: 67198c5e25b8fb985f27d4c24cb84e890aea8a23 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=67198c5e25b8… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Feb 16 16:16:53 2011 +0100 Disabled the `memory1' test (at least for the time being). --- tests/Polyhedron/Makefile.am | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/tests/Polyhedron/Makefile.am b/tests/Polyhedron/Makefile.am index a621ef7..36d4c55 100644 --- a/tests/Polyhedron/Makefile.am +++ b/tests/Polyhedron/Makefile.am @@ -663,9 +663,21 @@ watchdog1_SRCS = watchdog1.cc weightwatch1_SRCS = weightwatch1.cc if !VALGRIND_TESTS_ENABLED -VALGRIND_BRITTLE_TESTS = memory1 - -memory1_SOURCES = $(memory1_SRCS) +# The `memory1' test is currently disabled. The reason is that there +# is currently no reliable way to make it work, at least on Linux. +# The reason is that memory is limited using RLIMIT_AS, which limits +# brk, mmap and the stack: when we run out of stack, then of course +# we crash. So RLIMIT_AS cannot be used. In principle, we could use +# RLIMIT_DATA, which limits brk only. However, glibc uses mmap when +# it cannot obtain memory from brk (and perhaps in other cases as well), +# but mmap is not limited by RLIMIT_DATA. In summary, RLIMIT_AS limits +# too much (in particular the stack, that should not be limited); +# RLIMIT_DATA limits too little (it does not limit mmap, as we would like +# it to). + +#VALGRIND_BRITTLE_TESTS = memory1 + +#memory1_SOURCES = $(memory1_SRCS) endif !VALGRIND_TESTS_ENABLED

1 0

[GIT] ppl/ppl(ppl-0_11-branch): test06 no longer overflows when using 8-bit coefficients.
by Enea Zaffanella 16 Feb '11

16 Feb '11

Module: ppl/ppl Branch: ppl-0_11-branch Commit: 17f593d69c2b8f2da0609d96afae9ec52f78153c URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=17f593d69c2b… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 16 09:41:05 2011 +0100 test06 no longer overflows when using 8-bit coefficients. --- tests/PIP_Problem/pipproblem1.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/PIP_Problem/pipproblem1.cc b/tests/PIP_Problem/pipproblem1.cc index 98ea9b0..0497da5 100644 --- a/tests/PIP_Problem/pipproblem1.cc +++ b/tests/PIP_Problem/pipproblem1.cc @@ -789,7 +789,7 @@ BEGIN_MAIN DO_TEST(test03); DO_TEST(test04); DO_TEST_F8(test05); - DO_TEST_F8(test06); + DO_TEST(test06); DO_TEST_F8(test07); DO_TEST_F8(test08); DO_TEST_F8(test09);

1 0

[GIT] ppl/ppl(master): test06 no longer overflows when using 8-bit coefficients.
by Enea Zaffanella 16 Feb '11

16 Feb '11

Module: ppl/ppl Branch: master Commit: fa59cbeb2a6dd1f47f7ac9f6023cb4209dac1be1 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=fa59cbeb2a6d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Feb 16 09:14:24 2011 +0100 test06 no longer overflows when using 8-bit coefficients. --- tests/PIP_Problem/pipproblem1.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/PIP_Problem/pipproblem1.cc b/tests/PIP_Problem/pipproblem1.cc index 98ea9b0..0497da5 100644 --- a/tests/PIP_Problem/pipproblem1.cc +++ b/tests/PIP_Problem/pipproblem1.cc @@ -789,7 +789,7 @@ BEGIN_MAIN DO_TEST(test03); DO_TEST(test04); DO_TEST_F8(test05); - DO_TEST_F8(test06); + DO_TEST(test06); DO_TEST_F8(test07); DO_TEST_F8(test08); DO_TEST_F8(test09);

1 0

[GIT] ppl/ppl(floating_point): New commits
by Roberto Bagnara 15 Feb '11

15 Feb '11

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2ecc4a9389ba… Merge: b9c75c0855011b07b8d014c510403a3e34cf0a91 73cfc6e2390366f132e6967d225c4d5ec317bb46 Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Feb 15 19:04:49 2011 +0100 Merge branch 'master' into floating_point URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=73cfc6e23903… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Mon Feb 14 21:23:11 2011 +0100 PIP_Tree: simplify unnecessarily complicated code in compatibility_check_find_pivot_in_set(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8ca3aebcc9cb… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 19:46:29 2011 +0100 Ignore *.lzma. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=24b68b1c48e4… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Mon Feb 14 19:45:34 2011 +0100 PIP_Tree: avoid repeated calls to Sparse_Row::get(), in solve(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=215c270204d9… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 14 19:14:13 2011 +0100 Corrected a (checked-integer related) problem in PIP_Solution_Tree::solve(). Updated expected results for 32-bits checked integers: ppl_pips test lineri.dat no longer overflows. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=41c580634b7e… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 16:56:35 2011 +0100 Updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b4e8a607e5a6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 16:45:57 2011 +0100 Fixed a number of wrong conditionals. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5147bf4e1914… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 14 16:45:38 2011 +0100 Minor improvements to documentation. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d6bbae877309… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 13:01:50 2011 +0100 Copyright notices updated. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0f42c4966e4c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 14 11:57:05 2011 +0100 Document parameter indent_level in PIP_Tree_Node::solve(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5e75a7050611… Author: Abramo Bagnara <abramo.bagnara(a)gmail.com> Date: Thu Feb 3 17:26:08 2011 +0100 Added other plain char specializations. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e5f893b6c2cf… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Feb 3 17:11:20 2011 +0100 Added missing specializations for plain char. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8b29e34e75e9… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Feb 3 07:48:15 2011 +0100 Specialize C_Integer<T> for plain char. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=69c0e4568236… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Jan 30 22:11:01 2011 +0100 Added specializations for plain char. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6861c446e762… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Jan 30 22:08:31 2011 +0100 Copy-and-paste mistake fixed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=743d879f0284… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Jan 30 20:06:05 2011 +0100 Detect whether the plain char type is signed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8a7cd78d3971… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 10:55:23 2011 +0100 Reduce the argument of valgrind's --num-callers below the allowed maximum. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=73dd768d9265… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Feb 14 08:36:29 2011 +0100 Mentioned a correction affecting PIP_Problem solution trees. Mentioned an improvement in the generation of PIP_Tree_Node tautological cnstraints, node splitting constraints and artificial parameters. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2a224dfc21ff… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Mon Feb 14 07:33:55 2011 +0100 Copyright notices updated.

1 0

[GIT] ppl/ppl(master): PIP_Tree: simplify unnecessarily complicated code in compatibility_check_find_pivot_in_set ().
by Marco Poletti 14 Feb '11

14 Feb '11

Module: ppl/ppl Branch: master Commit: 73cfc6e2390366f132e6967d225c4d5ec317bb46 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=73cfc6e23903… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Mon Feb 14 21:23:11 2011 +0100 PIP_Tree: simplify unnecessarily complicated code in compatibility_check_find_pivot_in_set(). --- src/PIP_Tree.cc | 31 +++++++++++-------------------- 1 files changed, 11 insertions(+), 20 deletions(-) diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index 2660877..c9fe387 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -622,6 +622,7 @@ compatibility_check_find_pivot_in_set( // Not in base. const Row& row = s[row_index]; Row::const_iterator row_itr = row.lower_bound(pj); + Row::const_iterator new_row_itr; Row::const_iterator row_end = row.end(); PPL_DIRTY_TEMP_COEFFICIENT(row_value); if (row_itr != row_end && row_itr.index() == pj) { @@ -629,6 +630,7 @@ compatibility_check_find_pivot_in_set( ++row_itr; } else row_value = 0; + PPL_DIRTY_TEMP_COEFFICIENT(row_challenger_value); for (++i; i != i_end; ++i) { const dimension_type challenger_j = i->first; Coefficient_traits::const_reference challenger_cost = i->second.cost; @@ -638,27 +640,16 @@ compatibility_check_find_pivot_in_set( PPL_ASSERT(challenger_value > 0); PPL_ASSERT(pj < challenger_j); - PPL_DIRTY_TEMP_COEFFICIENT(row_challenger_value); - // row_challenger_value = &(row.get(challenger_j)); - if (row_itr != row_end) { - if (row_itr.index() < challenger_j) { - row_itr = row.lower_bound(row_itr, challenger_j); - if (row_itr != row_end && row_itr.index() == challenger_j) { - row_challenger_value = *row_itr; - ++row_itr; - } else - row_challenger_value = 0; - } else { - if (row_itr.index() == challenger_j) { - row_challenger_value = *row_itr; - ++row_itr; - } else { - PPL_ASSERT(row_itr.index() > challenger_j); - row_challenger_value = 0; - } - } - } else + new_row_itr = row.find(row_itr, challenger_j); + if (new_row_itr != row.end()) { + row_challenger_value = *new_row_itr; + // Use new_row_itr as a hint in next iterations + row_itr = new_row_itr; + } else { row_challenger_value = 0; + // Using end() as a hint is not useful, keep the current hint. + } + PPL_ASSERT(row_challenger_value == row.get(challenger_j)); // Before computing and comparing the actual values, the signs are // compared. This speeds up the code, because the values' computation

1 0