January 2012 - PPL-devel - BUGSENG Mailman

PPL (6 of 70 tests failed) OS X Lion, XCode 4.2 [clang]
by David Abdurachmanov 31 Jan '12

31 Jan '12

Hi, I am running 'make check' on my PPL build on Mac OS X Lion with XCode 4.2 using clang compiler. I was using clean environment (env -i) and additional environment variables: export CC='/Developer/usr/bin/clang' export CXX='/Developer/usr/bin/clang++' export F90FLAGS='-O2 -m64' export OBJC='/Developer/usr/bin/clang' export FCFLAGS='-O2 -m64' export INSTALL='/usr/bin/install -c' export OBJCFLAGS='-O2 -arch x86_64' export FFLAGS='-O2 -m64' export ABI='64' Here is the list of failed tests: tests failed: test08 FAIL: affineimage1 tests failed: test03 test04 FAIL: frompolyhedron1 tests failed: test01 test02 FAIL: frompolyhedron2 tests failed: test01 test03 FAIL: propagateconstraints2 tests failed: test01 FAIL: refinewithconstraint1 tests failed: test03 test04 FAIL: nnc_frompolyhedron1 $ /Developer/usr/bin/clang -v Apple clang version 3.0 (tags/Apple/clang-211.12) (based on LLVM 3.0svn) Target: x86_64-apple-darwin11.2.0 Thread model: posix Thanks, David

2 3

[GIT] ppl/ppl(master): Improved.
by Roberto Bagnara 22 Jan '12

22 Jan '12

Module: ppl/ppl Branch: master Commit: 9cd53027cc4ddcfe5e38030e697e968b26a4cfa1 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9cd53027cc4d… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Jan 22 20:44:03 2012 +0100 Improved. --- devtools/bump_copyright_years | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/devtools/bump_copyright_years b/devtools/bump_copyright_years index abf71c8..0fca806 100755 --- a/devtools/bump_copyright_years +++ b/devtools/bump_copyright_years @@ -1,8 +1,8 @@ -#!/bin/sh +#!/bin/bash temp_file=`mktemp /tmp/bump_copyright_years.XXXXXXXXXX` || exit 1 -for k in `find . -type f` +find . -type f -print0 | while read -d $'\0' file do - sed -e "s/Copyright (C) 2010-2012 BUGSENG srl/Copyright (C) 2010-2012 BUGSENG srl/g" <$k >$temp_file - chmod --reference=$k $temp_file - mv -f $temp_file $k + sed -e "s/Copyright (C) 2010-2012 BUGSENG srl/Copyright (C) 2010-2013 BUGSENG srl/g" <$file >$temp_file + chmod --reference=$file $temp_file + mv -f $temp_file $file done

1 0

[GIT] ppl/ppl(master): Reduced the scope of some variables.
by Roberto Bagnara 20 Jan '12

20 Jan '12

Module: ppl/ppl Branch: master Commit: 68ee3845682d61e60861d9c9afd9fdb707164c39 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=68ee3845682d… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jan 20 18:46:10 2012 +0100 Reduced the scope of some variables. Detected by ECLAIR service minscope. --- src/Grid.templates.hh | 2 +- src/Grid_Generator_System.cc | 2 +- src/Grid_public.cc | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Grid.templates.hh b/src/Grid.templates.hh index be1d9af..94d756f 100644 --- a/src/Grid.templates.hh +++ b/src/Grid.templates.hh @@ -66,12 +66,12 @@ Grid::Grid(const Box<Interval>& box, for (dimension_type k = space_dim; k-- > 0; ) { // This is declared here because it may be invalidated by the call to // gen_sys.insert() at the end of the loop. - Grid_Generator& point = gen_sys[0]; bool closed = false; // TODO: Consider producing the system(s) in minimized form. if (box.get_lower_bound(k, closed, l_n, l_d)) { if (box.get_upper_bound(k, closed, u_n, u_d)) if (l_n * u_d == u_n * l_d) { + Grid_Generator& point = gen_sys[0]; // A point interval sets dimension k of every point to a // single value. con_sys.insert(l_d * Variable(k) == l_n); diff --git a/src/Grid_Generator_System.cc b/src/Grid_Generator_System.cc index 4e9f3ba..534f5e9 100644 --- a/src/Grid_Generator_System.cc +++ b/src/Grid_Generator_System.cc @@ -83,10 +83,10 @@ PPL::Grid_Generator_System::recycling_insert(Grid_Generator& g) { void PPL::Grid_Generator_System::insert(const Grid_Generator& g) { - dimension_type g_space_dim = g.space_dimension(); if (g.is_parameter()) if (g.all_homogeneous_terms_are_zero()) { + dimension_type g_space_dim = g.space_dimension(); dimension_type initial_space_dim = space_dimension(); if (initial_space_dim < g_space_dim) { // Adjust the space dimension. diff --git a/src/Grid_public.cc b/src/Grid_public.cc index 17b8a9b..1d778b2 100644 --- a/src/Grid_public.cc +++ b/src/Grid_public.cc @@ -1059,7 +1059,8 @@ PPL::Grid::OK(bool check_not_empty) const { goto fail; Grid tmp_gr = *this; - Congruence_System cs_copy = tmp_gr.con_sys; + // Make a copy here, before changing tmp_gr, to check later. + const Congruence_System cs_copy = tmp_gr.con_sys; // Clear the generators in tmp_gr. Grid_Generator_System gs(space_dim); @@ -1643,7 +1644,6 @@ PPL::Grid::simplify_using_context_assign(const Grid& y) { const Congruence_System& x_cs = x.con_sys; const dimension_type x_cs_num_rows = x_cs.num_rows(); - const Grid_Generator_System& y_gs = y.gen_sys; // Record into `redundant_by_y' the info about which congruences of // `x' are redundant in the context `y'. Count the number of @@ -1704,6 +1704,7 @@ PPL::Grid::simplify_using_context_assign(const Grid& y) { const Coefficient& modulus = c.modulus(); div = modulus; + const Grid_Generator_System& y_gs = y.gen_sys; dimension_type num_ruled_out_generators = 0; for (Grid_Generator_System::const_iterator k = y_gs.begin(), y_gs_end = y_gs.end(); k != y_gs_end; ++k) {

1 0

[GIT] ppl/ppl(master): Bumped copyright years.
by Roberto Bagnara 18 Jan '12

18 Jan '12

1 0

[GIT] ppl/ppl(master): Reduced the scope of several variables.
by Roberto Bagnara 18 Jan '12

18 Jan '12

Module: ppl/ppl Branch: master Commit: 7f879511e0d654a8d218e4eaf2b94f7b7c1993b6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7f879511e0d6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Jan 18 11:48:24 2012 +0100 Reduced the scope of several variables. Detected by ECLAIR service minscope. --- demos/ppl_pips/ppl_pips.cc | 5 ++--- src/BD_Shape.templates.hh | 16 +++++++++------- src/Boundary.defs.hh | 3 +-- src/MIP_Problem.cc | 14 +++++++++----- src/PIP_Tree.cc | 7 ++----- src/Sparse_Row.cc | 6 +++--- src/Variables_Set.cc | 2 +- src/termination.cc | 2 +- src/wrap_assign.hh | 4 ++-- 9 files changed, 30 insertions(+), 29 deletions(-) diff --git a/demos/ppl_pips/ppl_pips.cc b/demos/ppl_pips/ppl_pips.cc index bfa1def..5ff21b9 100644 --- a/demos/ppl_pips/ppl_pips.cc +++ b/demos/ppl_pips/ppl_pips.cc @@ -391,8 +391,8 @@ protected: bool read_comment(std::istream& in) { comment = ""; int count = 1; - char c; do { + char c; if (!in.get(c)) return false; if (c == '(') @@ -635,7 +635,6 @@ process_options(int argc, char* argv[]) { break; char* endptr; - long l; switch (c) { case 0: break; @@ -649,7 +648,7 @@ process_options(int argc, char* argv[]) { case 'R': { const int MEGA = 1024*1024; - l = strtol(optarg, &endptr, 10); + long l = strtol(optarg, &endptr, 10); if (*endptr || l < 0) fatal("a non-negative integer must follow `-R'"); else if (static_cast<unsigned long>(l) > ULONG_MAX/MEGA) diff --git a/src/BD_Shape.templates.hh b/src/BD_Shape.templates.hh index 911812f..49f4fe0 100644 --- a/src/BD_Shape.templates.hh +++ b/src/BD_Shape.templates.hh @@ -412,12 +412,11 @@ BD_Shape<T>::add_constraint(const Constraint& c) { // Select the cell to be modified for the "<=" part of the constraint, // and set `coeff' to the absolute value of itself. const bool negative = (coeff < 0); - N& x = negative ? dbm[i][j] : dbm[j][i]; - N& y = negative ? dbm[j][i] : dbm[i][j]; if (negative) neg_assign(coeff); bool changed = false; + N& x = negative ? dbm[i][j] : dbm[j][i]; // Compute the bound for `x', rounding towards plus infinity. PPL_DIRTY_TEMP(N, d); div_round_up(d, inhomo, coeff); @@ -427,6 +426,7 @@ BD_Shape<T>::add_constraint(const Constraint& c) { } if (c.is_equality()) { + N& y = negative ? dbm[j][i] : dbm[i][j]; // Also compute the bound for `y', rounding towards plus infinity. PPL_DIRTY_TEMP_COEFFICIENT(minus_c_term); neg_assign(minus_c_term, inhomo); @@ -2983,14 +2983,13 @@ BD_Shape<T>::get_limiting_shape(const Constraint_System& cs, const N& x = negative ? dbm[i][j] : dbm[j][i]; const N& y = negative ? dbm[j][i] : dbm[i][j]; DB_Matrix<N>& ls_dbm = limiting_shape.dbm; - N& ls_x = negative ? ls_dbm[i][j] : ls_dbm[j][i]; - N& ls_y = negative ? ls_dbm[j][i] : ls_dbm[i][j]; if (negative) neg_assign(coeff); // Compute the bound for `x', rounding towards plus infinity. div_round_up(d, c.inhomogeneous_term(), coeff); if (x <= d) { if (c.is_inequality()) { + N& ls_x = negative ? ls_dbm[i][j] : ls_dbm[j][i]; if (ls_x > d) { ls_x = d; changed = true; @@ -3000,12 +2999,15 @@ BD_Shape<T>::get_limiting_shape(const Constraint_System& cs, // Compute the bound for `y', rounding towards plus infinity. neg_assign(minus_c_term, c.inhomogeneous_term()); div_round_up(d1, minus_c_term, coeff); - if (y <= d1) + if (y <= d1) { + N& ls_x = negative ? ls_dbm[i][j] : ls_dbm[j][i]; + N& ls_y = negative ? ls_dbm[j][i] : ls_dbm[i][j]; if ((ls_x >= d && ls_y > d1) || (ls_x > d && ls_y >= d1)) { ls_x = d; ls_y = d1; changed = true; } + } } } } @@ -4243,12 +4245,12 @@ void BD_Shape<T> PPL_DIRTY_TEMP(N, b_mlb); neg_assign_r(b_mlb, b.lower(), ROUND_NOT_NEEDED); - // true if b = [b_lb, b_ub] = [0;0]. - bool is_b_zero = (b_mlb == 0 && b_ub == 0); // true if w_coeff = [1;1] bool is_w_coeff_one = (w_coeff == 1); if (w_id == var_id) { + // true if b = [b_lb, b_ub] = [0;0]. + bool is_b_zero = (b_mlb == 0 && b_ub == 0); // Here `lf' is of the form: [+/-1;+/-1] * v + b. if (is_w_coeff_one) { if (is_b_zero) diff --git a/src/Boundary.defs.hh b/src/Boundary.defs.hh index 7b85dc0..fb24935 100644 --- a/src/Boundary.defs.hh +++ b/src/Boundary.defs.hh @@ -716,7 +716,6 @@ inline Result div_assign_z(Boundary_Type to_type, To& to, To_Info& to_info, Boundary_Type type1, const T1& x1, const Info1& info1, int x1s, Boundary_Type type2, const T2& x2, const Info2& info2, int x2s) { - bool shrink; if (x1s != 0) { if (x2s != 0) return div_assign(to_type, to, to_info, @@ -728,7 +727,7 @@ div_assign_z(Boundary_Type to_type, To& to, To_Info& to_info, } } else { - shrink = info1.get_boundary_property(type1, OPEN) + bool shrink = info1.get_boundary_property(type1, OPEN) && !is_boundary_infinity_closed(type2, x2, info2); return set_zero(to_type, to, to_info, shrink); } diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index 07558bf..6ecfa28 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -2662,8 +2662,8 @@ PPL::MIP_Problem::ascii_load(std::istream& s) { if (!(s >> str) || str != ")") return false; - dimension_type base_value; for (dimension_type i = 0; i != base_size; ++i) { + dimension_type base_value; if (!(s >> base_value)) return false; base.push_back(base_value); @@ -2685,26 +2685,30 @@ PPL::MIP_Problem::ascii_load(std::istream& s) { if (!(s >> str) || str != ")") return false; - dimension_type first_value; - dimension_type second_value; - dimension_type index; - // The first `mapping' index is never used, so we initialize // it pushing back a dummy value. if (tableau.num_columns() != 0) mapping.push_back(std::make_pair(0, 0)); for (dimension_type i = 1; i < mapping_size; ++i) { + dimension_type index; if (!(s >> index)) return false; + if (!(s >> str) || str != "->") return false; + + dimension_type first_value; if (!(s >> first_value)) return false; + if (!(s >> str) || str != "->") return false; + + dimension_type second_value; if (!(s >> second_value)) return false; + mapping.push_back(std::make_pair(first_value, second_value)); } diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index f788457..1b12491 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -735,11 +735,7 @@ compatibility_check_find_pivot(const Matrix& s, current_data.value = s_ij; } else { data_struct& current_data = candidates_map[j]; - - Coefficient_traits::const_reference value_b = s_i.get(j); - PPL_ASSERT(current_data.value > 0); - PPL_ASSERT(value_b > 0); // Before computing and comparing the actual values, the signs are // compared. This speeds up the code, because the values' computation @@ -759,9 +755,10 @@ compatibility_check_find_pivot(const Matrix& s, } // Otherwise, keep current pivot for this column. } else { - // Sign comparison is not enough this time. // Do the full computation. + Coefficient_traits::const_reference value_b = s_i.get(j); + PPL_ASSERT(value_b > 0); PPL_DIRTY_TEMP_COEFFICIENT(lhs_coeff); lhs_coeff = current_data.cost; diff --git a/src/Sparse_Row.cc b/src/Sparse_Row.cc index 9a61ced..c5efd90 100644 --- a/src/Sparse_Row.cc +++ b/src/Sparse_Row.cc @@ -475,17 +475,17 @@ PPL::Sparse_Row::ascii_load(std::istream& s) { if (!(s >> size_)) return false; clear(); - dimension_type n_elements; - dimension_type current_key; - Coefficient current_data; if (!(s >> str) || str != "elements") return false; + dimension_type n_elements; if (!(s >> n_elements)) return false; + PPL_DIRTY_TEMP_COEFFICIENT(current_data); for (dimension_type i = 0; i < n_elements; ++i) { + dimension_type current_key; if (!(s >> str) || str != "[") return false; if (!(s >> current_key)) diff --git a/src/Variables_Set.cc b/src/Variables_Set.cc index d73ad15..0a0abe5 100644 --- a/src/Variables_Set.cc +++ b/src/Variables_Set.cc @@ -81,8 +81,8 @@ PPL::Variables_Set::ascii_load(std::istream& s) { if (!(s >> str) || str != ")") return false; - dimension_type variable_value; for (dimension_type i = 0; i < size; ++i) { + dimension_type variable_value; if (!(s >> variable_value)) return false; insert(variable_value); diff --git a/src/termination.cc b/src/termination.cc index 0ac4e00..50e2710 100644 --- a/src/termination.cc +++ b/src/termination.cc @@ -883,13 +883,13 @@ all_affine_ranking_functions_PR_original(const Constraint_System& cs, #endif const Generator_System& gs_in = ph.generators(); - Generator_System gs_out; Generator_System::const_iterator gs_in_it = gs_in.begin(); Generator_System::const_iterator gs_in_end = gs_in.end(); if (gs_in_it == gs_in_end) // The system is unsatisfiable. mu_space = NNC_Polyhedron(n + 1, EMPTY); else { + Generator_System gs_out; for ( ; gs_in_it != gs_in_end; ++gs_in_it) { const Generator& g = *gs_in_it; Linear_Expression le; diff --git a/src/wrap_assign.hh b/src/wrap_assign.hh index 7461749..a416506 100644 --- a/src/wrap_assign.hh +++ b/src/wrap_assign.hh @@ -168,8 +168,8 @@ wrap_assign(PSET& pointset, // and vars.space_dimension() <= pointset.space_dimension(). // Dimension-compatibility check of `*cs_p', if any. - const dimension_type vars_space_dim = vars.space_dimension(); if (cs_p != 0) { + const dimension_type vars_space_dim = vars.space_dimension(); if (cs_p->space_dimension() > vars_space_dim) { std::ostringstream s; s << "PPL::" << class_name << "::wrap_assign(..., cs_p, ...):" @@ -190,7 +190,7 @@ wrap_assign(PSET& pointset, const Constraint& c = *i; for (dimension_type d = cs_space_dim; d-- > 0; ) { PPL_ASSERT(c.coefficient(Variable(d)) == 0 - || vars.find(d) != vars_end); + || vars.find(d) != vars_end); } } #endif

1 0

problems with Box::operator<<
by Gianluca Amato 18 Jan '12

18 Jan '12

Hi all, I have a problem using operator<< with boxes. The following code does not compile with PPL 0.11.2 and gcc 4.6.1. ---- #include <ppl.hh> #include <iostream> using namespace Parma_Polyhedra_Library; struct Floating_Point_Box_Interval_Info_Policy { const_bool_nodef(store_special, false); const_bool_nodef(store_open, true); const_bool_nodef(cache_empty, true); const_bool_nodef(cache_singleton, true); const_bool_nodef(cache_normalized, false); const_int_nodef(next_bit, 0); const_bool_nodef(may_be_empty, true); const_bool_nodef(may_contain_infinity, false); const_bool_nodef(check_empty_result, false); const_bool_nodef(check_inexact, false); }; typedef Interval_Restriction_None<Interval_Info_Bitset <unsigned int, Floating_Point_Box_Interval_Info_Policy> > Floating_Point_Box_Interval_Info; typedef Box<Interval<double, Floating_Point_Box_Interval_Info> > Double_Box; int main(void) { Double_Box db; db.print(); std::cout << db; return 0; } --- The offending line is the one with std::cout << db, which gives the following error: no match for ‘operator<<’ in ‘std::cout << db’ I am not an expert neither with C++ nor with PPL, so I don't known if there is an obvious mistake in my code. Can someone give me an hint? Thanks, --gianluca

2 1

ppl-0.11.2 install problems with GCC
by Andre Nicolle 16 Jan '12

16 Jan '12

Hi All I have recently been compiling GCC 4.6.2 on a newly installed centos 5.6 computer and come across several strange problems when compiling PPL. GCC is being compiled to a new directory for distribution on a cluster so I install gmp-5.0.2 with configuration command ./configure --prefix=/share/apps/gcc/4.6.2 --enable-cxx this I compile using GCC 4.4 which was installed from the repositories. When compiling ppl-0.11.2 with configuration command ./configure --prefix=/share/apps/gcc/4.6.2 --with-gmp-build=/share/apps/gcc/4.6.2 and GCC 4.4 I get the following error message: checking how to link with libgmp... /share/apps/gcc/4.6.2/lib/libgmp.so -Wl,-rpath -Wl,/share/apps/gcc/4.6.2/lib checking how to link with libgmpxx... /share/apps/gcc/4.6.2/lib/libgmpxx.so /share/apps/gcc/4.6.2/lib/libgmp.so -Wl,-rpath -Wl,/share/apps/gcc/4.6.2/lib -Wl,-rpath -Wl,/share/apps/gcc/4.6.2/lib checking for the GMP library version 4.1.3 or above... no configure: error: Cannot find GMP version 4.1.3 or higher. GMP is the GNU Multi-Precision library: This is similar to the discussion at this link: http://www.cs.unipr.it/pipermail/ppl-devel/2011-March/017387.html Switching back to GCC 4.1 solves this problem and I successfully compile and test gmp and ppl-0.11.2. Is this a problem with the configure script? I then decided to compile ppl-0.11.2 again but this time using my newly compiled GCC 4.6.2 which does not encounter the previous error and configures correctly. However during the build I get the following error: /share/apps/gcc/4.6.2/lib../lib/libstdc++.so: could not read symbols: File in wrong format The environmental variables are set with the following command to use the newly installed GCC 4.6.2. export PATH=/share/apps/gcc/4.6.2/bin:$PATH export LD_LIBRARY_PATH=/share/apps/gcc/4.6.2/lib:/share/apps/gcc/4.6.2/lib64:$LD_LIBRARY_PATH This I discover is due to the compiler trying to link to the non-64bit version of libstdc++.so similar to the discussion here: http://www.cs.unipr.it/pipermail/ppl-devel/2009-April/014677.html By linking: ln -s /share/apps/gcc/4.6.2/lib64/libstdc++.so /share/apps/gcc/4.6.2/lib/libstdc++.so the 64bit version of the file into the requested location, I am able to compile and test ppl. This does not seem correct behaviour, could somebody tell me what is going wrong and how to fix this. Thanks Andre

2 2

[GIT] ppl/ppl(master): Also add bugseng_logo.pdf to EXTRA_DIST.
by Enea Zaffanella 05 Jan '12

05 Jan '12

Module: ppl/ppl Branch: master Commit: c34e47c445db87c610a7b266d880e0c4717ab82d URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c34e47c445db… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Jan 5 15:44:12 2012 +0100 Also add bugseng_logo.pdf to EXTRA_DIST. --- doc/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index d4225de..c30ecb8 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1656,6 +1656,7 @@ EXTRA_DIST= \ $(DIST_DOCS) \ $(DOX_FILES) \ README.doc \ +bugseng_logo.pdf \ devref-language-interface.tex \ devref.tex \ fdl.tex \

1 0

[GIT] ppl/ppl(master): Added ppl_logo* to EXTRA_DIST.
by Enea Zaffanella 04 Jan '12

04 Jan '12

Module: ppl/ppl Branch: master Commit: 19fed334bf697bfd4c63e1c94f3239d912dd6219 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=19fed334bf69… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Jan 4 08:49:02 2012 +0100 Added ppl_logo* to EXTRA_DIST. --- doc/Makefile.am | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 148cae2..d4225de 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1663,6 +1663,8 @@ gpl.tex \ interfaces-html.sed \ interfaces-latex.sed \ ppl.sty \ +ppl_logo.pdf \ +ppl_logo_no_ppl.pdf \ user-language-interface.tex \ user.tex

1 0

[GIT] ppl/ppl(sparse_matrices): Fixed a performance regression caused by a bug in the computation of
by Enea Zaffanella 02 Jan '12

02 Jan '12

Module: ppl/ppl Branch: sparse_matrices Commit: 95219a9f931d8b868975050d10326bde214dda46 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=95219a9f931d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 10:17:15 2012 +0100 Fixed a performance regression caused by a bug in the computation of the number of subsumed rows. --- src/Polyhedron_conversion.templates.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Polyhedron_conversion.templates.hh b/src/Polyhedron_conversion.templates.hh index e850214..90f0ce5 100644 --- a/src/Polyhedron_conversion.templates.hh +++ b/src/Polyhedron_conversion.templates.hh @@ -700,7 +700,7 @@ Polyhedron::conversion(Source_Linear_System& source, // NOTE: this number has to be less than `k' because // we are treating the `k'-th constraint. const dimension_type num_common_satur - = k - new_satrow.count_ones(); + = k - redundant_source_rows.size() - new_satrow.count_ones(); // Even before actually creating the new ray as a // positive combination of `dest_rows[i]' and `dest_rows[j]',

1 0