February 2012 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): Type fixed.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: 37b4bdd5f55204f194749a687ab97a9ef1f03fc4 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=37b4bdd5f552… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 19:46:43 2012 +0100 Type fixed. Detected by ECLAIR service utypflag. --- utils/timings.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils/timings.cc b/utils/timings.cc index 23ba39d..20b94fd 100644 --- a/utils/timings.cc +++ b/utils/timings.cc @@ -92,7 +92,7 @@ print_clock(ostream& s) { } } assert(csecs >= 0 && csecs < 100 && secs >= 0); - int fill_char = s.fill(); + char fill_char = s.fill(); s << secs << "." << setfill('0') << setw(2) << csecs; s.fill(fill_char); }

1 0

[GIT] ppl/ppl(master): Added missing parentheses around a macro argument.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: df14c76cab47c24f88acc88c0a60dafeda066fcb URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=df14c76cab47… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 19:37:34 2012 +0100 Added missing parentheses around a macro argument. Detected by ECLAIR service macrbody. --- src/meta_programming.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/meta_programming.hh b/src/meta_programming.hh index 1284b09..dedb45e 100644 --- a/src/meta_programming.hh +++ b/src/meta_programming.hh @@ -120,7 +120,7 @@ struct Compile_Time_Check<true> { enum anonymous_enum_compile_time_check_ ## suffix { \ /* If e evaluates to false, then the sizeof cannot be compiled. */ \ PPL_COMPILE_TIME_CHECK_NAME(suffix) \ - = sizeof(Parma_Polyhedra_Library::Compile_Time_Check<e>) \ + = sizeof(Parma_Polyhedra_Library::Compile_Time_Check<(e)>) \ } #ifdef PPL_DOXYGEN_INCLUDE_IMPLEMENTATION_DETAILS

1 0

[GIT] ppl/ppl(master): Avoid null statements that, apart from a comment, are not on a line by themselves.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: 35c29d765b0b2acd717b13a878fed3a742f728f1 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=35c29d765b0b… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 10:24:21 2012 +0100 Avoid null statements that, apart from a comment, are not on a line by themselves. Detected by ECLAIR service nullstmt. --- src/CO_Tree.cc | 2 +- src/MIP_Problem.cc | 2 +- src/globals.defs.hh | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/CO_Tree.cc b/src/CO_Tree.cc index bf45dec..68f9fe0 100644 --- a/src/CO_Tree.cc +++ b/src/CO_Tree.cc @@ -786,7 +786,7 @@ PPL::CO_Tree::rebalance(tree_iterator itr, dimension_type key, subtree_reserved_size = 2*subtree_reserved_size + 1; --itr_depth_minus_1; PPL_ASSERT(itr.depth() - 1 == itr_depth_minus_1); - }; + } // Now the subtree rooted at itr has been chosen as the subtree to be // rebalanced. diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index c777be6..e3ad951 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -685,7 +685,7 @@ PPL::MIP_Problem::process_pending_constraints() { is_remergeable_variable)) { status = UNSATISFIABLE; return false; - }; + } // Merge back any variable that was previously split into a positive // and a negative part and is now known to be nonnegative. diff --git a/src/globals.defs.hh b/src/globals.defs.hh index d30a292..9b59ba1 100644 --- a/src/globals.defs.hh +++ b/src/globals.defs.hh @@ -155,7 +155,9 @@ extern unsigned int in_assert; wp__.end(factor); \ } while(0) #else -#define WEIGHT_BEGIN() +#define WEIGHT_BEGIN() \ + do { \ + } while(0) #define WEIGHT_ADD(delta) \ do { \ Weightwatch_Traits::weight += (delta); \

1 0

[GIT] ppl/ppl(master): Updated.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: 4f263321dba7e0865cd234aa0ed69a716b13c688 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4f263321dba7… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 09:10:15 2012 +0100 Updated. --- Watchdog/compile | 33 +++--- Watchdog/config.guess | 50 ++++++---- Watchdog/config.sub | 102 ++++++++++++------ Watchdog/depcomp | 74 ++++++++++++-- Watchdog/install-sh | 23 +++-- Watchdog/ltmain.sh | 95 ++++++++++------- Watchdog/m4/libtool.m4 | 265 ++++++++++++++++++++++++++++++++++++---------- Watchdog/m4/ltoptions.m4 | 19 +++- Watchdog/m4/ltversion.m4 | 10 +- Watchdog/missing | 53 +--------- compile | 33 +++--- config.guess | 50 ++++++---- config.sub | 102 ++++++++++++------ depcomp | 74 ++++++++++++-- install-sh | 23 +++-- ltmain.sh | 95 ++++++++++------- m4/libtool.m4 | 265 ++++++++++++++++++++++++++++++++++++---------- m4/ltoptions.m4 | 19 +++- m4/ltversion.m4 | 10 +- missing | 53 +--------- 20 files changed, 970 insertions(+), 478 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=4f263321…

1 0

[GIT] ppl/ppl(master): Prolog sources must go under .../share/ ppl as these files are architecture independent.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: 10e0afa8fa25c9e0e8eaac9a0d730ab325086010 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=10e0afa8fa25… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 08:48:59 2012 +0100 Prolog sources must go under .../share/ppl as these files are architecture independent. Moreover, new versions of Automake no longer accept pkglib_DATA. --- interfaces/Prolog/Ciao/Makefile.am | 2 +- interfaces/Prolog/GNU/Makefile.am | 2 +- interfaces/Prolog/SICStus/Makefile.am | 4 ++-- interfaces/Prolog/SWI/Makefile.am | 2 +- interfaces/Prolog/XSB/Makefile.am | 2 +- interfaces/Prolog/YAP/Makefile.am | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/interfaces/Prolog/Ciao/Makefile.am b/interfaces/Prolog/Ciao/Makefile.am index c8dd56e..8dcf17e 100644 --- a/interfaces/Prolog/Ciao/Makefile.am +++ b/interfaces/Prolog/Ciao/Makefile.am @@ -170,7 +170,7 @@ $(NO_UNDEFINED_FLAG) \ -module \ -avoid-version -pkglib_DATA = ppl_ciao.po +pkgdata_DATA = ppl_ciao.po ppl_ciao.pl: $(interface_generator_dependencies) $(M4) --prefix-builtin -I../.. -I$(srcdir)/.. -I$(srcdir)/../.. \ diff --git a/interfaces/Prolog/GNU/Makefile.am b/interfaces/Prolog/GNU/Makefile.am index 5904bf1..2ba45ee 100644 --- a/interfaces/Prolog/GNU/Makefile.am +++ b/interfaces/Prolog/GNU/Makefile.am @@ -169,7 +169,7 @@ ppl_gprolog.pl: $(interface_generator_dependencies) $(M4) --prefix-builtin -I../.. -I$(srcdir)/.. -I$(srcdir)/../.. \ $(srcdir)/ppl_interface_generator_gprolog_pl.m4 > $@ -pkglib_DATA = ppl_gprolog.pl +pkgdata_DATA = ppl_gprolog.pl bin_PROGRAMS = ppl_gprolog diff --git a/interfaces/Prolog/SICStus/Makefile.am b/interfaces/Prolog/SICStus/Makefile.am index 17a54c7..22f809f 100644 --- a/interfaces/Prolog/SICStus/Makefile.am +++ b/interfaces/Prolog/SICStus/Makefile.am @@ -69,7 +69,7 @@ ppl_sicstus_SOURCES = if ENABLE_SHARED -pkglib_DATA = ppl_sicstus.pl ppl_sicstus.s.o +pkgdata_DATA = ppl_sicstus.pl ppl_sicstus.s.o ppl_sicstus.so: ppl_sicstus.pl $(top_builddir)/src/libppl.la $(WATCHDOG_LIBRARY) libppl_sicstus.la $(LIBTOOL) --mode=link --tag=CXX \ @@ -87,7 +87,7 @@ install-data-local: ppl_sicstus.so else !ENABLE_SHARED -pkglib_DATA = ppl_sicstus.pl +pkgdata_DATA = ppl_sicstus.pl endif !ENABLE_SHARED diff --git a/interfaces/Prolog/SWI/Makefile.am b/interfaces/Prolog/SWI/Makefile.am index f5bcbe8..5e4e0e4 100644 --- a/interfaces/Prolog/SWI/Makefile.am +++ b/interfaces/Prolog/SWI/Makefile.am @@ -189,7 +189,7 @@ $(NO_UNDEFINED_FLAG) \ bin_PROGRAMS = ppl_pl ppl_pl_SOURCES = ppl_pl.cc -pkglib_DATA = ppl_swiprolog.pl +pkgdata_DATA = ppl_swiprolog.pl CLPQ_TESTS_NONSTRICT = \ ack.clpq \ diff --git a/interfaces/Prolog/XSB/Makefile.am b/interfaces/Prolog/XSB/Makefile.am index 18648eb..1bc1e67 100644 --- a/interfaces/Prolog/XSB/Makefile.am +++ b/interfaces/Prolog/XSB/Makefile.am @@ -188,7 +188,7 @@ $(NO_UNDEFINED_FLAG) \ -module \ -avoid-version -pkglib_DATA = ppl_xsb.xwam +pkgdata_DATA = ppl_xsb.xwam ppl_xsb.xwam: ppl_xsb.H ppl_xsb.cc libppl_xsb.la cp -f ppl_xsb.cc ppl_xsb.c diff --git a/interfaces/Prolog/YAP/Makefile.am b/interfaces/Prolog/YAP/Makefile.am index fab59c2..34d89e9 100644 --- a/interfaces/Prolog/YAP/Makefile.am +++ b/interfaces/Prolog/YAP/Makefile.am @@ -179,7 +179,7 @@ $(NO_UNDEFINED_FLAG) \ -module \ -avoid-version -pkglib_DATA = ppl_yap.pl +pkgdata_DATA = ppl_yap.pl CLPQ_TESTS_NONSTRICT = \ ack.clpq \

1 0

[GIT] ppl/ppl(master): Added missing template parameter.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: a372f86d78f0effbfb551dd6f1078f6a4a7a0161 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a372f86d78f0… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 08:16:03 2012 +0100 Added missing template parameter. --- configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eed647d..983f8c7 100644 --- a/configure.ac +++ b/configure.ac @@ -24,7 +24,7 @@ # Process this file with Autoconf to produce a configure script. # Every other copy of the package version number gets its value from here. -AC_INIT([the Parma Polyhedra Library], [0.12pre4], [ppl-devel(a)cs.unipr.it], [ppl]) +AC_INIT([the Parma Polyhedra Library], [0.12pre5], [ppl-devel(a)cs.unipr.it], [ppl]) # Minimum Autoconf version required. AC_PREREQ(2.61) @@ -673,7 +673,7 @@ AM_CONDITIONAL(USE_INT64, test x"$coefficient_bits" = x64) if test x"$coefficient_kind" = xnative then - coefficient_type="Parma_Polyhedra_Library::Checked_Number<int${coefficient_bits}_t, Checked_Number_Transparent_Policy>" + coefficient_type="Parma_Polyhedra_Library::Checked_Number<int${coefficient_bits}_t, Checked_Number_Transparent_Policy<int${coefficient_bits}_t> >" AC_DEFINE_UNQUOTED(PPL_COEFFICIENT_TYPE, $coefficient_type, [The integral type used to represent coefficients.]) AC_DEFINE_UNQUOTED(PPL_COEFFICIENT_BITS, $coefficient_bits, [The number of bits of coefficients; 0 if unbounded.]) AC_DEFINE(PPL_NATIVE_INTEGERS, 1, [Defined if the integral type to be used for coefficients is a native one.])

1 0

[GIT] ppl/ppl(master): INT_MIN % -1 is undefined behavior in C++11.
by Roberto Bagnara 12 Feb '12

12 Feb '12

Module: ppl/ppl Branch: master Commit: 7a847c76c10734e3d554f43963f647ac421f93f4 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7a847c76c107… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sun Feb 12 08:14:28 2012 +0100 INT_MIN % -1 is undefined behavior in C++11. The PPL has been proven to be immune to this potential problem by ECLAIR. (Thanks to Rene Sugar.) Long lines avoided on passing. --- src/checked_int.inlines.hh | 55 +++++++++++++++++++++++++++++-------------- 1 files changed, 37 insertions(+), 18 deletions(-) diff --git a/src/checked_int.inlines.hh b/src/checked_int.inlines.hh index 0e0e421..ffcc55a 100644 --- a/src/checked_int.inlines.hh +++ b/src/checked_int.inlines.hh @@ -926,7 +926,8 @@ neg_int_larger(Type& to, const Type x, Rounding_Dir dir) { return assign<To_Policy, To_Policy>(to, l, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result add_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { typename Larger<Type>::type_for_add l = x; @@ -934,7 +935,8 @@ add_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { return assign<To_Policy, To_Policy>(to, l, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result sub_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { typename Larger<Type>::type_for_sub l = x; @@ -942,7 +944,8 @@ sub_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { return assign<To_Policy, To_Policy>(to, l, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result mul_int_larger(Type& to, const Type x, const Type y, Rounding_Dir dir) { typename Larger<Type>::type_for_mul l = x; @@ -973,7 +976,8 @@ neg_unsigned_int(Type& to, const Type from, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result add_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_add) @@ -990,7 +994,8 @@ add_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result add_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_add) @@ -1002,7 +1007,8 @@ add_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result sub_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_sub) @@ -1019,7 +1025,8 @@ sub_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result sub_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_sub) @@ -1031,7 +1038,8 @@ sub_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result mul_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_mul) @@ -1070,7 +1078,8 @@ mul_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result mul_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (To_Policy::check_overflow && Larger<Type>::use_for_mul) @@ -1089,7 +1098,8 @@ mul_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result div_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1100,6 +1110,8 @@ div_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { to = x / y; if (round_not_requested(dir)) return V_LGE; + if (y == -1) + return V_EQ; Type m = x % y; if (m < 0) return round_lt_int_no_overflow<To_Policy>(to, dir); @@ -1109,7 +1121,8 @@ div_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result div_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1124,7 +1137,8 @@ div_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return round_gt_int<To_Policy>(to, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result idiv_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1136,7 +1150,8 @@ idiv_signed_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result idiv_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1146,17 +1161,19 @@ idiv_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir) { return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result rem_signed_int(Type& to, const Type x, const Type y, Rounding_Dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { return assign_nan<To_Policy>(to, V_MOD_ZERO); } - to = x % y; + to = (y == -1) ? 0 : (x % y); return V_EQ; } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result rem_unsigned_int(Type& to, const Type x, const Type y, Rounding_Dir) { if (CHECK_P(To_Policy::check_div_zero, y == 0)) { @@ -1453,7 +1470,8 @@ sqrt_signed_int(Type& to, const Type from, Rounding_Dir dir) { return sqrt_unsigned_int<To_Policy, From_Policy>(to, from, dir); } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result add_mul_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { Type z; @@ -1475,7 +1493,8 @@ add_mul_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { } } -template <typename To_Policy, typename From1_Policy, typename From2_Policy, typename Type> +template <typename To_Policy, typename From1_Policy, typename From2_Policy, + typename Type> inline Result sub_mul_int(Type& to, const Type x, const Type y, Rounding_Dir dir) { Type z;

1 0

[GIT] ppl/ppl(master): Reflected file removal.
by Roberto Bagnara 11 Feb '12

11 Feb '12

Module: ppl/ppl Branch: master Commit: cb83c4ee577c102c190f919efbd711ef53e7519a URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cb83c4ee577c… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Feb 11 21:02:10 2012 +0100 Reflected file removal. --- m4/Makefile.am | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/m4/Makefile.am b/m4/Makefile.am index e4dffad..bf7d977 100644 --- a/m4/Makefile.am +++ b/m4/Makefile.am @@ -48,7 +48,6 @@ ac_cxx_long_double_binary_format.m4 \ ac_cxx_long_double_exact_output.m4 \ ac_cxx_plain_char_is_signed.m4 \ ac_cxx_proper_long_double.m4 \ -ac_cxx_remainder_bug.m4 \ ac_prog_jar.m4 \ ac_prog_java.m4 \ ac_prog_javac.m4 \

1 0

[GIT] ppl/ppl(master): INT_MIN % -1 is undefined behavior in C++11.
by Roberto Bagnara 11 Feb '12

11 Feb '12

Module: ppl/ppl Branch: master Commit: ccd09e698f00e26a8dc4ccc2265843e6b9ec1598 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ccd09e698f00… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Feb 11 20:51:31 2012 +0100 INT_MIN % -1 is undefined behavior in C++11. The PPL has been proven to be immune to this potential problem by ECLAIR. (Thanks to Rene Sugar.) --- TODO | 7 ---- configure.ac | 5 +-- m4/ac_cxx_remainder_bug.m4 | 71 -------------------------------------------- src/checked.cc | 1 + 4 files changed, 2 insertions(+), 82 deletions(-) diff --git a/TODO b/TODO index 6ea8729..271fb42 100644 --- a/TODO +++ b/TODO @@ -23,13 +23,6 @@ Enhancements for PPL 0.12 or later versions Explain it in README.configure. - Ensure the tests in tests/MIP_Problem/* cover every line of code in MIP_Problem.*. -- Define functions rem() and remp() to compute the remainder of division - in the general case, for rem(), and in the case where the second - argument is known to be positive, for remp(). In the implementation - of rem(), if CXX_HAS_REMAINDER_BUG is nonzero, a suitable workaround - should be implemented to circumvent the INT_MIN % -1 bug. - rem() and remp() should be used (with a strong preference to the second, - of course) wherever we now use operator%(). - Suppose we want to sum three numbers, and suppose we do it by add(T& to, const T& x, const T& y, const T& z) { diff --git a/configure.ac b/configure.ac index 898f540..eed647d 100644 --- a/configure.ac +++ b/configure.ac @@ -24,7 +24,7 @@ # Process this file with Autoconf to produce a configure script. # Every other copy of the package version number gets its value from here. -AC_INIT([the Parma Polyhedra Library], [0.12pre3], [ppl-devel(a)cs.unipr.it], [ppl]) +AC_INIT([the Parma Polyhedra Library], [0.12pre4], [ppl-devel(a)cs.unipr.it], [ppl]) # Minimum Autoconf version required. AC_PREREQ(2.61) @@ -780,9 +780,6 @@ AC_CXX_SUPPORTS_ZERO_LENGTH_ARRAYS # Check whether the IEEE inexact flag is supported in C++. AC_CXX_SUPPORTS_IEEE_INEXACT_FLAG -# Check whether the C++ compiler has the remainder bug. -AC_CXX_HAS_REMAINDER_BUG - # Check whether the C++ compiler supports __attribute__ ((weak)). AC_CXX_SUPPORTS_ATTRIBUTE_WEAK diff --git a/m4/ac_cxx_remainder_bug.m4 b/m4/ac_cxx_remainder_bug.m4 deleted file mode 100644 index 0dfb146..0000000 --- a/m4/ac_cxx_remainder_bug.m4 +++ /dev/null @@ -1,71 +0,0 @@ -dnl A function to check whether the C++ compiler has the `remainder' bug. -dnl Copyright (C) 2001-2010 Roberto Bagnara <bagnara(a)cs.unipr.it> -dnl Copyright (C) 2010-2012 BUGSENG srl (http://bugseng.com) -dnl -dnl This file is part of the Parma Polyhedra Library (PPL). -dnl -dnl The PPL is free software; you can redistribute it and/or modify it -dnl under the terms of the GNU General Public License as published by the -dnl Free Software Foundation; either version 3 of the License, or (at your -dnl option) any later version. -dnl -dnl The PPL is distributed in the hope that it will be useful, but WITHOUT -dnl ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or -dnl FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License -dnl for more details. -dnl -dnl You should have received a copy of the GNU General Public License -dnl along with this program; if not, write to the Free Software Foundation, -dnl Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA. -dnl -dnl For the most up-to-date information see the Parma Polyhedra Library -dnl site: http://bugseng.com/products/ppl/ . - -AC_DEFUN([AC_CXX_HAS_REMAINDER_BUG], -[ - -ac_save_CPPFLAGS="$CPPFLAGS" -ac_save_LIBS="$LIBS" -AC_LANG_PUSH(C++) - -AC_MSG_CHECKING([if the compiler has the remainder bug]) -AC_RUN_IFELSE([AC_LANG_SOURCE([[ -#include <climits> - -int minus_one(int n) { - return (n+1)*(n-1)-n*n; -} - -int p(int x, int y) { - int z = x % y; - return z; -} - -int main(int argc, char** argv) { - if (p(INT_MIN, minus_one(argc)) != 0) - return 1; - else - return 0; -} -]])], - AC_MSG_RESULT(no) - ac_cv_cxx_has_remainder_bug=no, - AC_MSG_RESULT(yes) - ac_cv_cxx_has_remainder_bug=yes, - AC_MSG_RESULT([assuming yes]) - ac_cv_cxx_has_remainder_bug=yes) - -if test x"$ac_cv_cxx_has_remainder_bug" = xyes -then - value=1 -else - value=0 -fi -AC_DEFINE_UNQUOTED(PPL_CXX_HAS_REMAINDER_BUG, $value, - [Not zero if the C++ compiler has the remainder bug.]) - -AC_LANG_POP(C++) -CPPFLAGS="$ac_save_CPPFLAGS" -LIBS="$ac_save_LIBS" -]) - diff --git a/src/checked.cc b/src/checked.cc index 104fecf..93a933c 100644 --- a/src/checked.cc +++ b/src/checked.cc @@ -278,6 +278,7 @@ parse_number_part(std::istream& is, number_struct& numer) { goto unexpected; exp: state = EXPONENT; + PPL_ASSERT(numer.base >= 2); max_exp_div = LONG_MAX / numer.base; max_exp_rem = static_cast<int>(LONG_MAX % numer.base); if (!is.get(c))

1 0

[GIT] ppl/ppl(master): Added a default label to switch.
by Patricia Hill 03 Feb '12

03 Feb '12

Module: ppl/ppl Branch: master Commit: a190d3da98795c4e4a696746633e08fe8f335baa URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a190d3da9879… Author: Patricia Hill <p.m.hill(a)leeds.ac.uk> Date: Fri Feb 3 16:58:13 2012 +0000 Added a default label to switch. --- src/Grid_Generator.inlines.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Grid_Generator.inlines.hh b/src/Grid_Generator.inlines.hh index e691739..14379f6 100644 --- a/src/Grid_Generator.inlines.hh +++ b/src/Grid_Generator.inlines.hh @@ -76,8 +76,8 @@ Grid_Generator::type() const { case Generator::LINE: return LINE; case Generator::CLOSURE_POINT: + default: PPL_UNREACHABLE; - return POINT; } }

1 0