March 2012 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): Commented-out code removed.
by Roberto Bagnara 10 Mar '12

10 Mar '12

Module: ppl/ppl Branch: master Commit: 0f0ce5d8d426bb5aa7288d3f0956c615b1e18ff4 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0f0ce5d8d426… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Mar 9 19:15:34 2012 +0100 Commented-out code removed. Detected by ECLAIR service cmntdout. --- src/ppl-config.cc.in | 13 ------------- 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/src/ppl-config.cc.in b/src/ppl-config.cc.in index 6691fd5..48265f2 100644 --- a/src/ppl-config.cc.in +++ b/src/ppl-config.cc.in @@ -145,19 +145,6 @@ fatal(const char* format, ...) { exit(1); } -// Currently unused, but we may want to use it in the future. -/* -void -warning(const char* format, ...) { - va_list ap; - va_start(ap, format); - fprintf(stderr, "%s: Warning: ", program_name); - vfprintf(stderr, format, ap); - fprintf(stderr, "\n"); - va_end(ap); -} -*/ - void internal_error() __attribute__((__noreturn__));

1 0

[GIT] ppl/ppl(master): Comment corrected.
by Roberto Bagnara 10 Mar '12

10 Mar '12

Module: ppl/ppl Branch: master Commit: 5010fa847b1f389aaee61e8cdfc94e1d8df27c1b URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5010fa847b1f… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Mar 9 19:14:06 2012 +0100 Comment corrected. --- src/PIP_Tree.cc | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index 4f2e82e..0864681 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -221,8 +221,10 @@ add_artificial_parameters(Matrix& context, Variables_Set& params, } /* Compares two columns lexicographically in a revised simplex tableau: - - returns true if (column ja)*(-cst_a)/pivot_a[ja] - << (column jb)*(-cst_b)/pivot_b[jb]; + - returns true if + <CODE> + (column ja)*(-cst_a)/pivot_a[ja] < (column jb)*(-cst_b)/pivot_b[jb]; + </CODE> - returns false otherwise. */ bool

1 0

[GIT] ppl/ppl(master): Old FIXMEs dealt with.
by Roberto Bagnara 10 Mar '12

10 Mar '12

Module: ppl/ppl Branch: master Commit: a00f2ac21655be81d14e14c0cbf2dad07bf3e28d URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a00f2ac21655… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Mar 9 19:04:35 2012 +0100 Old FIXMEs dealt with. Detected by ECLAIR service cmntdout. --- src/termination.cc | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/termination.cc b/src/termination.cc index db33684..96e6ade 100644 --- a/src/termination.cc +++ b/src/termination.cc @@ -427,9 +427,7 @@ fill_constraint_system_PR(const Constraint_System& cs_before, for (dimension_type i = s + 2*r; i-- > 0; ) cs_out.insert(Variable(i) >= 0); - // FIXME: iterate backwards once the debugging phase is over. - //for (dimension_type j = 2*n; j-- > 0; ) - for (dimension_type j = 0; j < 2*n; ++j) + for (dimension_type j = 2*n; j-- > 0; ) cs_out.insert(les_eq[j] == 0); } @@ -479,9 +477,7 @@ fill_constraint_system_PR_original(const Constraint_System& cs, for (dimension_type i = 2*m; i-- > 0; ) cs_out.insert(Variable(i) >= 0); - // FIXME: iterate backwards once the debugging phase is over. - //for (dimension_type j = 3*n; j-- > 0; ) - for (dimension_type j = 0; j < 3*n; ++j) + for (dimension_type j = 3*n; j-- > 0; ) cs_out.insert(les_eq[j] == 0); }

1 0

[GIT] ppl/ppl(master): Do use the notation "[l, u]" to denote the closed interval with boundaries `l' and `u'.
by Roberto Bagnara 10 Mar '12

10 Mar '12

Module: ppl/ppl Branch: master Commit: 9c44e7ac3e0247d174ddfa43ebbe4a77c55f3adc URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9c44e7ac3e02… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Mar 9 18:57:39 2012 +0100 Do use the notation "[l, u]" to denote the closed interval with boundaries `l' and `u'. --- src/BD_Shape.templates.hh | 24 ++++++------ src/Cast_Floating_Point_Expression.defs.hh | 2 +- src/Constant_Floating_Point_Expression.defs.hh | 2 +- src/Difference_Floating_Point_Expression.defs.hh | 2 +- src/Division_Floating_Point_Expression.defs.hh | 12 +++--- src/Float.defs.hh | 2 +- src/Floating_Point_Expression.defs.hh | 10 +++--- src/Linear_Form.defs.hh | 6 ++-- ...ultiplication_Floating_Point_Expression.defs.hh | 20 +++++----- src/Octagonal_Shape.templates.hh | 38 ++++++++++---------- src/Sum_Floating_Point_Expression.defs.hh | 2 +- src/Variable_Floating_Point_Expression.defs.hh | 2 +- src/linearize.hh | 36 +++++++++--------- 13 files changed, 79 insertions(+), 79 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=9c44e7ac…

1 0

[GIT] ppl/ppl(master): Added missing full-stop in comment.
by Roberto Bagnara 10 Mar '12

10 Mar '12

Module: ppl/ppl Branch: master Commit: bfe9db5473e2d4958bebb4cc28380a46ecbd6967 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=bfe9db5473e2… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Mar 9 18:36:05 2012 +0100 Added missing full-stop in comment. --- src/Octagonal_Shape.templates.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Octagonal_Shape.templates.hh b/src/Octagonal_Shape.templates.hh index 93bd0c1..11da999 100644 --- a/src/Octagonal_Shape.templates.hh +++ b/src/Octagonal_Shape.templates.hh @@ -5446,7 +5446,7 @@ linear_form_upper_bound(const Linear_Form< Interval<T, Interval_Info> >& lf, div_2exp_assign_r(curr_var_ub, curr_var_ub, 1, ROUND_UP); neg_assign_r(curr_minus_var_ub, matrix[n_var][n_var + 1], ROUND_NOT_NEEDED); div_2exp_assign_r(curr_minus_var_ub, curr_minus_var_ub, 1, ROUND_DOWN); - // Optimize the most common case: curr = +/-[1;1] + // Optimize the most common case: curr = +/-[1;1]. if (curr_lb == 1 && curr_ub == 1) { add_assign_r(result, result, std::max(curr_var_ub, curr_minus_var_ub), ROUND_UP);

1 0

[PPL] Thread safety with Java API?
by Rémi Delmas 08 Mar '12

08 Mar '12

Hello, I'm using the java API to the PPL from Scala code. I want to parallelize my code using scala actors (which under some conditions are mapped to jvm threads). I would like to know if the PPL can work normally when accessed concurrently from different JVM threads, if each thread manipulates its own PPL context instance. Best regards, /Rémi -- Rémi Delmas Remi.Delmas(a)onera.fr +33.5.62.25.26.54 http://www.onera.fr/dtim/systemes-critiques/ ONERA BP4025 2 avenue Edouard Belin FR-31055 TOULOUSE CEDEX 4

1 0

[GIT] ppl/ppl(master): Renamed Box methods get_{upper, lower}_bound() as has_{upper, lower}_bound().
by Enea Zaffanella 08 Mar '12

08 Mar '12

Module: ppl/ppl Branch: master Commit: 50030fba0045a46c3aad0dfc6d3906fbaa3590bf URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=50030fba0045… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Mar 8 13:01:20 2012 +0100 Renamed Box methods get_{upper,lower}_bound() as has_{upper,lower}_bound(). Improved documentation: in particular, make clearer that undefined behavior is obtained when calling them on an empty box. --- src/Box.defs.hh | 77 +++++++++++++++++++++++------------------- src/Box.inlines.hh | 8 ++-- src/Box.templates.hh | 10 +++--- src/Grid.templates.hh | 4 +- src/Polyhedron.templates.hh | 8 ++-- 5 files changed, 57 insertions(+), 50 deletions(-) diff --git a/src/Box.defs.hh b/src/Box.defs.hh index cde52d0..4b5a4e3 100644 --- a/src/Box.defs.hh +++ b/src/Box.defs.hh @@ -1630,48 +1630,55 @@ public: void set_interval(Variable var, const ITV& i); /*! \brief - If the <CODE>k</CODE>-th space dimension is unbounded below, returns - <CODE>false</CODE>. Otherwise returns <CODE>true</CODE> and set + If the <CODE>k</CODE>-th space dimension is unbounded below, return + <CODE>false</CODE>. Otherwise return <CODE>true</CODE> and set \p closed, \p n and \p d accordingly. - Let \f$I\f$ the interval corresponding to the <CODE>k</CODE>-th - space dimension. If \f$I\f$ is not bounded from below, simply return - <CODE>false</CODE>. Otherwise, set <CODE>closed</CODE>, - <CODE>n</CODE> and <CODE>d</CODE> as follows: <CODE>closed</CODE> - is set to <CODE>true</CODE> if the the lower boundary of \f$I\f$ - is closed and is set to <CODE>false</CODE> otherwise; - <CODE>n</CODE> and <CODE>d</CODE> are assigned the integers - \f$n\f$ and \f$d\f$ such that the canonical fraction \f$n/d\f$ - corresponds to the greatest lower bound of \f$I\f$. The fraction - \f$n/d\f$ is in canonical form if and only if \f$n\f$ and \f$d\f$ - have no common factors and \f$d\f$ is positive, \f$0/1\f$ being - the unique representation for zero. - - An undefined behavior is obtained if \p k is greater than - or equal to the space dimension of \p *this. - */ - bool get_lower_bound(dimension_type k, bool& closed, + \note + It is assumed that <CODE>*this</CODE> is a non-empty box + having space dimension greater than \p k. An undefined behavior + is obtained if this assumption is not met. + + Let \f$I\f$ be the interval corresponding to the <CODE>k</CODE>-th + space dimension of the non-empty box <CODE>*this</CODE>. + If \f$I\f$ is not bounded from below, simply return <CODE>false</CODE> + (leaving all other parameters unchanged). + Otherwise, set \p closed, \p n and \p d as follows: + - \p closed is set to <CODE>true</CODE> if and only if the lower + boundary of \f$I\f$ is closed (i.e., it is included in the interval); + - \p n and \p d are assigned the integers \f$n\f$ and \f$d\f$ such + that the fraction \f$n/d\f$ corresponds to the greatest lower bound + of \f$I\f$. The fraction \f$n/d\f$ is in canonical form, meaning + that \f$n\f$ and \f$d\f$ have no common factors, \f$d\f$ is positive, + and if \f$n\f$ is zero then \f$d\f$ is one. + */ + bool has_lower_bound(dimension_type k, bool& closed, Coefficient& n, Coefficient& d) const; /*! \brief - If the <CODE>k</CODE>-th space dimension is unbounded above, returns - <CODE>false</CODE>. Otherwise returns <CODE>true</CODE> and set + If the <CODE>k</CODE>-th space dimension is unbounded above, return + <CODE>false</CODE>. Otherwise return <CODE>true</CODE> and set \p closed, \p n and \p d accordingly. - Let \f$I\f$ the interval corresponding to the <CODE>k</CODE>-th - space dimension. If \f$I\f$ is not bounded from above, simply return - <CODE>false</CODE>. Otherwise, set <CODE>closed</CODE>, - <CODE>n</CODE> and <CODE>d</CODE> as follows: <CODE>closed</CODE> - is set to <CODE>true</CODE> if the the upper boundary of \f$I\f$ - is closed and is set to <CODE>false</CODE> otherwise; - <CODE>n</CODE> and <CODE>d</CODE> are assigned the integers - \f$n\f$ and \f$d\f$ such that the canonical fraction \f$n/d\f$ - corresponds to the least upper bound of \f$I\f$. - - An undefined behavior is obtained if \p k is greater than - or equal to the space dimension of \p *this. - */ - bool get_upper_bound(dimension_type k, bool& closed, + \note + It is assumed that <CODE>*this</CODE> is a non-empty box + having space dimension greater than \p k. An undefined behavior + is obtained if this assumption is not met. + + Let \f$I\f$ be the interval corresponding to the <CODE>k</CODE>-th + space dimension of the non-empty box <CODE>*this</CODE>. + If \f$I\f$ is not bounded from above, simply return <CODE>false</CODE> + (leaving all other parameters unchanged). + Otherwise, set \p closed, \p n and \p d as follows: + - \p closed is set to <CODE>true</CODE> if and only if the upper + boundary of \f$I\f$ is closed (i.e., it is included in the interval); + - \p n and \p d are assigned the integers \f$n\f$ and \f$d\f$ such + that the fraction \f$n/d\f$ corresponds to the least upper bound + of \f$I\f$. The fraction \f$n/d\f$ is in canonical form, meaning + that \f$n\f$ and \f$d\f$ have no common factors, \f$d\f$ is positive, + and if \f$n\f$ is zero then \f$d\f$ is one. + */ + bool has_upper_bound(dimension_type k, bool& closed, Coefficient& n, Coefficient& d) const; //! Returns a system of constraints defining \p *this. diff --git a/src/Box.inlines.hh b/src/Box.inlines.hh index b38e30f..8d0790c 100644 --- a/src/Box.inlines.hh +++ b/src/Box.inlines.hh @@ -264,9 +264,9 @@ operator!=(const Box<ITV>& x, const Box<ITV>& y) { template <typename ITV> inline bool -Box<ITV>::get_lower_bound(const dimension_type k, bool& closed, +Box<ITV>::has_lower_bound(const dimension_type k, bool& closed, Coefficient& n, Coefficient& d) const { - PPL_ASSERT(k < seq.size()); + PPL_ASSERT(!is_empty() && k < seq.size()); const ITV& seq_k = seq[k]; if (seq_k.lower_is_boundary_infinity()) @@ -284,9 +284,9 @@ Box<ITV>::get_lower_bound(const dimension_type k, bool& closed, template <typename ITV> inline bool -Box<ITV>::get_upper_bound(const dimension_type k, bool& closed, +Box<ITV>::has_upper_bound(const dimension_type k, bool& closed, Coefficient& n, Coefficient& d) const { - PPL_ASSERT(k < seq.size()); + PPL_ASSERT(!is_empty() && k < seq.size()); const ITV& seq_k = seq[k]; if (seq_k.upper_is_boundary_infinity()) diff --git a/src/Box.templates.hh b/src/Box.templates.hh index dc8bbd9..262e002 100644 --- a/src/Box.templates.hh +++ b/src/Box.templates.hh @@ -3873,13 +3873,13 @@ Box<ITV>::constraints() const { bool closed = false; PPL_DIRTY_TEMP(Coefficient, n); PPL_DIRTY_TEMP(Coefficient, d); - if (get_lower_bound(k, closed, n, d)) { + if (has_lower_bound(k, closed, n, d)) { if (closed) cs.insert(d*Variable(k) >= n); else cs.insert(d*Variable(k) > n); } - if (get_upper_bound(k, closed, n, d)) { + if (has_upper_bound(k, closed, n, d)) { if (closed) cs.insert(d*Variable(k) <= n); else @@ -3911,7 +3911,7 @@ Box<ITV>::minimized_constraints() const { bool closed = false; PPL_DIRTY_TEMP(Coefficient, n); PPL_DIRTY_TEMP(Coefficient, d); - if (get_lower_bound(k, closed, n, d)) { + if (has_lower_bound(k, closed, n, d)) { if (closed) // Make sure equality constraints are detected. if (seq[k].is_singleton()) { @@ -3923,7 +3923,7 @@ Box<ITV>::minimized_constraints() const { else cs.insert(d*Variable(k) > n); } - if (get_upper_bound(k, closed, n, d)) { + if (has_upper_bound(k, closed, n, d)) { if (closed) cs.insert(d*Variable(k) <= n); else @@ -3955,7 +3955,7 @@ Box<ITV>::congruences() const { bool closed = false; PPL_DIRTY_TEMP(Coefficient, n); PPL_DIRTY_TEMP(Coefficient, d); - if (get_lower_bound(k, closed, n, d) && closed) + if (has_lower_bound(k, closed, n, d) && closed) // Make sure equality congruences are detected. if (seq[k].is_singleton()) cgs.insert((d*Variable(k) %= n) / 0); diff --git a/src/Grid.templates.hh b/src/Grid.templates.hh index 8145c54..bc188ce 100644 --- a/src/Grid.templates.hh +++ b/src/Grid.templates.hh @@ -67,8 +67,8 @@ Grid::Grid(const Box<Interval>& box, Complexity_Class) // gen_sys.insert() at the end of the loop. bool closed = false; // TODO: Consider producing the system(s) in minimized form. - if (box.get_lower_bound(k, closed, l_n, l_d)) { - if (box.get_upper_bound(k, closed, u_n, u_d)) + if (box.has_lower_bound(k, closed, l_n, l_d)) { + if (box.has_upper_bound(k, closed, u_n, u_d)) if (l_n * u_d == u_n * l_d) { Grid_Generator& point = gen_sys[0]; // A point interval sets dimension k of every point to a diff --git a/src/Polyhedron.templates.hh b/src/Polyhedron.templates.hh index 51e7d25..015d70a 100644 --- a/src/Polyhedron.templates.hh +++ b/src/Polyhedron.templates.hh @@ -72,10 +72,10 @@ Polyhedron::Polyhedron(Topology topol, for (dimension_type k = space_dim; k-- > 0; ) { // See if we have a valid lower bound. bool l_closed = false; - bool l_bounded = box.get_lower_bound(k, l_closed, l_n, l_d); + bool l_bounded = box.has_lower_bound(k, l_closed, l_n, l_d); // See if we have a valid upper bound. bool u_closed = false; - bool u_bounded = box.get_upper_bound(k, u_closed, u_n, u_d); + bool u_bounded = box.has_upper_bound(k, u_closed, u_n, u_d); // See if we have an implicit equality constraint. if (l_bounded && u_bounded @@ -99,10 +99,10 @@ Polyhedron::Polyhedron(Topology topol, for (dimension_type k = space_dim; k-- > 0; ) { // See if we have a valid lower bound. bool l_closed = false; - bool l_bounded = box.get_lower_bound(k, l_closed, l_n, l_d); + bool l_bounded = box.has_lower_bound(k, l_closed, l_n, l_d); // See if we have a valid upper bound. bool u_closed = false; - bool u_bounded = box.get_upper_bound(k, u_closed, u_n, u_d); + bool u_bounded = box.has_upper_bound(k, u_closed, u_n, u_d); // See if we have an implicit equality constraint. if (l_bounded && u_bounded

1 0

Fwd: Question regarding OCaml Interface of PPL
by Roberto Bagnara 07 Mar '12

07 Mar '12

-------- Original Message -------- Subject: Question regarding OCaml Interface of PPL Date: Tue, 6 Mar 2012 13:49:10 -0500 From: Brian Pak <bpak(a)andrew.cmu.edu> To: support(a)bugseng.com Hi all, I'm a student in Carnegie Mellon University in US, and trying to use PPL for my research project. First, thank you for your great work! It is truly amazing :) I was fiddling with the library and interfaces (especially OCaml), and got stuck on one thing. I wanted to use 'get_interval' or 'get_lower/upper_bound' functions in Box class, but it seems it's not available in OCaml interface. Is there any way to get around this? I'm not too familiar with these mathematical concepts (I'm reading materials to grasp better understanding, though), but here's what I want to accomplish: - Given n variables where each of them is bounded (in some linear relation) -- build a constraint system out of these - Generate an n-polytope that above equations describe (currently planning to use C_Polyhedron) - I want to enumerate integer points in this polytope, but that's known to be difficult (please correct me if I'm wrong) - Create an n-dimensional Box object from C_Polyhedron we generated (which is basically a hyper-rectangle surrounding the polytope, possibly?) - Get the interval (low and upper bound) for each variable for the Box above. - Pick a random point in the Box (hopefully this is easier since we know the interval of each dimension) - Perform a rejection sampling to check if the picked point is contained in the polytope. - There doesn't seem to be a way to do this natively, so I'm planning to use the trick where I make a very small polytope that is constrained by Variable(0) == c_1 && Variable(1) == c_2 && … && Variable(n-1) == c_n, and use 'contains' function to check if it's contained in the polytope (represented by C_Polyhedron object above). Thanks for your help in advance! :D -Brian

2 2

[GIT] ppl/ppl(master): Avoid implicit conversions to bool ( prefer explicit tests against zero).
by Enea Zaffanella 01 Mar '12

01 Mar '12

Module: ppl/ppl Branch: master Commit: 7cab131006b0385c9855b298de5e0b85d8f05101 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7cab131006b0… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Mar 1 22:24:52 2012 +0100 Avoid implicit conversions to bool (prefer explicit tests against zero). Detected by ECLAIR service utypflag. --- src/Polyhedron_public.cc | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/Polyhedron_public.cc b/src/Polyhedron_public.cc index 0f8e3cf..31f2c7d 100644 --- a/src/Polyhedron_public.cc +++ b/src/Polyhedron_public.cc @@ -1191,28 +1191,32 @@ PPL::Polyhedron::OK(bool check_not_empty) const { for (dimension_type i = sat_c.num_rows(); i-- > 0; ) { const Generator tmp_gen = gen_sys[i]; const Bit_Row tmp_sat = sat_c[i]; - for (dimension_type j = sat_c.num_columns(); j-- > 0; ) - if (Scalar_Products::sign(con_sys[j], tmp_gen) != tmp_sat[j]) { + for (dimension_type j = sat_c.num_columns(); j-- > 0; ) { + const bool sat_j = (Scalar_Products::sign(con_sys[j], tmp_gen) == 0); + if (sat_j == tmp_sat[j]) { #ifndef NDEBUG cerr << "sat_c is declared up-to-date, but it is not!" << endl; #endif goto bomb; } + } } if (sat_g_is_up_to_date()) for (dimension_type i = sat_g.num_rows(); i-- > 0; ) { const Constraint tmp_con = con_sys[i]; const Bit_Row tmp_sat = sat_g[i]; - for (dimension_type j = sat_g.num_columns(); j-- > 0; ) - if (Scalar_Products::sign(tmp_con, gen_sys[j]) != tmp_sat[j]) { + for (dimension_type j = sat_g.num_columns(); j-- > 0; ) { + const bool sat_j = (Scalar_Products::sign(tmp_con, gen_sys[j]) == 0); + if (sat_j == tmp_sat[j]) { #ifndef NDEBUG cerr << "sat_g is declared up-to-date, but it is not!" << endl; #endif goto bomb; } + } } if (has_pending_constraints()) {

1 0

[GIT] ppl/ppl(master): Avoid implicit cast narrowing a signed integer value .
by Enea Zaffanella 01 Mar '12

01 Mar '12

Module: ppl/ppl Branch: master Commit: b6c3449ce47087c1e3957d2e37f717f5239c9796 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b6c3449ce470… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Mar 1 22:23:29 2012 +0100 Avoid implicit cast narrowing a signed integer value. Detected by ECLAIR service utypflag. --- src/Row_Flags.cc | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/Row_Flags.cc b/src/Row_Flags.cc index cb4d758..1d5a882 100644 --- a/src/Row_Flags.cc +++ b/src/Row_Flags.cc @@ -33,8 +33,7 @@ PPL::Row_Flags::ascii_dump(std::ostream& s) const { s << "0x"; std::ios::fmtflags old_flags = s.setf(std::ios::hex, std::ios::basefield); - const std::streamsize new_sz - = static_cast<std::streamsize>(2 * sizeof(Row_Flags::base_type)); + const int new_sz = 2 * static_cast<int>(sizeof(Row_Flags::base_type)); s << std::setw(new_sz) << std::setfill('0') << bits; s.flags(old_flags); }

1 0