August 2012 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): Advertise the portability improvements.
by Roberto Bagnara 18 Aug '12

18 Aug '12

Module: ppl/ppl Branch: master Commit: ccf34d6e8ac30e24cdeadce3817fde7913f3f91e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ccf34d6e8ac3… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 18 14:12:59 2012 +0200 Advertise the portability improvements. --- NEWS | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 0957671..8b0b11e 100644 --- a/NEWS +++ b/NEWS @@ -32,6 +32,12 @@ o In the Java language interface: - added value NOT_EQUAL to enumeration Relation_Symbol. +Bugfixes +======== + +o Portability improved. + + -------------------------------------------------------------------------- NEWS for version 1.0 (released on June 28, 2012) --------------------------------------------------------------------------

1 0

[GIT] ppl/ppl(master): Avoid a non-portable GNU Make idiom (using `$<' in a non-suffix rule context).
by Roberto Bagnara 18 Aug '12

18 Aug '12

Module: ppl/ppl Branch: master Commit: 416ab74e65a10ee317621632bec01177933dcfb1 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=416ab74e65a1… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 18 13:54:23 2012 +0200 Avoid a non-portable GNU Make idiom (using `$<' in a non-suffix rule context). --- demos/ppl_lcdd/Makefile.am | 6 +- demos/ppl_pips/Makefile.am | 3 +- doc/Makefile.am | 200 +++++++++++++++++++++------------ interfaces/C/Makefile.am | 2 +- interfaces/OCaml/Makefile.am | 5 +- interfaces/OCaml/tests/Makefile.am | 8 +- interfaces/Prolog/SICStus/Makefile.am | 2 +- 7 files changed, 143 insertions(+), 83 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=416ab74e…

1 0

[GIT] ppl/ppl(master): Modified the Expression_Adapter infrastructure.
by Enea Zaffanella 18 Aug '12

18 Aug '12

Module: ppl/ppl Branch: master Commit: f6247133f289fa26ff5d80e6aac36254ba458824 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f6247133f289… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Aug 18 11:14:19 2012 +0200 Modified the Expression_Adapter infrastructure. Prefer the creation of transient, lightweight adapters to the usage of wild reference casts. While at it, improved documentation and systematically renamed `Expression' inner typedefs as `expr_type'. --- src/BD_Shape.templates.hh | 12 +- src/Box.templates.hh | 44 ++++---- src/Congruence.cc | 5 +- src/Congruence.defs.hh | 12 +-- src/Congruence.inlines.hh | 16 +--- src/Constraint.cc | 2 +- src/Constraint.defs.hh | 14 +-- src/Constraint.inlines.hh | 22 +--- src/Expression_Adapter.defs.hh | 191 ++++++++++++++++++--------------- src/Expression_Adapter.inlines.hh | 78 +++++++------- src/Expression_Adapter.types.hh | 5 + src/Expression_Hide_Inhomo.defs.hh | 61 +++++++---- src/Expression_Hide_Inhomo.inlines.hh | 39 ++++--- src/Expression_Hide_Last.defs.hh | 82 ++++++++------ src/Expression_Hide_Last.inlines.hh | 61 ++++++----- src/Generator.defs.hh | 14 +-- src/Generator.inlines.hh | 22 +--- src/Grid.templates.hh | 4 +- src/Grid_Generator.defs.hh | 15 +-- src/Grid_Generator.inlines.hh | 16 +--- src/Linear_Expression.defs.hh | 17 ++-- src/Linear_Expression.inlines.hh | 8 +- src/MIP_Problem.cc | 6 +- src/PIP_Tree.cc | 4 +- src/Polyhedron.templates.hh | 4 +- src/termination.cc | 18 ++-- 26 files changed, 387 insertions(+), 385 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=f6247133…

1 0

[GIT] ppl/ppl(master): Do not use TABs for code layout.
by Roberto Bagnara 18 Aug '12

18 Aug '12

1 0

[GIT] ppl/ppl(ppl-1_0-branch): Merge branch 'master' into ppl-1_0-branch
by Roberto Bagnara 18 Aug '12

18 Aug '12

Module: ppl/ppl Branch: ppl-1_0-branch Commit: 7e820c2bd72ba62251be22118b4071e7868b6e3b URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7e820c2bd72b… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 18 10:29:41 2012 +0200 Merge branch 'master' into ppl-1_0-branch ---

1 0

[GIT] ppl/ppl(ppl-1_0-branch): Do not use TABs for code layout.
by Roberto Bagnara 18 Aug '12

18 Aug '12

1 0

[GIT] ppl/ppl(ppl-1_0-branch): New commits
by Roberto Bagnara 18 Aug '12

18 Aug '12

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e409464fc516… Merge: b909bcc5dc711a80c14a096d72f5c2964ddb8d35 ec76e739bace356dfd557bb9bd85040ad65c2e8f Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 18 09:52:59 2012 +0200 Merge branch 'master' into ppl-1_0-branch URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ec76e739bace… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 18 09:50:09 2012 +0200 Avoided som implicit integral conversion that changed the signedness of the underlying type. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e21546a47281… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Aug 17 20:55:00 2012 +0200 Unwanted recursion removed. Detected by ECLAIR service funrecsn. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=55227bfc8118… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Aug 17 18:18:12 2012 +0200 Prefer explicit cast to implicit narrowing conversion. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0873d966a21e… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Aug 17 17:13:39 2012 +0200 Added helper method insert_precise_aux to avoid recursive call. Detected by ECLAIR service funrecsn. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=076f771d01f2… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Aug 17 09:11:18 2012 +0200 Added several missing <CODE> tags in Doxygen comments. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3307c8da8a4a… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Aug 17 14:03:52 2012 +0200 Unwanted recursion removed. Detected by ECLAIR service funrecsn. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2a9d18174712… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Aug 16 17:29:09 2012 +0200 Fixed several minor documentation issues. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f6fd3a314e3a… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Aug 16 11:46:29 2012 +0200 Use PPL_U when macro parameters are used as template type arguments. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5d14a674e3ee… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Aug 16 11:29:45 2012 +0200 Avoid outer-scope name hiding. Detected by ECLAIR service declhidn. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2d2a72e2c4ac… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Aug 16 11:25:04 2012 +0200 Avoid outer-scope name hiding. Detected by ECLAIR service declhidn. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=359a800b113d… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Aug 16 14:28:20 2012 +0200 Indentation fixed. Detected by ECLAIR service indntion. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=38e903cb0048… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Aug 16 12:02:41 2012 +0200 Avoid implicit floating-integral conversions. Detected by ECLAIR service utypflag. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4cc7becbaff5… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Aug 16 11:59:10 2012 +0200 Do not let constant unsigned integer expressions wrap-around. Detected by ECLAIR service cnstwrap. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=079da25d79e9… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Aug 16 11:58:16 2012 +0200 Use a standard comment header block. Detected by ECLAIR service cmntfile. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=88e9d4926cd3… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Aug 15 15:56:13 2012 +0200 Literals fixed. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d9ca22ec68e0… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Aug 15 15:40:52 2012 +0200 Comment improved. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c7decce2dd41… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Aug 15 15:39:11 2012 +0200 Do not use comments to "comment out" code. Detected by ECLAIR service cmntdout. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=60feec935a43… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Aug 15 15:35:07 2012 +0200 Use a standard comment header block. Detected by ECLAIR service cmntfile. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0b783b0e686d… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Aug 15 14:30:32 2012 +0200 Code should not be on the same line as a null statement. Detected by ECLAIR service nullstmt. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=93c41b7c1dec… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Aug 15 14:27:37 2012 +0200 Do not use C-style casts. Detected by ECLAIR service castexpr. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2b67686580fa… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Aug 15 14:24:30 2012 +0200 Detected by ECLAIR service inclmixd. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=19bb7a9c716c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Aug 14 16:26:45 2012 +0200 Fixed a couple of name hiding issues in Expression_Hide_Inhomo adapter. This commit is meanto to be part of 9e4c9c57ae8ffca73bb9ee6c75a43d6ed6cd4096 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9e4c9c57ae8f… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Tue Aug 14 11:35:55 2012 +0200 Changed the way of accessing the underlying expression in classes Constraint, Generator, Congruence and Grid_Generator. The public methods expression() systematically returns (a const reference to) an expression adapter derived from template Expression_Adapter (including Expression_Hide_Inhomo and Expression_Hide_Last). These adapters provide a *read-only* interface enabling most (but not all) of the operations that can be performed on a Linear_Expression. Added four templatic constructors to Linear_Expression accepting any such adapter. Removed a dozen specific constructors that were tailored to the four classes Constraint, Generator, Congruence and Grid_Generator. As a consequence previous code such as Linear_Expression expr(gen); will no longer compile and should be replaced by Linear_Expression expr(gen.expression()); The systematic use of the new adapters, besides removing some indirections, also decreases the memory overhead of classes Constraint, Generator and Grid_Generator, as we no longer need members `wrapped_expr' and `semi_wrapped_expr'. While at it, corrected a few latent bugs in adapter Expression_Hide_Inhomo (these could not manifest as real failures because currently the Hide_Inhomo adapter is always re-wrapped using the Expression_Hide_Last adapter). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=72e6f15244b6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 11 17:27:27 2012 +0200 Version number bumped. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=88cf8d3fe09f… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Aug 8 15:04:55 2012 +0200 Added a few recent changes regarding the Java language interface. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=dda4797dcd59… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Aug 8 14:35:17 2012 +0200 A couple of changes to the Java interface: - Variable's id are of long type (like space dimension arguments); - added NOT_EQUAL value to enumeration Relation_Symbol.

1 0

[GIT] ppl/ppl(master): Avoided som implicit integral conversion that changed the signedness of the underlying type .
by Roberto Bagnara 18 Aug '12

18 Aug '12

Module: ppl/ppl Branch: master Commit: ec76e739bace356dfd557bb9bd85040ad65c2e8f URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ec76e739bace… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Aug 18 09:50:09 2012 +0200 Avoided som implicit integral conversion that changed the signedness of the underlying type. Detected by ECLAIR service utypflag. --- demos/ppl_lcdd/ppl_lcdd.cc | 6 +++--- demos/ppl_pips/ppl_pips.cc | 16 ++++++++++------ src/Polyhedron_conversion.templates.hh | 2 +- src/Polyhedron_minimize.templates.hh | 2 +- 4 files changed, 15 insertions(+), 11 deletions(-) diff --git a/demos/ppl_lcdd/ppl_lcdd.cc b/demos/ppl_lcdd/ppl_lcdd.cc index 744c696..0ce9dce 100644 --- a/demos/ppl_lcdd/ppl_lcdd.cc +++ b/demos/ppl_lcdd/ppl_lcdd.cc @@ -409,21 +409,21 @@ process_options(int argc, char* argv[]) { if (*endptr || l < 0) fatal("a non-negative integer must follow `-C'"); else - max_seconds_of_cpu_time = l; + max_seconds_of_cpu_time = static_cast<unsigned long>(l); break; #endif // defined(PPL_LCDD_SUPPORTS_LIMIT_ON_CPU_TIME) case 'R': { - const int MEGA = 1024*1024; + const unsigned long MEGA = 1024U*1024U; l = strtol(optarg, &endptr, 10); if (*endptr || l < 0) fatal("a non-negative integer must follow `-R'"); else if (static_cast<unsigned long>(l) > ULONG_MAX/MEGA) max_bytes_of_virtual_memory = ULONG_MAX; else - max_bytes_of_virtual_memory = l*MEGA; + max_bytes_of_virtual_memory = static_cast<unsigned long>(l)*MEGA; } break; diff --git a/demos/ppl_pips/ppl_pips.cc b/demos/ppl_pips/ppl_pips.cc index b60d2ce..f5854df 100644 --- a/demos/ppl_pips/ppl_pips.cc +++ b/demos/ppl_pips/ppl_pips.cc @@ -282,6 +282,7 @@ public: std::istringstream iss(line); iss >> bignum_column_coding; } + PPL_ASSERT(bignum_column_coding >= -1); PPL::dimension_type num_constraints; PPL::dimension_type constraint_width; @@ -305,9 +306,10 @@ public: } } - PPL::dimension_type bignum_column = (bignum_column_coding == -1) + PPL::dimension_type bignum_column + = (bignum_column_coding == -1) ? PPL::not_a_dimension() - : (num_vars + (bignum_column_coding - 1)); + : (num_vars + PPL::dimension_type(bignum_column_coding - 1)); bool result = update_pip(num_vars, num_params, num_constraints, num_ctx_rows, @@ -349,9 +351,11 @@ public: int bignum_column_coding; in >> bignum_column_coding; - PPL::dimension_type bignum_column = (bignum_column_coding == -1) + PPL_ASSERT(bignum_column_coding >= -1); + PPL::dimension_type bignum_column + = (bignum_column_coding == -1) ? PPL::not_a_dimension() - : (bignum_column_coding - 1); + : PPL::dimension_type(bignum_column_coding - 1); int solve_integer; in >> solve_integer; @@ -647,14 +651,14 @@ process_options(int argc, char* argv[]) { case 'R': { - const int MEGA = 1024*1024; + const unsigned long MEGA = 1024U*1024U; long l = strtol(optarg, &endptr, 10); if (*endptr || l < 0) fatal("a non-negative integer must follow `-R'"); else if (static_cast<unsigned long>(l) > ULONG_MAX/MEGA) max_bytes_of_virtual_memory = ULONG_MAX; else - max_bytes_of_virtual_memory = l*MEGA; + max_bytes_of_virtual_memory = static_cast<unsigned long>(l)*MEGA; } break; diff --git a/src/Polyhedron_conversion.templates.hh b/src/Polyhedron_conversion.templates.hh index 0f2451d..041904c 100644 --- a/src/Polyhedron_conversion.templates.hh +++ b/src/Polyhedron_conversion.templates.hh @@ -362,7 +362,7 @@ Polyhedron::conversion(Source_Linear_System& source, const dimension_type source_space_dim = source.space_dimension(); const dimension_type source_num_rows = source.num_rows(); const dimension_type source_num_columns = source_space_dim - + (source.is_necessarily_closed() ? 1 : 2); + + (source.is_necessarily_closed() ? 1U : 2U); dimension_type dest_num_rows = dest.num_rows(); diff --git a/src/Polyhedron_minimize.templates.hh b/src/Polyhedron_minimize.templates.hh index 0516bee..63e6173 100644 --- a/src/Polyhedron_minimize.templates.hh +++ b/src/Polyhedron_minimize.templates.hh @@ -144,7 +144,7 @@ Polyhedron::minimize(const bool con_to_gen, // and the 5th parameter (representing the number of lines in `dest'), // by construction, is equal to `dest_num_rows'. const dimension_type num_lines_or_equalities - = conversion(source, 0, dest, tmp_sat, dest_num_rows); + = conversion(source, 0U, dest, tmp_sat, dest_num_rows); // conversion() may have modified the number of rows in `dest'. dest_num_rows = dest.num_rows();

1 0

[GIT] ppl/ppl(master): Unwanted recursion removed.
by Roberto Bagnara 17 Aug '12

17 Aug '12

Module: ppl/ppl Branch: master Commit: e21546a47281ac48407d8407cfd8cb97756421f6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e21546a47281… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Aug 17 20:55:00 2012 +0200 Unwanted recursion removed. Detected by ECLAIR service funrecsn. --- src/CO_Tree.cc | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/CO_Tree.cc b/src/CO_Tree.cc index e19b5d1..ed67441 100644 --- a/src/CO_Tree.cc +++ b/src/CO_Tree.cc @@ -556,7 +556,6 @@ PPL::CO_Tree::init(dimension_type n) { max_depth = 0; if (n > 0) { - init(0); const dimension_type max_d = integer_log2(n) + 1; const height_t new_max_depth = static_cast<height_t>(max_d); const dimension_type new_reserved_size

1 0

[GIT] ppl/ppl(master): Prefer explicit cast to implicit narrowing conversion.
by Enea Zaffanella 17 Aug '12

17 Aug '12

Module: ppl/ppl Branch: master Commit: 55227bfc8118c5bc2d96808fff3df85af4d65860 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=55227bfc8118… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Fri Aug 17 18:18:12 2012 +0200 Prefer explicit cast to implicit narrowing conversion. Detected by ECLAIR service utypflag. --- src/CO_Tree.cc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/CO_Tree.cc b/src/CO_Tree.cc index 68d49d4..e19b5d1 100644 --- a/src/CO_Tree.cc +++ b/src/CO_Tree.cc @@ -557,7 +557,8 @@ PPL::CO_Tree::init(dimension_type n) { if (n > 0) { init(0); - const dimension_type new_max_depth = integer_log2(n) + 1; + const dimension_type max_d = integer_log2(n) + 1; + const height_t new_max_depth = static_cast<height_t>(max_d); const dimension_type new_reserved_size = (static_cast<dimension_type>(1) << new_max_depth) - 1; // If this throws, *this will be the empty tree.

1 0