January 2013 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(polyops): Missing comments added.
by Roberto Bagnara 04 Jan '13

04 Jan '13

Module: ppl/ppl Branch: polyops Commit: 45e0f69da1aec3a8193ed0de829558aef19489bf URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=45e0f69da1ae… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jan 4 19:07:41 2013 +0100 Missing comments added. --- src/Generator_defs.hh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/Generator_defs.hh b/src/Generator_defs.hh index 904d42d..5471ee2 100644 --- a/src/Generator_defs.hh +++ b/src/Generator_defs.hh @@ -539,10 +539,13 @@ private: RAY_OR_POINT_OR_INEQUALITY = 1 }; + //! The linear expression encoding \p *this. Linear_Expression expr; + //! The kind of \p *this. Kind kind_; + //! The topology of \p *this. Topology topology_; /*! \brief

1 0

[GIT] ppl/ppl(master): Const-qualify immutable objects.
by Roberto Bagnara 04 Jan '13

04 Jan '13

Module: ppl/ppl Branch: master Commit: 9ddca3fbdf256f9c2457298e2947185210a4a77f URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9ddca3fbdf25… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jan 4 19:08:19 2013 +0100 Const-qualify immutable objects. Detected by ECLAIR service cnstpnte. --- src/Box_templates.hh | 6 ++++-- src/CO_Tree.cc | 2 +- src/Linear_System_inlines.hh | 2 +- src/MIP_Problem.cc | 2 +- src/OR_Matrix_inlines.hh | 2 +- src/Polyhedron_inlines.hh | 2 +- src/c_streambuf.cc | 2 +- 7 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/Box_templates.hh b/src/Box_templates.hh index 6853b48..227dd65 100644 --- a/src/Box_templates.hh +++ b/src/Box_templates.hh @@ -2538,7 +2538,8 @@ Box<ITV>::propagate_constraint_no_check(const Constraint& c) { if (open == T_MAYBE && maybe_check_fpu_inexact<Temp_Boundary_Type>() == 1) open = T_YES; - Relation_Symbol rel = (open == T_YES) ? LESS_THAN : LESS_OR_EQUAL; + const Relation_Symbol rel + = (open == T_YES) ? LESS_THAN : LESS_OR_EQUAL; seq[k_var.id()].add_constraint(i_constraint(rel, t_bound)); reset_empty_up_to_date(); } @@ -2672,7 +2673,8 @@ Box<ITV>::propagate_constraint_no_check(const Constraint& c) { if (open == T_MAYBE && maybe_check_fpu_inexact<Temp_Boundary_Type>() == 1) open = T_YES; - Relation_Symbol rel = (open == T_YES) ? GREATER_THAN : GREATER_OR_EQUAL; + const Relation_Symbol rel + = (open == T_YES) ? GREATER_THAN : GREATER_OR_EQUAL; seq[k_var.id()].add_constraint(i_constraint(rel, t_bound)); reset_empty_up_to_date(); } diff --git a/src/CO_Tree.cc b/src/CO_Tree.cc index 5a67d90..a7e5ecd 100644 --- a/src/CO_Tree.cc +++ b/src/CO_Tree.cc @@ -169,7 +169,7 @@ PPL::CO_Tree::erase_element_and_shift_left(dimension_type key) { return; const dimension_type i = dfs_index(itr); dimension_type* p = indexes + i; - const dimension_type* p_end = indexes + (reserved_size + 1); + const dimension_type* const p_end = indexes + (reserved_size + 1); for ( ; p != p_end; ++p) if (*p != unused_index) --(*p); diff --git a/src/Linear_System_inlines.hh b/src/Linear_System_inlines.hh index 995043e..a2aedba 100644 --- a/src/Linear_System_inlines.hh +++ b/src/Linear_System_inlines.hh @@ -366,7 +366,7 @@ inline void Linear_System<Row>::remove_row_no_ok(const dimension_type i, const bool keep_sorted) { PPL_ASSERT(i < num_rows()); - bool was_pending = (i >= index_first_pending); + const bool was_pending = (i >= index_first_pending); if (sorted && keep_sorted && !was_pending) { for (dimension_type j = i + 1; j < rows.size(); ++j) diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index 8c3d12c..b5030d8 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -1035,7 +1035,7 @@ PPL::MIP_Problem::steepest_edge_float_entering_index() const { // this implementation and the dense implementation below. for (std::vector<std::pair<dimension_type, double> >::const_reverse_iterator i = columns.rbegin(), i_end = columns.rend(); i != i_end; ++i) { - double challenger_value = sqrt(i->second); + const double challenger_value = sqrt(i->second); if (entering_index == 0 || challenger_value > current_value) { current_value = challenger_value; entering_index = i->first; diff --git a/src/OR_Matrix_inlines.hh b/src/OR_Matrix_inlines.hh index 4dfd006..f0e8349 100644 --- a/src/OR_Matrix_inlines.hh +++ b/src/OR_Matrix_inlines.hh @@ -465,7 +465,7 @@ inline dimension_type OR_Matrix<T>::max_num_rows() { // Compute the maximum number of rows that are contained in a DB_Row // that allocates a pseudo-triangular matrix. - dimension_type k = isqrt(2*DB_Row<T>::max_size() + 1); + const dimension_type k = isqrt(2*DB_Row<T>::max_size() + 1); return (k - 1) - (k - 1) % 2; } diff --git a/src/Polyhedron_inlines.hh b/src/Polyhedron_inlines.hh index aa521e8..f543e9c 100644 --- a/src/Polyhedron_inlines.hh +++ b/src/Polyhedron_inlines.hh @@ -434,7 +434,7 @@ Polyhedron::strictly_contains(const Polyhedron& y) const { inline void Polyhedron::drop_some_non_integer_points(Complexity_Class complexity) { - const Variables_Set* p_vs = 0; + const Variables_Set* const p_vs = 0; drop_some_non_integer_points(p_vs, complexity); } diff --git a/src/c_streambuf.cc b/src/c_streambuf.cc index 3c83995..a15499a 100644 --- a/src/c_streambuf.cc +++ b/src/c_streambuf.cc @@ -30,7 +30,7 @@ namespace Parma_Polyhedra_Library { c_streambuf::int_type c_streambuf::uflow() { - int_type c = underflow(); + const int_type c = underflow(); next_char_buf = traits_type::eof(); return c; }

1 0

[GIT] ppl/ppl(master): Missing comments added.
by Roberto Bagnara 04 Jan '13

04 Jan '13

Module: ppl/ppl Branch: master Commit: 45e0f69da1aec3a8193ed0de829558aef19489bf URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=45e0f69da1ae… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jan 4 19:07:41 2013 +0100 Missing comments added. --- src/Generator_defs.hh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/Generator_defs.hh b/src/Generator_defs.hh index 904d42d..5471ee2 100644 --- a/src/Generator_defs.hh +++ b/src/Generator_defs.hh @@ -539,10 +539,13 @@ private: RAY_OR_POINT_OR_INEQUALITY = 1 }; + //! The linear expression encoding \p *this. Linear_Expression expr; + //! The kind of \p *this. Kind kind_; + //! The topology of \p *this. Topology topology_; /*! \brief

1 0

[GIT] ppl/ppl(polyops): New commits
by Roberto Bagnara 04 Jan '13

04 Jan '13

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=22b223fc02d6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jan 4 17:48:15 2013 +0100 Version number bumped. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=135638322d3d… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Jan 3 21:26:06 2013 +0100 Typo fixed. (Thanks to Chia-Hsun Cheng and Marco Bodrato.) URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1084b95029e7… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Jan 3 21:20:16 2013 +0100 Const-qualify immutable objects. Detected by ECLAIR service cnstpnte. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=225f9cb72077… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Jan 3 21:19:10 2013 +0100 Typo fixed. (Thanks to Chia-Hsun Cheng and Marco Bodrato.) URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=efd4b126fb23… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Jan 2 19:19:01 2013 +0100 Const-qualify immutable objects. Detected by ECLAIR service cnstpnte. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=377a1734ef7a… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Jan 1 21:40:48 2013 +0100 Const-qualify immutable objects. Detected by ECLAIR service cnstpnte. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c84e435b5ce8… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Tue Jan 1 09:51:34 2013 +0100 Const-qualify immutable objects. Detected by ECLAIR service cnstpnte.

1 0

[GIT] ppl/ppl(master): Version number bumped.
by Roberto Bagnara 04 Jan '13

04 Jan '13

Module: ppl/ppl Branch: master Commit: 22b223fc02d677756b8ce88320e536fc52c05c05 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=22b223fc02d6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jan 4 17:48:15 2013 +0100 Version number bumped. --- configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 2c371aa..81cb4c8 100644 --- a/configure.ac +++ b/configure.ac @@ -24,7 +24,7 @@ # Process this file with Autoconf to produce a configure script. # Every other copy of the package version number gets its value from here. -AC_INIT([the Parma Polyhedra Library], [1.1pre6], [ppl-devel(a)cs.unipr.it], [ppl]) +AC_INIT([the Parma Polyhedra Library], [1.1pre7], [ppl-devel(a)cs.unipr.it], [ppl]) # Minimum Autoconf version required. AC_PREREQ(2.61)

1 0

[Bug Report] GMP and PPL mismatches
by Chia-Hsun Cheng 03 Jan '13

03 Jan '13

Dear all, ------------ Problem ------------ This is a problem I faced when building prerequisite libraries(gmp, mpfr, mpc, ppl, cloog) before building gcc-4.7.2 from source today. I found a mismatch between GMP and PPL when trying to compile the PPL library from source code. (Building GMP alone is fine.) ------------------------------- Source Code Version ------------------------------- The source code that I downloaded from are a. GMP Site: http://gmplib.org/#DOWNLOAD Download link: ftp://ftp.gmplib.org/pub/gmp-5.1.0/gmp-5.1.0.tar.bz2 b. PPL(Parma Polyhedra Library) Site: http://bugseng.com/products/ppl/download Download link: http://bugseng.com/products/ppl/download/ftp/releases/1.0/ppl-1.0.tar.bz2 ----------------------- Problem Details ----------------------- 1. < Redefinition of numeric_limits > ppl-1.0/src/mp_std_bits.defs.hh:47 and gmp-5.1.0/gmpxx.h:3269 both define numeric_limits<mpz_class> and ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ numeric_limits<mpq_class> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Problem: It would lead to a redefinition error when trying to compile PPL source code to object code. It seems that the newer GMP library(5.1.0) has included the definition of numeric_limits but for PPL library, the definitions are not removed. I googled this problem. There are also some reports to this problem. Fix: I commented out the numeric_limits defined in ppl-1.0/src/mp_std_bits.defs.hh. 2. < Static data member name mismatches > ppl-1.0/src/mp_std_bits.defs.hh:72 and ppl-1.0/src/mp_std_bits.defs.hh:133 defines static const bool tininess_before = false; ^^^^^^^^^^^^^^^^^ However, in gmp-5.1.0/gmpxx.h:3302 and gmp-5.1.0/gmpxx.h:3339, there are static const bool tinyness_before = false; ^^^^^^^^^^^^^^^^^^ Problem: I am not sure if the two data member are the same. Since I commented out the whole block of numeric_limits in ppl-1.0/src/mp_std_bits.defs.hh in the last step, the member `tininess_before' cannot be resolved. Fix: Finally, I add static const bool tininess_before = false; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in gmp-5.1.0/gmpxx.h:3303 and gmp-5.1.0/gmpxx.h:3341 and add member initialization const bool numeric_limits<T>::tininess_before; \ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in gmp-5.1.0/cxx/limits.cc:47 and rebuild the gmp library. So, for PPL library, even if the code for numeric_limits is commented out, the declarations and object code can be found from GMP library. ---------------- Conclusion ---------------- GMP and PPL libraries can be compiled. I am running the PPL 'make check' test now. I am not sure whether it is a bug so I decided to report the issue to both sides. Hope that the mismatch can be fixed, thanks! --------------------- Attached Files --------------------- The mismatches are not related to configuration, so I skipped 'config.log'. If needed, please reply to me. gcc-v.log : GCC version uname-a.log : Info of environment diff_gmpxx.h.txt : Modification of gmp-5.1.0/gmpxx.h diff_mp_std_bits.defs.hh : Modification of ppl-1.0/src/mp_std_bits.defs.hh diff_limits.cc.txt : Modification of gmp-5.1.0/cxx/limits.cc Best Regards -- chiahsun

2 2

[GIT] ppl/ppl(master): Const-qualify immutable objects.
by Roberto Bagnara 02 Jan '13

02 Jan '13

Module: ppl/ppl Branch: master Commit: efd4b126fb23f8e039054f961bf844d0981fec06 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=efd4b126fb23… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Jan 2 19:19:01 2013 +0100 Const-qualify immutable objects. Detected by ECLAIR service cnstpnte. --- src/Dense_Row.cc | 6 +- src/Determinate_inlines.hh | 2 +- src/Grid_Generator.cc | 2 +- src/Grid_public.cc | 4 +- src/Interval_inlines.hh | 4 +- src/Linear_Expression_Impl_templates.hh | 84 +++++++++++++++--------------- src/Linear_System_inlines.hh | 2 +- src/Linear_System_templates.hh | 13 +++-- src/MIP_Problem.cc | 31 ++++++------ src/MIP_Problem_inlines.hh | 5 +- src/OR_Matrix_inlines.hh | 2 +- src/PIP_Problem.cc | 21 ++++---- src/PIP_Tree.cc | 74 ++++++++++++++------------- src/Partial_Function_inlines.hh | 2 +- src/Pointset_Powerset.cc | 18 +++--- src/Pointset_Powerset_templates.hh | 4 +- src/Polyhedron_chdims.cc | 4 +- src/Polyhedron_conversion_templates.hh | 2 +- src/Polyhedron_inlines.hh | 10 ++-- src/Polyhedron_nonpublic.cc | 27 ++++++---- src/Polyhedron_public.cc | 34 ++++++------- src/Polyhedron_simplify_templates.hh | 2 +- src/Polyhedron_widenings.cc | 6 +- src/Result_inlines.hh | 10 ++-- src/Rounding_Dir_inlines.hh | 4 +- src/Temp_inlines.hh | 2 +- src/Variable.cc | 4 +- src/Variables_Set.cc | 2 +- src/Watchdog.cc | 4 +- src/c_streambuf.cc | 2 +- src/checked.cc | 18 +++--- src/checked_float_inlines.hh | 2 +- src/checked_int_inlines.hh | 6 +- src/checked_mpz_inlines.hh | 14 +++--- src/fpu-c99_inlines.hh | 4 +- src/globals_inlines.hh | 2 +- src/stdiobuf.cc | 8 ++-- src/termination.cc | 42 ++++++++-------- src/wrap_assign.hh | 2 +- 39 files changed, 244 insertions(+), 241 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=efd4b126…

1 0

[GIT] ppl/ppl(master): Const-qualify immutable objects.
by Roberto Bagnara 01 Jan '13

01 Jan '13

Module: ppl/ppl Branch: master Commit: 377a1734ef7a016d9c8852d3c1341d35311f4f19 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=377a1734ef7a… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Tue Jan 1 21:40:48 2013 +0100 Const-qualify immutable objects. Detected by ECLAIR service cnstpnte. --- demos/ppl_pips/ppl_pips.cc | 4 ++-- src/Boundary_defs.hh | 2 +- src/C_Polyhedron.cc | 2 +- src/Congruence_System.cc | 17 +++++++++-------- src/Congruence_inlines.hh | 4 ++-- src/Constraint_System.cc | 6 +++--- src/Dense_Row.cc | 3 ++- src/Float_inlines.hh | 18 +++++++++--------- src/Generator.cc | 6 +++--- src/Generator_System.cc | 6 +++--- src/Grid_Certificate.cc | 4 ++-- src/Grid_Generator.cc | 8 ++++---- src/Grid_Generator_System.cc | 2 +- src/Grid_chdims.cc | 2 +- src/Grid_conversion.cc | 2 +- src/Grid_nonpublic.cc | 14 +++++++------- src/Grid_public.cc | 21 +++++++++++---------- src/Grid_simplify.cc | 2 +- src/Grid_widenings.cc | 2 +- src/Interval_defs.hh | 5 +++-- src/Interval_inlines.hh | 4 ++-- src/Linear_Expression_Impl_inlines.hh | 2 +- src/Linear_Expression_Impl_templates.hh | 31 +++++++++++++++++-------------- src/Linear_System_inlines.hh | 4 ++-- src/Linear_System_templates.hh | 9 +++++---- 25 files changed, 94 insertions(+), 86 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=377a1734…

1 0

[GIT] ppl/ppl(master): Const-qualify immutable objects.
by Roberto Bagnara 01 Jan '13

01 Jan '13

Module: ppl/ppl Branch: master Commit: c84e435b5ce84410f173dd75dceb606bab7bc468 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c84e435b5ce8… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Tue Jan 1 09:51:34 2013 +0100 Const-qualify immutable objects. Detected by ECLAIR service cnstpnte. --- demos/ppl_lcdd/ppl_lcdd.cc | 22 +++++++++++----------- demos/ppl_pips/ppl_pips.cc | 36 ++++++++++++++++++------------------ src/Bit_Row.cc | 10 +++++----- src/Bit_Row_inlines.hh | 2 +- src/Boundary_defs.hh | 3 ++- src/Box_templates.hh | 24 +++++++++++++----------- src/CO_Tree.cc | 23 ++++++++++++----------- src/CO_Tree_inlines.hh | 16 +++++++++------- src/CO_Tree_templates.hh | 2 +- src/Concrete_Expression_inlines.hh | 8 ++++---- src/Congruence.cc | 2 +- src/Congruence_System.cc | 2 +- utils/timings.cc | 10 +++++----- 13 files changed, 83 insertions(+), 77 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=c84e435b…

1 0

[GIT] ppl/ppl(polyops): Extended copyright years.
by Roberto Bagnara 01 Jan '13

01 Jan '13

1 0