September 2013 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): Directory fixed.
by Roberto Bagnara 10 Sep '13

10 Sep '13

Module: ppl/ppl Branch: master Commit: 8fe8ea8c619e5e8d73c653598ebcfa7957931efb URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8fe8ea8c619e… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Tue Sep 10 10:02:01 2013 +0200 Directory fixed. --- Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index b56c5a7..ad71e6e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -38,7 +38,7 @@ instchk.hh ppl-config.h: config.h $(srcdir)/ppl-config.sed $(SED) -f $(srcdir)/ppl-config.sed config.h >$@ -ppl-config.h.in: config.h.in $(srcdir)/ppl-config.sed +ppl-config.h.in: $(srcdir)/config.h.in $(srcdir)/ppl-config.sed $(SED) -f $(srcdir)/ppl-config.sed config.h.in >$@ DISTCHECK_CONFIGURE_FLAGS = \

1 0

[GIT] ppl/ppl(master): Version number bumped.
by Roberto Bagnara 10 Sep '13

10 Sep '13

Module: ppl/ppl Branch: master Commit: 69ba9e36eb6f3d3869976e19993399dab4dc3e13 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=69ba9e36eb6f… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Tue Sep 10 09:25:48 2013 +0200 Version number bumped. --- configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 07d7779..34b68f6 100644 --- a/configure.ac +++ b/configure.ac @@ -24,7 +24,7 @@ # Process this file with Autoconf to produce a configure script. # Every other copy of the package version number gets its value from here. -AC_INIT([the Parma Polyhedra Library], [1.1pre10], [ppl-devel(a)cs.unipr.it], [ppl]) +AC_INIT([the Parma Polyhedra Library], [1.1pre11], [ppl-devel(a)cs.unipr.it], [ppl]) # Minimum Autoconf version required. AC_PREREQ(2.61)

1 0

[GIT] ppl/ppl(master): Mention recently fixed Java interface bug.
by Enea Zaffanella 09 Sep '13

09 Sep '13

Module: ppl/ppl Branch: master Commit: 7251d8f70a5c3a1964ef8babb0b39c12f2405ca3 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7251d8f70a5c… Author: Enea Zaffanella <enea.zaffanella(a)bugseng.com> Date: Mon Sep 9 16:27:14 2013 +0200 Mention recently fixed Java interface bug. The bug was observed by Gianluca Amato when working (in Java) using a 32 bit build of the PPL. Fixed in commit 30478fbeb75f3e675ec0b3eff32f0a8dd7991f7a --- NEWS | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5eda9f7..2b035af 100644 --- a/NEWS +++ b/NEWS @@ -41,6 +41,11 @@ o Fixed a precision regression in Polyhedron method void drop_some_non_integer_points(const Variables_Set&, Complexity_Class); +o In the Java language interface, fixed a C++/Java conversion error + whereby the construction of a valid Variable object in JNI code + was leading to an exception being thrown. The bug has only been + observed on 32-bit builds. + o In the Java interface, fixed declaration of methods void drop_some_non_integer_points(...); so as to accept a Complexity_Class enum value.

1 0

[GIT] ppl/ppl(master): Initialize custom_compare_ext field in structure custom_operations.
by Enea Zaffanella 09 Sep '13

09 Sep '13

Module: ppl/ppl Branch: master Commit: df36ca0640a2a8e719c16534c2e2de0e2509b644 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=df36ca0640a2… Author: Enea Zaffanella <enea.zaffanella(a)bugseng.com> Date: Mon Sep 9 13:51:23 2013 +0200 Initialize custom_compare_ext field in structure custom_operations. --- .../OCaml/ppl_interface_generator_ocaml_cc_code.m4 | 6 ++++-- interfaces/OCaml/ppl_ocaml_common.cc | 9 ++++++--- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/interfaces/OCaml/ppl_interface_generator_ocaml_cc_code.m4 b/interfaces/OCaml/ppl_interface_generator_ocaml_cc_code.m4 index f07f513..3ef489c 100644 --- a/interfaces/OCaml/ppl_interface_generator_ocaml_cc_code.m4 +++ b/interfaces/OCaml/ppl_interface_generator_ocaml_cc_code.m4 @@ -50,7 +50,8 @@ struct custom_operations m4_current_interface`'_custom_operations = { custom_compare_default|COMMA| custom_hash_default|COMMA| custom_serialize_default|COMMA| - custom_deserialize_default + custom_deserialize_default|COMMA| + custom_compare_ext_default }; } // namespace OCaml @@ -1086,7 +1087,8 @@ struct custom_operations @CLASS@_iterator_custom_operations = { custom_compare_default|COMMA| custom_hash_default|COMMA| custom_serialize_default|COMMA| - custom_deserialize_default + custom_deserialize_default|COMMA| + custom_compare_ext_default }; inline value diff --git a/interfaces/OCaml/ppl_ocaml_common.cc b/interfaces/OCaml/ppl_ocaml_common.cc index 3e39178..6ddc47c 100644 --- a/interfaces/OCaml/ppl_ocaml_common.cc +++ b/interfaces/OCaml/ppl_ocaml_common.cc @@ -741,7 +741,8 @@ static struct custom_operations MIP_Problem_custom_operations = { custom_compare_default, custom_hash_default, custom_serialize_default, - custom_deserialize_default + custom_deserialize_default, + custom_compare_ext_default }; inline value @@ -769,7 +770,8 @@ static struct custom_operations PIP_Problem_custom_operations = { custom_compare_default, custom_hash_default, custom_serialize_default, - custom_deserialize_default + custom_deserialize_default, + custom_compare_ext_default }; inline value @@ -791,7 +793,8 @@ static struct custom_operations PIP_Tree_Node_custom_operations = { custom_compare_default, custom_hash_default, custom_serialize_default, - custom_deserialize_default + custom_deserialize_default, + custom_compare_ext_default }; //! Give access to the embedded const PIP_Tree_Node* in \p v.

1 0

[GIT] ppl/ppl(master): Do not clean inexistent dat file.
by Enea Zaffanella 09 Sep '13

09 Sep '13

Module: ppl/ppl Branch: master Commit: 0cc1a72f2607b6ba391987a9f2ec83eda0f829f5 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0cc1a72f2607… Author: Enea Zaffanella <enea.zaffanella(a)bugseng.com> Date: Mon Sep 9 13:49:16 2013 +0200 Do not clean inexistent dat file. Be consistent in naming dat files in Grid's ascii_dump/load tests. --- tests/Grid/Makefile.am | 3 +-- tests/Grid/asciidumpload2.cc | 28 ++++++++++++++-------------- 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/tests/Grid/Makefile.am b/tests/Grid/Makefile.am index 1f250f0..82cec2f 100644 --- a/tests/Grid/Makefile.am +++ b/tests/Grid/Makefile.am @@ -298,8 +298,7 @@ ascii_dump_load2.dat \ ascii_dump_load3.dat \ ascii_dump_load4.dat \ ascii_dump_load5.dat \ -ascii_dump_load6.dat \ -ascii_dump_load7.dat +ascii_dump_load6.dat $(top_builddir)/utils/libppl_utils.a: $(MAKE) $(AM_MAKEFLAGS) -C $(top_builddir)/utils libppl_utils.a diff --git a/tests/Grid/asciidumpload2.cc b/tests/Grid/asciidumpload2.cc index b6814d3..efd9717 100644 --- a/tests/Grid/asciidumpload2.cc +++ b/tests/Grid/asciidumpload2.cc @@ -36,7 +36,7 @@ namespace { // ascii_load simple test of loading the result of ascii_dump() bool test01() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -66,7 +66,7 @@ test01() { bool test02() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -100,7 +100,7 @@ test02() { bool test03() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -132,7 +132,7 @@ test03() { bool test04() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -164,7 +164,7 @@ test04() { bool test05() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -196,7 +196,7 @@ test05() { bool test06() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -228,7 +228,7 @@ test06() { bool test07() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -260,7 +260,7 @@ test07() { bool test08() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -292,7 +292,7 @@ test08() { bool test09() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); @@ -324,7 +324,7 @@ test09() { bool test10() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; fstream f; open(f, my_file, ios_base::out); f << "space_dim 2\n" @@ -341,7 +341,7 @@ test10() { bool test11() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; fstream f; open(f, my_file, ios_base::out); f << "space_dim 2\n" @@ -358,7 +358,7 @@ test11() { bool test12() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; fstream f; open(f, my_file, ios_base::out); f << "space_dim 2\n" @@ -375,7 +375,7 @@ test12() { bool test13() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; fstream f; open(f, my_file, ios_base::out); f << "space_dim 2\n" @@ -393,7 +393,7 @@ test13() { // A grid with a virtual generator. bool test14() { - const char* my_file = "ascii_dump_load1.dat"; + const char* my_file = "ascii_dump_load2.dat"; Variable A(0); Variable B(1); Variable C(2);

1 0

[GIT] ppl/ppl(master): Convert C++ Variable id' s to jlong before passing them to Java methods.
by Enea Zaffanella 09 Sep '13

09 Sep '13

Module: ppl/ppl Branch: master Commit: 30478fbeb75f3e675ec0b3eff32f0a8dd7991f7a URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=30478fbeb75f… Author: Enea Zaffanella <enea.zaffanella(a)bugseng.com> Date: Mon Sep 9 13:44:17 2013 +0200 Convert C++ Variable id's to jlong before passing them to Java methods. --- interfaces/Java/jni/ppl_java_common.cc | 5 +++-- interfaces/Java/jni/ppl_java_common_inlines.hh | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/interfaces/Java/jni/ppl_java_common.cc b/interfaces/Java/jni/ppl_java_common.cc index faea99b..c357cd6 100644 --- a/interfaces/Java/jni/ppl_java_common.cc +++ b/interfaces/Java/jni/ppl_java_common.cc @@ -413,7 +413,7 @@ jobject bool_to_j_boolean_class(JNIEnv* env, const bool value) { jobject ret = env->CallStaticObjectMethod(cached_classes.Boolean, cached_FMIDs.Boolean_valueOf_ID, - value); + static_cast<jboolean>(value)); CHECK_EXCEPTION_ASSERT(env); return ret; } @@ -1231,8 +1231,9 @@ Java_Variable_output_function(std::ostream& s, Variable v) { CHECK_RESULT_ASSERT(env, mID == dyn_mID); } #endif // #ifndef NDEBUG + jlong j_var_id = v.id(); jstring bi_string - = (jstring) env->CallObjectMethod(stringifier, mID, v.id()); + = (jstring) env->CallObjectMethod(stringifier, mID, j_var_id); CHECK_EXCEPTION_THROW(env); // Convert the string and print it on C++ stream. const char* nativeString = env->GetStringUTFChars(bi_string, 0); diff --git a/interfaces/Java/jni/ppl_java_common_inlines.hh b/interfaces/Java/jni/ppl_java_common_inlines.hh index 3f3c8f0..d23cd30 100644 --- a/interfaces/Java/jni/ppl_java_common_inlines.hh +++ b/interfaces/Java/jni/ppl_java_common_inlines.hh @@ -152,9 +152,10 @@ build_cxx_variable(JNIEnv* env, jobject j_var) { inline jobject build_java_variable(JNIEnv* env, const Variable var) { + jlong j_var_id = var.id(); jobject ret = env->NewObject(cached_classes.Variable, cached_FMIDs.Variable_init_ID, - var.id()); + j_var_id); CHECK_RESULT_THROW(env, ret); return ret; }

1 0