June 2014 - PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(compliance): Added missing braces. Fixes violations of rule MP1.6-3-1 detected by ECLAIR.
by Patrik Pomelli 14 Jun '14

14 Jun '14

Module: ppl/ppl Branch: compliance Commit: 5d0fb617340797024b1412e4895715af39b427a3 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5d0fb6173407… Author: Patrik Pomelli <patrik.pomelli(a)bugseng.com> Date: Sat Jun 14 02:24:01 2014 +0200 Added missing braces. Fixes violations of rule MP1.6-3-1 detected by ECLAIR. Signed-off-by: Roberto Bagnara <bagnara(a)cs.unipr.it> --- src/Box_templates.hh | 102 ++++++++++++++++++---------- src/Congruence_System_inlines.hh | 6 +- src/DB_Matrix_templates.hh | 3 +- src/Grid_public.cc | 3 +- src/Linear_Expression_Impl_templates.hh | 9 ++- src/Linear_System_inlines.hh | 5 +- src/MIP_Problem.cc | 13 ++-- src/Partially_Reduced_Product_templates.hh | 3 +- src/Pointset_Powerset_templates.hh | 6 +- src/Polyhedron_conversion_templates.hh | 6 +- src/Polyhedron_nonpublic.cc | 59 ++++++++++------ src/Polyhedron_public.cc | 69 ++++++++++++------- 12 files changed, 181 insertions(+), 103 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=5d0fb617…

1 0

[GIT] ppl/ppl(compliance): Merge branch 'master' into compliance.
by Roberto Bagnara 14 Jun '14

14 Jun '14

Module: ppl/ppl Branch: compliance Commit: 1e46c22014f25eb412cd3a172e3e36d3328edd3b URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1e46c22014f2… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sat Jun 14 05:57:00 2014 +0200 Merge branch 'master' into compliance. ---

1 0

[GIT] ppl/ppl(compliance): Trailing whitespace removed.
by Roberto Bagnara 14 Jun '14

14 Jun '14

Module: ppl/ppl Branch: compliance Commit: fe759bb940ffa3083ec6eca0c8221d388bd2bb64 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=fe759bb940ff… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Thu Jun 12 21:43:12 2014 +0200 Trailing whitespace removed. --- src/Polyhedron_chdims.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Polyhedron_chdims.cc b/src/Polyhedron_chdims.cc index 10a9e45..a52d04c 100644 --- a/src/Polyhedron_chdims.cc +++ b/src/Polyhedron_chdims.cc @@ -420,7 +420,7 @@ PPL::Polyhedron::expand_space_dimension(Variable var, dimension_type m) { Constraint c_template = c; c_template.expr.set_coefficient(var, Coefficient_zero()); - + // Each relevant constraint results in `m' new constraints. for (dimension_type dst_d = old_dim; dst_d < old_dim+m; ++dst_d) { Constraint new_c = c_template;

1 0

PPL Constraints usage
by Stefan Schupp 12 Jun '14

12 Jun '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, I am currently trying to create a Polytope from a matrix and a vector. Therefore I create linear expressions from the coefficients of the matrix in combination with the associated PPL-Variables. Afterwards I can add an inhomogenous term from the given vector. As far as I read the documentation I can construct a Polytope naturally by adding constraints. These constraints are supposed to be constructed from a relation of either a linear expression and a constant (my inhomogenuous term, if you want to put it that way) or a relation from two linear expressions. I tried both ways, but the constraint created seems to be empty. How am I supposed to create and use the needed Constraints? Short example: Linear expression: A + 3*B - 5 (when printed) resulting constraint: 0 >= -5 (created by: Parma_Polyhedra_Library::Constraint constraint = expr <= 0 , where expr is the linear expression) Best regards, Stefan - -- Stefan Schupp M.Sc. RWTH Aachen University Computer Science Department, Informatik 2 D-52056 Aachen, Germany http://www-i2.informatik.rwth-aachen.de/i2/schupp/ Tel.: +49 241 80 21243 -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - https://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTmGfQAAoJEFPSi5GyofDj2pMH/ikbRTgyELaev9vXansEqziP kKToH735PWdoynYKEEo+ANHPPUTjpe3J1fVGFQJAuO8PSElOUwN02xxkD0Yl9yV0 cM/8WVdVKZhADg0KsPjXgD5khlZMfR6DQS2L4ultddI82U6x2VaGkZSX8TZJDKHQ AJbyqd/1wcijEWHxILc2l2ip3YGAJAKfb64xlDD6RjDedorKuQtLiN7YFo82jteR YBmCSVgbXyI9cY2EcLfwcvltj3psxYRylqy/QpaEzPtyLGmEohCB+5n+8hPIYjms eEEGqWdJlVfvnnfeHnnCaCzIKYGArcGidc1n63hSWvb+p/+61bzG8Hq+JONyaa0= =g21U -----END PGP SIGNATURE-----

3 4

[GIT] ppl/ppl(compliance): Missing brace added.
by Roberto Bagnara 12 Jun '14

12 Jun '14

Module: ppl/ppl Branch: compliance Commit: a483b63739b1dd78bda63892043873e0205c2ab3 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a483b63739b1… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Jun 12 13:49:18 2014 +0200 Missing brace added. --- src/Bit_Matrix.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Bit_Matrix.cc b/src/Bit_Matrix.cc index 6da3540..c1107ef 100755 --- a/src/Bit_Matrix.cc +++ b/src/Bit_Matrix.cc @@ -263,7 +263,7 @@ bool PPL::Bit_Matrix::check_sorted() const { const Bit_Matrix& x = *this; for (dimension_type i = num_rows(); i-- > 1; ) { - if (compare(x[i-1], x[i]) > 0) + if (compare(x[i-1], x[i]) > 0) { return false; } }

1 0

[GIT] ppl/ppl(compliance): Added missing braces. Fixes violations of rules MP1.6-3-1 and MP1.6-4-1 detected by ECLAIR.
by Patrik Pomelli 12 Jun '14

12 Jun '14

Module: ppl/ppl Branch: compliance Commit: 2ea46ae16ed04657ba0577bd3b8e824099e5c08e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2ea46ae16ed0… Author: Patrik Pomelli <patrik.pomelli(a)bugseng.com> Date: Thu Jun 12 12:57:37 2014 +0200 Added missing braces. Fixes violations of rules MP1.6-3-1 and MP1.6-4-1 detected by ECLAIR. Signed-off-by: Roberto Bagnara <bagnara(a)cs.unipr.it> --- demos/ppl_pips/ppl_pips.cc | 24 ++++-- src/BD_Shape.cc | 3 +- src/BD_Shape_inlines.hh | 12 ++- src/BD_Shape_templates.hh | 22 ++++-- src/BHRZ03_Certificate.cc | 3 +- src/Box_templates.hh | 31 ++++++--- src/CO_Tree.cc | 77 ++++++++++++++------ src/CO_Tree_inlines.hh | 6 +- src/Congruence_System.cc | 36 ++++++--- src/Constraint_System.cc | 25 +++++-- src/DB_Matrix_templates.hh | 45 ++++++++---- src/DB_Row_templates.hh | 9 ++- src/Dense_Row.cc | 33 ++++++--- src/Dense_Row_inlines.hh | 3 +- src/Dense_Row_templates.hh | 9 ++- src/EList_inlines.hh | 3 +- src/Generator_System.cc | 29 +++++--- src/Grid_Generator_System.cc | 17 +++-- src/Grid_conversion.cc | 14 +++-- src/Grid_nonpublic.cc | 12 ++- src/Grid_public.cc | 51 +++++++++----- src/Grid_simplify.cc | 6 +- src/Grid_templates.hh | 9 ++- src/Linear_Expression_Impl.cc | 54 +++++++++----- src/Linear_Expression_Impl_templates.hh | 40 +++++++---- src/Linear_Expression_inlines.hh | 12 ++- src/Linear_System_inlines.hh | 27 +++++--- src/Linear_System_templates.hh | 51 +++++++++----- src/MIP_Problem.cc | 75 +++++++++++++------ src/MIP_Problem_inlines.hh | 9 ++- src/MIP_Problem_templates.hh | 8 ++- src/Matrix_templates.hh | 46 ++++++++---- src/OR_Matrix_inlines.hh | 3 +- src/OR_Matrix_templates.hh | 3 +- src/Octagonal_Shape_inlines.hh | 12 ++- src/Octagonal_Shape_templates.hh | 70 ++++++++++++------ src/PIP_Problem.cc | 18 +++-- src/PIP_Problem_inlines.hh | 3 +- src/PIP_Tree.cc | 78 ++++++++++++++------- src/Partial_Function.cc | 3 +- src/Partially_Reduced_Product_templates.hh | 9 ++- src/Pending_List_templates.hh | 4 +- src/Pointset_Powerset.cc | 24 +++++-- src/Pointset_Powerset_templates.hh | 109 +++++++++++++++++++--------- src/Polyhedron_chdims.cc | 6 +- src/Polyhedron_chdims_templates.hh | 3 +- src/Polyhedron_conversion_templates.hh | 8 ++- src/Polyhedron_minimize_templates.hh | 15 +++-- src/Polyhedron_nonpublic.cc | 25 +++---- src/Polyhedron_simplify_templates.hh | 3 +- src/Polyhedron_widenings.cc | 15 +++-- src/Powerset_templates.hh | 21 ++++-- src/Sparse_Row.cc | 58 ++++++++++----- src/Sparse_Row_templates.hh | 9 ++- src/Swapping_Vector_inlines.hh | 12 ++- src/Variables_Set.cc | 10 ++- src/algorithms.hh | 3 +- src/swapping_sort_templates.hh | 9 ++- src/termination.cc | 12 ++- src/termination_templates.hh | 3 +- src/wrap_assign.hh | 3 +- src/wrap_string.cc | 3 +- 62 files changed, 906 insertions(+), 449 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=2ea46ae1…

1 0

[GIT] ppl/ppl(compliance): Do not declare more than one variable per declaration. Fixes violations of rule CP1.DCL04 detected by ECLAIR.
by Patrik Pomelli 11 Jun '14

11 Jun '14

Module: ppl/ppl Branch: compliance Commit: 5992421fdd82d7172b88a5c0a98310a2124dee3d URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5992421fdd82… Author: Patrik Pomelli <patrik.pomelli(a)bugseng.com> Date: Mon Jun 9 15:44:24 2014 +0200 Do not declare more than one variable per declaration. Fixes violations of rule CP1.DCL04 detected by ECLAIR. Signed-off-by: Roberto Bagnara <bagnara(a)cs.unipr.it> --- demos/ppl_lcdd/ppl_lcdd.cc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/demos/ppl_lcdd/ppl_lcdd.cc b/demos/ppl_lcdd/ppl_lcdd.cc index 14dabc9..260b8a0 100755 --- a/demos/ppl_lcdd/ppl_lcdd.cc +++ b/demos/ppl_lcdd/ppl_lcdd.cc @@ -1068,7 +1068,8 @@ write_polyhedron(std::ostream& out, if (g.coefficient(PPL::Variable(j)) == 0) guarded_write(out, '0'); else { - mpz_class numer, denom; + mpz_class numer; + mpz_class denom; PPL::assign_r(numer, g.coefficient(PPL::Variable(j)), PPL::ROUND_NOT_NEEDED);

1 0

[GIT] ppl/ppl(compliance): Previous commit fixed.
by Patrik Pomelli 09 Jun '14

09 Jun '14

Module: ppl/ppl Branch: compliance Commit: 333a57b84a1806f10706f994cf6f7caa130bcceb URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=333a57b84a18… Author: Patrik Pomelli <patrik.pomelli(a)bugseng.com> Date: Mon Jun 9 12:00:23 2014 +0200 Previous commit fixed. Signed-off-by: Roberto Bagnara <roberto.bagnara(a)bugseng.com> --- src/Bit_Matrix.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Bit_Matrix.cc b/src/Bit_Matrix.cc index c57c54c..6da3540 100755 --- a/src/Bit_Matrix.cc +++ b/src/Bit_Matrix.cc @@ -226,8 +226,8 @@ PPL::Bit_Matrix::external_memory_in_bytes() const { memory_size_type n = rows.capacity() * sizeof(Dense_Row); for (dimension_type i = num_rows(); i-- > 0; ) { n += rows[i].external_memory_in_bytes(); - return n; } + return n; } bool

1 0

[GIT] ppl/ppl(compliance): Added missing braces. Fixes violations of rules MP1.6-3-1 and MP1.6-4-1 detected by ECLAIR
by Patrik Pomelli 09 Jun '14

09 Jun '14

Module: ppl/ppl Branch: compliance Commit: f3dc0ba64a4437f7a33a8120dd99d4ceeb7537f7 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f3dc0ba64a44… Author: Patrik Pomelli <patrik.pomelli(a)bugseng.com> Date: Mon Jun 9 10:25:27 2014 +0200 Added missing braces. Fixes violations of rules MP1.6-3-1 and MP1.6-4-1 detected by ECLAIR Signed-off-by: Roberto Bagnara <roberto.bagnara(a)bugseng.com> --- demos/ppl_lcdd/ppl_lcdd.cc | 43 +- src/BD_Shape_templates.hh | 1427 ++++++++++++++++++++++++++------------------ src/BHRZ03_Certificate.cc | 69 ++- src/Bit_Matrix.cc | 78 ++- src/Box_templates.hh | 166 ++++-- 5 files changed, 1064 insertions(+), 719 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=f3dc0ba6…

1 0

[GIT] ppl/ppl(compliance): Long lines avoided.
by Roberto Bagnara 09 Jun '14

09 Jun '14

Module: ppl/ppl Branch: compliance Commit: 057444894a1b5e509f8017c7a99ef7b2df1b74c5 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=057444894a1b… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sun Jun 8 17:06:33 2014 +0200 Long lines avoided. Fixes violations of rule LP1.41 detected by ECLAIR. --- src/Polyhedron_nonpublic.cc | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Polyhedron_nonpublic.cc b/src/Polyhedron_nonpublic.cc index b00f50c..0457714 100644 --- a/src/Polyhedron_nonpublic.cc +++ b/src/Polyhedron_nonpublic.cc @@ -2310,10 +2310,13 @@ PPL::Polyhedron::positive_time_elapse_assign_impl(const Polyhedron& y) { const Generator &gx = x_points_gs.sys.rows[j]; PPL_ASSERT(gx.is_point()); // ...insert the point obtained as the sum of g and gx. - Generator new_g = g; // make a copy - Coefficient new_divisor = g.expr.inhomogeneous_term() * gx.expr.inhomogeneous_term(); + Generator new_g = g; + Coefficient new_divisor + = g.expr.inhomogeneous_term() * gx.expr.inhomogeneous_term(); - new_g.expr.linear_combine(gx.expr, gx.expr.inhomogeneous_term(), g.expr.inhomogeneous_term()); + new_g.expr.linear_combine(gx.expr, + gx.expr.inhomogeneous_term(), + g.expr.inhomogeneous_term()); new_g.expr.set_inhomogeneous_term(new_divisor); if (new_g.is_not_necessarily_closed()) { new_g.set_epsilon_coefficient(g.epsilon_coefficient());

1 0