- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): Prefer explicit test against zero.
by Enea Zaffanella 25 Feb '12

25 Feb '12

Module: ppl/ppl Branch: master Commit: e37265ae0a0f108cc0ed86f7e848b9ebc8ff7883 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=e37265ae0a0f… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 25 11:08:39 2012 +0100 Prefer explicit test against zero. Detected by ECLAIR service utypflag. --- src/checked_mpz.inlines.hh | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/checked_mpz.inlines.hh b/src/checked_mpz.inlines.hh index e8aec87..9b2c324 100644 --- a/src/checked_mpz.inlines.hh +++ b/src/checked_mpz.inlines.hh @@ -329,14 +329,14 @@ assign_mpz_mpq(mpz_class& to, const mpq_class& from, Rounding_Dir dir) { if (round_down(dir)) { mpz_fdiv_q(to.get_mpz_t(), n, d); if (round_strict_relation(dir)) - return mpz_divisible_p(n, d) ? V_EQ : V_GT; + return (mpz_divisible_p(n, d) != 0) ? V_EQ : V_GT; return V_GE; } else { PPL_ASSERT(round_up(dir)); mpz_cdiv_q(to.get_mpz_t(), n, d); if (round_strict_relation(dir)) - return mpz_divisible_p(n, d) ? V_EQ : V_LT; + return (mpz_divisible_p(n, d) != 0) ? V_EQ : V_LT; return V_LE; } } @@ -403,14 +403,14 @@ div_mpz(mpz_class& to, const mpz_class& x, const mpz_class& y, if (round_down(dir)) { mpz_fdiv_q(to.get_mpz_t(), n, d); if (round_strict_relation(dir)) - return mpz_divisible_p(n, d) ? V_EQ : V_GT; + return (mpz_divisible_p(n, d) != 0) ? V_EQ : V_GT; return V_GE; } else { PPL_ASSERT(round_up(dir)); mpz_cdiv_q(to.get_mpz_t(), n, d); if (round_strict_relation(dir)) - return mpz_divisible_p(n, d) ? V_EQ : V_LT; + return (mpz_divisible_p(n, d) != 0) ? V_EQ : V_LT; return V_LE; } } @@ -492,7 +492,7 @@ div_2exp_mpz(mpz_class& to, const mpz_class& x, unsigned int exp, if (round_down(dir)) { mpz_fdiv_q_2exp(to.get_mpz_t(), n, exp); if (round_strict_relation(dir)) - return mpz_divisible_2exp_p(n, exp) ? V_EQ : V_GT; + return (mpz_divisible_2exp_p(n, exp) != 0) ? V_EQ : V_GT; return V_GE; } else {

1 0

[GIT] ppl/ppl(master): Avoid long line.
by Enea Zaffanella 25 Feb '12

25 Feb '12

Module: ppl/ppl Branch: master Commit: 20bbd20223a29626e84163094c0e0782b6ca4882 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=20bbd20223a2… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 25 10:50:26 2012 +0100 Avoid long line. --- src/Interval_Info.defs.hh | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/Interval_Info.defs.hh b/src/Interval_Info.defs.hh index e9751ce..5a2158e 100644 --- a/src/Interval_Info.defs.hh +++ b/src/Interval_Info.defs.hh @@ -190,7 +190,9 @@ public: set_boundary_property(t, SPECIAL, false); set_boundary_property(t, OPEN, false); } - void set_boundary_property(Boundary_Type t, const Boundary_NS::Property& p, bool value = true) { + void set_boundary_property(Boundary_Type t, + const Boundary_NS::Property& p, + bool value = true) { switch (p.type) { case Boundary_NS::Property::SPECIAL_: if (store_special) {

1 0

[GIT] ppl/ppl(master): Prefer explicit test against zero.
by Enea Zaffanella 25 Feb '12

25 Feb '12

Module: ppl/ppl Branch: master Commit: 2ee9075c66455229ef794874e2f1bdf45e02c6d4 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2ee9075c6645… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 25 10:49:52 2012 +0100 Prefer explicit test against zero. Detected by ECLAIR service utypflag. --- src/checked_mpz.inlines.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/checked_mpz.inlines.hh b/src/checked_mpz.inlines.hh index afa84b0..e8aec87 100644 --- a/src/checked_mpz.inlines.hh +++ b/src/checked_mpz.inlines.hh @@ -510,7 +510,7 @@ template <typename To_Policy, typename From_Policy> inline Result smod_2exp_mpz(mpz_class& to, const mpz_class& x, unsigned int exp, Rounding_Dir) { - if (mpz_tstbit(x.get_mpz_t(), exp - 1)) + if (mpz_tstbit(x.get_mpz_t(), exp - 1) != 0) mpz_cdiv_r_2exp(to.get_mpz_t(), x.get_mpz_t(), exp); else mpz_fdiv_r_2exp(to.get_mpz_t(), x.get_mpz_t(), exp);

1 0

[GIT] ppl/ppl(master): Prefer explicit tests against zero.
by Enea Zaffanella 25 Feb '12

25 Feb '12

Module: ppl/ppl Branch: master Commit: ed45790955fc4f20ef69774b573dd8b505a71d78 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ed45790955fc… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Sat Feb 25 10:15:43 2012 +0100 Prefer explicit tests against zero. Detected by ECLAIR service utypflag. --- src/globals.defs.hh | 4 ++-- src/globals.inlines.hh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/globals.defs.hh b/src/globals.defs.hh index 314194d..2c54772 100644 --- a/src/globals.defs.hh +++ b/src/globals.defs.hh @@ -175,12 +175,12 @@ extern unsigned int in_assert; #define WEIGHT_BEGIN() #define WEIGHT_ADD(delta) \ do { \ - if (!Implementation::in_assert) \ + if (Implementation::in_assert == 0) \ Weightwatch_Traits::weight += delta; \ } while (false) #define WEIGHT_ADD_MUL(delta, factor) \ do { \ - if (!Implementation::in_assert) \ + if (Implementation::in_assert == 0) \ Weightwatch_Traits::weight += delta * factor; \ } while (false) #endif diff --git a/src/globals.inlines.hh b/src/globals.inlines.hh index 09936ec..d176bb0 100644 --- a/src/globals.inlines.hh +++ b/src/globals.inlines.hh @@ -64,7 +64,7 @@ Throwable::~Throwable() { inline void maybe_abandon() { #ifndef NDEBUG - if (Implementation::in_assert) + if (Implementation::in_assert != 0) return; #endif if (Weightwatch_Traits::check_function != 0)

1 0

[GIT] ppl/ppl(master): Code layout made conformat to the coding standard.
by Roberto Bagnara 25 Feb '12

25 Feb '12

Module: ppl/ppl Branch: master Commit: 206682b08f624911ad29cfdc1d64bef59d6e8278 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=206682b08f62… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Feb 25 08:43:06 2012 +0100 Code layout made conformat to the coding standard. --- src/compiler.hh | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/compiler.hh b/src/compiler.hh index 0aa3e85..a0a162d 100644 --- a/src/compiler.hh +++ b/src/compiler.hh @@ -82,7 +82,8 @@ struct Suppress_Uninitialized_Warnings_Type { #if !defined(__GNUC__) -inline unsigned int clz32(u_int32_t w) { +inline unsigned int +clz32(u_int32_t w) { unsigned int r = 31; if ((w & 0xffffffff00000000ULL) != 0) { w = (w >> 31) >> 1; @@ -109,14 +110,16 @@ inline unsigned int clz32(u_int32_t w) { return r; } -inline unsigned int clz64(u_int64_t w) { +inline unsigned int +clz64(u_int64_t w) { if ((w & 0xffffffff00000000ULL) == 0) return clz32(static_cast<u_int32_t>(w)) + 32; else return clz32(static_cast<u_int32_t>(w >> 32)); } -inline unsigned int ctz32(u_int32_t w) { +inline unsigned int +ctz32(u_int32_t w) { static const unsigned int mod37_table[] = { 32, 0, 1, 26, 2, 23, 27, 0, 3, 16, 24, 30, 28, 11, 0, 13, 4, 7, 17, 0, 25, 22, 31, 15, 29, 10, 12, 6, 0, 21, 14, 9, @@ -125,7 +128,8 @@ inline unsigned int ctz32(u_int32_t w) { return mod37_table[(w & -w) % 37]; } -inline unsigned int ctz64(u_int64_t w) { +inline unsigned int +ctz64(u_int64_t w) { if ((w & 0x00000000ffffffffULL) == 0) return ctz32(static_cast<u_int32_t>(w >> 32)) + 32; else

1 0

[GIT] ppl/ppl(master): Restore previous names.
by Abramo Bagnara 24 Feb '12

24 Feb '12

Module: ppl/ppl Branch: master Commit: 1b647baaca8ae93381e8579ac7ca157af0d433ac URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1b647baaca8a… Author: Abramo Bagnara <abramo.bagnara(a)gmail.com> Date: Fri Feb 24 22:42:44 2012 +0100 Restore previous names. --- src/Octagonal_Shape.templates.hh | 28 ++++++++++++++-------------- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/Octagonal_Shape.templates.hh b/src/Octagonal_Shape.templates.hh index 84dc855..7dfea5b 100644 --- a/src/Octagonal_Shape.templates.hh +++ b/src/Octagonal_Shape.templates.hh @@ -4431,8 +4431,8 @@ Octagonal_Shape<T>::refine(const Variable var, PPL_DIRTY_TEMP(N, minus_coeff_i); // Note: indices above `w' can be disregarded, as they all have // a zero coefficient in `sc_expr'. - for (Row_iterator m_iter = m_begin, m_end = m_begin + (2 * w_id + 2); - m_iter != m_end; ) { + for (Row_iterator m_iter = m_begin, m_iter_end = m_begin + (2 * w_id + 2); + m_iter != m_iter_end; ) { const dimension_type n_i = m_iter.index(); const dimension_type id = n_i/2; Row_reference m_i = *m_iter; @@ -4618,8 +4618,8 @@ Octagonal_Shape<T>::refine(const Variable var, PPL_DIRTY_TEMP_COEFFICIENT(minus_sc_i); // Note: indices above `w_id' can be disregarded, as they all have // a zero coefficient in `expr'. - for (Row_Iterator m_iter = m_begin, m_end = m_begin + (2 * w_id + 2); - m_iter != m_end; ) { + for (Row_Iterator m_iter = m_begin, m_iter_end = m_begin + (2 * w_id + 2); + m_iter != m_iter_end; ) { const dimension_type n_i = m_iter.index(); const dimension_type id = n_i/2; Row_Reference m_i = *m_iter; @@ -4702,8 +4702,8 @@ Octagonal_Shape<T>::refine(const Variable var, PPL_DIRTY_TEMP(N, coeff_i); PPL_DIRTY_TEMP(N, approx_i); PPL_DIRTY_TEMP_COEFFICIENT(minus_sc_i); - for (Row_Iterator m_iter = m_begin, m_end = m_begin + (2 * w_id + 2); - m_iter != m_end; ) { + for (Row_Iterator m_iter = m_begin, m_iter_end = m_begin + (2 * w_id + 2); + m_iter != m_iter_end; ) { const dimension_type n_i = m_iter.index(); const dimension_type id = n_i/2; Row_Reference m_i = *m_iter; @@ -4999,8 +4999,8 @@ Octagonal_Shape<T>::affine_image(const Variable var, // Note: indices above `w' can be disregarded, as they all have // a zero coefficient in `sc_expr'. const Row_Iterator m_begin = matrix.row_begin(); - for (Row_iterator m_iter = m_begin, - m_end = m_begin + (2 * w_id + 2); m_iter != m_end; ) { + for (Row_iterator m_iter = m_begin, m_iter_end = m_begin + (2 * w_id + 2); + m_iter != m_iter_end; ) { const dimension_type n_i = m_iter.index(); const dimension_type id = n_i/2; Row_reference m_i = *m_iter; @@ -5933,8 +5933,8 @@ Octagonal_Shape<T> PPL_DIRTY_TEMP_COEFFICIENT(minus_sc_i); // Note: indices above `w' can be disregarded, as they all have // a zero coefficient in `sc_expr'. - for (Row_iterator m_iter = m_begin, m_end = m_begin + (2 * w_id + 2); - m_iter != m_end; ) { + for (Row_iterator m_iter = m_begin, m_iter_end = m_begin + (2 * w_id + 2); + m_iter != m_iter_end; ) { const dimension_type n_i = m_iter.index(); const dimension_type id = n_i/2; Row_reference m_i = *m_iter; @@ -6027,8 +6027,8 @@ Octagonal_Shape<T> PPL_DIRTY_TEMP_COEFFICIENT(minus_sc_i); PPL_DIRTY_TEMP(N, approx_i); // Approximate the homogeneous part of `-sc_expr'. - for (Row_iterator m_iter = m_begin, m_end = m_begin + (2 * w_id + 2); - m_iter != m_end; ) { + for (Row_iterator m_iter = m_begin, m_iter_end = m_begin + (2 * w_id + 2); + m_iter != m_iter_end; ) { const dimension_type n_i = m_iter.index(); const dimension_type id = n_i/2; Row_reference m_i = *m_iter; @@ -6493,8 +6493,8 @@ Octagonal_Shape<T>::bounded_affine_image(const Variable var, PPL_DIRTY_TEMP_COEFFICIENT(minus_sc_i); // Note: indices above `w' can be disregarded, as they all have // a zero coefficient in `sc_expr'. - for (Row_iterator m_iter = m_begin, m_end = m_begin + (2 * w_id + 2); - m_iter != m_end; ) { + for (Row_iterator m_iter = m_begin, m_iter_end = m_begin + (2 * w_id + 2); + m_iter != m_iter_end; ) { const dimension_type n_i = m_iter.index(); const dimension_type id = n_i/2; Row_reference m_i = *m_iter;

1 0

[GIT] ppl/ppl(master): Use "" quotes to include non-system headers.
by Roberto Bagnara 24 Feb '12

24 Feb '12

Module: ppl/ppl Branch: master Commit: d1113c510bef0d225dc673e31ed4df18ab5c4749 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d1113c510bef… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Feb 24 21:12:15 2012 +0100 Use "" quotes to include non-system headers. Detected by ECLAIR service hedrname. --- src/Threshold_Watcher.cc | 3 +-- src/Time.cc | 3 +-- src/Watchdog.cc | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Threshold_Watcher.cc b/src/Threshold_Watcher.cc index 9652c0e..70a0a2c 100644 --- a/src/Threshold_Watcher.cc +++ b/src/Threshold_Watcher.cc @@ -22,7 +22,6 @@ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA. For the most up-to-date information see the Parma Polyhedra Library site: http://bugseng.com/products/ppl/ . */ -#include <ppl-config.h> - +#include "ppl-config.h" #include "Threshold_Watcher.defs.hh" diff --git a/src/Time.cc b/src/Time.cc index 47568aa..213df40 100644 --- a/src/Time.cc +++ b/src/Time.cc @@ -21,8 +21,7 @@ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA. For the most up-to-date information see the Parma Polyhedra Library site: http://bugseng.com/products/ppl/ . */ -#include <ppl-config.h> - +#include "ppl-config.h" #include "Time.defs.hh" namespace PPL = Parma_Polyhedra_Library; diff --git a/src/Watchdog.cc b/src/Watchdog.cc index b038e88..db789a8 100644 --- a/src/Watchdog.cc +++ b/src/Watchdog.cc @@ -21,8 +21,7 @@ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA. For the most up-to-date information see the Parma Polyhedra Library site: http://bugseng.com/products/ppl/ . */ -#include <ppl-config.h> - +#include "ppl-config.h" #include "Watchdog.defs.hh" #if PPL_HAVE_DECL_SETITIMER && PPL_HAVE_DECL_SIGACTION

1 0

[GIT] ppl/ppl(master): Comments improved.
by Roberto Bagnara 24 Feb '12

24 Feb '12

Module: ppl/ppl Branch: master Commit: 4b09274909915d1908c5a0668390286604a2bda7 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4b0927490991… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Feb 24 21:10:28 2012 +0100 Comments improved. --- src/BD_Shape.templates.hh | 26 ++++++++++++++------------ src/Polyhedron_chdims.cc | 4 ++-- src/simplify.cc | 7 ++++--- 3 files changed, 20 insertions(+), 17 deletions(-) diff --git a/src/BD_Shape.templates.hh b/src/BD_Shape.templates.hh index 3d4e132..6bd8c72 100644 --- a/src/BD_Shape.templates.hh +++ b/src/BD_Shape.templates.hh @@ -597,24 +597,26 @@ BD_Shape<T>::contains(const BD_Shape& y) const { } /* - The `y' bounded difference shape need be closed. - In fact if, for example, in `*this' we have the constraints: + The `y' bounded difference shape must be closed. As an example, + consider the case where in `*this' we have the constraints - x1 - x2 <= 1; - x1 <= 3; - x2 <= 2; + x1 - x2 <= 1, + x1 <= 3, + x2 <= 2, - in `y' the constraints are: + and in `y' the constraints are - x1 - x2 <= 0; - x2 <= 1; + x1 - x2 <= 0, + x2 <= 1. - without closure it returns "false", instead if we close `y' we have - the implicit constraint + Without closure the (erroneous) analysis of the inhomogeneous terms + would conclude containment does not hold. Closing `y' results into + the "discovery" of the implicit constraint - x1 <= 1; + x1 <= 1, - and so we obtain the right result "true". + at which point the inhomogeneous terms can be examined to determine + that containment does hold. */ y.shortest_path_closure_assign(); diff --git a/src/Polyhedron_chdims.cc b/src/Polyhedron_chdims.cc index e4eabda..1ef2024 100644 --- a/src/Polyhedron_chdims.cc +++ b/src/Polyhedron_chdims.cc @@ -229,7 +229,7 @@ PPL::Polyhedron::add_space_dimensions_and_project(dimension_type m) { // In contrast, in the system of constraints, new rows are needed // in order to avoid embedding the old polyhedron in the new space. // Thus, for each new dimensions `x[k]', we add the constraint - // x[k] = 0; this is done by invoking the function add_space_dimensions() + // x[k] = 0: this is done by invoking the function add_space_dimensions() // giving the system of constraints as the second argument. if (constraints_are_up_to_date()) if (generators_are_up_to_date()) { @@ -237,7 +237,7 @@ PPL::Polyhedron::add_space_dimensions_and_project(dimension_type m) { if (!sat_g_is_up_to_date()) update_sat_g(); // Adds rows and/or columns to both matrices. - // `add_space_dimensions' correctly handles pending constraints + // `add_space_dimensions()' correctly handles pending constraints // or generators. add_space_dimensions(gen_sys, con_sys, sat_g, sat_c, m); } diff --git a/src/simplify.cc b/src/simplify.cc index 46b7f2a..cdda027 100644 --- a/src/simplify.cc +++ b/src/simplify.cc @@ -192,11 +192,12 @@ PPL::Polyhedron::simplify(Linear_System& sys, Bit_Matrix& sat) { // condition for an inequality to be irredundant (i.e., it provides // a sufficient condition for identifying redundant inequalities). // Let - // num_saturators[i] = num_sat_lines[i] + num_sat_rays_or_points[i]; - // dim_lin_space = num_irredundant_lines; + // + // num_saturators[i] = num_sat_lines[i] + num_sat_rays_or_points[i], + // dim_lin_space = num_irredundant_lines, // dim_ray_space // = dim_vector_space - num_irredundant_equalities - dim_lin_space - // = num_columns - 1 - num_lines_or_equalities - dim_lin_space; + // = num_columns - 1 - num_lines_or_equalities - dim_lin_space, // min_sat_rays_or_points = dim_ray_space. // // An inequality saturated by less than `dim_ray_space' _rays/points_

1 0

[GIT] ppl/ppl(master): Avoid commented-out code.
by Roberto Bagnara 24 Feb '12

24 Feb '12

Module: ppl/ppl Branch: master Commit: 5155daa681e19cb6bede5c899860cade0ac18174 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5155daa681e1… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Feb 24 19:57:30 2012 +0100 Avoid commented-out code. Detected by ECLAIR service cmntdout. --- src/Checked_Number.defs.hh | 21 +++++++++++---------- src/WRD_coefficient_types.defs.hh | 34 ++++++++++++++-------------------- src/checked.inlines.hh | 10 +++++----- 3 files changed, 30 insertions(+), 35 deletions(-) diff --git a/src/Checked_Number.defs.hh b/src/Checked_Number.defs.hh index 0bf4a5f..d7bad52 100644 --- a/src/Checked_Number.defs.hh +++ b/src/Checked_Number.defs.hh @@ -46,18 +46,19 @@ struct Extended_Number_Policy { const_bool_nodef(check_sqrt_neg, false); const_bool_nodef(has_nan, true); const_bool_nodef(has_infinity, true); - // Do not uncomment the following. - // The compile time error on conversions is the expected behavior. - // const_bool_nodef(convertible, false); + + // `convertible' is intentionally not defined: the compile time + // error on conversions is the expected behavior. + const_bool_nodef(fpu_check_inexact, true); const_bool_nodef(fpu_check_nan_result, true); - // Do not uncomment the following. - // The compile time error is the expected behavior. - // static const Rounding_Dir ROUND_DEFAULT_CONSTRUCTOR = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_OPERATOR = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_FUNCTION = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_INPUT = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_OUTPUT = ROUND_UP; + + // ROUND_DEFAULT_CONSTRUCTOR is intentionally not defined. + // ROUND_DEFAULT_OPERATOR is intentionally not defined. + // ROUND_DEFAULT_FUNCTION is intentionally not defined. + // ROUND_DEFAULT_INPUT is intentionally not defined. + // ROUND_DEFAULT_OUTPUT is intentionally not defined. + static void handle_result(Result r); }; diff --git a/src/WRD_coefficient_types.defs.hh b/src/WRD_coefficient_types.defs.hh index 52df272..7c1e23e 100644 --- a/src/WRD_coefficient_types.defs.hh +++ b/src/WRD_coefficient_types.defs.hh @@ -65,9 +65,8 @@ struct WRD_Extended_Number_Policy { //! Handle infinity special values. const_bool_nodef(has_infinity, true); - // Do not uncomment the following. - // The compile time error on conversions is the expected behavior. - // const_bool_nodef(convertible, false); + // `convertible' is intentionally not defined: the compile time + // error on conversions is the expected behavior. //! Honor requests to check for FPU inexact results. const_bool_nodef(fpu_check_inexact, true); @@ -75,13 +74,11 @@ struct WRD_Extended_Number_Policy { //! Do not make extra checks to detect FPU NaN results. const_bool_nodef(fpu_check_nan_result, false); - // Do not uncomment the following. - // The compile time error is the expected behavior. - // static const Rounding_Dir ROUND_DEFAULT_CONSTRUCTOR = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_OPERATOR = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_FUNCTION = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_INPUT = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_OUTPUT = ROUND_UP; + // ROUND_DEFAULT_CONSTRUCTOR is intentionally not defined. + // ROUND_DEFAULT_OPERATOR is intentionally not defined. + // ROUND_DEFAULT_FUNCTION is intentionally not defined. + // ROUND_DEFAULT_INPUT is intentionally not defined. + // ROUND_DEFAULT_OUTPUT is intentionally not defined. /*! \brief Handles \p r: called by all constructors, operators and functions that @@ -127,9 +124,8 @@ struct Debug_WRD_Extended_Number_Policy { //! Handle infinity special values. const_bool_nodef(has_infinity, true); - // Do not uncomment the following. - // The compile time error on conversions is the expected behavior. - // const_bool_nodef(convertible, false); + // `convertible' is intentionally not defined: the compile time + // error on conversions is the expected behavior. //! Honor requests to check for FPU inexact results. const_bool_nodef(fpu_check_inexact, true); @@ -137,13 +133,11 @@ struct Debug_WRD_Extended_Number_Policy { //! Make extra checks to detect FPU NaN results. const_bool_nodef(fpu_check_nan_result, true); - // Do not uncomment the following. - // The compile time error is the expected behavior. - // static const Rounding_Dir ROUND_DEFAULT_CONSTRUCTOR = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_OPERATOR = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_FUNCTION = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_INPUT = ROUND_UP; - // static const Rounding_Dir ROUND_DEFAULT_OUTPUT = ROUND_UP; + // ROUND_DEFAULT_CONSTRUCTOR is intentionally not defined. + // ROUND_DEFAULT_OPERATOR is intentionally not defined. + // ROUND_DEFAULT_FUNCTION is intentionally not defined. + // ROUND_DEFAULT_INPUT is intentionally not defined. + // ROUND_DEFAULT_OUTPUT is intentionally not defined. /*! \brief Handles \p r: called by all constructors, operators and functions that diff --git a/src/checked.inlines.hh b/src/checked.inlines.hh index bf91e75..44eea27 100644 --- a/src/checked.inlines.hh +++ b/src/checked.inlines.hh @@ -222,27 +222,27 @@ PPL_SAFE_CONVERSION(mpz_class, signed char); PPL_SAFE_CONVERSION(mpz_class, signed short); PPL_SAFE_CONVERSION(mpz_class, signed int); PPL_SAFE_CONVERSION(mpz_class, signed long); -//PPL_SAFE_CONVERSION(mpz_class, signed long long); +// GMP's API does not support signed long long. PPL_SAFE_CONVERSION(mpz_class, unsigned char); PPL_SAFE_CONVERSION(mpz_class, unsigned short); PPL_SAFE_CONVERSION(mpz_class, unsigned int); PPL_SAFE_CONVERSION(mpz_class, unsigned long); -//PPL_SAFE_CONVERSION(mpz_class, unsigned long long); +// GMP's API does not support unsigned long long. PPL_SAFE_CONVERSION(mpq_class, char); PPL_SAFE_CONVERSION(mpq_class, signed char); PPL_SAFE_CONVERSION(mpq_class, signed short); PPL_SAFE_CONVERSION(mpq_class, signed int); PPL_SAFE_CONVERSION(mpq_class, signed long); -//PPL_SAFE_CONVERSION(mpq_class, signed long long); +// GMP's API does not support signed long long. PPL_SAFE_CONVERSION(mpq_class, unsigned char); PPL_SAFE_CONVERSION(mpq_class, unsigned short); PPL_SAFE_CONVERSION(mpq_class, unsigned int); PPL_SAFE_CONVERSION(mpq_class, unsigned long); -//PPL_SAFE_CONVERSION(mpq_class, unsigned long long); +// GMP's API does not support unsigned long long. PPL_SAFE_CONVERSION(mpq_class, float); PPL_SAFE_CONVERSION(mpq_class, double); -//PPL_SAFE_CONVERSION(mpq_class, long double); +// GMP's API does not support long double. #undef PPL_SAFE_CONVERSION

1 0

[GIT] ppl/ppl(master): Comments improved.
by Roberto Bagnara 24 Feb '12

24 Feb '12

Module: ppl/ppl Branch: master Commit: 5161145cfadb50f9c441a4fc41fecf441483918e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5161145cfadb… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Feb 24 19:57:23 2012 +0100 Comments improved. --- src/Polyhedron_nonpublic.cc | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Polyhedron_nonpublic.cc b/src/Polyhedron_nonpublic.cc index dba2518..2516b2a 100644 --- a/src/Polyhedron_nonpublic.cc +++ b/src/Polyhedron_nonpublic.cc @@ -1460,7 +1460,8 @@ PPL::Polyhedron::BHZ09_C_poly_hull_assign_if_exact(const Polyhedron& y) { // Minimization is not really required, but it is probably the best // way of getting constraints, generators and saturation matrices - // up-to-date; it also removes redundant constraints/generators. + // up-to-date. Minimization it also removes redundant + // constraints/generators. (void) x.minimize(); (void) y.minimize(); @@ -1563,7 +1564,8 @@ PPL::Polyhedron::BHZ09_NNC_poly_hull_assign_if_exact(const Polyhedron& y) { // Minimization is not really required, but it is probably the best // way of getting constraints, generators and saturation matrices - // up-to-date; it also removes redundant constraints/generators. + // up-to-date. Minimization also removes redundant + // constraints/generators. (void) x.minimize(); (void) y.minimize();

1 0