- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(master): Bumped copyright years.
by Roberto Bagnara 18 Jan '12

18 Jan '12

1 0

[GIT] ppl/ppl(master): Reduced the scope of several variables.
by Roberto Bagnara 18 Jan '12

18 Jan '12

Module: ppl/ppl Branch: master Commit: 7f879511e0d654a8d218e4eaf2b94f7b7c1993b6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7f879511e0d6… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Jan 18 11:48:24 2012 +0100 Reduced the scope of several variables. Detected by ECLAIR service minscope. --- demos/ppl_pips/ppl_pips.cc | 5 ++--- src/BD_Shape.templates.hh | 16 +++++++++------- src/Boundary.defs.hh | 3 +-- src/MIP_Problem.cc | 14 +++++++++----- src/PIP_Tree.cc | 7 ++----- src/Sparse_Row.cc | 6 +++--- src/Variables_Set.cc | 2 +- src/termination.cc | 2 +- src/wrap_assign.hh | 4 ++-- 9 files changed, 30 insertions(+), 29 deletions(-) diff --git a/demos/ppl_pips/ppl_pips.cc b/demos/ppl_pips/ppl_pips.cc index bfa1def..5ff21b9 100644 --- a/demos/ppl_pips/ppl_pips.cc +++ b/demos/ppl_pips/ppl_pips.cc @@ -391,8 +391,8 @@ protected: bool read_comment(std::istream& in) { comment = ""; int count = 1; - char c; do { + char c; if (!in.get(c)) return false; if (c == '(') @@ -635,7 +635,6 @@ process_options(int argc, char* argv[]) { break; char* endptr; - long l; switch (c) { case 0: break; @@ -649,7 +648,7 @@ process_options(int argc, char* argv[]) { case 'R': { const int MEGA = 1024*1024; - l = strtol(optarg, &endptr, 10); + long l = strtol(optarg, &endptr, 10); if (*endptr || l < 0) fatal("a non-negative integer must follow `-R'"); else if (static_cast<unsigned long>(l) > ULONG_MAX/MEGA) diff --git a/src/BD_Shape.templates.hh b/src/BD_Shape.templates.hh index 911812f..49f4fe0 100644 --- a/src/BD_Shape.templates.hh +++ b/src/BD_Shape.templates.hh @@ -412,12 +412,11 @@ BD_Shape<T>::add_constraint(const Constraint& c) { // Select the cell to be modified for the "<=" part of the constraint, // and set `coeff' to the absolute value of itself. const bool negative = (coeff < 0); - N& x = negative ? dbm[i][j] : dbm[j][i]; - N& y = negative ? dbm[j][i] : dbm[i][j]; if (negative) neg_assign(coeff); bool changed = false; + N& x = negative ? dbm[i][j] : dbm[j][i]; // Compute the bound for `x', rounding towards plus infinity. PPL_DIRTY_TEMP(N, d); div_round_up(d, inhomo, coeff); @@ -427,6 +426,7 @@ BD_Shape<T>::add_constraint(const Constraint& c) { } if (c.is_equality()) { + N& y = negative ? dbm[j][i] : dbm[i][j]; // Also compute the bound for `y', rounding towards plus infinity. PPL_DIRTY_TEMP_COEFFICIENT(minus_c_term); neg_assign(minus_c_term, inhomo); @@ -2983,14 +2983,13 @@ BD_Shape<T>::get_limiting_shape(const Constraint_System& cs, const N& x = negative ? dbm[i][j] : dbm[j][i]; const N& y = negative ? dbm[j][i] : dbm[i][j]; DB_Matrix<N>& ls_dbm = limiting_shape.dbm; - N& ls_x = negative ? ls_dbm[i][j] : ls_dbm[j][i]; - N& ls_y = negative ? ls_dbm[j][i] : ls_dbm[i][j]; if (negative) neg_assign(coeff); // Compute the bound for `x', rounding towards plus infinity. div_round_up(d, c.inhomogeneous_term(), coeff); if (x <= d) { if (c.is_inequality()) { + N& ls_x = negative ? ls_dbm[i][j] : ls_dbm[j][i]; if (ls_x > d) { ls_x = d; changed = true; @@ -3000,12 +2999,15 @@ BD_Shape<T>::get_limiting_shape(const Constraint_System& cs, // Compute the bound for `y', rounding towards plus infinity. neg_assign(minus_c_term, c.inhomogeneous_term()); div_round_up(d1, minus_c_term, coeff); - if (y <= d1) + if (y <= d1) { + N& ls_x = negative ? ls_dbm[i][j] : ls_dbm[j][i]; + N& ls_y = negative ? ls_dbm[j][i] : ls_dbm[i][j]; if ((ls_x >= d && ls_y > d1) || (ls_x > d && ls_y >= d1)) { ls_x = d; ls_y = d1; changed = true; } + } } } } @@ -4243,12 +4245,12 @@ void BD_Shape<T> PPL_DIRTY_TEMP(N, b_mlb); neg_assign_r(b_mlb, b.lower(), ROUND_NOT_NEEDED); - // true if b = [b_lb, b_ub] = [0;0]. - bool is_b_zero = (b_mlb == 0 && b_ub == 0); // true if w_coeff = [1;1] bool is_w_coeff_one = (w_coeff == 1); if (w_id == var_id) { + // true if b = [b_lb, b_ub] = [0;0]. + bool is_b_zero = (b_mlb == 0 && b_ub == 0); // Here `lf' is of the form: [+/-1;+/-1] * v + b. if (is_w_coeff_one) { if (is_b_zero) diff --git a/src/Boundary.defs.hh b/src/Boundary.defs.hh index 7b85dc0..fb24935 100644 --- a/src/Boundary.defs.hh +++ b/src/Boundary.defs.hh @@ -716,7 +716,6 @@ inline Result div_assign_z(Boundary_Type to_type, To& to, To_Info& to_info, Boundary_Type type1, const T1& x1, const Info1& info1, int x1s, Boundary_Type type2, const T2& x2, const Info2& info2, int x2s) { - bool shrink; if (x1s != 0) { if (x2s != 0) return div_assign(to_type, to, to_info, @@ -728,7 +727,7 @@ div_assign_z(Boundary_Type to_type, To& to, To_Info& to_info, } } else { - shrink = info1.get_boundary_property(type1, OPEN) + bool shrink = info1.get_boundary_property(type1, OPEN) && !is_boundary_infinity_closed(type2, x2, info2); return set_zero(to_type, to, to_info, shrink); } diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index 07558bf..6ecfa28 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -2662,8 +2662,8 @@ PPL::MIP_Problem::ascii_load(std::istream& s) { if (!(s >> str) || str != ")") return false; - dimension_type base_value; for (dimension_type i = 0; i != base_size; ++i) { + dimension_type base_value; if (!(s >> base_value)) return false; base.push_back(base_value); @@ -2685,26 +2685,30 @@ PPL::MIP_Problem::ascii_load(std::istream& s) { if (!(s >> str) || str != ")") return false; - dimension_type first_value; - dimension_type second_value; - dimension_type index; - // The first `mapping' index is never used, so we initialize // it pushing back a dummy value. if (tableau.num_columns() != 0) mapping.push_back(std::make_pair(0, 0)); for (dimension_type i = 1; i < mapping_size; ++i) { + dimension_type index; if (!(s >> index)) return false; + if (!(s >> str) || str != "->") return false; + + dimension_type first_value; if (!(s >> first_value)) return false; + if (!(s >> str) || str != "->") return false; + + dimension_type second_value; if (!(s >> second_value)) return false; + mapping.push_back(std::make_pair(first_value, second_value)); } diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc index f788457..1b12491 100644 --- a/src/PIP_Tree.cc +++ b/src/PIP_Tree.cc @@ -735,11 +735,7 @@ compatibility_check_find_pivot(const Matrix& s, current_data.value = s_ij; } else { data_struct& current_data = candidates_map[j]; - - Coefficient_traits::const_reference value_b = s_i.get(j); - PPL_ASSERT(current_data.value > 0); - PPL_ASSERT(value_b > 0); // Before computing and comparing the actual values, the signs are // compared. This speeds up the code, because the values' computation @@ -759,9 +755,10 @@ compatibility_check_find_pivot(const Matrix& s, } // Otherwise, keep current pivot for this column. } else { - // Sign comparison is not enough this time. // Do the full computation. + Coefficient_traits::const_reference value_b = s_i.get(j); + PPL_ASSERT(value_b > 0); PPL_DIRTY_TEMP_COEFFICIENT(lhs_coeff); lhs_coeff = current_data.cost; diff --git a/src/Sparse_Row.cc b/src/Sparse_Row.cc index 9a61ced..c5efd90 100644 --- a/src/Sparse_Row.cc +++ b/src/Sparse_Row.cc @@ -475,17 +475,17 @@ PPL::Sparse_Row::ascii_load(std::istream& s) { if (!(s >> size_)) return false; clear(); - dimension_type n_elements; - dimension_type current_key; - Coefficient current_data; if (!(s >> str) || str != "elements") return false; + dimension_type n_elements; if (!(s >> n_elements)) return false; + PPL_DIRTY_TEMP_COEFFICIENT(current_data); for (dimension_type i = 0; i < n_elements; ++i) { + dimension_type current_key; if (!(s >> str) || str != "[") return false; if (!(s >> current_key)) diff --git a/src/Variables_Set.cc b/src/Variables_Set.cc index d73ad15..0a0abe5 100644 --- a/src/Variables_Set.cc +++ b/src/Variables_Set.cc @@ -81,8 +81,8 @@ PPL::Variables_Set::ascii_load(std::istream& s) { if (!(s >> str) || str != ")") return false; - dimension_type variable_value; for (dimension_type i = 0; i < size; ++i) { + dimension_type variable_value; if (!(s >> variable_value)) return false; insert(variable_value); diff --git a/src/termination.cc b/src/termination.cc index 0ac4e00..50e2710 100644 --- a/src/termination.cc +++ b/src/termination.cc @@ -883,13 +883,13 @@ all_affine_ranking_functions_PR_original(const Constraint_System& cs, #endif const Generator_System& gs_in = ph.generators(); - Generator_System gs_out; Generator_System::const_iterator gs_in_it = gs_in.begin(); Generator_System::const_iterator gs_in_end = gs_in.end(); if (gs_in_it == gs_in_end) // The system is unsatisfiable. mu_space = NNC_Polyhedron(n + 1, EMPTY); else { + Generator_System gs_out; for ( ; gs_in_it != gs_in_end; ++gs_in_it) { const Generator& g = *gs_in_it; Linear_Expression le; diff --git a/src/wrap_assign.hh b/src/wrap_assign.hh index 7461749..a416506 100644 --- a/src/wrap_assign.hh +++ b/src/wrap_assign.hh @@ -168,8 +168,8 @@ wrap_assign(PSET& pointset, // and vars.space_dimension() <= pointset.space_dimension(). // Dimension-compatibility check of `*cs_p', if any. - const dimension_type vars_space_dim = vars.space_dimension(); if (cs_p != 0) { + const dimension_type vars_space_dim = vars.space_dimension(); if (cs_p->space_dimension() > vars_space_dim) { std::ostringstream s; s << "PPL::" << class_name << "::wrap_assign(..., cs_p, ...):" @@ -190,7 +190,7 @@ wrap_assign(PSET& pointset, const Constraint& c = *i; for (dimension_type d = cs_space_dim; d-- > 0; ) { PPL_ASSERT(c.coefficient(Variable(d)) == 0 - || vars.find(d) != vars_end); + || vars.find(d) != vars_end); } } #endif

1 0

problems with Box::operator<<
by Gianluca Amato 18 Jan '12

18 Jan '12

Hi all, I have a problem using operator<< with boxes. The following code does not compile with PPL 0.11.2 and gcc 4.6.1. ---- #include <ppl.hh> #include <iostream> using namespace Parma_Polyhedra_Library; struct Floating_Point_Box_Interval_Info_Policy { const_bool_nodef(store_special, false); const_bool_nodef(store_open, true); const_bool_nodef(cache_empty, true); const_bool_nodef(cache_singleton, true); const_bool_nodef(cache_normalized, false); const_int_nodef(next_bit, 0); const_bool_nodef(may_be_empty, true); const_bool_nodef(may_contain_infinity, false); const_bool_nodef(check_empty_result, false); const_bool_nodef(check_inexact, false); }; typedef Interval_Restriction_None<Interval_Info_Bitset <unsigned int, Floating_Point_Box_Interval_Info_Policy> > Floating_Point_Box_Interval_Info; typedef Box<Interval<double, Floating_Point_Box_Interval_Info> > Double_Box; int main(void) { Double_Box db; db.print(); std::cout << db; return 0; } --- The offending line is the one with std::cout << db, which gives the following error: no match for ‘operator<<’ in ‘std::cout << db’ I am not an expert neither with C++ nor with PPL, so I don't known if there is an obvious mistake in my code. Can someone give me an hint? Thanks, --gianluca

2 1

ppl-0.11.2 install problems with GCC
by Andre Nicolle 16 Jan '12

16 Jan '12

Hi All I have recently been compiling GCC 4.6.2 on a newly installed centos 5.6 computer and come across several strange problems when compiling PPL. GCC is being compiled to a new directory for distribution on a cluster so I install gmp-5.0.2 with configuration command ./configure --prefix=/share/apps/gcc/4.6.2 --enable-cxx this I compile using GCC 4.4 which was installed from the repositories. When compiling ppl-0.11.2 with configuration command ./configure --prefix=/share/apps/gcc/4.6.2 --with-gmp-build=/share/apps/gcc/4.6.2 and GCC 4.4 I get the following error message: checking how to link with libgmp... /share/apps/gcc/4.6.2/lib/libgmp.so -Wl,-rpath -Wl,/share/apps/gcc/4.6.2/lib checking how to link with libgmpxx... /share/apps/gcc/4.6.2/lib/libgmpxx.so /share/apps/gcc/4.6.2/lib/libgmp.so -Wl,-rpath -Wl,/share/apps/gcc/4.6.2/lib -Wl,-rpath -Wl,/share/apps/gcc/4.6.2/lib checking for the GMP library version 4.1.3 or above... no configure: error: Cannot find GMP version 4.1.3 or higher. GMP is the GNU Multi-Precision library: This is similar to the discussion at this link: http://www.cs.unipr.it/pipermail/ppl-devel/2011-March/017387.html Switching back to GCC 4.1 solves this problem and I successfully compile and test gmp and ppl-0.11.2. Is this a problem with the configure script? I then decided to compile ppl-0.11.2 again but this time using my newly compiled GCC 4.6.2 which does not encounter the previous error and configures correctly. However during the build I get the following error: /share/apps/gcc/4.6.2/lib../lib/libstdc++.so: could not read symbols: File in wrong format The environmental variables are set with the following command to use the newly installed GCC 4.6.2. export PATH=/share/apps/gcc/4.6.2/bin:$PATH export LD_LIBRARY_PATH=/share/apps/gcc/4.6.2/lib:/share/apps/gcc/4.6.2/lib64:$LD_LIBRARY_PATH This I discover is due to the compiler trying to link to the non-64bit version of libstdc++.so similar to the discussion here: http://www.cs.unipr.it/pipermail/ppl-devel/2009-April/014677.html By linking: ln -s /share/apps/gcc/4.6.2/lib64/libstdc++.so /share/apps/gcc/4.6.2/lib/libstdc++.so the 64bit version of the file into the requested location, I am able to compile and test ppl. This does not seem correct behaviour, could somebody tell me what is going wrong and how to fix this. Thanks Andre

2 2

[GIT] ppl/ppl(master): Also add bugseng_logo.pdf to EXTRA_DIST.
by Enea Zaffanella 05 Jan '12

05 Jan '12

Module: ppl/ppl Branch: master Commit: c34e47c445db87c610a7b266d880e0c4717ab82d URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c34e47c445db… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Jan 5 15:44:12 2012 +0100 Also add bugseng_logo.pdf to EXTRA_DIST. --- doc/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index d4225de..c30ecb8 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1656,6 +1656,7 @@ EXTRA_DIST= \ $(DIST_DOCS) \ $(DOX_FILES) \ README.doc \ +bugseng_logo.pdf \ devref-language-interface.tex \ devref.tex \ fdl.tex \

1 0

[GIT] ppl/ppl(master): Added ppl_logo* to EXTRA_DIST.
by Enea Zaffanella 04 Jan '12

04 Jan '12

Module: ppl/ppl Branch: master Commit: 19fed334bf697bfd4c63e1c94f3239d912dd6219 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=19fed334bf69… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Wed Jan 4 08:49:02 2012 +0100 Added ppl_logo* to EXTRA_DIST. --- doc/Makefile.am | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 148cae2..d4225de 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1663,6 +1663,8 @@ gpl.tex \ interfaces-html.sed \ interfaces-latex.sed \ ppl.sty \ +ppl_logo.pdf \ +ppl_logo_no_ppl.pdf \ user-language-interface.tex \ user.tex

1 0

[GIT] ppl/ppl(sparse_matrices): Fixed a performance regression caused by a bug in the computation of
by Enea Zaffanella 02 Jan '12

02 Jan '12

Module: ppl/ppl Branch: sparse_matrices Commit: 95219a9f931d8b868975050d10326bde214dda46 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=95219a9f931d… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 10:17:15 2012 +0100 Fixed a performance regression caused by a bug in the computation of the number of subsumed rows. --- src/Polyhedron_conversion.templates.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Polyhedron_conversion.templates.hh b/src/Polyhedron_conversion.templates.hh index e850214..90f0ce5 100644 --- a/src/Polyhedron_conversion.templates.hh +++ b/src/Polyhedron_conversion.templates.hh @@ -700,7 +700,7 @@ Polyhedron::conversion(Source_Linear_System& source, // NOTE: this number has to be less than `k' because // we are treating the `k'-th constraint. const dimension_type num_common_satur - = k - new_satrow.count_ones(); + = k - redundant_source_rows.size() - new_satrow.count_ones(); // Even before actually creating the new ray as a // positive combination of `dest_rows[i]' and `dest_rows[j]',

1 0

[GIT] ppl/ppl(sparse_matrices): Restored old code trying to keep the system sortedness flag on.
by Enea Zaffanella 02 Jan '12

02 Jan '12

Module: ppl/ppl Branch: sparse_matrices Commit: 8f6d05de095b067c86926f04986aefd7aba6b0d7 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=8f6d05de095b… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 09:58:14 2012 +0100 Restored old code trying to keep the system sortedness flag on. Factored out of loop some invariant space dimension computation. --- src/Polyhedron_conversion.templates.hh | 37 ++++++++++++++----------------- 1 files changed, 17 insertions(+), 20 deletions(-) diff --git a/src/Polyhedron_conversion.templates.hh b/src/Polyhedron_conversion.templates.hh index 45cd39b..e850214 100644 --- a/src/Polyhedron_conversion.templates.hh +++ b/src/Polyhedron_conversion.templates.hh @@ -353,11 +353,18 @@ Polyhedron::conversion(Source_Linear_System& source, Dest_Linear_System& dest, Bit_Matrix& sat, dimension_type num_lines_or_equalities) { - typedef typename Dest_Linear_System::row_type dest_row_type; typedef typename Source_Linear_System::row_type source_row_type; + // Constraints and generators must have the same dimension, + // otherwise the scalar products below will bomb. + PPL_ASSERT(source.space_dimension() == dest.space_dimension()); + const dimension_type source_space_dim = source.space_dimension(); const dimension_type source_num_rows = source.num_rows(); + const dimension_type source_num_columns = source_space_dim + + (source.is_necessarily_closed() ? 1 : 2); + + dimension_type dest_num_rows = dest.num_rows(); // The rows removed from `dest' will be placed in this vector, so they // can be recycled if needed. @@ -388,10 +395,6 @@ Polyhedron::conversion(Source_Linear_System& source, for (dimension_type k = start; k < source_num_rows; ++k) { const source_row_type& source_k = source[k]; - // Constraints and generators must have the same dimension, - // otherwise the scalar product below will bomb. - PPL_ASSERT(source.space_dimension() == dest.space_dimension()); - // `scalar_prod[i]' will contain the scalar product of the // constraint `source_k' and the generator `dest_rows[i]'. This // product is 0 if and only if the generator saturates the @@ -408,7 +411,7 @@ Polyhedron::conversion(Source_Linear_System& source, Scalar_Products::assign(scalar_prod[index_non_zero], source_k, dest.sys.rows[index_non_zero]); - WEIGHT_ADD_MUL(17, source.space_dimension()); + WEIGHT_ADD_MUL(17, source_space_dim); if (scalar_prod[index_non_zero] != 0) // The generator does not saturate the constraint. break; @@ -420,7 +423,7 @@ Polyhedron::conversion(Source_Linear_System& source, for (dimension_type i = index_non_zero + 1; i < dest_num_rows; ++i) { WEIGHT_BEGIN(); Scalar_Products::assign(scalar_prod[i], source_k, dest.sys.rows[i]); - WEIGHT_ADD_MUL(25, source.space_dimension()); + WEIGHT_ADD_MUL(25, source_space_dim); // Check if the client has requested abandoning all expensive // computations. If so, the exception specified by the client // is thrown now. @@ -544,7 +547,7 @@ Polyhedron::conversion(Source_Linear_System& source, // They are all checked at the end of this function. scalar_prod[i] = 0; // `dest_sorted' has already been set to false. - WEIGHT_ADD_MUL(41, dest.space_dimension()); + WEIGHT_ADD_MUL(41, source_space_dim); } // Check if the client has requested abandoning all expensive // computations. If so, the exception specified by the client @@ -696,8 +699,8 @@ Polyhedron::conversion(Source_Linear_System& source, // Compute the number of common saturators. // NOTE: this number has to be less than `k' because // we are treating the `k'-th constraint. - const dimension_type - num_common_satur = k - new_satrow.count_ones(); + const dimension_type num_common_satur + = k - new_satrow.count_ones(); // Even before actually creating the new ray as a // positive combination of `dest_rows[i]' and `dest_rows[j]', @@ -713,9 +716,6 @@ Polyhedron::conversion(Source_Linear_System& source, // an extremal ray saturates at least // `source_num_columns - num_lines_or_equalities - 2' // constraints. - const dimension_type source_num_columns - = source.topology() == NECESSARILY_CLOSED ? source.space_dimension() + 1 - : source.space_dimension() + 2; if (num_common_satur >= source_num_columns - num_lines_or_equalities - 2) { // The minimal proper face rule is satisfied. @@ -745,7 +745,7 @@ Polyhedron::conversion(Source_Linear_System& source, else { swap(new_row, recyclable_dest_rows.back()); recyclable_dest_rows.pop_back(); - new_row.set_space_dimension_no_ok(dest.space_dimension()); + new_row.set_space_dimension_no_ok(source_space_dim); swap(sat[dest_num_rows], new_satrow); } @@ -764,7 +764,7 @@ Polyhedron::conversion(Source_Linear_System& source, normalized_sp_i, normalized_sp_o); WEIGHT_BEGIN(); - + neg_assign(normalized_sp_o); new_row = dest.sys.rows[j]; // TODO: Check if the following assertions hold. @@ -772,8 +772,8 @@ Polyhedron::conversion(Source_Linear_System& source, PPL_ASSERT(normalized_sp_o != 0); new_row.expr.linear_combine(dest.sys.rows[i].expr, normalized_sp_i, normalized_sp_o); - - WEIGHT_ADD_MUL(86, dest.space_dimension()); + + WEIGHT_ADD_MUL(86, source_space_dim); new_row.strong_normalize(); // Don't assert new_row.OK() here, because it may fail if // the parameter `dest' contained a row that wasn't ok. @@ -862,7 +862,6 @@ Polyhedron::conversion(Source_Linear_System& source, sat.remove_trailing_columns(redundant_source_rows.size()); } - /* FIXME: Check why the following does not work anymore. // If `start == 0', then `source' was sorted and remained so. // If otherwise `start > 0', then the two sub-system made by the // non-pending rows and the pending rows, respectively, were both sorted. @@ -872,8 +871,6 @@ Polyhedron::conversion(Source_Linear_System& source, // the two sub-systems. if (start > 0 && start < source.num_rows()) source.set_sorted(compare(source[start - 1], source[start]) <= 0); - */ - source.set_sorted(false); // There are no longer pending constraints in `source'. source.unset_pending_rows();

1 0

[GIT] ppl/ppl(sparse_matrices): New commits
by Roberto Bagnara 02 Jan '12

02 Jan '12

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=3f4b4ad00e08… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 09:53:59 2012 +0100 By default, use the default_representation in constructors. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=a62e7d228f4f… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 09:50:27 2012 +0100 Restored some checks in OK() methods for constraint/generator systems. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=45c9de9d9cf2… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 09:33:30 2012 +0100 Fixed bug spotted in test12() in tests/BD_Shape/boundedaffinepreimage1.cc. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b4b3f73fa095… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 09:29:14 2012 +0100 Added test showing a bug in BD_Shape::bounded_affine_preimage(). NOTE: the bug only affects the sparse_matrices branch and was synthesized from a corresponding Java interface test. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1ed36cb18af6… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 09:17:37 2012 +0100 Fixed a bug in generalized_affine_image. Under quite specific conditions, a generalized affine image application using a strict relation symbol was resulting in undefined behavior due to the use of invalid references. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=21b5672f913c… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 09:11:01 2012 +0100 Fixed a couple of comments and/or code layout issues. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=96e0e977f9e5… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Mon Jan 2 09:02:52 2012 +0100 Removed useless return of a void-typed expression.

1 0

[GIT] ppl/ppl(sparse_matrices): Unused variable declaration removed.
by Roberto Bagnara 24 Dec '11

24 Dec '11

Module: ppl/ppl Branch: sparse_matrices Commit: 79ab9a850e89992a534ac96309c952747234a94a URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=79ab9a850e89… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Sat Dec 24 12:56:41 2011 +0100 Unused variable declaration removed. --- src/wrap_assign.hh | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/wrap_assign.hh b/src/wrap_assign.hh index d9610e8..32e3780 100644 --- a/src/wrap_assign.hh +++ b/src/wrap_assign.hh @@ -82,7 +82,6 @@ wrap_assign_ind(PSET& pointset, if (vars.empty()) p.refine_with_constraints(cs); else { - Variables_Set::const_iterator vars_end = vars.end(); for (Constraint_System::const_iterator j = cs.begin(), cs_end = cs.end(); j != cs_end; ++j) if (j->expression().all_zeroes(vars))

1 0