- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(MPI): Distributed_Sparse_Matrix: optimize compute_working_cost_reducer_functor.
by Marco Poletti 10 Sep '10

10 Sep '10

Module: ppl/ppl Branch: MPI Commit: 262fd31e77b59abfafba4ee7b1fb8f4adf5de2ac URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=262fd31e77b5… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Fri Sep 10 17:47:07 2010 +0200 Distributed_Sparse_Matrix: optimize compute_working_cost_reducer_functor. --- src/Distributed_Sparse_Matrix.cc | 42 ++++++++++++++++++------------------- 1 files changed, 20 insertions(+), 22 deletions(-) diff --git a/src/Distributed_Sparse_Matrix.cc b/src/Distributed_Sparse_Matrix.cc index 3b44eaf..9ec2f61 100644 --- a/src/Distributed_Sparse_Matrix.cc +++ b/src/Distributed_Sparse_Matrix.cc @@ -583,21 +583,18 @@ namespace { struct compute_working_cost_reducer_functor { typedef std::pair<std::pair<PPL::Coefficient, PPL::Coefficient>, PPL::Sparse_Row> pair_type; - pair_type - operator()(const pair_type& x, const pair_type& y) const { - pair_type result(x); - const PPL::Coefficient& x_scaling = x.first.first; - const PPL::Coefficient& x_reverse_scaling = x.first.second; + const pair_type& + operator()(pair_type& x, const pair_type& y) const { + PPL::Coefficient& x_scaling = x.first.first; + PPL::Coefficient& x_reverse_scaling = x.first.second; + PPL::Sparse_Row& x_row = x.second; const PPL::Coefficient& y_scaling = y.first.first; const PPL::Coefficient& y_reverse_scaling = y.first.second; + const PPL::Sparse_Row& y_row = y.second; PPL_ASSERT(x_scaling != 0); PPL_ASSERT(x_reverse_scaling != 0); PPL_ASSERT(y_scaling != 0); PPL_ASSERT(y_reverse_scaling != 0); - const PPL::Sparse_Row& y_row = y.second; - PPL::Coefficient& scaling = result.first.first; - PPL::Coefficient& reverse_scaling = result.first.second; - PPL::Sparse_Row& row = result.second; PPL::Coefficient x_normalized_scaling = x_scaling * y_reverse_scaling; PPL::Coefficient y_normalized_scaling = y_scaling * x_reverse_scaling; @@ -606,19 +603,20 @@ struct compute_working_cost_reducer_functor { PPL::exact_div_assign(x_normalized_scaling, x_normalized_scaling, gcd); PPL::exact_div_assign(y_normalized_scaling, y_normalized_scaling, gcd); - scaling *= y_scaling; - reverse_scaling = gcd; - PPL_ASSERT(scaling != 0); - PPL_ASSERT(reverse_scaling != 0); - PPL::normalize2(scaling, reverse_scaling, scaling, reverse_scaling); - PPL_ASSERT(scaling != 0); - PPL_ASSERT(reverse_scaling != 0); - - PPL::dimension_type n = x.second.size(); - PPL::Dense_Row tmp(n, PPL::Row_Flags()); - row.linear_combine(y_row, y_normalized_scaling, x_normalized_scaling); - // TODO: Check if the copy can be avoided. - return result; + x_scaling *= y_scaling; + x_reverse_scaling = gcd; + + x_row.linear_combine(y_row, y_normalized_scaling, x_normalized_scaling); + + x_row.normalize(gcd); + x_reverse_scaling *= gcd; + + PPL::normalize2(x_scaling, x_reverse_scaling, + x_scaling, x_reverse_scaling); + + // This return is needed because mpi::reduce() requires it. + // x will be assigned to itself, so the data will not be copied. + return x; } };

1 0

[GIT] ppl/ppl(MPI): Distributed_Sparse_Matrix: add TODO.
by Marco Poletti 10 Sep '10

10 Sep '10

Module: ppl/ppl Branch: MPI Commit: dc2fc3585c8459ca6383271c2b442ae3eff56430 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=dc2fc3585c84… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Fri Sep 10 17:46:07 2010 +0200 Distributed_Sparse_Matrix: add TODO. --- src/Distributed_Sparse_Matrix.cc | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/Distributed_Sparse_Matrix.cc b/src/Distributed_Sparse_Matrix.cc index bff6c62..3b44eaf 100644 --- a/src/Distributed_Sparse_Matrix.cc +++ b/src/Distributed_Sparse_Matrix.cc @@ -763,6 +763,8 @@ PPL::Distributed_Sparse_Matrix::linear_combine_with_base_rows__common( i != i_end; ++i) row_k[i.index()] += global_reverse_scaling * *i; + // TODO: row_k seems to be already normalized, check whether this can be + // removed or not. row_k.normalize(); }

1 0

[GIT] ppl/ppl(MPI): Init: call MPI_Init and MPI_Finalize directly, instead of using an mpi::environment, avoiding crashes on some systems.
by Marco Poletti 10 Sep '10

10 Sep '10

Module: ppl/ppl Branch: MPI Commit: 4b615df4b01f520c6a3f67ccd2af4dfe7db19670 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4b615df4b01f… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Fri Sep 10 12:01:54 2010 +0200 Init: call MPI_Init and MPI_Finalize directly, instead of using an mpi::environment, avoiding crashes on some systems. --- src/Init.cc | 11 +++++------ src/Init.defs.hh | 1 - 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/Init.cc b/src/Init.cc index c5eaf18..1c4a9d6 100644 --- a/src/Init.cc +++ b/src/Init.cc @@ -52,8 +52,7 @@ unsigned int PPL::Init::count = 0; PPL::fpu_rounding_direction_type PPL::Init::old_rounding_direction; #if USE_PPL_DISTRIBUTED_SPARSE_MATRIX -boost::mpi::communicator* PPL::Init::mpi_communicator; -boost::mpi::environment* PPL::Init::mpi_environment; +boost::mpi::communicator* PPL::Init::mpi_communicator = NULL; #endif // USE_PPL_DISTRIBUTED_SPARSE_MATRIX extern "C" void @@ -189,11 +188,11 @@ PPL::Init::Init() { #if USE_PPL_DISTRIBUTED_SPARSE_MATRIX // Initialize MPI - int fake_argc = 0; + int fake_argc = 1; char c = '\0'; char *fake_argv0 = &c; char **fake_argv = &fake_argv0; - mpi_environment = new boost::mpi::environment(fake_argc, fake_argv); + MPI_Init(&fake_argc, &fake_argv); mpi_communicator = new boost::mpi::communicator(); if (mpi_communicator->rank() == 0) { Distributed_Sparse_Matrix::init_root(*mpi_communicator); @@ -201,7 +200,7 @@ PPL::Init::Init() { // WARNING: worker nodes will block here until process termination Distributed_Sparse_Matrix::worker_main_loop(*mpi_communicator); delete mpi_communicator; - delete mpi_environment; + MPI_Finalize(); exit(0); } #endif // USE_PPL_DISTRIBUTED_SPARSE_MATRIX @@ -215,7 +214,7 @@ PPL::Init::~Init() { // Release MPI resources. Distributed_Sparse_Matrix::quit_workers(); delete mpi_communicator; - delete mpi_environment; + MPI_Finalize(); #endif // USE_PPL_DISTRIBUTED_SPARSE_MATRIX #if PPL_CAN_CONTROL_FPU diff --git a/src/Init.defs.hh b/src/Init.defs.hh index 7df6a7e..f9f2ed3 100644 --- a/src/Init.defs.hh +++ b/src/Init.defs.hh @@ -86,7 +86,6 @@ private: static fpu_rounding_direction_type old_rounding_direction; #if USE_PPL_DISTRIBUTED_SPARSE_MATRIX static boost::mpi::communicator* mpi_communicator; - static boost::mpi::environment* mpi_environment; #endif friend void set_rounding_for_PPL();

1 0

[GIT] ppl/ppl(ppl-0_11-branch): Reflected the changes in http://gcc.gnu.org /bugzilla/show_bug.cgi?id=8966
by Roberto Bagnara 09 Sep '10

09 Sep '10

Module: ppl/ppl Branch: ppl-0_11-branch Commit: 71babe653a3099830e9cb3b37ea52be8925f88b6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=71babe653a30… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Sep 9 15:13:48 2010 +0200 Reflected the changes in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8966 Reflected the changes in gcc.gnu.org/bugzilla/show_bug.cgi?id=8966 --- README.alpha | 5 +++-- tests/BD_Shape/disjoint1.cc | 3 --- tests/Box/congruences1.cc | 3 --- tests/Box/max_min1.cc | 3 --- tests/Box/relations4.cc | 3 --- tests/Grid/addcongruences1.cc | 3 --- tests/MIP_Problem/exceptions1.cc | 3 --- tests/Octagonal_Shape/affineimage1.cc | 3 --- tests/Octagonal_Shape/boundedaffineimage1.cc | 3 --- tests/Octagonal_Shape/cc76extrapolation1.cc | 3 --- tests/Octagonal_Shape/difference1.cc | 3 --- tests/Octagonal_Shape/disjoint1.cc | 3 --- tests/Octagonal_Shape/generalizedaffineimage3.cc | 3 --- .../Octagonal_Shape/generalizedaffinepreimage2.cc | 3 --- .../Octagonal_Shape/generalizedaffinepreimage3.cc | 3 --- tests/Octagonal_Shape/unconstrain1.cc | 3 --- tests/Polyhedron/exceptions2.cc | 3 --- 17 files changed, 3 insertions(+), 50 deletions(-) diff --git a/README.alpha b/README.alpha index 15ce29a..fca425c 100644 --- a/README.alpha +++ b/README.alpha @@ -1,5 +1,6 @@ -There appears to be a bug in GCC (all versions) concerning exception -handling on the Alpha. This may be related to +There appears to be a bug in GCC (all versions up to and including +4.3.x) concerning exception handling on the Alpha. This may be +related to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8966 diff --git a/tests/BD_Shape/disjoint1.cc b/tests/BD_Shape/disjoint1.cc index 3214d4c..1da81e7 100644 --- a/tests/BD_Shape/disjoint1.cc +++ b/tests/BD_Shape/disjoint1.cc @@ -185,10 +185,7 @@ BEGIN_MAIN DO_TEST(test01); DO_TEST(test02); DO_TEST(test03); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test04); -#endif DO_TEST(test05); DO_TEST(test06); DO_TEST(test07); diff --git a/tests/Box/congruences1.cc b/tests/Box/congruences1.cc index 48e52f8..c7250a9 100644 --- a/tests/Box/congruences1.cc +++ b/tests/Box/congruences1.cc @@ -372,9 +372,6 @@ BEGIN_MAIN DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test14); -#endif DO_TEST(test15); END_MAIN diff --git a/tests/Box/max_min1.cc b/tests/Box/max_min1.cc index 19e37bd..7255326 100644 --- a/tests/Box/max_min1.cc +++ b/tests/Box/max_min1.cc @@ -749,10 +749,7 @@ BEGIN_MAIN DO_TEST(test09); DO_TEST(test10); DO_TEST(test11); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test12); -#endif DO_TEST(test13); DO_TEST(test14); DO_TEST(test15); diff --git a/tests/Box/relations4.cc b/tests/Box/relations4.cc index e040f6d..476275a 100644 --- a/tests/Box/relations4.cc +++ b/tests/Box/relations4.cc @@ -480,9 +480,6 @@ BEGIN_MAIN DO_TEST(test16); DO_TEST(test17); DO_TEST(test18); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test19); -#endif DO_TEST(test20); END_MAIN diff --git a/tests/Grid/addcongruences1.cc b/tests/Grid/addcongruences1.cc index f14e2b7..e58e509 100644 --- a/tests/Grid/addcongruences1.cc +++ b/tests/Grid/addcongruences1.cc @@ -322,10 +322,7 @@ BEGIN_MAIN DO_TEST(test03); DO_TEST(test04); DO_TEST(test05); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test06); -#endif DO_TEST(test07); DO_TEST(test08); DO_TEST(test09); diff --git a/tests/MIP_Problem/exceptions1.cc b/tests/MIP_Problem/exceptions1.cc index fc87e49..524f655 100644 --- a/tests/MIP_Problem/exceptions1.cc +++ b/tests/MIP_Problem/exceptions1.cc @@ -485,8 +485,6 @@ test19() { } // namespace BEGIN_MAIN -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test01); DO_TEST(test02); DO_TEST(test03); @@ -506,5 +504,4 @@ BEGIN_MAIN DO_TEST(test17); DO_TEST(test18); DO_TEST(test19); -#endif END_MAIN diff --git a/tests/Octagonal_Shape/affineimage1.cc b/tests/Octagonal_Shape/affineimage1.cc index dba2a25..cdb850b 100644 --- a/tests/Octagonal_Shape/affineimage1.cc +++ b/tests/Octagonal_Shape/affineimage1.cc @@ -505,10 +505,7 @@ BEGIN_MAIN DO_TEST(test07); DO_TEST(test08); DO_TEST(test09); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test10); -#endif DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); diff --git a/tests/Octagonal_Shape/boundedaffineimage1.cc b/tests/Octagonal_Shape/boundedaffineimage1.cc index 8133a45..785195d 100644 --- a/tests/Octagonal_Shape/boundedaffineimage1.cc +++ b/tests/Octagonal_Shape/boundedaffineimage1.cc @@ -595,10 +595,7 @@ BEGIN_MAIN DO_TEST(test13); DO_TEST(test14); DO_TEST(test15); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test16); DO_TEST(test17); -#endif DO_TEST(test18); END_MAIN diff --git a/tests/Octagonal_Shape/cc76extrapolation1.cc b/tests/Octagonal_Shape/cc76extrapolation1.cc index 3c5c42e..eb92fd3 100644 --- a/tests/Octagonal_Shape/cc76extrapolation1.cc +++ b/tests/Octagonal_Shape/cc76extrapolation1.cc @@ -508,10 +508,7 @@ BEGIN_MAIN DO_TEST(test07); DO_TEST(test08); DO_TEST(test09); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test10); -#endif DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); diff --git a/tests/Octagonal_Shape/difference1.cc b/tests/Octagonal_Shape/difference1.cc index 65e52f2..0227fa5 100644 --- a/tests/Octagonal_Shape/difference1.cc +++ b/tests/Octagonal_Shape/difference1.cc @@ -249,10 +249,7 @@ BEGIN_MAIN DO_TEST(test01); DO_TEST(test02); DO_TEST(test03); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test04); -#endif DO_TEST(test05); DO_TEST(test06); DO_TEST(test07); diff --git a/tests/Octagonal_Shape/disjoint1.cc b/tests/Octagonal_Shape/disjoint1.cc index 953c1f9..f588a8c 100644 --- a/tests/Octagonal_Shape/disjoint1.cc +++ b/tests/Octagonal_Shape/disjoint1.cc @@ -184,9 +184,6 @@ BEGIN_MAIN DO_TEST(test03); DO_TEST(test04); DO_TEST(test05); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test06); -#endif DO_TEST(test07); END_MAIN diff --git a/tests/Octagonal_Shape/generalizedaffineimage3.cc b/tests/Octagonal_Shape/generalizedaffineimage3.cc index e4202f9..30c18c4 100644 --- a/tests/Octagonal_Shape/generalizedaffineimage3.cc +++ b/tests/Octagonal_Shape/generalizedaffineimage3.cc @@ -579,8 +579,6 @@ BEGIN_MAIN DO_TEST(test08); DO_TEST(test09); DO_TEST(test10); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); @@ -589,7 +587,6 @@ BEGIN_MAIN DO_TEST(test16); DO_TEST(test17); DO_TEST(test18); -#endif DO_TEST(test19); DO_TEST(test20); END_MAIN diff --git a/tests/Octagonal_Shape/generalizedaffinepreimage2.cc b/tests/Octagonal_Shape/generalizedaffinepreimage2.cc index f85c444..a95867d 100644 --- a/tests/Octagonal_Shape/generalizedaffinepreimage2.cc +++ b/tests/Octagonal_Shape/generalizedaffinepreimage2.cc @@ -596,10 +596,7 @@ test20() { } // namespace BEGIN_MAIN -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test01); -#endif DO_TEST(test02); DO_TEST(test03); DO_TEST(test04); diff --git a/tests/Octagonal_Shape/generalizedaffinepreimage3.cc b/tests/Octagonal_Shape/generalizedaffinepreimage3.cc index 653c390..62218fa 100644 --- a/tests/Octagonal_Shape/generalizedaffinepreimage3.cc +++ b/tests/Octagonal_Shape/generalizedaffinepreimage3.cc @@ -597,10 +597,7 @@ BEGIN_MAIN DO_TEST(test01); DO_TEST(test02); DO_TEST(test03); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test04); -#endif DO_TEST(test05); DO_TEST(test06); DO_TEST(test07); diff --git a/tests/Octagonal_Shape/unconstrain1.cc b/tests/Octagonal_Shape/unconstrain1.cc index 96d130f..c34e5d8 100644 --- a/tests/Octagonal_Shape/unconstrain1.cc +++ b/tests/Octagonal_Shape/unconstrain1.cc @@ -222,10 +222,7 @@ BEGIN_MAIN DO_TEST(test04); DO_TEST(test05); DO_TEST(test06); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test07); -#endif DO_TEST(test08); DO_TEST(test09); END_MAIN diff --git a/tests/Polyhedron/exceptions2.cc b/tests/Polyhedron/exceptions2.cc index 8a0a2ed..38c2370 100644 --- a/tests/Polyhedron/exceptions2.cc +++ b/tests/Polyhedron/exceptions2.cc @@ -893,10 +893,7 @@ BEGIN_MAIN DO_TEST(test16); DO_TEST(test17); DO_TEST(test18); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test19); -#endif DO_TEST(test20); DO_TEST(test21); DO_TEST(test22);

1 0

Problems with test suite on alpha
by Michael Tautschnig 09 Sep '10

09 Sep '10

Hi PPL developers, I've reported problems with some test cases because of suspected gcc bugs on alpha earlier already. Now it seems that even more test cases are broken, most probably because of the very same bug (I suspect it to be http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8966). My question now is: How to proceed? Shall I specifically disable the failing test cases by surrounding them with an #ifndef __alpha__ or disable the entire test suite on alpha? Thanks, Michael

2 6

[GIT] ppl/ppl(master): Reflected the changes in http://gcc.gnu.org/bugzilla /show_bug.cgi?id=8966
by Roberto Bagnara 09 Sep '10

09 Sep '10

Module: ppl/ppl Branch: master Commit: ad3694d4bbf7a930d3d262568487cce8066f55fd URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ad3694d4bbf7… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Thu Sep 9 17:13:48 2010 +0200 Reflected the changes in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8966 --- README.alpha | 5 +++-- tests/BD_Shape/disjoint1.cc | 3 --- tests/Box/congruences1.cc | 3 --- tests/Box/max_min1.cc | 3 --- tests/Box/relations4.cc | 3 --- tests/Grid/addcongruences1.cc | 3 --- tests/MIP_Problem/exceptions1.cc | 3 --- tests/Octagonal_Shape/affineimage1.cc | 3 --- tests/Octagonal_Shape/boundedaffineimage1.cc | 3 --- tests/Octagonal_Shape/cc76extrapolation1.cc | 3 --- tests/Octagonal_Shape/difference1.cc | 3 --- tests/Octagonal_Shape/disjoint1.cc | 3 --- tests/Octagonal_Shape/generalizedaffineimage3.cc | 3 --- .../Octagonal_Shape/generalizedaffinepreimage2.cc | 3 --- .../Octagonal_Shape/generalizedaffinepreimage3.cc | 3 --- tests/Octagonal_Shape/unconstrain1.cc | 3 --- tests/Polyhedron/exceptions2.cc | 3 --- 17 files changed, 3 insertions(+), 50 deletions(-) diff --git a/README.alpha b/README.alpha index 15ce29a..fca425c 100644 --- a/README.alpha +++ b/README.alpha @@ -1,5 +1,6 @@ -There appears to be a bug in GCC (all versions) concerning exception -handling on the Alpha. This may be related to +There appears to be a bug in GCC (all versions up to and including +4.3.x) concerning exception handling on the Alpha. This may be +related to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8966 diff --git a/tests/BD_Shape/disjoint1.cc b/tests/BD_Shape/disjoint1.cc index 3214d4c..1da81e7 100644 --- a/tests/BD_Shape/disjoint1.cc +++ b/tests/BD_Shape/disjoint1.cc @@ -185,10 +185,7 @@ BEGIN_MAIN DO_TEST(test01); DO_TEST(test02); DO_TEST(test03); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test04); -#endif DO_TEST(test05); DO_TEST(test06); DO_TEST(test07); diff --git a/tests/Box/congruences1.cc b/tests/Box/congruences1.cc index 48e52f8..c7250a9 100644 --- a/tests/Box/congruences1.cc +++ b/tests/Box/congruences1.cc @@ -372,9 +372,6 @@ BEGIN_MAIN DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test14); -#endif DO_TEST(test15); END_MAIN diff --git a/tests/Box/max_min1.cc b/tests/Box/max_min1.cc index 19e37bd..7255326 100644 --- a/tests/Box/max_min1.cc +++ b/tests/Box/max_min1.cc @@ -749,10 +749,7 @@ BEGIN_MAIN DO_TEST(test09); DO_TEST(test10); DO_TEST(test11); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test12); -#endif DO_TEST(test13); DO_TEST(test14); DO_TEST(test15); diff --git a/tests/Box/relations4.cc b/tests/Box/relations4.cc index e040f6d..476275a 100644 --- a/tests/Box/relations4.cc +++ b/tests/Box/relations4.cc @@ -480,9 +480,6 @@ BEGIN_MAIN DO_TEST(test16); DO_TEST(test17); DO_TEST(test18); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test19); -#endif DO_TEST(test20); END_MAIN diff --git a/tests/Grid/addcongruences1.cc b/tests/Grid/addcongruences1.cc index f14e2b7..e58e509 100644 --- a/tests/Grid/addcongruences1.cc +++ b/tests/Grid/addcongruences1.cc @@ -322,10 +322,7 @@ BEGIN_MAIN DO_TEST(test03); DO_TEST(test04); DO_TEST(test05); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test06); -#endif DO_TEST(test07); DO_TEST(test08); DO_TEST(test09); diff --git a/tests/MIP_Problem/exceptions1.cc b/tests/MIP_Problem/exceptions1.cc index fc87e49..524f655 100644 --- a/tests/MIP_Problem/exceptions1.cc +++ b/tests/MIP_Problem/exceptions1.cc @@ -485,8 +485,6 @@ test19() { } // namespace BEGIN_MAIN -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test01); DO_TEST(test02); DO_TEST(test03); @@ -506,5 +504,4 @@ BEGIN_MAIN DO_TEST(test17); DO_TEST(test18); DO_TEST(test19); -#endif END_MAIN diff --git a/tests/Octagonal_Shape/affineimage1.cc b/tests/Octagonal_Shape/affineimage1.cc index dba2a25..cdb850b 100644 --- a/tests/Octagonal_Shape/affineimage1.cc +++ b/tests/Octagonal_Shape/affineimage1.cc @@ -505,10 +505,7 @@ BEGIN_MAIN DO_TEST(test07); DO_TEST(test08); DO_TEST(test09); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test10); -#endif DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); diff --git a/tests/Octagonal_Shape/boundedaffineimage1.cc b/tests/Octagonal_Shape/boundedaffineimage1.cc index 8133a45..785195d 100644 --- a/tests/Octagonal_Shape/boundedaffineimage1.cc +++ b/tests/Octagonal_Shape/boundedaffineimage1.cc @@ -595,10 +595,7 @@ BEGIN_MAIN DO_TEST(test13); DO_TEST(test14); DO_TEST(test15); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test16); DO_TEST(test17); -#endif DO_TEST(test18); END_MAIN diff --git a/tests/Octagonal_Shape/cc76extrapolation1.cc b/tests/Octagonal_Shape/cc76extrapolation1.cc index 3c5c42e..eb92fd3 100644 --- a/tests/Octagonal_Shape/cc76extrapolation1.cc +++ b/tests/Octagonal_Shape/cc76extrapolation1.cc @@ -508,10 +508,7 @@ BEGIN_MAIN DO_TEST(test07); DO_TEST(test08); DO_TEST(test09); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test10); -#endif DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); diff --git a/tests/Octagonal_Shape/difference1.cc b/tests/Octagonal_Shape/difference1.cc index 65e52f2..0227fa5 100644 --- a/tests/Octagonal_Shape/difference1.cc +++ b/tests/Octagonal_Shape/difference1.cc @@ -249,10 +249,7 @@ BEGIN_MAIN DO_TEST(test01); DO_TEST(test02); DO_TEST(test03); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test04); -#endif DO_TEST(test05); DO_TEST(test06); DO_TEST(test07); diff --git a/tests/Octagonal_Shape/disjoint1.cc b/tests/Octagonal_Shape/disjoint1.cc index 953c1f9..f588a8c 100644 --- a/tests/Octagonal_Shape/disjoint1.cc +++ b/tests/Octagonal_Shape/disjoint1.cc @@ -184,9 +184,6 @@ BEGIN_MAIN DO_TEST(test03); DO_TEST(test04); DO_TEST(test05); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test06); -#endif DO_TEST(test07); END_MAIN diff --git a/tests/Octagonal_Shape/generalizedaffineimage3.cc b/tests/Octagonal_Shape/generalizedaffineimage3.cc index e4202f9..30c18c4 100644 --- a/tests/Octagonal_Shape/generalizedaffineimage3.cc +++ b/tests/Octagonal_Shape/generalizedaffineimage3.cc @@ -579,8 +579,6 @@ BEGIN_MAIN DO_TEST(test08); DO_TEST(test09); DO_TEST(test10); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test11); DO_TEST(test12); DO_TEST(test13); @@ -589,7 +587,6 @@ BEGIN_MAIN DO_TEST(test16); DO_TEST(test17); DO_TEST(test18); -#endif DO_TEST(test19); DO_TEST(test20); END_MAIN diff --git a/tests/Octagonal_Shape/generalizedaffinepreimage2.cc b/tests/Octagonal_Shape/generalizedaffinepreimage2.cc index f85c444..a95867d 100644 --- a/tests/Octagonal_Shape/generalizedaffinepreimage2.cc +++ b/tests/Octagonal_Shape/generalizedaffinepreimage2.cc @@ -596,10 +596,7 @@ test20() { } // namespace BEGIN_MAIN -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test01); -#endif DO_TEST(test02); DO_TEST(test03); DO_TEST(test04); diff --git a/tests/Octagonal_Shape/generalizedaffinepreimage3.cc b/tests/Octagonal_Shape/generalizedaffinepreimage3.cc index 653c390..62218fa 100644 --- a/tests/Octagonal_Shape/generalizedaffinepreimage3.cc +++ b/tests/Octagonal_Shape/generalizedaffinepreimage3.cc @@ -597,10 +597,7 @@ BEGIN_MAIN DO_TEST(test01); DO_TEST(test02); DO_TEST(test03); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test04); -#endif DO_TEST(test05); DO_TEST(test06); DO_TEST(test07); diff --git a/tests/Octagonal_Shape/unconstrain1.cc b/tests/Octagonal_Shape/unconstrain1.cc index 96d130f..c34e5d8 100644 --- a/tests/Octagonal_Shape/unconstrain1.cc +++ b/tests/Octagonal_Shape/unconstrain1.cc @@ -222,10 +222,7 @@ BEGIN_MAIN DO_TEST(test04); DO_TEST(test05); DO_TEST(test06); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test07); -#endif DO_TEST(test08); DO_TEST(test09); END_MAIN diff --git a/tests/Polyhedron/exceptions2.cc b/tests/Polyhedron/exceptions2.cc index 8a0a2ed..38c2370 100644 --- a/tests/Polyhedron/exceptions2.cc +++ b/tests/Polyhedron/exceptions2.cc @@ -893,10 +893,7 @@ BEGIN_MAIN DO_TEST(test16); DO_TEST(test17); DO_TEST(test18); -#ifndef __alpha__ - // Exception handling is broken in GCC on the Alpha. DO_TEST(test19); -#endif DO_TEST(test20); DO_TEST(test21); DO_TEST(test22);

1 0

[GIT] ppl/ppl(master): MIP_Problem: don' t copy Coefficient objects to cache accesses, in steepest_edge_exact_entering_index().
by Marco Poletti 09 Sep '10

09 Sep '10

Module: ppl/ppl Branch: master Commit: 4974d4f39e8c674119b8ec0423fc5e5da918b0b4 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4974d4f39e8c… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Thu Sep 9 08:25:24 2010 +0200 MIP_Problem: don't copy Coefficient objects to cache accesses, in steepest_edge_exact_entering_index(). --- src/MIP_Problem.cc | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index c122db4..882af9e 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -1089,14 +1089,11 @@ PPL::MIP_Problem::steepest_edge_exact_entering_index() const { // Compute the lcm of all the coefficients of variables in base. PPL_DIRTY_TEMP_COEFFICIENT(lcm_basis); lcm_basis = 1; - std::vector<Coefficient> tableau_base(tableau_num_rows); - for (dimension_type i = tableau_num_rows; i-- > 0; ) { - tableau_base[i] = tableau[i].get(base[i]); - lcm_assign(lcm_basis, lcm_basis, tableau_base[i]); - } + for (dimension_type i = tableau_num_rows; i-- > 0; ) + lcm_assign(lcm_basis, lcm_basis, tableau[i].get(base[i])); // Compute normalization factors. for (dimension_type i = tableau_num_rows; i-- > 0; ) - exact_div_assign(norm_factor[i], lcm_basis, tableau_base[i]); + exact_div_assign(norm_factor[i], lcm_basis, tableau[i].get(base[i])); // Compute the square of `lcm_basis', exploiting the fact that // `lcm_basis' will no longer be needed. lcm_basis *= lcm_basis;

1 0

[GIT] ppl/ppl(MPI): New commits
by Roberto Bagnara 08 Sep '10

08 Sep '10

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9176d26db689… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 22:54:39 2010 +0200 Distributed_Sparse_Matrix: store a copy of the appropriate part of reverse_row_mapping in each worker node. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0fede9dc32bc… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 21:22:41 2010 +0200 Distribute_Sparse_Matrix: move code common to the root node and worker nodes from set_artificial_indexes_for_unfeasible_rows() into set_artificial_indexes_for_unfeasible_rows__common(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d572b72f052b… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 21:12:11 2010 +0200 Distribute_Sparse_Matrix: move code common to the root node and worker nodes from swap_rows() into swap_rows__common(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c915e23ac683… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 20:52:52 2010 +0200 Distributed_Sparse_Matrix: remove linear_combine_some() and linear_combine_with() methods. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=598fa93254e3… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 20:47:23 2010 +0200 Distributed_Sparse_Row: move some code into make_inhomogeneous_terms_nonpositive__common(). Reorder existing code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f959bfe4255b… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 20:18:39 2010 +0200 Distributed_Sparse_Matrix: optimize linear_combine_matrix() and move code common to root and worker nodes into linear_combine_matrix__common(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=49892ed05d9f… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 18:07:29 2010 +0200 Distributed_Sparse_Matrix: remove useless temporary variables, in linear_combine(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4e47bdce47c6… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 17:40:11 2010 +0200 Distributed_Sparse_Matrix: declare incremental_linear_combine() as a template instead of declaring it for both Dense_Row and Sparse_Row. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5a4f781affaf… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 17:32:45 2010 +0200 Distribute_Sparse_Matrix: move code common to the root node and worker nodes from compute_working_cost() into compute_working_cost__common().

1 0

[GIT] ppl/ppl(MPI): New commits
by Roberto Bagnara 08 Sep '10

08 Sep '10

URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6f3b66c3082b… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 17:16:54 2010 +0200 MIP_Problem: use the new Sparse_Row::linear_combine() method, simplifying code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=db419c5a19d7… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 17:15:58 2010 +0200 Distributed_Sparse_Matrix: use the new Sparse_Row::linear_combine() method, simplifying code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=655f8c56d871… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 17:15:07 2010 +0200 Sparse_Row: add a convenience linear_combine() method. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5c7337837921… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 16:53:04 2010 +0200 Distributed_Sparse_Matrix: add sum_of_products_combiner class and use it to simplify and share code. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f3b393b41fcf… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 16:29:46 2010 +0200 MIP_Problem: use Distributed_Sparse_Matrix::linear_combine_with_base_rows(). URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=4563e4eeb5eb… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 16:29:09 2010 +0200 Distributed_Sparse_Matrix: add some assertions. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6ea8fd1ea0e2… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 16:28:42 2010 +0200 Distributed_Sparse_Matrix: add a linear_combine_with_base_rows() method. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d5fb40f15c2d… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 12:17:59 2010 +0200 Distributed_Sparse_Matrix: optimize compute_working_cost(), greatly increasing performance. URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=dd87503e6564… Author: Marco Poletti <poletti.marco(a)gmail.com> Date: Wed Sep 8 12:16:57 2010 +0200 Sparse_Row: add a normalize() method that takes a Coefficient&.

1 0

[GIT] ppl/ppl(ppl-0_11-branch): Mentioned the fix to Interval::Interval( const char*).
by Roberto Bagnara 08 Sep '10

08 Sep '10

Module: ppl/ppl Branch: ppl-0_11-branch Commit: 6d7114d091eefdf7b1201876e04f54e21793fea6 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=6d7114d091ee… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Wed Sep 8 05:31:19 2010 +0200 Mentioned the fix to Interval::Interval(const char*). Mentioned the fix to Interval::Interval(const char*). --- NEWS | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index e884a40..76dce77 100644 --- a/NEWS +++ b/NEWS @@ -21,6 +21,13 @@ o Corrected a bug affecting methods whereby a lower bound would not be computed correctly when the two iterators specify an empty list of stop points. +o Fixed a bug affecting + + Interval::Interval(const char* s) + + whereby a wrong interval would be constructed if `s' denotes a number + that can only be represented as an infinity. + -------------------------------------------------------------------------- NEWS for version 0.11 (released on August 2, 2010)

1 0