- PPL-devel - BUGSENG Mailman

A Python wrapper for PPL
by Vincent Delecroix 17 Jan '16

17 Jan '16

Dear ppl developers, As I needed it, I isolated the Python wrapper for PPL from the Sage project [1] as a standalone Python package. It can be found here https://github.com/videlec/pplpy https://pypi.python.org/pypi/pplpy/ Any remark or comment is very welcome. Thanks for this very efficient library! All best, Vincent [1] http://sagemath.org

2 1

[GIT] ppl/ppl(devel): Merge branch 'master' into devel.
by Roberto Bagnara 03 Jan '16

03 Jan '16

Module: ppl/ppl Branch: devel Commit: 5525b05b000cfbcff748059f82e86e093c85407f URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5525b05b000c… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sun Jan 3 15:08:56 2016 +0100 Merge branch 'master' into devel. ---

1 0

[GIT] ppl/ppl(devel): Extended copyright years.
by Roberto Bagnara 03 Jan '16

03 Jan '16

1 0

[GIT] ppl/ppl(devel): Adapted to SWI-Prolog version 7.x.
by Roberto Bagnara 03 Jan '16

03 Jan '16

Module: ppl/ppl Branch: devel Commit: c9b20bc27d2a9931f131b6c3350eadf3c7f33405 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=c9b20bc27d2a… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Tue Nov 24 10:05:32 2015 +0100 Adapted to SWI-Prolog version 7.x. --- interfaces/Prolog/SWI/pl_clpq.pl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/interfaces/Prolog/SWI/pl_clpq.pl b/interfaces/Prolog/SWI/pl_clpq.pl index 3b87de4..ca1854f 100644 --- a/interfaces/Prolog/SWI/pl_clpq.pl +++ b/interfaces/Prolog/SWI/pl_clpq.pl @@ -21,7 +21,8 @@ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA. For the most up-to-date information see the Parma Polyhedra Library site: http://bugseng.com/products/ppl/ . */ -eat_eol. +eat_eol :- + get_code(user_input, _EOL). main :- % FIXME: clearing the prompt as it is done here is a temporary workaround.

1 0

[GIT] ppl/ppl(devel): Warnings avoided.
by Roberto Bagnara 03 Jan '16

03 Jan '16

Module: ppl/ppl Branch: devel Commit: 142a58fa623e5b875efa4bd73f1071688a38f0ed URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=142a58fa623e… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Tue Nov 24 10:05:15 2015 +0100 Warnings avoided. --- ...face_generator_prolog_generated_test_pl_code.m4 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/interfaces/Prolog/tests/ppl_interface_generator_prolog_generated_test_pl_code.m4 b/interfaces/Prolog/tests/ppl_interface_generator_prolog_generated_test_pl_code.m4 index 7b553e3..b2f7c32 100644 --- a/interfaces/Prolog/tests/ppl_interface_generator_prolog_generated_test_pl_code.m4 +++ b/interfaces/Prolog/tests/ppl_interface_generator_prolog_generated_test_pl_code.m4 @@ -947,7 +947,7 @@ ppl_@CLASS@_frequency_6_test :- F_N == F_Nexptd, F_D == F_Dexptd, V_N == V_Nexptd, V_D == V_Dexptd) ; - \+ ppl_@CLASS@_frequency(PS, LE, F_N, F_D, V_N, V_D) + \+ ppl_@CLASS@_frequency(PS, LE, _F_N, _F_D, _V_N, _V_D) ), ppl_@CLASS@_OK(PS), ppl_delete_@CLASS@(PS)

1 0

[GIT] ppl/ppl(master): Extended copyright years.
by Roberto Bagnara 03 Jan '16

03 Jan '16

1 0

Question on Merging Two Dimensions in a NNC_Polyhedron.
by Li Li 12 Dec '15

12 Dec '15

Dear Sir/Madam, Thank you for developing such a great library. I am currently learning how to use it. I have a question as follows. Could you give me some suggestions? The question is as follows. Given a NNC_Polyhedron, I want to merge two dimensions in it, say dim1 and dim2. Then, my current code is _polyhedron.add_constraint(PPL::Variable(dim1) == PPL::Variable(dim2)); > _polyhedron.remove_space_dimensions( > PPL::Variables_Set( > PPL::Variable(dim1) > ) > ); When _polyhedron is very large, say 60 dimensions, the merging operation becomes extremely slow. Is there a better way to merge dimensions? There is a operation called fold_space_dimensions. But I am not sure about its effect. Thank you very much! Best Regards, Li Li -- ( Dr ) Li Li Email : lilissun(a)gmail.com iTrust, Singapore University of Technology and Design

1 0

[GIT] ppl/ppl(devel): Avoid a memory leak due to the global list of dirty temporaries.
by Enea Zaffanella 26 Nov '15

26 Nov '15

Module: ppl/ppl Branch: devel Commit: cc65f4c19ad8d6e8005e76605c4dd8f62679c0eb URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cc65f4c19ad8… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Nov 26 12:31:01 2015 +0100 Avoid a memory leak due to the global list of dirty temporaries. The memory leak was not causing a real problem, in that the list of dirty temporaries is meant to survive up to the end of the process. However, it could cause a problem if/when the library is extended to become multi-thread safe, since in such a scenario it is meaningful to have a list of dirty temporaries for each thread (to be released on thread exit). --- src/Temp_defs.hh | 14 +++++++++++++- src/Temp_inlines.hh | 23 ++++++++++++++++++----- src/Temp_templates.hh | 8 +++++++- 3 files changed, 38 insertions(+), 7 deletions(-) diff --git a/src/Temp_defs.hh b/src/Temp_defs.hh index 9c16020..e272397 100644 --- a/src/Temp_defs.hh +++ b/src/Temp_defs.hh @@ -51,8 +51,20 @@ private: //! Pointer to the next item in the free list. Temp_Item* next; + class Free_List { + public: + Free_List(); + ~Free_List(); + Temp_Item* head_ptr; + private: + Free_List(const Free_List&); // Not implemented. + Free_List& operator=(const Free_List&); // Not implemented. + }; // class Free_List + + friend class Free_List; + //! Head of the free list. - static Temp_Item* free_list_head; + static Temp_Item*& free_list_ref(); //! Default constructor. Temp_Item(); diff --git a/src/Temp_inlines.hh b/src/Temp_inlines.hh index 607fc0d..f357b3e 100644 --- a/src/Temp_inlines.hh +++ b/src/Temp_inlines.hh @@ -41,11 +41,24 @@ Temp_Item<T>::item() { } template <typename T> +inline +Temp_Item<T>::Free_List::Free_List() + : head_ptr(0) { +} + +template <typename T> +inline Temp_Item<T>*& +Temp_Item<T>::free_list_ref() { + static Free_List free_list; + return free_list.head_ptr; +} + +template <typename T> inline Temp_Item<T>& Temp_Item<T>::obtain() { - if (free_list_head != 0) { - Temp_Item* const p = free_list_head; - free_list_head = free_list_head->next; + Temp_Item* const p = free_list_ref(); + if (p != 0) { + free_list_ref() = p->next; return *p; } else { @@ -56,8 +69,8 @@ Temp_Item<T>::obtain() { template <typename T> inline void Temp_Item<T>::release(Temp_Item& p) { - p.next = free_list_head; - free_list_head = &p; + p.next = free_list_ref(); + free_list_ref() = &p; } template <typename T> diff --git a/src/Temp_templates.hh b/src/Temp_templates.hh index 09f6b11..40c65af 100644 --- a/src/Temp_templates.hh +++ b/src/Temp_templates.hh @@ -27,7 +27,13 @@ site: http://bugseng.com/products/ppl/ . */ namespace Parma_Polyhedra_Library { template <typename T> -Temp_Item<T>* Temp_Item<T>::free_list_head = 0; +Temp_Item<T>::Free_List::~Free_List() { + while (head_ptr != 0) { + Temp_Item* const p = head_ptr; + head_ptr = head_ptr->next; + delete p; + } +} } // namespace Parma_Polyhedra_Library

1 0

[GIT] ppl/ppl(devel): Avoid a couple of memory leaks in the C interface tests.
by Enea Zaffanella 26 Nov '15

26 Nov '15

Module: ppl/ppl Branch: devel Commit: 34499fe653764da084bf7fa70b1bc012de08882d URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=34499fe65376… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Nov 26 12:18:30 2015 +0100 Avoid a couple of memory leaks in the C interface tests. --- interfaces/C/tests/formatted_output.c | 4 ++++ interfaces/C/tests/pip_test.c | 18 ++++++++++++------ 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/interfaces/C/tests/formatted_output.c b/interfaces/C/tests/formatted_output.c index 780f2ef..679e149 100644 --- a/interfaces/C/tests/formatted_output.c +++ b/interfaces/C/tests/formatted_output.c @@ -24,6 +24,7 @@ site: http://bugseng.com/products/ppl/ . */ #include "ppl_c_test.h" #include "print_to_buffer.h" +#include <stdlib.h> #include <stdio.h> #define DIMENSION 100 @@ -58,7 +59,10 @@ main() { else printf(" %s\n", p); } + free(p); ppl_delete_Constraint_System(cs); + ppl_delete_Coefficient(coeff); ppl_finalize(); + mpz_clear(z); return 0; } diff --git a/interfaces/C/tests/pip_test.c b/interfaces/C/tests/pip_test.c index 15ac12c..1a4451f 100644 --- a/interfaces/C/tests/pip_test.c +++ b/interfaces/C/tests/pip_test.c @@ -112,6 +112,8 @@ display_solution_i(ppl_const_PIP_Tree_Node_t node, ppl_io_print_Constraint(c); notfirst = 1; } + ppl_delete_Constraint_System_const_iterator(end); + ppl_delete_Constraint_System_const_iterator(i); printf(" then\n"); } ppl_PIP_Tree_Node_as_decision(node, &dn); @@ -175,6 +177,7 @@ display_solution(ppl_const_PIP_Tree_Node_t node, int main(int argc, char **argv) { ppl_PIP_Problem_t pip; + ppl_Constraint_System_t cs; ppl_Constraint_t ct; ppl_Coefficient_t c; ppl_Linear_Expression_t le; @@ -220,6 +223,7 @@ main(int argc, char **argv) { ppl_new_PIP_Problem_from_space_dimension(&pip, N_VARS+N_PARAMETERS); ppl_PIP_Problem_add_to_parameter_space_dimensions(pip, parameter_dim, N_PARAMETERS); + ppl_new_Constraint_System(&cs); ppl_new_Coefficient(&c); for (i = 0; i < N_CONSTRAINTS; ++i) { ppl_new_Linear_Expression(&le); @@ -232,7 +236,9 @@ main(int argc, char **argv) { ppl_assign_Coefficient_from_mpz_t(c, mpc); ppl_Linear_Expression_add_to_inhomogeneous(le, c); ppl_new_Constraint(&ct, le, PPL_CONSTRAINT_TYPE_GREATER_OR_EQUAL); + ppl_Constraint_System_insert_Constraint(cs, ct); ppl_PIP_Problem_add_constraint(pip, ct); + ppl_delete_Constraint(ct); ppl_delete_Linear_Expression(le); } ppl_delete_Coefficient(c); @@ -246,7 +252,6 @@ main(int argc, char **argv) { ppl_dimension_type dim; ppl_const_PIP_Tree_Node_t solution; ppl_PIP_Problem_t pip0; - ppl_Constraint_System_t constraints; ppl_Constraint_System_const_iterator_t begin, end; ppl_PIP_Problem_space_dimension(pip, &dim); @@ -255,18 +260,19 @@ main(int argc, char **argv) { display_solution(solution, N_VARS, N_PARAMETERS, parameter_dim); ppl_new_Constraint_System_const_iterator(&begin); ppl_new_Constraint_System_const_iterator(&end); - ppl_new_Constraint_System_from_Constraint(&constraints, ct); - ppl_Constraint_System_begin(constraints, begin); - ppl_Constraint_System_end(constraints, end); + ppl_Constraint_System_begin(cs, begin); + ppl_Constraint_System_end(cs, end); ppl_new_PIP_Problem_from_constraints(&pip0, N_VARS+N_PARAMETERS, begin, end, N_PARAMETERS, parameter_dim); ok = ppl_PIP_Problem_OK(pip0); - ppl_delete_Constraint(ct); - ppl_delete_Constraint_System(constraints); + ppl_delete_PIP_Problem(pip0); + ppl_delete_Constraint_System_const_iterator(end); + ppl_delete_Constraint_System_const_iterator(begin); } ppl_delete_PIP_Problem(pip); + ppl_delete_Constraint_System(cs); ppl_finalize(); return ok ? 0 : 1; }

1 0

[GIT] ppl/ppl(devel): Get rid of temporary print previously added for debugging purposes.
by Enea Zaffanella 26 Nov '15

26 Nov '15

Module: ppl/ppl Branch: devel Commit: 44ae5b13d0584b4f3257d86b485d717a2c6dd540 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=44ae5b13d058… Author: Enea Zaffanella <zaffanella(a)cs.unipr.it> Date: Thu Nov 26 11:54:30 2015 +0100 Get rid of temporary print previously added for debugging purposes. --- src/Polyhedron_conversion_templates.hh | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/Polyhedron_conversion_templates.hh b/src/Polyhedron_conversion_templates.hh index 9bcdf4c..d1415cf 100644 --- a/src/Polyhedron_conversion_templates.hh +++ b/src/Polyhedron_conversion_templates.hh @@ -425,7 +425,6 @@ Polyhedron::conversion(Source_Linear_System& source, #ifndef NDEBUG #if PPL_QUICK_ADJ_TEST for (dimension_type i = dest_num_rows; i-- > 0; ) { - std::cerr << "sat_num_ones[" << i << "] = " << sat_num_ones[i] << "\n"; PPL_ASSERT(sat_num_ones[i] == sat[i].count_ones()); } #endif // PPL_QUICK_ADJ_TEST

1 0