- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(floating_point): Added missing inline specifier.
by Fabio Bossi 23 Jul '10

23 Jul '10

Module: ppl/ppl Branch: floating_point Commit: 9c9c1ff2fef76d9dd8fbf669cf96c349794f9df5 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=9c9c1ff2fef7… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Fri Jul 23 11:30:13 2010 +0200 Added missing inline specifier. Make check now works. --- src/Concrete_Expression.inlines.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Concrete_Expression.inlines.hh b/src/Concrete_Expression.inlines.hh index 3c9cd1e..c812919 100644 --- a/src/Concrete_Expression.inlines.hh +++ b/src/Concrete_Expression.inlines.hh @@ -73,7 +73,7 @@ Concrete_Expression_Type::bounded_integer_type_width() const { return impl.bounded_integer_type_width; } -Bounded_Integer_Type_Representation +inline Bounded_Integer_Type_Representation Concrete_Expression_Type::bounded_integer_type_representation() const { return impl.bounded_integer_type_representation; }

1 0

[GIT] ppl/ppl(floating_point): Avoid a cyclic dependency problem ( make check still doesn't work).
by Fabio Bossi 23 Jul '10

23 Jul '10

Module: ppl/ppl Branch: floating_point Commit: 0db84c97d57aa3eb8324d5b9113ca8393efa65f3 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0db84c97d57a… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Fri Jul 23 11:15:56 2010 +0200 Avoid a cyclic dependency problem (make check still doesn't work). --- src/Linear_Form.defs.hh | 2 +- src/Linear_Form.templates.hh | 1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/Linear_Form.defs.hh b/src/Linear_Form.defs.hh index f7ed492..ccb4e0f 100644 --- a/src/Linear_Form.defs.hh +++ b/src/Linear_Form.defs.hh @@ -428,6 +428,6 @@ private: }; #include "Linear_Form.inlines.hh" -#include "Linear_Form.templates.hh" +// Linear_Form.templates.hh is not included here on purpose. #endif // !defined(PPL_Linear_Form_defs_hh) diff --git a/src/Linear_Form.templates.hh b/src/Linear_Form.templates.hh index f676626..e508759 100644 --- a/src/Linear_Form.templates.hh +++ b/src/Linear_Form.templates.hh @@ -23,6 +23,7 @@ site: http://www.cs.unipr.it/ppl/ . */ #ifndef PPL_Linear_Form_templates_hh #define PPL_Linear_Form_templates_hh 1 +#include "Linear_Form.defs.hh" #include "Linear_Expression.defs.hh" #include "Box.defs.hh" #include <stdexcept>

1 0

[GIT] ppl/ppl(floating_point): Restored inclusion of Polyhedron.defs. hh to allow
by Fabio Bossi 22 Jul '10

22 Jul '10

Module: ppl/ppl Branch: floating_point Commit: 608cd868519a4b228aea86441b5bb25d0ee4fcf5 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=608cd868519a… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Thu Jul 22 15:31:36 2010 +0200 Restored inclusion of Polyhedron.defs.hh to allow compilation of Grid_public.cc. --- src/Grid.defs.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Grid.defs.hh b/src/Grid.defs.hh index bf4e617..4ee26be 100644 --- a/src/Grid.defs.hh +++ b/src/Grid.defs.hh @@ -40,7 +40,7 @@ site: http://www.cs.unipr.it/ppl/ . */ #include "Poly_Gen_Relation.defs.hh" #include "Grid_Certificate.types.hh" #include "Box.types.hh" -#include "Polyhedron.types.hh" +#include "Polyhedron.defs.hh" #include "BD_Shape.types.hh" #include "Octagonal_Shape.types.hh" #include <vector>

1 0

[GIT] ppl/ppl(floating_point): Added a FIXME note.
by Fabio Bossi 22 Jul '10

22 Jul '10

Module: ppl/ppl Branch: floating_point Commit: 1e5b8d148576252e05021bfaf76a14e14416f8c0 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1e5b8d148576… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Thu Jul 22 12:18:02 2010 +0200 Added a FIXME note. --- src/Float.templates.hh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/Float.templates.hh b/src/Float.templates.hh index ab93c35..e5bf852 100644 --- a/src/Float.templates.hh +++ b/src/Float.templates.hh @@ -33,6 +33,7 @@ const FP_Interval_Type& compute_absolute_error( const Floating_Point_Format analyzed_format) { typedef typename FP_Interval_Type::boundary_type analyzer_format; + // FIXME: check if initializing caches with EMPTY is better. static const FP_Interval_Type ZERO_INTERVAL = FP_Interval_Type(0); // Cached results for each different analyzed format. static FP_Interval_Type ieee754_half_result = ZERO_INTERVAL;

1 0

[GIT] ppl/ppl(floating_point): Fixed a typo.
by Fabio Bossi 22 Jul '10

22 Jul '10

Module: ppl/ppl Branch: floating_point Commit: 36c398be7c32598e44f067236ad2aa040a927265 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=36c398be7c32… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Thu Jul 22 11:52:09 2010 +0200 Fixed a typo. --- src/Float.templates.hh | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Float.templates.hh b/src/Float.templates.hh index 139a153..ab93c35 100644 --- a/src/Float.templates.hh +++ b/src/Float.templates.hh @@ -21,8 +21,8 @@ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA. For the most up-to-date information see the Parma Polyhedra Library site: http://www.cs.unipr.it/ppl/ . */ -#ifndef PPL_Float_Templates_hh -#define PPL_Float_Templates_hh 1 +#ifndef PPL_Float_templates_hh +#define PPL_Float_templates_hh 1 #include <cmath> @@ -121,4 +121,4 @@ const FP_Interval_Type& compute_absolute_error( } // namespace Parma_Polyhedra_Library -#endif // !defined(PPL_Float_Templates_hh) +#endif // !defined(PPL_Float_templates_hh)

1 0

[GIT] ppl/ppl(floating_point): Removed two probable unnecessary inclusions.
by Fabio Bossi 22 Jul '10

22 Jul '10

Module: ppl/ppl Branch: floating_point Commit: 598a0f5c035c8c0ebdb93d7a390b21c6500a8263 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=598a0f5c035c… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Thu Jul 22 11:30:13 2010 +0200 Removed two probable unnecessary inclusions. --- src/Grid.defs.hh | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/Grid.defs.hh b/src/Grid.defs.hh index c51ffd0..bf4e617 100644 --- a/src/Grid.defs.hh +++ b/src/Grid.defs.hh @@ -40,9 +40,7 @@ site: http://www.cs.unipr.it/ppl/ . */ #include "Poly_Gen_Relation.defs.hh" #include "Grid_Certificate.types.hh" #include "Box.types.hh" -#include "Polyhedron.defs.hh" #include "Polyhedron.types.hh" -#include "Polyhedron.inlines.hh" #include "BD_Shape.types.hh" #include "Octagonal_Shape.types.hh" #include <vector>

1 0

[GIT] ppl/ppl(floating_point): Fixed a typo in the inclusion guard.
by Fabio Bossi 22 Jul '10

22 Jul '10

Module: ppl/ppl Branch: floating_point Commit: cc3822c311bf9c585c8a73c0bbdfed071de8277b URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=cc3822c311bf… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Thu Jul 22 10:29:16 2010 +0200 Fixed a typo in the inclusion guard. --- src/Float.templates.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Float.templates.hh b/src/Float.templates.hh index 4912b9a..139a153 100644 --- a/src/Float.templates.hh +++ b/src/Float.templates.hh @@ -21,7 +21,7 @@ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA. For the most up-to-date information see the Parma Polyhedra Library site: http://www.cs.unipr.it/ppl/ . */ -#ifndef PPL_Float_templates_hh +#ifndef PPL_Float_Templates_hh #define PPL_Float_Templates_hh 1 #include <cmath>

1 0

[GIT] ppl/ppl(floating_point): Removed class absolute_error.
by Fabio Bossi 21 Jul '10

21 Jul '10

Module: ppl/ppl Branch: floating_point Commit: 0decead53d0c887298b1dc309e7003d2ce59698f URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0decead53d0c… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Wed Jul 21 17:18:30 2010 +0200 Removed class absolute_error. Cache results locally in compute_absolute_error instead. --- src/Float.defs.hh | 60 +---------------------------------------------- src/Float.templates.hh | 47 ++++++++++++++++++++++++++++++++---- 2 files changed, 43 insertions(+), 64 deletions(-) diff --git a/src/Float.defs.hh b/src/Float.defs.hh index 43a0399..e68c3bd 100644 --- a/src/Float.defs.hh +++ b/src/Float.defs.hh @@ -361,64 +361,8 @@ public: #endif template <typename FP_Interval_Type> -FP_Interval_Type compute_absolute_error(Floating_Point_Format analyzed_format); - -template <typename FP_Interval_Type, Floating_Point_Format> -struct absolute_error; - -template <typename FP_Interval_Type> -struct absolute_error<FP_Interval_Type, IEEE754_HALF> { - static const FP_Interval_Type value; -}; - -template <typename FP_Interval_Type> -const FP_Interval_Type absolute_error<FP_Interval_Type, IEEE754_HALF>::value = - compute_absolute_error<FP_Interval_Type>(IEEE754_HALF); - -template <typename FP_Interval_Type> -struct absolute_error<FP_Interval_Type, IEEE754_SINGLE> { - static const FP_Interval_Type value; -}; - -template <typename FP_Interval_Type> -const FP_Interval_Type absolute_error<FP_Interval_Type, IEEE754_SINGLE>::value = - compute_absolute_error<FP_Interval_Type>(IEEE754_SINGLE); - -template <typename FP_Interval_Type> -struct absolute_error<FP_Interval_Type, IEEE754_DOUBLE> { - static const FP_Interval_Type value; -}; - -template <typename FP_Interval_Type> -const FP_Interval_Type absolute_error<FP_Interval_Type, IEEE754_DOUBLE>::value = - compute_absolute_error<FP_Interval_Type>(IEEE754_DOUBLE); - -template <typename FP_Interval_Type> -struct absolute_error<FP_Interval_Type, IBM_SINGLE> { - static const FP_Interval_Type value; -}; - -template <typename FP_Interval_Type> -const FP_Interval_Type absolute_error<FP_Interval_Type, IBM_SINGLE>::value = - compute_absolute_error<FP_Interval_Type>(IBM_SINGLE); - -template <typename FP_Interval_Type> -struct absolute_error<FP_Interval_Type, IEEE754_QUAD> { - static const FP_Interval_Type value; -}; - -template <typename FP_Interval_Type> -const FP_Interval_Type absolute_error<FP_Interval_Type, IEEE754_QUAD>::value = - compute_absolute_error<FP_Interval_Type>(IEEE754_QUAD); - -template <typename FP_Interval_Type> -struct absolute_error<FP_Interval_Type, INTEL_DOUBLE_EXTENDED> { - static const FP_Interval_Type value; -}; - -template <typename FP_Interval_Type> -const FP_Interval_Type absolute_error<FP_Interval_Type, INTEL_DOUBLE_EXTENDED>::value = - compute_absolute_error<FP_Interval_Type>(INTEL_DOUBLE_EXTENDED); +const FP_Interval_Type& compute_absolute_error( + Floating_Point_Format analyzed_format); } // namespace Parma_Polyhedra_Library diff --git a/src/Float.templates.hh b/src/Float.templates.hh index feaa8bb..4912b9a 100644 --- a/src/Float.templates.hh +++ b/src/Float.templates.hh @@ -29,41 +29,75 @@ site: http://www.cs.unipr.it/ppl/ . */ namespace Parma_Polyhedra_Library { template <typename FP_Interval_Type> -FP_Interval_Type compute_absolute_error( - const Floating_Point_Format analyzed_format) { +const FP_Interval_Type& compute_absolute_error( + const Floating_Point_Format analyzed_format) { typedef typename FP_Interval_Type::boundary_type analyzer_format; + static const FP_Interval_Type ZERO_INTERVAL = FP_Interval_Type(0); + // Cached results for each different analyzed format. + static FP_Interval_Type ieee754_half_result = ZERO_INTERVAL; + static FP_Interval_Type ieee754_single_result = ZERO_INTERVAL; + static FP_Interval_Type ieee754_double_result = ZERO_INTERVAL; + static FP_Interval_Type ibm_single_result = ZERO_INTERVAL; + static FP_Interval_Type ieee754_quad_result = ZERO_INTERVAL; + static FP_Interval_Type intel_double_extended_result = ZERO_INTERVAL; + + FP_Interval_Type* to_compute = NULL; // Get the necessary information on the analyzed's format. unsigned int f_base; int f_exponent_bias; unsigned int f_mantissa_bits; switch (analyzed_format) { case IEEE754_HALF: + if (ieee754_half_result != ZERO_INTERVAL) + return ieee754_half_result; + + to_compute = &ieee754_half_result; f_base = float_ieee754_half::BASE; f_exponent_bias = float_ieee754_half::EXPONENT_BIAS; f_mantissa_bits = float_ieee754_half::MANTISSA_BITS; break; case IEEE754_SINGLE: + if (ieee754_single_result != ZERO_INTERVAL) + return ieee754_single_result; + + to_compute = &ieee754_single_result; f_base = float_ieee754_single::BASE; f_exponent_bias = float_ieee754_single::EXPONENT_BIAS; f_mantissa_bits = float_ieee754_single::MANTISSA_BITS; break; case IEEE754_DOUBLE: + if (ieee754_double_result != ZERO_INTERVAL) + return ieee754_double_result; + + to_compute = &ieee754_double_result; f_base = float_ieee754_double::BASE; f_exponent_bias = float_ieee754_double::EXPONENT_BIAS; f_mantissa_bits = float_ieee754_double::MANTISSA_BITS; break; case IBM_SINGLE: + if (ibm_single_result != ZERO_INTERVAL) + return ibm_single_result; + + to_compute = &ibm_single_result; f_base = float_ibm_single::BASE; f_exponent_bias = float_ibm_single::EXPONENT_BIAS; f_mantissa_bits = float_ibm_single::MANTISSA_BITS; break; case IEEE754_QUAD: + if (ieee754_quad_result != ZERO_INTERVAL) + return ieee754_quad_result; + + to_compute = &ieee754_quad_result; f_base = float_ieee754_quad::BASE; f_exponent_bias = float_ieee754_quad::EXPONENT_BIAS; f_mantissa_bits = float_ieee754_quad::MANTISSA_BITS; break; case INTEL_DOUBLE_EXTENDED: + if (intel_double_extended_result != ZERO_INTERVAL) + return intel_double_extended_result; + + to_compute = &intel_double_extended_result; f_base = float_intel_double_extended::BASE; f_exponent_bias = float_intel_double_extended::EXPONENT_BIAS; f_mantissa_bits = float_intel_double_extended::MANTISSA_BITS; @@ -72,16 +106,17 @@ FP_Interval_Type compute_absolute_error( throw std::runtime_error("PPL internal error"); } + PPL_ASSERT(to_compute != NULL); + analyzer_format omega = std::max( static_cast<analyzer_format>(pow(f_base, static_cast<analyzer_format>(1) - f_exponent_bias - f_mantissa_bits)), std::numeric_limits<analyzer_format>::denorm_min()); - FP_Interval_Type result; - result.build(i_constraint(GREATER_OR_EQUAL, -omega), - i_constraint(LESS_OR_EQUAL, omega)); - return result; + to_compute->build(i_constraint(GREATER_OR_EQUAL, -omega), + i_constraint(LESS_OR_EQUAL, omega)); + return *to_compute; } } // namespace Parma_Polyhedra_Library

1 0

[GIT] ppl/ppl(floating_point): Correctly handle unexpected formats.
by Fabio Bossi 21 Jul '10

21 Jul '10

Module: ppl/ppl Branch: floating_point Commit: d7bfff5fe6a73fd3496b5c6af2cd1864fab1e4b9 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=d7bfff5fe6a7… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Wed Jul 21 15:48:54 2010 +0200 Correctly handle unexpected formats. --- src/Float.templates.hh | 2 ++ src/Linear_Form.templates.hh | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/Float.templates.hh b/src/Float.templates.hh index 5cc53fc..feaa8bb 100644 --- a/src/Float.templates.hh +++ b/src/Float.templates.hh @@ -68,6 +68,8 @@ FP_Interval_Type compute_absolute_error( f_exponent_bias = float_intel_double_extended::EXPONENT_BIAS; f_mantissa_bits = float_intel_double_extended::MANTISSA_BITS; break; + default: + throw std::runtime_error("PPL internal error"); } analyzer_format omega = std::max( diff --git a/src/Linear_Form.templates.hh b/src/Linear_Form.templates.hh index 666207e..f676626 100644 --- a/src/Linear_Form.templates.hh +++ b/src/Linear_Form.templates.hh @@ -412,6 +412,8 @@ Linear_Form<C>::relative_error( f_base = float_intel_double_extended::BASE; f_mantissa_bits = float_intel_double_extended::MANTISSA_BITS; break; + default: + throw std::runtime_error("PPL internal error"); } C error_propagator;

1 0

[GIT] ppl/ppl(floating_point): Made class absolute_error a struct.
by Fabio Bossi 21 Jul '10

21 Jul '10

Module: ppl/ppl Branch: floating_point Commit: 5f7ad90bdec26fb1710939a6887bf0b89277f91f URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=5f7ad90bdec2… Author: Fabio Bossi <bossi(a)cs.unipr.it> Date: Wed Jul 21 15:28:22 2010 +0200 Made class absolute_error a struct. --- src/Float.defs.hh | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Float.defs.hh b/src/Float.defs.hh index 21270da..43a0399 100644 --- a/src/Float.defs.hh +++ b/src/Float.defs.hh @@ -364,10 +364,10 @@ template <typename FP_Interval_Type> FP_Interval_Type compute_absolute_error(Floating_Point_Format analyzed_format); template <typename FP_Interval_Type, Floating_Point_Format> -class absolute_error; +struct absolute_error; template <typename FP_Interval_Type> -class absolute_error<FP_Interval_Type, IEEE754_HALF> { +struct absolute_error<FP_Interval_Type, IEEE754_HALF> { static const FP_Interval_Type value; }; @@ -376,7 +376,7 @@ const FP_Interval_Type absolute_error<FP_Interval_Type, IEEE754_HALF>::value = compute_absolute_error<FP_Interval_Type>(IEEE754_HALF); template <typename FP_Interval_Type> -class absolute_error<FP_Interval_Type, IEEE754_SINGLE> { +struct absolute_error<FP_Interval_Type, IEEE754_SINGLE> { static const FP_Interval_Type value; }; @@ -385,7 +385,7 @@ const FP_Interval_Type absolute_error<FP_Interval_Type, IEEE754_SINGLE>::value = compute_absolute_error<FP_Interval_Type>(IEEE754_SINGLE); template <typename FP_Interval_Type> -class absolute_error<FP_Interval_Type, IEEE754_DOUBLE> { +struct absolute_error<FP_Interval_Type, IEEE754_DOUBLE> { static const FP_Interval_Type value; }; @@ -394,7 +394,7 @@ const FP_Interval_Type absolute_error<FP_Interval_Type, IEEE754_DOUBLE>::value = compute_absolute_error<FP_Interval_Type>(IEEE754_DOUBLE); template <typename FP_Interval_Type> -class absolute_error<FP_Interval_Type, IBM_SINGLE> { +struct absolute_error<FP_Interval_Type, IBM_SINGLE> { static const FP_Interval_Type value; }; @@ -403,7 +403,7 @@ const FP_Interval_Type absolute_error<FP_Interval_Type, IBM_SINGLE>::value = compute_absolute_error<FP_Interval_Type>(IBM_SINGLE); template <typename FP_Interval_Type> -class absolute_error<FP_Interval_Type, IEEE754_QUAD> { +struct absolute_error<FP_Interval_Type, IEEE754_QUAD> { static const FP_Interval_Type value; }; @@ -412,7 +412,7 @@ const FP_Interval_Type absolute_error<FP_Interval_Type, IEEE754_QUAD>::value = compute_absolute_error<FP_Interval_Type>(IEEE754_QUAD); template <typename FP_Interval_Type> -class absolute_error<FP_Interval_Type, INTEL_DOUBLE_EXTENDED> { +struct absolute_error<FP_Interval_Type, INTEL_DOUBLE_EXTENDED> { static const FP_Interval_Type value; };

1 0