Module: ppl/ppl Branch: master Commit: 111862b03b7104fbc82949ea22af69a37ec66daa URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=111862b03b710...
Author: Enea Zaffanella zaffanella@cs.unipr.it Date: Thu Apr 2 13:31:29 2009 +0200
Another FIXME postponed to 0.11.
---
src/Grid.templates.hh | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/Grid.templates.hh b/src/Grid.templates.hh index 7e9410e..12196b1 100644 --- a/src/Grid.templates.hh +++ b/src/Grid.templates.hh @@ -120,11 +120,15 @@ Grid::Grid(const Box& box, From_Covering_Box) PPL_DIRTY_TEMP_COEFFICIENT(l_n); PPL_DIRTY_TEMP_COEFFICIENT(l_d);
- // Check that all bounds are closed. This check must be done before + // FIXME: consider whether or not covering boxes supporting open + // boundaries should be disabled at compile time. If that is not + // the case, consider if the test !box.is_topologically_closed() + // can replace the whole loop here below. + + // Check that no finite bounds is open. This check must be done before // the empty test below, as an open bound might mean an empty box. for (dimension_type k = space_dim; k-- > 0; ) { bool closed = false; - // FIXME(0.10.1): Perhaps introduce Box::is_bounded_and_closed. if (box.get_lower_bound(k, closed, l_n, l_d) && !closed) throw_invalid_argument("Grid(box, from_covering_box)", "box"); if (box.get_upper_bound(k, closed, l_n, l_d) && !closed)