- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(compliance): Added missing braces. Fixes violations of rule MP1.6-4-1 detected by ECLAIR.
by Patrik Pomelli 24 Jun '14

24 Jun '14

1 0

[GIT] ppl/ppl(compliance): Brace position fixed.
by Patrik Pomelli 21 Jun '14

21 Jun '14

Module: ppl/ppl Branch: compliance Commit: bd70cc6e44ca2db50ec8eabb7b62047611bca249 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=bd70cc6e44ca… Author: Patrik Pomelli <patrik.pomelli(a)bugseng.com> Date: Sat Jun 21 12:17:47 2014 +0200 Brace position fixed. Signed-off-by: Roberto Bagnara <roberto.bagnara(a)bugseng.com> --- src/Matrix_templates.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Matrix_templates.hh b/src/Matrix_templates.hh index b89acdb..496aab5 100644 --- a/src/Matrix_templates.hh +++ b/src/Matrix_templates.hh @@ -128,8 +128,8 @@ void Matrix<Row>::remove_column(dimension_type i) { for (dimension_type j = rows.size(); j-- > 0; ) { rows[j].delete_element_and_shift(i); - --num_columns_; } + --num_columns_; PPL_ASSERT(OK()); }

1 0

[GIT] ppl/ppl(master): Trailing whitespace removed.
by Roberto Bagnara 20 Jun '14

20 Jun '14

Module: ppl/ppl Branch: master Commit: fe759bb940ffa3083ec6eca0c8221d388bd2bb64 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=fe759bb940ff… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Thu Jun 12 21:43:12 2014 +0200 Trailing whitespace removed. --- src/Polyhedron_chdims.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Polyhedron_chdims.cc b/src/Polyhedron_chdims.cc index 10a9e45..a52d04c 100644 --- a/src/Polyhedron_chdims.cc +++ b/src/Polyhedron_chdims.cc @@ -420,7 +420,7 @@ PPL::Polyhedron::expand_space_dimension(Variable var, dimension_type m) { Constraint c_template = c; c_template.expr.set_coefficient(var, Coefficient_zero()); - + // Each relevant constraint results in `m' new constraints. for (dimension_type dst_d = old_dim; dst_d < old_dim+m; ++dst_d) { Constraint new_c = c_template;

1 0

[GIT] ppl/ppl(compliance): Typo fixed.
by Roberto Bagnara 20 Jun '14

20 Jun '14

Module: ppl/ppl Branch: compliance Commit: 2c040ae004351cf05e0f37f29d3e7a282776b01c URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2c040ae00435… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jun 20 11:27:20 2014 +0200 Typo fixed. --- src/Constraint.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Constraint.cc b/src/Constraint.cc index 82308ee..f3c6a6b 100644 --- a/src/Constraint.cc +++ b/src/Constraint.cc @@ -92,7 +92,7 @@ PPL::Constraint if (cycle.size() < 2) { // No-op. No need to call sign_normalize(). return; - !} + } expr.permute_space_dimensions(cycle); // *this is still normalized but may be not strongly normalized:

1 0

[GIT] ppl/ppl(compliance): Permissions fixed.
by Roberto Bagnara 20 Jun '14

20 Jun '14

Module: ppl/ppl Branch: compliance Commit: 178fed3200d9b837ca003f790e8969c2c029801e URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=178fed3200d9… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jun 20 11:18:25 2014 +0200 Permissions fixed. --- 0 files changed, 0 insertions(+), 0 deletions(-) diff --git a/src/BHRZ03_Certificate.cc b/src/BHRZ03_Certificate.cc old mode 100755 new mode 100644 diff --git a/src/Bit_Matrix.cc b/src/Bit_Matrix.cc old mode 100755 new mode 100644

1 0

[GIT] ppl/ppl(compliance): Added missing braces. Fixes violations of rule MP1.6-4-1 detected by ECLAIR.
by Roberto Bagnara 20 Jun '14

20 Jun '14

Module: ppl/ppl Branch: compliance Commit: b8be0e6326fe0aef445832b58442e7ad057b4586 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b8be0e6326fe… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri Jun 20 11:15:47 2014 +0200 Added missing braces. Fixes violations of rule MP1.6-4-1 detected by ECLAIR. --- src/Box_templates.hh | 1085 ++++++++++++++++++++++++++++++++------------------ 1 files changed, 690 insertions(+), 395 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=b8be0e63…

1 0

[GIT] ppl/ppl(compliance): Deleted trailing whitespace.
by Roberto Bagnara 20 Jun '14

20 Jun '14

1 0

[GIT] ppl/ppl(compliance): Added missing braces. Fixes violations of rule MP1.6-4-1 detected by ECLAIR.
by Patrik Pomelli 20 Jun '14

20 Jun '14

1 0

[GIT] ppl/ppl(compliance): Deleted trailing whitespace.
by Roberto Bagnara 18 Jun '14

18 Jun '14

Module: ppl/ppl Branch: compliance Commit: b66d4542348843ce6ac4fe8efc6f3686f0055117 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=b66d45423488… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Wed Jun 18 21:56:56 2014 +0200 Deleted trailing whitespace. --- src/Box_templates.hh | 12 ++++++------ src/Generator_inlines.hh | 2 +- src/Linear_System_inlines.hh | 2 +- src/MIP_Problem.cc | 2 +- src/Polyhedron_nonpublic.cc | 4 ++-- src/Polyhedron_public.cc | 4 ++-- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/Box_templates.hh b/src/Box_templates.hh index 092283e..078577b 100755 --- a/src/Box_templates.hh +++ b/src/Box_templates.hh @@ -1340,7 +1340,7 @@ Box<ITV>::affine_dimension() const { if (seq[k].is_singleton()) --d; } - + return d; } @@ -1739,7 +1739,7 @@ Box<ITV>::drop_some_non_integer_points(Complexity_Class) { for (dimension_type k = seq.size(); k-- > 0; ) { seq[k].drop_some_non_integer_points(); } - + PPL_ASSERT(OK()); } @@ -1764,7 +1764,7 @@ Box<ITV>::drop_some_non_integer_points(const Variables_Set& vars, v_end = vars.end(); v_i != v_end; ++v_i) { seq[*v_i].drop_some_non_integer_points(); } - + PPL_ASSERT(OK()); } @@ -1798,7 +1798,7 @@ Box<ITV>::intersection_assign(const Box& y) { for (dimension_type k = space_dim; k-- > 0; ) { x.seq[k].intersect_assign(y.seq[k]); } - + PPL_ASSERT(x.OK()); } @@ -1822,7 +1822,7 @@ Box<ITV>::upper_bound_assign(const Box& y) { for (dimension_type k = x.seq.size(); k-- > 0; ) { x.seq[k].join_assign(y.seq[k]); } - + PPL_ASSERT(x.OK()); } @@ -1907,7 +1907,7 @@ Box<ITV>::difference_assign(const Box& y) { break; } } - + switch (number_non_contained) { case 0: // `y' covers `x': the difference is empty. diff --git a/src/Generator_inlines.hh b/src/Generator_inlines.hh index 0a85c2e..c3366b4 100644 --- a/src/Generator_inlines.hh +++ b/src/Generator_inlines.hh @@ -436,7 +436,7 @@ Generator::ascii_dump(std::ostream& s) const { expr.ascii_dump(s); s << " "; - + switch (type()) { case Generator::LINE: s << "L "; diff --git a/src/Linear_System_inlines.hh b/src/Linear_System_inlines.hh index ed17b4e..9fc14aa 100644 --- a/src/Linear_System_inlines.hh +++ b/src/Linear_System_inlines.hh @@ -540,7 +540,7 @@ Linear_System<Row>::swap_row_intervals(dimension_type first, for (dimension_type i = first; i < last; ++i) { swap(rows[i], rows[i + offset]); } - + if (first < index_first_pending) // The swaps involved not pending rows, so they may not be sorted anymore. set_sorted(false); diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index 54ad205..a174b6d 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -1666,7 +1666,7 @@ PPL::MIP_Problem::erase_artificials(const dimension_type begin_artificials, for (dimension_type i = tableau_n_rows; i-- > 0; ) { tableau[i].reset(new_last_column); } - + // ... then properly set the element in the (new) last column, // encoding the kind of optimization; ... { diff --git a/src/Polyhedron_nonpublic.cc b/src/Polyhedron_nonpublic.cc index 5a9812e..0e71ea6 100644 --- a/src/Polyhedron_nonpublic.cc +++ b/src/Polyhedron_nonpublic.cc @@ -1499,7 +1499,7 @@ PPL::Polyhedron::BHZ09_C_poly_hull_assign_if_exact(const Polyhedron& y) { ++num_x_gs_red_in_y; } } - + Bit_Row y_gs_red_in_x; dimension_type num_y_gs_red_in_x = 0; for (dimension_type i = y_gs_num_rows; i-- > 0; ) { @@ -1555,7 +1555,7 @@ PPL::Polyhedron::BHZ09_C_poly_hull_assign_if_exact(const Polyhedron& y) { if (!y_gs_red_in_x[j]) add_generator(y_gs[j]); } - + PPL_ASSERT_HEAVY(OK()); return true; } diff --git a/src/Polyhedron_public.cc b/src/Polyhedron_public.cc index 60d44f6..d6d630d 100644 --- a/src/Polyhedron_public.cc +++ b/src/Polyhedron_public.cc @@ -499,7 +499,7 @@ PPL::Polyhedron::is_bounded() const { if (gen_sys[i].is_line_or_ray()) return false; } - + // The system of generators is composed only by // points and closure points: the polyhedron is bounded. return true; @@ -705,7 +705,7 @@ PPL::Polyhedron::constrains(const Variable var) const { if (gen_sys[i].is_line()) ++num_lines; } - + if (num_lines == space_dim) return false; }

1 0

[GIT] ppl/ppl(compliance): Readded newlines erased by mistake.
by Patrik Pomelli 18 Jun '14

18 Jun '14

Module: ppl/ppl Branch: compliance Commit: 00014551b6abf9de80d4ef436628c70c3bd74f7a URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=00014551b6ab… Author: Patrik Pomelli <patrik.pomelli(a)bugseng.com> Date: Mon Jun 16 09:02:53 2014 +0200 Readded newlines erased by mistake. Signed-off-by: Roberto Bagnara <roberto.bagnara(a)bugseng.com> --- src/MIP_Problem.cc | 1 + src/Polyhedron_nonpublic.cc | 2 ++ src/Polyhedron_public.cc | 2 ++ 3 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/MIP_Problem.cc b/src/MIP_Problem.cc index 1313c9a..54ad205 100644 --- a/src/MIP_Problem.cc +++ b/src/MIP_Problem.cc @@ -1666,6 +1666,7 @@ PPL::MIP_Problem::erase_artificials(const dimension_type begin_artificials, for (dimension_type i = tableau_n_rows; i-- > 0; ) { tableau[i].reset(new_last_column); } + // ... then properly set the element in the (new) last column, // encoding the kind of optimization; ... { diff --git a/src/Polyhedron_nonpublic.cc b/src/Polyhedron_nonpublic.cc index ad1b652..5a9812e 100644 --- a/src/Polyhedron_nonpublic.cc +++ b/src/Polyhedron_nonpublic.cc @@ -1499,6 +1499,7 @@ PPL::Polyhedron::BHZ09_C_poly_hull_assign_if_exact(const Polyhedron& y) { ++num_x_gs_red_in_y; } } + Bit_Row y_gs_red_in_x; dimension_type num_y_gs_red_in_x = 0; for (dimension_type i = y_gs_num_rows; i-- > 0; ) { @@ -1554,6 +1555,7 @@ PPL::Polyhedron::BHZ09_C_poly_hull_assign_if_exact(const Polyhedron& y) { if (!y_gs_red_in_x[j]) add_generator(y_gs[j]); } + PPL_ASSERT_HEAVY(OK()); return true; } diff --git a/src/Polyhedron_public.cc b/src/Polyhedron_public.cc index f844f81..60d44f6 100644 --- a/src/Polyhedron_public.cc +++ b/src/Polyhedron_public.cc @@ -499,6 +499,7 @@ PPL::Polyhedron::is_bounded() const { if (gen_sys[i].is_line_or_ray()) return false; } + // The system of generators is composed only by // points and closure points: the polyhedron is bounded. return true; @@ -704,6 +705,7 @@ PPL::Polyhedron::constrains(const Variable var) const { if (gen_sys[i].is_line()) ++num_lines; } + if (num_lines == space_dim) return false; }

1 0