- PPL-devel - BUGSENG Mailman

[GIT] ppl/ppl(compliance): Added missing braces. Fixes violations of rules MP1.6-3-1 and MP1.6-4-1 detected by ECLAIR
by Patrik Pomelli 09 Jun '14

09 Jun '14

Module: ppl/ppl Branch: compliance Commit: f3dc0ba64a4437f7a33a8120dd99d4ceeb7537f7 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f3dc0ba64a44… Author: Patrik Pomelli <patrik.pomelli(a)bugseng.com> Date: Mon Jun 9 10:25:27 2014 +0200 Added missing braces. Fixes violations of rules MP1.6-3-1 and MP1.6-4-1 detected by ECLAIR Signed-off-by: Roberto Bagnara <roberto.bagnara(a)bugseng.com> --- demos/ppl_lcdd/ppl_lcdd.cc | 43 +- src/BD_Shape_templates.hh | 1427 ++++++++++++++++++++++++++------------------ src/BHRZ03_Certificate.cc | 69 ++- src/Bit_Matrix.cc | 78 ++- src/Box_templates.hh | 166 ++++-- 5 files changed, 1064 insertions(+), 719 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=f3dc0ba6…

1 0

[GIT] ppl/ppl(compliance): Long lines avoided.
by Roberto Bagnara 09 Jun '14

09 Jun '14

Module: ppl/ppl Branch: compliance Commit: 057444894a1b5e509f8017c7a99ef7b2df1b74c5 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=057444894a1b… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sun Jun 8 17:06:33 2014 +0200 Long lines avoided. Fixes violations of rule LP1.41 detected by ECLAIR. --- src/Polyhedron_nonpublic.cc | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Polyhedron_nonpublic.cc b/src/Polyhedron_nonpublic.cc index b00f50c..0457714 100644 --- a/src/Polyhedron_nonpublic.cc +++ b/src/Polyhedron_nonpublic.cc @@ -2310,10 +2310,13 @@ PPL::Polyhedron::positive_time_elapse_assign_impl(const Polyhedron& y) { const Generator &gx = x_points_gs.sys.rows[j]; PPL_ASSERT(gx.is_point()); // ...insert the point obtained as the sum of g and gx. - Generator new_g = g; // make a copy - Coefficient new_divisor = g.expr.inhomogeneous_term() * gx.expr.inhomogeneous_term(); + Generator new_g = g; + Coefficient new_divisor + = g.expr.inhomogeneous_term() * gx.expr.inhomogeneous_term(); - new_g.expr.linear_combine(gx.expr, gx.expr.inhomogeneous_term(), g.expr.inhomogeneous_term()); + new_g.expr.linear_combine(gx.expr, + gx.expr.inhomogeneous_term(), + g.expr.inhomogeneous_term()); new_g.expr.set_inhomogeneous_term(new_divisor); if (new_g.is_not_necessarily_closed()) { new_g.set_epsilon_coefficient(g.epsilon_coefficient());

1 0

[GIT] ppl/ppl(master): Long lines avoided.
by Roberto Bagnara 08 Jun '14

08 Jun '14

Module: ppl/ppl Branch: master Commit: 057444894a1b5e509f8017c7a99ef7b2df1b74c5 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=057444894a1b… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sun Jun 8 17:06:33 2014 +0200 Long lines avoided. Fixes violations of rule LP1.41 detected by ECLAIR. --- src/Polyhedron_nonpublic.cc | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Polyhedron_nonpublic.cc b/src/Polyhedron_nonpublic.cc index b00f50c..0457714 100644 --- a/src/Polyhedron_nonpublic.cc +++ b/src/Polyhedron_nonpublic.cc @@ -2310,10 +2310,13 @@ PPL::Polyhedron::positive_time_elapse_assign_impl(const Polyhedron& y) { const Generator &gx = x_points_gs.sys.rows[j]; PPL_ASSERT(gx.is_point()); // ...insert the point obtained as the sum of g and gx. - Generator new_g = g; // make a copy - Coefficient new_divisor = g.expr.inhomogeneous_term() * gx.expr.inhomogeneous_term(); + Generator new_g = g; + Coefficient new_divisor + = g.expr.inhomogeneous_term() * gx.expr.inhomogeneous_term(); - new_g.expr.linear_combine(gx.expr, gx.expr.inhomogeneous_term(), g.expr.inhomogeneous_term()); + new_g.expr.linear_combine(gx.expr, + gx.expr.inhomogeneous_term(), + g.expr.inhomogeneous_term()); new_g.expr.set_inhomogeneous_term(new_divisor); if (new_g.is_not_necessarily_closed()) { new_g.set_epsilon_coefficient(g.epsilon_coefficient());

1 0

[GIT] ppl/ppl(master): Tabs avoided.
by Roberto Bagnara 08 Jun '14

08 Jun '14

Module: ppl/ppl Branch: master Commit: f583be190c8ea3ad57216efc2ec17b71807b8b14 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=f583be190c8e… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Sun Jun 8 16:39:39 2014 +0200 Tabs avoided. Fixes violations of rule UCRP1.RS1 detected by ECLAIR. --- src/Polyhedron_nonpublic.cc | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Polyhedron_nonpublic.cc b/src/Polyhedron_nonpublic.cc index ad47770..b00f50c 100644 --- a/src/Polyhedron_nonpublic.cc +++ b/src/Polyhedron_nonpublic.cc @@ -2320,19 +2320,19 @@ PPL::Polyhedron::positive_time_elapse_assign_impl(const Polyhedron& y) { } new_g.expr.normalize(); PPL_ASSERT(new_g.OK()); - new_gs.insert(new_g); + new_gs.insert(new_g); } break; case Generator::CLOSURE_POINT: // If g is not the origin, insert g into new_gs, as a ray. if (!g.expr.all_homogeneous_terms_are_zero()) { - // Turn a copy of g into a ray. - Generator g_as_a_ray = g; - g_as_a_ray.expr.set_inhomogeneous_term(0); - g_as_a_ray.expr.normalize(); - PPL_ASSERT(g_as_a_ray.OK()); - // Insert the ray. - new_gs.insert(g_as_a_ray); + // Turn a copy of g into a ray. + Generator g_as_a_ray = g; + g_as_a_ray.expr.set_inhomogeneous_term(0); + g_as_a_ray.expr.normalize(); + PPL_ASSERT(g_as_a_ray.OK()); + // Insert the ray. + new_gs.insert(g_as_a_ray); } break; case Generator::RAY:

1 0

extrapolation and termination
by Bishoksan Kafle 01 Jun '14

01 Jun '14

Dear Roberto, I have a question about extrapolation operators in PPL library, in general, they don't guarantee termination, right? Then, I found the following text from the documentation: "Note that a convergence guarantee can only be obtained by suitably restricting the set of constraints that can occur in this additional parameter. " Here is my question: Do they guarantee termination if I have a fixed set (any) of constraints? or the set of constraints has to be carefully chosen? Many thanks in advance :) Best Bishoksan

2 1

ppl-0.11, ppl-0.12.1
by John 23 May '14

23 May '14

I'm trying to build the ppl and cloog requires for building gcc, and have found that both ppl 0.11 and 0.12.1 builds crash because of a boatload of errors in the ppl_lpsol demo. The errors look like this. These are from ppl-0.12.1 and there are many more errors. ppl_lpsol.c:583: error: implicit declaration of function ‘lpx_set_int_parm’ ppl_lpsol.c:583: error: ‘glpk_lp’ undeclared (first use in this function) ppl_lpsol.c:583: error: (Each undeclared identifier is reported only once ppl_lpsol.c:583: error: for each function it appears in.) ppl_lpsol.c:583: error: ‘LPX_K_MSGLEV’ undeclared (first use in this function) ppl_lpsol.c:585: error: ‘LPX_LP’ undeclared (first use in this function) ppl_lpsol.c:588: error: implicit declaration of function ‘lpx_set_obj_dir’ Why did you release software packages with these easily discoverable defects? I wasted several hours this morning compiling and got nothing. OS: Debian Linux 6.0.9 compilers: GCC-4.4.5 GCC and G++ John Tellefson Salina, KS USA http://www.mozilla.org Firefox browser, Thunderbird email, Seamonkey all-in-one, Sunbird calendar and more. Free open-source software for Windows, Linux, Mac OS and other systems

2 1

Fwd: PPL Interface Issue
by Syed Sabah-ud-Din Gilani 15 May '14

15 May '14

Dear Sir, I have used ppl 0.9 in my project, now I am upgrading it to ppl 1.1, during compilation I had ppl interface issue i.e. *shrink_bounding_box* and some other functions not found. I have commented all these functions and compiled my project successfully, now when I try to parse some file it returns me the following error: *terminate called after throwing an instance of 'std::out_of_range'* * what(): basic_string::substr* *Aborted* I want guidelines and will be glade to have you positive response. Best Regards, *Syed Sabah-ud-din Gilani*

2 11

[GIT] ppl/ppl(master): Updated.
by Roberto Bagnara 09 May '14

09 May '14

Module: ppl/ppl Branch: master Commit: 23a04544864823822a4d50bfc7ebfe0e2be5dbd8 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=23a045448648… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Fri May 9 14:15:11 2014 +0200 Updated. --- config.guess | 192 ++++++++------------------------------------------------- config.sub | 34 ++++++---- missing | 4 +- 3 files changed, 49 insertions(+), 181 deletions(-) Diff: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commitdiff;h=23a04544…

1 0

[GIT] ppl/ppl(master): Put under Git control.
by Roberto Bagnara 09 May '14

09 May '14

Module: ppl/ppl Branch: master Commit: bbaf7691df42719fb2a87a78e92218d4c2e9da84 URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=bbaf7691df42… Author: Roberto Bagnara <bagnara(a)cs.unipr.it> Date: Fri May 9 13:46:51 2014 +0200 Put under Git control. --- test-driver | 140 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 139 insertions(+), 1 deletions(-) diff --git a/test-driver b/test-driver deleted file mode 120000 index 29fa213..0000000 --- a/test-driver +++ /dev/null @@ -1 +0,0 @@ -/usr/local/share/automake-1.14/test-driver \ No newline at end of file diff --git a/test-driver b/test-driver new file mode 100755 index 0000000..d306056 --- /dev/null +++ b/test-driver @@ -0,0 +1,139 @@ +#! /bin/sh +# test-driver - basic testsuite driver script. + +scriptversion=2013-07-13.22; # UTC + +# Copyright (C) 2011-2013 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# As a special exception to the GNU General Public License, if you +# distribute this file as part of a program that contains a +# configuration script generated by Autoconf, you may include it under +# the same distribution terms that you use for the rest of that program. + +# This file is maintained in Automake, please report +# bugs to <bug-automake(a)gnu.org> or send patches to +# <automake-patches(a)gnu.org>. + +# Make unconditional expansion of undefined variables an error. This +# helps a lot in preventing typo-related bugs. +set -u + +usage_error () +{ + echo "$0: $*" >&2 + print_usage >&2 + exit 2 +} + +print_usage () +{ + cat <<END +Usage: + test-driver --test-name=NAME --log-file=PATH --trs-file=PATH + [--expect-failure={yes|no}] [--color-tests={yes|no}] + [--enable-hard-errors={yes|no}] [--] + TEST-SCRIPT [TEST-SCRIPT-ARGUMENTS] +The '--test-name', '--log-file' and '--trs-file' options are mandatory. +END +} + +test_name= # Used for reporting. +log_file= # Where to save the output of the test script. +trs_file= # Where to save the metadata of the test run. +expect_failure=no +color_tests=no +enable_hard_errors=yes +while test $# -gt 0; do + case $1 in + --help) print_usage; exit $?;; + --version) echo "test-driver $scriptversion"; exit $?;; + --test-name) test_name=$2; shift;; + --log-file) log_file=$2; shift;; + --trs-file) trs_file=$2; shift;; + --color-tests) color_tests=$2; shift;; + --expect-failure) expect_failure=$2; shift;; + --enable-hard-errors) enable_hard_errors=$2; shift;; + --) shift; break;; + -*) usage_error "invalid option: '$1'";; + *) break;; + esac + shift +done + +missing_opts= +test x"$test_name" = x && missing_opts="$missing_opts --test-name" +test x"$log_file" = x && missing_opts="$missing_opts --log-file" +test x"$trs_file" = x && missing_opts="$missing_opts --trs-file" +if test x"$missing_opts" != x; then + usage_error "the following mandatory options are missing:$missing_opts" +fi + +if test $# -eq 0; then + usage_error "missing argument" +fi + +if test $color_tests = yes; then + # Keep this in sync with 'lib/am/check.am:$(am__tty_colors)'. + red='[0;31m' # Red. + grn='[0;32m' # Green. + lgn='[1;32m' # Light green. + blu='[1;34m' # Blue. + mgn='[0;35m' # Magenta. + std='[m' # No color. +else + red= grn= lgn= blu= mgn= std= +fi + +do_exit='rm -f $log_file $trs_file; (exit $st); exit $st' +trap "st=129; $do_exit" 1 +trap "st=130; $do_exit" 2 +trap "st=141; $do_exit" 13 +trap "st=143; $do_exit" 15 + +# Test script is run here. +"$@" >$log_file 2>&1 +estatus=$? +if test $enable_hard_errors = no && test $estatus -eq 99; then + estatus=1 +fi + +case $estatus:$expect_failure in + 0:yes) col=$red res=XPASS recheck=yes gcopy=yes;; + 0:*) col=$grn res=PASS recheck=no gcopy=no;; + 77:*) col=$blu res=SKIP recheck=no gcopy=yes;; + 99:*) col=$mgn res=ERROR recheck=yes gcopy=yes;; + *:yes) col=$lgn res=XFAIL recheck=no gcopy=yes;; + *:*) col=$red res=FAIL recheck=yes gcopy=yes;; +esac + +# Report outcome to console. +echo "${col}${res}${std}: $test_name" + +# Register the test result, and other relevant metadata. +echo ":test-result: $res" > $trs_file +echo ":global-test-result: $res" >> $trs_file +echo ":recheck: $recheck" >> $trs_file +echo ":copy-in-global-log: $gcopy" >> $trs_file + +# Local Variables: +# mode: shell-script +# sh-indentation: 2 +# eval: (add-hook 'write-file-hooks 'time-stamp) +# time-stamp-start: "scriptversion=" +# time-stamp-format: "%:y-%02m-%02d.%02H" +# time-stamp-time-zone: "UTC" +# time-stamp-end: "; # UTC" +# End:

1 0

[GIT] ppl/ppl(master): Typo fixed. Set warnings for compilation with clang .
by Roberto Bagnara 08 May '14

08 May '14

Module: ppl/ppl Branch: master Commit: 962067f2907bc09b83f569ef74685798ea24100b URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=962067f2907b… Author: Roberto Bagnara <roberto.bagnara(a)bugseng.com> Date: Thu May 8 21:46:47 2014 +0200 Typo fixed. Set warnings for compilation with clang. --- configure.ac | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 9d51bc0..f4c901a 100644 --- a/configure.ac +++ b/configure.ac @@ -537,7 +537,7 @@ then OPT_FLAGS="$OPT_FLAGS -fp-model strict -fp-speculation off" else # -frounding-math is not yet supported in clang++ or llvm-g++. - if test x"$CLANGXX" = xyes || x"$LLVM_GXX" = xyes + if test x"$CLANGXX" = xyes || test x"$LLVM_GXX" = xyes then if test x"$use_fpmath" = xyes then @@ -1605,6 +1605,9 @@ then if test x"$ICC" = xyes then CFLAGS="$CFLAGS -w2 -wd161,177,193,279,383,444,981,1098,1188,1418,1419,1572" + elif test x"$CLANG" = xyes + then + CFLAGS="$CFLAGS -Weverything -Wno-exit-time-destructors -Wno-global-constructors -Wno-documentation -Wno-missing-noreturn -Wno-covered-switch-default -Wno-unreachable-code -Wno-c++98-compat-pedantic -Wno-switch-enum -Wno-sign-conversion -Wno-c++98-compat -Wno-padded -Wno-disabled-macro-expansion" else CFLAGS="$CFLAGS -W -Wall" fi @@ -1614,6 +1617,9 @@ then if test x"$ICPC" = xyes then CXXFLAGS="$CXXFLAGS -w2 -wd161,177,193,279,383,444,981,1098,1188,1418,1419,1572" + elif test x"$CLANGXX" = xyes + then + CXXFLAGS="$CXXFLAGS -Weverything -Wno-exit-time-destructors -Wno-global-constructors -Wno-documentation -Wno-missing-noreturn -Wno-covered-switch-default -Wno-unreachable-code -Wno-c++98-compat-pedantic -Wno-switch-enum -Wno-sign-conversion -Wno-c++98-compat -Wno-padded -Wno-disabled-macro-expansion" else CXXFLAGS="$CXXFLAGS -W -Wall" fi

1 0